Commit Graph

15842 Commits

Author SHA1 Message Date
therealyingtong dbb7e027c8 Orchard: invalidate mempool transactions that use orphaned anchors. 2022-03-03 17:37:07 +08:00
Kris Nuttycombe 681505e9d6 Log outpoint for failed Sapling witness lookup. 2022-03-02 16:00:15 -07:00
sasha 2e52c1623d gtests ordering: clean up wallet files before each WalletZkeysTest
This allows us to use --gtest_repeat= on the WalletZkeysTest group,
otherwise, each test will reuse its previous iteration's wallet file,
causing assertions to be invalidated.

We put the RemoveDb at the beginning of each test because putting it
at the end of the test means it doesn't get run if the test fails.
This would lead to a single failed test causing every instance of that
test thereafter to fail (since it uses the same temporary directory).

The dummyWallet.LoadWallet() ensures that CDB is initialized, otherwise
bitdb.RemoveDb causes the error:
"BDB1565 DB_ENV->dbremove: method not permitted before handle's open
method"
2022-03-02 13:24:55 -08:00
sasha 902187368e gtests ordering: make Metrics.GetLocalSolPS idempotent
we use our new AtomicTimer::zeroize() to reset the miningTimer and
solutionTargetChecks.decrement() thrice to get it back to original value
2022-03-02 11:29:09 -08:00
sasha 0e13aba1b7 implement AtomicTimer::zeroize() that resets start_time and total_time 2022-03-02 11:29:09 -08:00
therealyingtong cedf2b5ecb wallet_sendmany_any_taddr.py: Expect expired tx to be ignored. 2022-03-03 01:31:32 +08:00
therealyingtong 454c1eed46 FindSpendableInputs: Add nDepth < 0 check.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2022-03-03 01:31:32 +08:00
therealyingtong 98cd4bab0b wallet_sendmany_any_taddr.py: Test sending output from expired tx. 2022-03-03 01:31:32 +08:00
Kris Nuttycombe 5141c2971c
Merge pull request #5594 from LarryRuane/2022-02-getblocktemplate-locking
Fix csBestBlock/cvBlockChange waiting in rpc/mining
2022-03-01 20:08:29 -07:00
Larry Ruane e170c3abd6 document global variables 2022-03-01 17:43:43 -07:00
Pieter Wuille c079a518c0 Modernize best block mutex/cv/hash variable naming
(cherry picked from commit bitcoin/bitcoin@4a6c0e3dcf)
2022-03-01 17:09:19 -07:00
Pieter Wuille 4693f8165f Fix csBestBlock/cvBlockChange waiting in rpc/mining
(cherry picked from commit bitcoin/bitcoin@45dd135039)
2022-03-01 17:09:19 -07:00
therealyingtong 4a8bdabb2f wallet_sendmany_any_taddr.py: Test sending from a change taddr. 2022-03-01 11:33:54 +08:00
sasha 0f06774e94 gtests ordering: CheckBlock.VersionTooLow calls SelectParams(MAIN) 2022-02-28 17:59:50 -08:00
sasha 3a7b4eca87 gtests ordering: ContextualCheckBlockTest's TearDown deactivates Blossom 2022-02-28 17:58:00 -08:00
sasha 489c025f81 gtests ordering: change wallet filename in WriteZkeyDirectToDb 2022-02-28 17:57:10 -08:00
Jack Grigg b5ce94d16c rust: Fix clippy lint 2022-03-01 01:35:46 +00:00
Jack Grigg 7b7dddba0c cargo update 2022-03-01 00:34:02 +00:00
Jack Grigg 2f1fbcc81f depends: Update Clang / libcxx to LLVM 13.0.1 2022-03-01 00:30:32 +00:00
Jack Grigg 21430b13ac depends: Update Rust to 1.59.0 2022-03-01 00:09:18 +00:00
Jack Grigg adb7d074d5 qa: Postpone recent CCache release 2022-03-01 00:05:01 +00:00
Jack Grigg 4c49af7750 qa: Bump all postponed dependencies
We have a pending PR to address the `native_ccache` and `googletest`
dependencies, and we aren't going to touch `bdb`.
2022-03-01 00:03:42 +00:00
Kris Nuttycombe 18f443db1c
Merge pull request #5604 from nuttycom/fix_missing_wallet_lock
GenerateNewKey must be guarded by a cs_wallet lock
2022-02-27 09:20:44 -07:00
Kris Nuttycombe 399ffa7f5c GenerateNewKey must be guarded by a cs_wallet lock 2022-02-26 20:13:38 -07:00
sasha 077f5550d4 remove superfluous space at end of native_packages line 2022-02-25 14:43:13 -08:00
Taylor Hornby 7d9dda4b7e
Merge pull request #5576 from superbaud/use-debian-libtinfo
fix breakage on Arch by using Debian libtinfo5_6.0 to satisfy clang
2022-02-24 16:33:13 -07:00
Steven 82c33596b9
Merge pull request #5580 from steven-ecc/update-transaction-size-estimation
Update transaction size estimation to include V5 transactions
2022-02-23 20:16:58 -08:00
Steven Smith a0740650c3 Update transaction size estimation to include V5 transactions 2022-02-23 16:49:01 -08:00
John Newbery 4942020624 Log calls to getblocktemplate
(cherry picked from commit bitcoin/bitcoin@1352092dbd)
2022-02-22 22:14:36 -07:00
sasha eab7efcae5 explain the 0x0f0f[..]0f0f powLimit constant for regtest 2022-02-22 11:21:37 -08:00
Kris Nuttycombe bb91c9fbc3
Merge pull request #5549 from therealyingtong/cache-ua
Cache UA recipients passed to `z_sendmany`
2022-02-22 09:05:13 -07:00
sasha 2d6dcd4750 on Arch only, use Debian's libtinfo5_6.0 to satisfy clang 2022-02-21 20:28:03 -08:00
therealyingtong 1dae16a41c WriteRecipientMapping: Check that receiver exists in UA.
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-22 11:53:23 +08:00
ying tong 2943e13c8b
Apply docfixes from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-22 08:44:09 +08:00
therealyingtong 108e9d4658 CSerializeRecipientAddress: add Read method and make constructor private.
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2022-02-18 16:39:43 +08:00
therealyingtong 99a69182cd Docfixes. 2022-02-18 13:55:58 +08:00
therealyingtong 4c4ee558d6 ShieldToAddress: Factor out static shieldToAddress() helper. 2022-02-18 13:55:23 +08:00
str4d 6cd5b8792b
Merge pull request #5560 from steven-ecc/z_gettreestate_update_for_orchard
Add Orchard support to the z_gettreestate RPC
2022-02-18 03:17:05 +00:00
Kris Nuttycombe d08c992b5e Move parsing of unified addresses to UnifiedAddress.
In cases where we want to be able to decode a string that
is known to be a unified address, it doesn't make sense to have
to route through KeyIO::DecodePaymentAddress and then return
an error depending upon the result type, when it's possible to
provide unified address parsing more directly.

KeyIO::DecodePaymentAddress has been modified to delegate
to UnifiedAddress::Parse
2022-02-17 18:27:15 -07:00
Larry Ruane ba9e020fcd add functional test 2022-02-17 16:47:59 -07:00
Kris Nuttycombe 73a75a37fe Make SaveRecipientMappings polymorphic in RecipientMapping type. 2022-02-17 08:55:59 -07:00
Steven Smith 59c6b028f7 Add Orchard support to the z_gettreestate RPC 2022-02-17 06:14:21 -08:00
therealyingtong 79c0514919 z_sendmany: Only get ua if decoded is ua variant. 2022-02-17 19:38:02 +08:00
Steven ffdc11c378
Merge pull request #5555 from steven-ecc/deprecate_rpcs
Mark z_gettotalbalance and dumpwallet as deprecated
2022-02-16 15:58:46 -08:00
Daira Hopwood 816649db2a
Cosmetic whitespace change 2022-02-16 22:19:59 +00:00
Steven Smith 512c862a5f Mark z_gettotalbalance and dumpwallet as deprecated 2022-02-16 08:47:34 -08:00
str4d d0d6d47aa7
Merge pull request #5545 from LarryRuane/2022-02-z_listreceivedbyaddress-reject-ua-component
z_listreceivedbyaddress: reject UA component addr (#5537)
2022-02-16 16:30:34 +00:00
therealyingtong 94ab8e4c77 Implement read and write for (txid, recipient) -> ua mapping.
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Co-authored-by: Jack Grigg <jack@z.cash>
2022-02-16 20:15:07 +08:00
Taylor Hornby a2c647d4bf Untested, not working yet, use libtinfo from the debian packages 2022-02-15 14:01:54 -07:00
Larry Ruane 698f7ba770 z_listreceivedbyaddress: reject UA component addr (#5537) 2022-02-15 09:19:09 -07:00