From 60f660e53f5ad7e1eb5ea8e6a5e9cb8cf62b15f1 Mon Sep 17 00:00:00 2001 From: Janito Vaqueiro Ferreira Filho Date: Fri, 21 May 2021 21:53:25 +0000 Subject: [PATCH] Test if validation doesn't offset past times Use some mock gossiped peers that all have `last_seen` times in the past and check that they don't have any changes to the `last_seen` times applied by the `validate_addrs` function. --- .../peer_set/candidate_set/tests/vectors.rs | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/zebra-network/src/peer_set/candidate_set/tests/vectors.rs b/zebra-network/src/peer_set/candidate_set/tests/vectors.rs index 53828f3e9..04e47ce41 100644 --- a/zebra-network/src/peer_set/candidate_set/tests/vectors.rs +++ b/zebra-network/src/peer_set/candidate_set/tests/vectors.rs @@ -34,6 +34,25 @@ fn offsets_last_seen_times_in_the_future() { assert_eq!(validated_peers, expected_peers); } +/// Test that offset is not applied if all addresses have `last_seen` times that are in the past. +#[test] +fn doesnt_offset_last_seen_times_in_the_past() { + let last_seen_limit = DateTime32::now(); + let last_seen_limit_chrono = last_seen_limit.to_chrono(); + + let input_peers = mock_gossiped_peers(vec![ + last_seen_limit_chrono - Duration::minutes(30), + last_seen_limit_chrono - Duration::minutes(45), + last_seen_limit_chrono - Duration::days(1), + ]); + + let validated_peers: Vec<_> = validate_addrs(input_peers.clone(), last_seen_limit).collect(); + + let expected_peers = input_peers; + + assert_eq!(validated_peers, expected_peers); +} + /// Create a mock list of gossiped [`MetaAddr`]s with the specified `last_seen_times`. /// /// The IP address and port of the generated ports should not matter for the test.