From 694390c50b9af6d817b727f2ca12c75f0bd5bde4 Mon Sep 17 00:00:00 2001 From: teor Date: Thu, 22 Sep 2022 04:47:28 +1000 Subject: [PATCH] change(dev): Add CHANGELOG checks to PR review template (#5202) * Ask PR reviewer to check name, labels, and CHANGELOG * Re-phrase extra CHANGELOG info --- .github/pull_request_template.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2eb1c886b..a9e7f0043 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -37,9 +37,11 @@ If you want a specific reviewer for this PR, tag them here. ### Reviewer Checklist - - [ ] Code implements Specs and Designs - - [ ] Tests for Expected Behaviour - - [ ] Tests for Errors + - [ ] Will the PR name make sense to users? + - [ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes) + - [ ] Are the PR labels correct? + - [ ] Does the code do what the ticket and PR says? + - [ ] How do you know it works? Does it have tests? ## Follow Up Work