From cf6d0cc2d596b11cfdea868f8a4ab6a35da24765 Mon Sep 17 00:00:00 2001 From: teor Date: Fri, 14 Apr 2023 14:36:38 +1000 Subject: [PATCH] fix(ux): Disable issue URLs for a known shutdown panic in abscissa (#6486) * Disable bug report URLs for a known abscissa panic * Remove trailing whitespace in deny.toml * upddate doc Co-authored-by: Deirdre Connolly --------- Co-authored-by: Alfredo Garcia Co-authored-by: Deirdre Connolly --- deny.toml | 2 +- zebrad/src/application.rs | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/deny.toml b/deny.toml index 7db861735..fe3633897 100644 --- a/deny.toml +++ b/deny.toml @@ -90,7 +90,7 @@ skip-tree = [ # wait for console-subscriber and tower to update hdrhistogram. # also wait for ron to update insta, and wait for tonic update. { name = "base64", version = "=0.13.1" }, - + # wait for proptest's rusty-fork dependency to upgrade quick-error { name = "quick-error", version = "=1.2.3" }, diff --git a/zebrad/src/application.rs b/zebrad/src/application.rs index 07608408d..4408de111 100644 --- a/zebrad/src/application.rs +++ b/zebrad/src/application.rs @@ -1,8 +1,5 @@ //! Zebrad Abscissa Application -mod entry_point; -use self::entry_point::EntryPoint; - use std::{fmt::Write as _, io::Write as _, process}; use abscissa_core::{ @@ -18,6 +15,9 @@ use zebra_state::constants::{DATABASE_FORMAT_VERSION, LOCK_FILE_ERROR}; use crate::{commands::ZebradCmd, components::tracing::Tracing, config::ZebradConfig}; +mod entry_point; +use entry_point::EntryPoint; + /// See /// Print a fatal error message and exit fn fatal_error(app_name: String, err: &dyn std::error::Error) -> ! { @@ -309,10 +309,14 @@ impl Application for ZebradApp { return false; } + // Don't ask users to create bug reports for known timeouts, duplicate blocks, + // full disks, or updated binaries. let error_str = error.to_string(); !error_str.contains("timed out") && !error_str.contains("duplicate hash") && !error_str.contains("No space left on device") + // abscissa panics like this when the running zebrad binary has been updated + && !error_str.contains("error canonicalizing application path") } });