624bbf4b9a
Update release-checklist.md ( #1810 )
...
With edits from our recent release
2021-02-24 08:56:06 +10:00
7b675bbd73
build(deps): bump futures from 0.3.12 to 0.3.13
...
Bumps [futures](https://github.com/rust-lang/futures-rs ) from 0.3.12 to 0.3.13.
- [Release notes](https://github.com/rust-lang/futures-rs/releases )
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.12...0.3.13 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-02-23 16:09:53 -05:00
58f26df5cb
build(deps): bump futures-core from 0.3.12 to 0.3.13
...
Bumps [futures-core](https://github.com/rust-lang/futures-rs ) from 0.3.12 to 0.3.13.
- [Release notes](https://github.com/rust-lang/futures-rs/releases )
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.12...0.3.13 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-02-23 11:11:35 -05:00
dab65b33eb
build(deps): bump once_cell from 1.5.2 to 1.6.0
...
Bumps [once_cell](https://github.com/matklad/once_cell ) from 1.5.2 to 1.6.0.
- [Release notes](https://github.com/matklad/once_cell/releases )
- [Changelog](https://github.com/matklad/once_cell/blob/master/CHANGELOG.md )
- [Commits](https://github.com/matklad/once_cell/compare/v1.5.2...v1.6.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-02-23 10:59:40 -05:00
7558f74c78
Bump versions for zebrad 1.0.0-alpha.3
2021-02-23 10:39:13 -05:00
d0632ea29b
Add md files to release checklist commands
2021-02-23 17:33:39 +10:00
6badfe73ca
Add fastmod example to release checklist
2021-02-23 17:31:02 +10:00
a1c507240f
Fix a release-checklist.md typo
2021-02-23 11:47:02 +10:00
304d7682f5
build(deps): bump tracing-subscriber from 0.2.15 to 0.2.16
...
Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing ) from 0.2.15 to 0.2.16.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-subscriber-0.2.15...tracing-subscriber-0.2.16 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-02-22 01:38:42 -05:00
b578d1ff2e
build(deps): bump proptest-derive from 0.2.0 to 0.3.0
...
Bumps [proptest-derive](https://github.com/AltSysrq/proptest ) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/AltSysrq/proptest/releases )
- [Changelog](https://github.com/AltSysrq/proptest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/AltSysrq/proptest/compare/proptest-derive-0.2.0...proptest-derive-0.3.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-02-22 01:33:54 -05:00
1fa41ff199
Use new bech32 methods that expect a Variant enum variant
2021-02-21 20:51:43 -05:00
dd940f7dbf
build(deps): bump bech32 from 0.7.2 to 0.8.0
...
Bumps [bech32](https://github.com/rust-bitcoin/rust-bech32 ) from 0.7.2 to 0.8.0.
- [Release notes](https://github.com/rust-bitcoin/rust-bech32/releases )
- [Commits](https://github.com/rust-bitcoin/rust-bech32/compare/v0.7.2...v0.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-02-21 20:51:43 -05:00
3af57ece7a
Partly revert "Fix poll_ready usage in ChainVerifier" ( #1735 )
...
* Revert "Fix poll_ready usage in ChainVerifier (#1700 )"
This reverts commit 0723ac5be1
2021-02-20 10:43:38 +10:00
d4f2f27218
Add global span to spawned network tasks ( #1761 )
...
Closes #1575
2021-02-20 08:36:50 +10:00
b7fddbde94
Compute the expected body length to reduce heap allocations ( #1773 )
...
* Compute the expected body length to reduce heap allocations
2021-02-19 22:18:57 +00:00
736092abb8
Apply suggestions from code review
...
Co-authored-by: teor <teor@riseup.net>
2021-02-19 14:11:35 -08:00
6f205a1812
make sure peer/error.s comments are up to date
2021-02-19 14:11:35 -08:00
2266886a53
ensure peer/client.rs comments are up to date
2021-02-19 14:11:35 -08:00
c3724031df
remove unnecessary Option around request timeout
2021-02-19 14:11:35 -08:00
651d352ce1
update comments throughout connection.rs
2021-02-19 14:11:35 -08:00
2adee7b31a
deduplicate match arms in handle_client_request
2021-02-19 14:11:35 -08:00
cfc4717b98
rename transitions from Exit to Close
2021-02-19 14:11:35 -08:00
5e4bf804aa
Remove remaining references to fail_with
2021-02-19 14:11:35 -08:00
e06705ed81
Only reject pending client requests when the peer has errored
...
- Add an `ExitClient` transition, used when the internal client channel
is closed or dropped, and there are no more pending requests
- Ignore pending requests after an `ExitClient` transition
- Reject pending requests when the peer has caused an error
(the `Exit` and `ExitRequest` transitions)
- Remove `PeerError::ConnectionDropped`, because it is now handled by
`ExitClient`. (Which is an internal error, not a peer error.)
2021-02-19 14:11:35 -08:00
9d9734ea81
rustfmt
2021-02-19 14:11:35 -08:00
5ec8d09e0d
accidental drop on mustusesender
2021-02-19 14:11:35 -08:00
6906f87ead
introduce Transition enum
2021-02-19 14:11:35 -08:00
e6cb20e13f
leverage return value for propagating errors
2021-02-19 14:11:35 -08:00
bae49e54df
Disable unreliable `sync_large_checkpoints_testnet` ( #1789 )
...
* delete `sync_large_checkpoints_testnet`
2021-02-19 21:40:01 +00:00
d4915c18e7
Fix inverted was_killed logic ( #1779 )
...
Also improve the error messages and code structure.
2021-02-20 06:26:00 +10:00
b0bc4a79c9
Disable conflict failure cleanup on macOS
2021-02-20 06:22:11 +10:00
af12f20732
Re-enable macOS conflict tests
...
We disabled these tests pending #1613 . But the comment incorrectly said
we were waiting for #1631 .
2021-02-20 06:22:11 +10:00
7bba67d97b
build(deps): bump thiserror from 1.0.23 to 1.0.24
...
Bumps [thiserror](https://github.com/dtolnay/thiserror ) from 1.0.23 to 1.0.24.
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.23...1.0.24 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-02-19 14:54:40 -05:00
9e6db31db0
Add Usability Testing Plan template to the list of issue templates ( #1519 )
2021-02-19 10:53:11 +01:00
a445cfbd55
Set ZEBRA_SKIP_NETWORK_TESTS using Windows syntax ( #1782 )
...
Use Powershell syntax to set ZEBRA_SKIP_NETWORK_TESTS on Windows.
Also skip the entire large sync test step on Ubuntu and
Windows, because the tests are skipped anyway due to
ZEBRA_SKIP_NETWORK_TESTS. This saves some
compilation time.
2021-02-19 19:36:32 +10:00
535e9d0234
Disable failing docs workflow ( #1787 )
2021-02-19 19:35:46 +10:00
1b1185518e
remove fail-fast from test job ( #1776 )
2021-02-19 18:04:01 +10:00
a9e4768d35
remove fail-fast from test job
2021-02-19 18:03:07 +10:00
c51fd688ee
Skip node2.is_running() on Windows
...
`node2.is_running()` can return `true` on Windows, even though `node2`
has logged a panic. This cleanup code only runs if `node2` fails to panic
and exit as expected. So it's ok for us to skip it.
See #1781 for details.
2021-02-19 18:03:07 +10:00
631fe22422
Fix conflict test node termination
...
On Windows, if a process is killed after it is dead, it returns `true`
for `was_killed`. Instead, check if the process is running before killing
it.
Also make the section where processes are running as short as possible,
and include context for both processes in every error.
2021-02-19 18:03:07 +10:00
7665c6792e
Fix the yaml indentation for the docs.yml workflow
...
Gotta love yaml.
2021-02-18 22:50:48 -05:00
f19ef44493
build(deps): bump tracing from 0.1.23 to 0.1.24
...
Bumps [tracing](https://github.com/tokio-rs/tracing ) from 0.1.23 to 0.1.24.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.23...tracing-0.1.24 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-02-18 22:21:49 -05:00
bcb9cead88
Kill running acceptance test nodes on error ( #1770 )
...
And show the output from those nodes.
These changes help us diagnose errors that happen while one or more
acceptance test nodes are running.
2021-02-19 06:46:27 +10:00
e61b5e50a2
Diagnostics for CI port conflict failures ( #1766 )
...
Log a "Trying..." message before each listener opens, to see if the
delay is inside Zebra, or in the test harness or OS.
Also report the configured and actual ports where possible, for better
diagnostics.
2021-02-18 12:15:09 -03:00
5424e1d8ba
Fix candidate set address state handling ( #1709 )
...
Design:
- Add a `PeerAddrState` to each `MetaAddr`
- Use a single peer set for all peers, regardless of state
- Implement time-based liveness as an `AddressBook` method, rather than
a `PeerAddrState` variant
- Delete `AddressBook.by_state`
Implementation:
- Simplify `AddressBook` changes using `update` and `take` modifier
methods
- Simplify the `AddressBook` iterator implementation, replacing it with
methods that are more obviously correct
- Consistently collect peer set metrics
Documentation:
- Expand and update the peer set documentation
We can optimise later, but for now we want simple code that is more
obviously correct.
2021-02-18 11:18:32 +10:00
579bd4a368
Retry DNS resolution on failure ( #1762 )
...
Otherwise, a transient DNS failure makes the node hang.
2021-02-18 07:09:02 +10:00
86169f6412
Update PeerSet metrics after every change ( #1727 )
2021-02-18 07:06:59 +10:00
972103d797
Fix tracing macro syntax
2021-02-17 11:09:22 -05:00
253d1c02b3
Make sync logging a bit less verbose
...
And tweak some log content
2021-02-17 11:09:22 -05:00
8d1c498234
Log initial peer connection failures
...
And standardise another log message
2021-02-17 09:21:53 -05:00
Deirdre Connolly
dependabot[bot]
teor
ebfull
Jane Lusby
Jane Lusby
Alfredo Garcia
Pili Guerra