b90581a3d7
zebrad: create a Downloads Stream for syncing.
...
This makes two changes relative to the existing download code:
1. It uses a oneshot to attempt to cancel the download task after it
has started;
2. It encapsulates the download creation and cancellation logic into a
Downloads struct.
2020-10-26 12:05:35 -07:00
8e709bfa88
network: don't fail on unsolicited messages
...
These messages might be unsolicited, or they might be a response to a
request we already canceled. So don't fail the whole connection, just
drop the message and move on.
2020-10-26 12:05:35 -07:00
13daefa729
network: handle request cancellation in Connection
...
We handle request cancellation in two places: before we transition into
the AwaitingResponse state, and while we are in AwaitingResponse. We
need both places, or else if we started processing a request, we
wouldn't process the cancellation until the timeout elapsed.
The first is a check that the oneshot is not already canceled.
For the second, we wait on a cancellation, either from a timeout or from
the tx channel closing.
2020-10-26 12:05:35 -07:00
b636660d6a
zebrad: rename sync::Error alias to BoxError.
2020-10-26 12:05:35 -07:00
a141c336ab
Actually fix whitespace
2020-10-26 13:49:48 -04:00
bbe4aa47ea
Fix whitespace for rustfmt
2020-10-26 13:49:48 -04:00
2fa3d8a8f4
Add a comment explaining why block metrics follow validation
2020-10-26 13:49:48 -04:00
f5a53d9dae
Update block metrics after async transaction verification
2020-10-26 13:49:48 -04:00
fb079c2ca1
Replace BlockHeaderHash with block::Hash
2020-10-26 22:27:57 +10:00
a9102e8d6d
Fix State RFC rendering ambiguities
2020-10-26 22:02:45 +10:00
0935b3305a
Fix more state RFC function heading sizes
2020-10-26 21:14:14 +10:00
7bf2fdd6d7
Fix a header level in the state RFC
2020-10-26 21:11:26 +10:00
60322c3d48
Test that the checkpoint list gap is correct
...
If we change the gap, but don't rebuild the lists, `zebrad` hangs with
weird errors.
2020-10-26 20:59:40 +10:00
f9dc481934
Rebuild the checkpoint lists with smaller checkpoints
2020-10-26 20:59:40 +10:00
20dfd04463
Reduce maximum checkpoint size in the Zebra code
...
The new limits are 400 blocks and 32 MB.
2020-10-26 20:59:40 +10:00
672b39a847
Use MAX_BLOCK_REORG_HEIGHT in zebra-checkpoints
...
MAX_BLOCK_REORG_HEIGHT is 1 less than the constant it replaces. The new
calculation is correct: the 100th block is finalized.
2020-10-26 20:59:40 +10:00
90e755472c
Add data source instructions to the metrics help
2020-10-23 15:06:37 -04:00
b492cabeee
Bind grafana to localhost in metrics instructions
...
Binding grafana to localhost makes it inaccessible from the wider internet,
which is a secure default.
Since we run docker with host networking, docker containers have access to D-Bus and other
security-related services on localhost. So it's risky to also expose them to the wider internet.
2020-10-23 15:06:37 -04:00
ff51c2e0c0
build(deps): bump tracing-subscriber from 0.2.13 to 0.2.14
...
Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing ) from 0.2.13 to 0.2.14.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-subscriber-0.2.13...tracing-subscriber-0.2.14 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-10-23 15:02:02 -04:00
cab96aa1a8
zebrad: clarify config help text ( #1194 )
2020-10-22 15:03:01 +10:00
6dc95b1d6d
Revise the checkpoint verifier metrics ( #1195 )
...
* update continuous and processing.next metrics correctly
* remove duplicate metrics
* rename ambiguous metrics
2020-10-21 20:06:26 -07:00
d745d2b47c
Stop assuming Mainnet in Address From impls ( #1191 )
2020-10-22 07:58:52 +10:00
21ad6ffc47
Reverse displayed endianness of transaction and block hashes ( #1171 )
...
* Reverse displayed endianness of transaction and block hashes
* fix zebra-checkpoints utility for new hash order
* Stop using "zebrad revhex" in zebrad-hash-lookup
* Rebuild checkpoint lists in new hash order
This change also adds additional checkpoints to the end of each list.
* Replace TransactionHash with transaction::Hash
This change should have been made in #905 , but we missed Debug impls
and some docs.
Co-authored-by: Ramana Venkata <vramana@users.noreply.github.com>
Co-authored-by: teor <teor@riseup.net>
2020-10-22 07:54:02 +10:00
a5a86622d4
Add team approval to the RFC pull request template ( #1178 )
2020-10-21 11:36:23 -07:00
e52a1c07a3
Ignore longer sync tests by default
2020-10-21 21:08:04 +10:00
0d121833af
Add sync tests that download 2000 blocks
2020-10-21 21:08:04 +10:00
b4f92adc40
Disable sync tests on Windows CI
2020-10-21 00:58:08 -04:00
6fe3cc56dd
Refactor sync test to be more flexible
...
And add documentation
2020-10-21 00:58:08 -04:00
17a3612b36
Remove a redundant condition in expect_stdout
...
When the loop exits, either the process has stopped running,
or the deadline has passed.
If the process is still running, we want to kill it.
2020-10-21 00:58:08 -04:00
0343e28d3a
Disable sync test on ubuntu CI runners
...
They don't seem to have DNS or network configured during the tests.
Also make capitalisation of step names consistent.
2020-10-21 00:58:08 -04:00
1d35c5a0b9
Enable the zebrad sync tests by default
...
If your test environment does not have DNS or network access, set the
ZEBRA_SKIP_NETWORK_TESTS environmental variable to disable these tests.
2020-10-21 00:58:08 -04:00
9549e180c0
Allow dead_code on parameters for now
2020-10-20 11:16:22 -04:00
a7ef6f6a40
Allow dead_code for checkpoint::Verifier for now
2020-10-20 11:16:22 -04:00
e796132057
Allow dead_code for the transaction::Request for now (mempool)
2020-10-20 11:16:22 -04:00
eb43893de0
consensus: minimize API, clean docs
...
This reduces the API surface to the minimum required for functionality,
and cleans up module documentation. The stub mempool module is deleted
entirely, since it will need to be redone later anyways.
2020-10-20 11:16:22 -04:00
d4ce3eb054
consensus: improve docs
...
- remove no longer accurate documentation about transaction verifier;
- add description of the role of the crate.
2020-10-20 11:16:22 -04:00
c0aa1b477e
consensus: add #[source] attributes to chain errors
2020-10-20 11:16:22 -04:00
8a64c056fb
consensus: integrate block, transaction Verifiers
2020-10-20 11:16:22 -04:00
4a36c4485a
consensus: integrate script, transaction Verifiers
2020-10-20 11:16:22 -04:00
248c318906
consensus: sketch of transaction::Verifier
...
This squashes the previous sequence of commits to let us separate out
the structural skeleton (which unblocks other work and is not
consensus-critical) from the actual checks (which don't block other work
and are consensus-critical).
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
2020-10-20 11:16:22 -04:00
9dc8d76d68
consensus: add stub groth16::Verifier
...
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
2020-10-20 11:16:22 -04:00
eb56666d30
chain: add ShieldedData::binding_verification_key()
2020-10-20 11:16:22 -04:00
5a78bbb6c9
Add nullifiers(), and note_commitments() to ShieldedData
2020-10-20 11:16:22 -04:00
97b6ba10cc
Use redjubjub crate exported from zebra-chain in the redjubjub::Verifier
2020-10-20 11:16:22 -04:00
f9de91716c
Add docstrings for sighash
2020-10-20 11:16:22 -04:00
db54a623b7
Export sighash::HashType
2020-10-20 11:16:22 -04:00
5df0ff4086
Add Clippy (stable) job and continue-on-error Clippy (nightly) job
...
Do not pass -- -D warnings to the Clippy (nightly) job
We do _not_ want the nightly job to fail on warnings.
Resolves #1156
2020-10-20 01:03:43 -04:00
0856e5d654
build(deps): bump codecov/codecov-action from v1.0.13 to v1.0.14
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from v1.0.13 to v1.0.14.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Commits](https://github.com/codecov/codecov-action/compare/v1.0.13...7d5dfa54903bd909319c580a00535b483d1efcf3 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-10-19 10:59:44 -04:00
8def574bc2
Activate the standard pull request template by default
...
Non-default pull request templates can be used via the CLI,
or a URL query parameter:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters
2020-10-17 17:20:41 -04:00
2358091a37
build(deps): bump serde from 1.0.116 to 1.0.117
...
Bumps [serde](https://github.com/serde-rs/serde ) from 1.0.116 to 1.0.117.
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.116...v1.0.117 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-10-16 15:26:00 -04:00
Henry de Valence
teor
dependabot[bot]
Alfredo Garcia
Deirdre Connolly
Jane Lusby