628b3e39af
fix(net): Add outer timeouts for critical network operations to avoid hangs ( #7869 )
...
* Refactor out try_to_sync_once()
* Add outer timeouts for obtaining and extending tips
* Refactor out request_genesis_once()
* Wrap genesis download once in a timeout
* Increase the genesis timeout to avoid denial of service from old nodes
* Add an outer timeout to mempool crawls
* Add an outer timeout to mempool download/verify
* Remove threaded mutex blocking from the inbound service
* Explain why inbound readiness never hangs
* Fix whitespace that cargo fmt doesn't
* Avoid hangs by always resetting the past lookahead limit flag
* Document block-specific and syncer-wide errors
* Update zebrad/src/components/sync.rs
Co-authored-by: Marek <mail@marek.onl>
* Use correct condition for log messages
Co-authored-by: Marek <mail@marek.onl>
* Keep lookahead reset metric
---------
Co-authored-by: Arya <aryasolhi@gmail.com>
Co-authored-by: Marek <mail@marek.onl>
2023-11-02 15:00:18 +00:00
afbe807060
change(docs): Replace doc.zebra.zfnd.org API documentation with docs.rs ( #7886 )
...
* Simple replacements of doc.zebra.zfnd.org with docs.rs
* Manual fixes for specific main/internal/external docs
* Point developer docs to doc-internal.zebra.zfnd.org
* fastmod --glob '\!.git' -- doc.zebra.zfnd.org/zebrad docs.rs/zebrad/latest/zebrad
* Manually remove any remaining doc.zfnd.zebra.org links
* Remove the external docs job
* Add changelog entry and fix links
* Fix links that were broken before this PR
2023-11-01 22:09:40 +00:00
daabe8b196
build(deps): bump the devops group with 1 update ( #7887 )
...
Bumps the devops group with 1 update: [tj-actions/changed-files](https://github.com/tj-actions/changed-files ).
- [Release notes](https://github.com/tj-actions/changed-files/releases )
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md )
- [Commits](https://github.com/tj-actions/changed-files/compare/v39.2.4...v40.0.2 )
---
updated-dependencies:
- dependency-name: tj-actions/changed-files
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: devops
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-01 19:51:34 +00:00
b78c9dd802
change(deps): `cargo update` on commit bd06294 on 2023-11-01 ( #7885 )
...
* `cargo update` on commit bd06294
2023-11-01 18:26:16 +00:00
898b40f9fd
Update README.md before 1.4.0 release ( #7884 )
2023-10-31 22:58:37 +00:00
bd062941b9
build(deps): bump the prod group with 2 updates ( #7881 )
...
Bumps the prod group with 2 updates: [clap](https://github.com/clap-rs/clap ) and [serde_json](https://github.com/serde-rs/json ).
Updates `clap` from 4.4.6 to 4.4.7
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/v4.4.6...v4.4.7 )
Updates `serde_json` from 1.0.107 to 1.0.108
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.107...v1.0.108 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: prod
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: prod
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-31 13:15:47 +00:00
e94be80f17
change(devops): Split dependency upgrades into 4 large categories ( #7848 )
...
* try groups with more than 10 items.
* reorgs dependabot groups, condenses patterns
* Tries using `dependency-type`
2023-10-31 00:32:58 +00:00
b0555c0e61
build(deps): bump the test group with 1 update ( #7876 )
...
* build(deps): bump the test group with 1 update
Bumps the test group with 1 update: [tempfile](https://github.com/Stebalien/tempfile ).
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/commits )
---
updated-dependencies:
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: test
...
Signed-off-by: dependabot[bot] <support@github.com>
* add duplicated dependency
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
2023-10-30 22:08:34 +00:00
0d3892f61f
change(state): Refactor the naming of note commitment subtrees ( #7855 )
...
* Rename `node` & `Node` to `root` & `Root`
* Rename `end` to `end_height`
* Rename `Root` to `SubtreeRoot`
2023-10-30 20:06:54 +00:00
f3048653c8
chore: fix typos ( #7877 )
...
Co-authored-by: Dimitris Apostolou <dimitris.apostolou@icloud.com>
2023-10-30 20:06:35 +00:00
d0e5b2f3ef
build(deps): bump the async group with 2 updates ( #7872 )
...
Bumps the async group with 2 updates: [futures](https://github.com/rust-lang/futures-rs ) and [tokio-util](https://github.com/tokio-rs/tokio ).
Updates `futures` from 0.3.28 to 0.3.29
- [Release notes](https://github.com/rust-lang/futures-rs/releases )
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.28...0.3.29 )
Updates `tokio-util` from 0.7.9 to 0.7.10
- [Release notes](https://github.com/tokio-rs/tokio/releases )
- [Commits](https://github.com/tokio-rs/tokio/commits )
---
updated-dependencies:
- dependency-name: futures
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: async
- dependency-name: tokio-util
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: async
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-30 18:26:53 +00:00
ad0051c228
build(deps): bump the formats group with 1 update ( #7874 )
...
Bumps the formats group with 1 update: [serde](https://github.com/serde-rs/serde ).
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.189...v1.0.190 )
---
updated-dependencies:
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: formats
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-30 18:26:30 +00:00
9cbb108805
Update full sync test URL in release ticket template ( #7830 )
2023-10-30 15:15:11 +00:00
df55201c87
chore(clippy): Cleanup nightly clippy warnings from 2023-10-30 ( #7868 )
...
* Use first() rather than get(0)
* Remove unused imports and silence test-related warnings
* More clippy fixes
2023-10-30 12:21:05 +00:00
49a9e598bf
Update mainnet and testnet checkpoints on 2023-10-30 ( #7866 )
2023-10-30 12:20:54 +00:00
7e7f989545
Fix new nightly clippy and rustc lints ( #7860 )
2023-10-27 19:35:57 +00:00
e4c3f95d27
chore: fix typos ( #7862 )
...
Co-authored-by: vuittont60 <81072379+vuittont60@users.noreply.github.com>
2023-10-27 17:45:43 +00:00
5367ccbc5c
fix(network): Reconnect with peers after brief network interruption ( #7853 )
...
* Fixes bug where Zebra won't reconnect to peers after brief loss of network connectivity
* only dial on timercrawl when theres a new address or zero active outbound conns
2023-10-27 06:13:16 +00:00
0a3790b73e
change(consensus): Remove Sprout and Sapling parameter download task and debug_skip_preload config ( #7844 )
...
* removes groth16 download task
* updates docs.
* Adds new config to test configs
* fixes compatibility with past configs
* uses inner config to deserialize removed field for compatibility
* update docs
* updates latest config
* Applies suggestions from code review
* Avoid duplicating hard-coded default values
---------
Co-authored-by: teor <teor@riseup.net>
2023-10-27 06:12:57 +00:00
d145526ad7
Remove unused deny.toml entries ( #7818 )
2023-10-27 01:05:46 +00:00
920ee14512
fix(doc): Fix broken links to `zebra_network` and `zebra_state` `Config` structs on doc.zebra.zfnd.org ( #7838 )
...
* Use full module paths to avoid a rustdoc bug
* Exclude zebra-test from external docs
2023-10-27 01:05:26 +00:00
b6fc0add9a
remove the zebra icon ( #7849 )
...
from the state lib
2023-10-26 23:59:52 +00:00
ce22be37dc
change(docs): Add macOS M1 as a tier 3 supported platform ( #7851 )
...
* Add macOS M1 as a tier 3 supported platform
* Add apple machine brand name that users will know
2023-10-26 22:08:22 +00:00
64bf38c17c
Make macOS a tier 2 supported platform in the docs. closes #7824 ( #7843 )
2023-10-26 19:17:47 +00:00
879fd5f37e
Revert #6825 ( #7834 )
...
* revert #6825
* remove todo comment from CI
2023-10-26 12:48:09 +00:00
06ab529877
docs: Refactor the installation instructions for `s-nomp` ( #7835 )
...
* Remove references to `getblocktemplate-rpcs`
* Refactor the sync description
* Refactor the instructions for installing `s-nomp`
* Mention Node 10 instead of 8.11
* Refactor the description of Zebra's sync
Co-authored-by: teor <teor@riseup.net>
---------
Co-authored-by: teor <teor@riseup.net>
2023-10-26 00:06:40 +00:00
71a9865b6c
remove(cmd): Remove `zebrad download` command, because it no longer does anything ( #7819 )
...
* Remove the `zebrad download` command
* Reorder command.rs imports
* Remove zcash-params/Dockerfile and the main Dockerfile commands that use it
* Stop building zcash-params Docker images in CI
* Update CHANGELOG for `zebrad download` removal
* Clarify why the image is smaller
Co-authored-by: Marek <mail@marek.onl>
---------
Co-authored-by: Marek <mail@marek.onl>
2023-10-25 23:42:27 +00:00
a126acb160
change(doc): Document state format upgrade implementation and testing ( #7799 )
...
* Explain verification modes
* Explain block write modes
* Expand upgrade goals
* Document testing requirements
* Update current format docs
* Move the detailed checklist to the ticket template
* Move an example back
* Reword confusing paragraphs
Co-authored-by: Arya <aryasolhi@gmail.com>
* Explain the difference between major and minor/patch versions
* Simplify upgrade wording
Co-authored-by: Marek <mail@marek.onl>
---------
Co-authored-by: Arya <aryasolhi@gmail.com>
Co-authored-by: Marek <mail@marek.onl>
2023-10-25 22:18:41 +00:00
b244d5628c
build(deps): bump tj-actions/changed-files from 39.2.3 to 39.2.4 ( #7826 )
...
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files ) from 39.2.3 to 39.2.4.
- [Release notes](https://github.com/tj-actions/changed-files/releases )
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md )
- [Commits](https://github.com/tj-actions/changed-files/compare/v39.2.3...v39.2.4 )
---
updated-dependencies:
- dependency-name: tj-actions/changed-files
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-25 22:00:04 +00:00
06f381230a
build(deps): bump Swatinem/rust-cache from 2.7.0 to 2.7.1 ( #7825 )
...
Bumps [Swatinem/rust-cache](https://github.com/swatinem/rust-cache ) from 2.7.0 to 2.7.1.
- [Release notes](https://github.com/swatinem/rust-cache/releases )
- [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md )
- [Commits](https://github.com/swatinem/rust-cache/compare/v2.7.0...v2.7.1 )
---
updated-dependencies:
- dependency-name: Swatinem/rust-cache
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-25 21:59:53 +00:00
0e00ef4f4f
Increase Docker unit test timeout ( #7814 )
2023-10-25 09:37:52 +00:00
c173198d4f
docs(build): Add ECC dependencies documentation ( #7794 )
...
* add ecc dependencies documentation
* add `cargo deny` suggestion to deny.toml section
Co-authored-by: Arya <aryasolhi@gmail.com>
* change sententence syntax
Co-authored-by: Arya <aryasolhi@gmail.com>
* Apply suggestions from code review
Co-authored-by: teor <teor@riseup.net>
* move consistency check
---------
Co-authored-by: Arya <aryasolhi@gmail.com>
Co-authored-by: teor <teor@riseup.net>
2023-10-25 03:27:16 +00:00
ae10eafb57
Update Dockerfile features comment ( #7815 )
2023-10-25 02:38:34 +00:00
aad883b68a
change(consensus): Build Sprout and Sapling parameters into the zebrad binary, so a download server isn't needed ( #7800 )
...
* Build sapling parameters into zebrad
* Load the sapling parameters from wagyu-zcash-parameters
* Reword logs
* wget https://github.com/zcash/zcash/raw/master/src/rust/src/sprout-groth16.vk
* Load sprout from binary and remove download code
* Remove download examples binaries
* Remove unused features and dependencies
* Remove docs and comments about downloading parameters
* Add CHANGELOG entry
* Remove parameter cache steps in workflows
* Update comment about downloading
Co-authored-by: Marek <mail@marek.onl>
* Fix outdated timeout comments and short timeouts
---------
Co-authored-by: Marek <mail@marek.onl>
2023-10-24 23:27:24 +00:00
bb7eeb6f76
Document how to fix deny.toml warnings ( #7806 )
2023-10-24 13:12:57 +00:00
37a3c2a511
build(deps): bump the formats group with 1 update ( #7803 )
...
Bumps the formats group with 1 update: [serde_with](https://github.com/jonasbb/serde_with ).
- [Release notes](https://github.com/jonasbb/serde_with/releases )
- [Commits](https://github.com/jonasbb/serde_with/compare/v3.3.0...v3.4.0 )
---
updated-dependencies:
- dependency-name: serde_with
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: formats
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-23 19:19:08 +00:00
e56b66d182
build(deps): bump the app group with 1 update ( #7802 )
...
Bumps the app group with 1 update: [toml](https://github.com/toml-rs/toml ).
- [Commits](https://github.com/toml-rs/toml/compare/toml-v0.8.2...toml-v0.8.3 )
---
updated-dependencies:
- dependency-name: toml
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: app
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-23 19:18:56 +00:00
b04cca9ec5
change(dev doc): Document how to change branch protection rules ( #7773 )
...
* Document branch protection rules
* Document automatic jobs for new crates
* Link to patch workflow docs
* Update book/src/dev/continuous-integration.md
Co-authored-by: Marek <mail@marek.onl>
---------
Co-authored-by: Gustavo Valverde <gustavo@iterativo.do>
Co-authored-by: Marek <mail@marek.onl>
2023-10-22 15:40:19 +00:00
60b447bef2
change(ci): Remove duplicate CI jobs for getblocktemplate-rpcs ( #7753 )
...
* Remove duplicate CI docker job and make features consistent
* Remove duplicate OS job
* Rename experimental release build
* Make Rust features into GitHub repository variables
* Remove redundant features in entrypoint.sh
* Remove a dependency on a deleted job
* Fix syntax of array
* Another fix attempt
* Undo some accidental merge overwrites
* Add missing space
* Explain how default is implemented
* Fix missing --features and quoting
* We can fix this later
* Use vars directly in with: blocks
* Use correct features for fake activation heights test
2023-10-22 15:40:10 +00:00
92f473240b
change(docs): Add changelog entry for stable mining feature ( #7788 )
...
* Add changelog entry for stable mining feature
* Fix typos and clarify
Co-authored-by: Marek <mail@marek.onl>
* Update mining section in README.md
* Add missing word
Co-authored-by: Arya <aryasolhi@gmail.com>
---------
Co-authored-by: Marek <mail@marek.onl>
Co-authored-by: Arya <aryasolhi@gmail.com>
2023-10-20 17:31:04 +00:00
06a29831e2
cleanup(state): Refactor subtree read functions to accept ranges and check memory first ( #7739 )
...
* refactors sapling_subtrees to use ranges
* refactor orchard_subtrees() to use ranges
* Restores check for inconsistent subtree roots
* updates vectors tests
* Applies some suggestions from code review and adds `read::tree::subtrees` function
* updates correctness comment & db read method names
* adds test_subtrees
* tests in-memory reads
* test that subtree read fns work right with excluded start bound
* applies suggestions from code review
* Applies suggestions from code review.
* Updates docs applying suggestion from code review
* adds new arg to zs_range_iter calls
2023-10-20 05:06:05 +00:00
9c993f82e2
build(deps): bump ECC dependencies ( #7784 )
...
* bump the versions
* replace `is_odd()` with `is_right_child()`
---------
Co-authored-by: teor <teor@riseup.net>
2023-10-20 02:12:02 +00:00
56e6305f04
change(state): Set iterator read bounds where possible in DiskDb ( #7731 )
...
* Adds zs_iter_opts method
* uses checked_add
* uses zs_range_iter for other read methods
* fixes bug
* Fixes bug in zs_iter_opts
* Adds test & updates method docs
* updates docs
* Update zebra-state/src/service/finalized_state/disk_db/tests.rs
* Corrects code comment
* adds support for variable-sized keys
* adds test case
* Updates docs
* Applies suggestions from code review
* Add extra checks
* Fix test code and rustfmt
* fixes test
* fixes test
* adds reverse arg to new zs_range_iter calls
---------
Co-authored-by: teor <teor@riseup.net>
2023-10-20 00:44:48 +00:00
ab3ce9a277
Fix an incorrect consensus-critical comment ( #7774 )
...
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
2023-10-19 22:18:22 +00:00
126b5ad93e
build(deps): bump shimataro/ssh-key-action from 2.5.1 to 2.6.1 ( #7767 )
...
Bumps [shimataro/ssh-key-action](https://github.com/shimataro/ssh-key-action ) from 2.5.1 to 2.6.1.
- [Release notes](https://github.com/shimataro/ssh-key-action/releases )
- [Changelog](https://github.com/shimataro/ssh-key-action/blob/v2/CHANGELOG.md )
- [Commits](https://github.com/shimataro/ssh-key-action/compare/v2.5.1...v2.6.1 )
---
updated-dependencies:
- dependency-name: shimataro/ssh-key-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-19 19:31:35 +00:00
56e48eea2f
build(deps): bump actions/checkout from 4.1.0 to 4.1.1 ( #7766 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-19 17:05:38 +00:00
64f777274c
fix(security): fix concurrency issues in tree key formats, and CPU usage in genesis tree roots ( #7392 )
...
* Add tree key format and cached root upgrades
* Document the changes in the upgrades
* Remove unnecessary clippy::unwrap_in_result
* Fix database type
* Bump state version
* Skip some checks if the database is empty
* Fix tests for a short state upgrade
* Disable format checks in some tests
* Document state performance issues
* Clarify upgrade behaviour
* Clarify panic messages
* Delete incorrect genesis trees write code
* Fix metrics handling for genesis
* Remove an unused import
* Explain why genesis anchors are ok
* Update snapshots
* Debug a failing test
* Fix some tests
* Fix missing imports
* Move the state check in a test
* Fix comment and doc typos
Co-authored-by: Marek <mail@marek.onl>
Co-authored-by: Arya <aryasolhi@gmail.com>
* Clarify what a long upgrade is
* Rename unused function arguments
Co-authored-by: Marek <mail@marek.onl>
* Add all_unordered log regex matching methods
* Fix timing issues with version upgrades and other logs
* Fix argument name in docs
Co-authored-by: Marek <mail@marek.onl>
* Explain match until first for all regexes behaviour better
---------
Co-authored-by: Marek <mail@marek.onl>
Co-authored-by: Arya <aryasolhi@gmail.com>
2023-10-19 14:50:46 +00:00
8c01fecc91
Limit jobs launched by the crates workflow ( #7754 )
2023-10-19 13:41:23 +00:00
92a074abdf
build(deps): bump tj-actions/changed-files from 39.2.1 to 39.2.3 ( #7768 )
...
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files ) from 39.2.1 to 39.2.3.
- [Release notes](https://github.com/tj-actions/changed-files/releases )
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md )
- [Commits](https://github.com/tj-actions/changed-files/compare/v39.2.1...v39.2.3 )
---
updated-dependencies:
- dependency-name: tj-actions/changed-files
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-19 13:41:10 +00:00
2f14efac24
fix(ci): Add missing timeouts to CI and CD tests ( #7730 )
...
* Add missing timeouts to CI and CD tests
* Remove timeout keys that are not allowed by the syntax
2023-10-19 12:30:53 +00:00
teor
dependabot[bot]
Arya
Marek
Alfredo Garcia
Pili Guerra