0f70d0b8a5
The constructor() concept doesn't exist
...
Did it ever?
2015-12-29 22:59:25 +09:00
9d9fcbde64
Proper treatment of restored hardware wallets
...
They have a different wallet type; they require no plugin nor
plugin libraries to use.
Remove pointless public key code that was implemented in the
base classes already.
Partial fix for #1592 . Unfortunately the plugin and library
are still required to actually restore the wallet, but for
no reason that isn't fixable.
2015-12-28 20:24:15 +09:00
11e1c62f28
Move hardware wallet to trezor/
...
On second thoughts it does go better there.
2015-12-27 18:23:46 +09:00
669cf74789
Fix trezor restore
...
Broken by my recent changes
2015-12-27 15:38:52 +09:00
3a1bb5b61a
Combine keepkey and trezor wallet code
...
Essentially identical so silly to have two copies.
Also fix a double-dialog during sign bug that caused one to not
disappear (on MacOSX at least).
2015-12-26 16:25:10 +09:00
c298860e11
A fix and cleanups for hardware wallets
2015-12-26 12:02:19 +09:00
a58c19d7c0
Clean up and fix account adding
...
As per BIP44, 20 addresses are checked for transactions, not just the
first one.
Show the last account only if used or named.
If all accounts are used, prompt for password to create new one.
Fixes #1128
2015-12-25 23:34:04 +09:00
72fdf0cd21
Better error when opening a non-wallet file
...
Also window modality fixes for __init__.py
2015-12-23 13:54:43 +09:00
e1c0298fc2
Write the wallet less often
...
This should speed up synchronization / restoration of large wallets.
Wallets are written only when they switch to up_to_date state, or
when stop_threads() is called when closing the daemon, or when
a command line command finishes.
2015-12-20 15:47:46 +09:00
0a3d74de8f
Avoid index-out-of-range
...
Also add sanity assertion
2015-12-20 12:19:44 +09:00
9d3162b1a1
simplify get_label
2015-12-15 12:52:30 +01:00
06eb3142c4
Oldest First
2015-12-12 19:01:14 +09:00
52fc739052
Update default chooser name too.
2015-12-12 18:39:03 +09:00
75b3ecee49
Add coin chooser to try and minimize loss of privacy.
2015-12-09 22:20:23 +09:00
4682d95a76
merge jsonrpc gui and daemon
2015-11-30 10:09:54 +01:00
9a6dcf7b1e
Use bucketing to choose coins
...
Bucketing is generalization of coin chooser logic that makes it easy
to implement other algorithms.
- Put core coin chooser functionality in base class.
- Specialize derived class to implement classic electrum algorithm of
oldest coins first. One bucket per output.
No intended change in behaviour.
Coin chooser now sorts the coins as it wants; remove redundant sorting
from get_spendable_coins().
2015-11-29 17:59:36 +09:00
93bb09230c
Track tx size directly; calculate fees from that
...
This has several advantages. Fee calculation is now very fast,
as we don't need to keep reserializing the tx. Another is that
we can reason about the fees after adding a change output without
having to add it, recalculate the tx fee, and remove it again.
2015-11-29 15:40:11 +09:00
a4dd5acc48
Prepare to calculate tx fee given a tx size
2015-11-29 12:41:54 +09:00
d97106f17d
Don't keep dust change in any case
2015-11-28 22:27:01 +09:00
8785b65a1f
Remove need for coin chooser to take a wallet
2015-11-28 22:12:20 +09:00
a6ea9a0c71
Simplify interface to make_tx in coin chooser
...
Makes the coin chooser code simpler and easier to understand.
2015-11-28 22:08:00 +09:00
90dee43998
Move estimated_fee to Transaction class
...
It's not a function of the wallet but of the transaction
so it more naturally belongs there.
2015-11-28 21:28:54 +09:00
e9061ea371
Move coin choosing logic to own class
...
This contains no change in logic, but is preparation for cleanup
and possible alternative strategies.
2015-11-28 14:49:10 +09:00
175fdbcac6
Disentangle plugins and window management; use Qt signals
2015-11-23 09:05:34 +01:00
0dcaa13d31
Show the wallet path in -v output
2015-11-14 16:14:00 +09:00
ae42576423
Merge branch 'master' of git://github.com/spesmilo/electrum
2015-11-12 14:32:19 +01:00
86a0103a7f
increase min_relay_tx_fee, and make dust_threshold a function
2015-11-12 14:31:17 +01:00
206e38fb7c
Make use of trigger_callback easier to understand
2015-11-12 16:08:37 +09:00
8cc3b58364
Allow syncronizer to be GC-ed
...
Proper fix for #1525 .
Using python's GC module, I've verified that the daemon, when running,
now releases all verifiers, synchronizers and wallets - all the resources
we care about releasing.
2015-11-12 08:40:58 +09:00
d612684196
Attempt at fixing issue 1525
...
The main problem is, I think, that the synchronizer and wallet
still exist in the daemon process, and updates to things like
TXI and TXO are made but never saved (as client exit is what
saves the wallet).
I suspect fixing the lingering objects is hard; this is a short
term fix to ensure that when internal wallet state is updated,
the wallet is written to disk, so later daemon clients pick up
the correct state.
2015-11-11 16:38:28 +09:00
2a3c97813d
wallet.get_max_amount method, used by qt and kivy
2015-10-30 14:10:41 +01:00
079cb311ec
call wallet.wait_until_synchronized before commands
2015-10-29 05:01:06 +01:00
052d8b236e
fix #1494
2015-10-28 10:36:44 +01:00
2a23aab24b
workaround #1513
2015-10-28 07:32:29 +01:00
26682491b2
generic restore from command line
2015-10-27 14:33:41 +01:00
97568bedf5
Default to unused address for privkey sweeps
...
Fixes #1506
- New function wallet.get_unused_addresses
- Have wallet.get_unused_address use it
- Use it for the sweep key dialog
2015-10-26 20:33:35 +09:00
171363aa86
minor fix (import stat)
2015-10-20 13:57:43 +02:00
a9f451decd
preserve file permissions when saving wallet
2015-10-20 13:52:38 +02:00
fc141cba28
Fix KeyErrror typo
2015-10-19 10:42:46 +13:00
fbda9dac79
fix #1479
2015-10-18 12:36:04 +02:00
0fe410d7e6
restore lock in storage.write (follow up to b5e0363f)
2015-10-01 13:26:22 +02:00
b5e0363f85
Only save wallet if modified
2015-09-11 14:02:01 +09:00
f710d872c7
When using labels plugin write wallet once
...
Poor hook coupling would cause the wallet to be written
twice unnecessarily when using the labels plugin and changing
a label
2015-09-10 22:29:25 +09:00
886192aba7
Make trustedcoin.py multi-window compatible
2015-09-09 17:27:58 +09:00
39615333c0
Attribute more diagnostic messages
2015-09-06 22:04:44 +09:00
1171a25815
Genericize plugin handling of thread jobs
...
Move it to the Plugins class so all plugins get it for
free.
2015-09-05 17:21:28 +09:00
89fbda30e0
Labels plugin now working for multiple windows
2015-09-04 17:38:14 +09:00
9d76bf6828
temporary fix wallet constructors
2015-09-02 14:37:40 +02:00
7a55d02654
Fix 992c70a688
...
This works for ordinary wallets at least; cannot test hardware.
But after staring for ages I think it's right.
2015-09-02 21:27:12 +09:00
992c70a688
detect available hardware wallets before listing them in wizard
2015-09-02 13:08:06 +02:00
351272f0b6
Small optimization for large wallets
...
Previously the verifier job would scan all transactions in
unverified_tx each time it ran.
Nothing was ever removed from this map; it would essentially
be the full set of transactions.
As the job runs about 10 times a second, for a wallet with 500 txs
this would be 5,000 useless loops a second.
This patch makes unverified_tx be simply the set of confirmed
transactions that haven't yet been verified. txs are added once
confirmed, and removed once verified. Hence it will almost always be
empty.
2015-08-28 12:39:19 +09:00
478bde8afa
Access to unverified_tx no longer needs a lock
...
Once the proxy thread jobs are created only they access this,
and they all run under the proxy thread, so there is no contention.
2015-08-28 11:10:50 +09:00
578a83fa30
show error message raised during sign_transaction. see issue #1422
2015-08-27 08:22:02 +02:00
b64c42b1eb
Make the verifier a thread job instead of a thread
...
The verifier, like the synchronizer, now runs as part of the
network proxy thread.
2015-08-26 17:07:36 +09:00
01491dd1d0
Have network_proxy use ThreadJob framework
...
Rename WalletSynchronizer to Synchronizer so that diagnostic messages,
which are based on class name, still refer to Synchronizer.
2015-08-26 16:50:40 +09:00
bfae04e6f0
Improved in network callbacks:
...
* Pass arguments
* Don't redraw history when a tx is verified.
* Fix new tx notifications.
2015-08-16 11:36:23 +02:00
e0939348c3
minimize calls to estimated_fee
2015-08-15 12:31:57 +02:00
6232a0b76c
speedup fee computation when collecting small inputs
2015-08-15 10:02:47 +02:00
d69da1ef43
add/remove transaction: remove unused tx_height parameter
2015-08-14 15:30:00 +02:00
6b87256795
sign tx with empty scriptSig inputs
2015-08-07 17:11:42 +02:00
714445aba8
fix: wallet.is_used
2015-08-06 19:19:25 +02:00
43880d452e
dynamic fees
2015-08-05 15:45:28 +02:00
e9f5e6866d
check www dir on daemon start
2015-07-25 12:25:47 +02:00
3da148f406
use local copy of javascript files
2015-07-24 12:36:08 +02:00
41d9c94821
don't add bip70 suffixes
2015-07-22 16:00:08 +02:00
8960b16e09
more sanitization
2015-07-22 15:28:43 +02:00
acbd434f76
cleanup request signing
2015-07-22 09:06:03 +02:00
a6c65b8997
change internal format of requests
2015-07-21 12:26:37 +02:00
380e072842
fix bug with import_key
2015-07-18 11:00:41 +02:00
da55d9ed6e
payment requests: cmdline fixes
2015-07-11 21:09:56 +02:00
cb2bc54f96
store and display signatures of own requests
2015-07-09 14:15:30 +02:00
0368a2cd5e
fix bug from #1281
2015-07-05 18:16:33 +02:00
b0f7411a0a
check and fix history on startup
2015-07-05 17:29:41 +02:00
e2c19ff871
fix #1344
2015-07-05 16:19:44 +02:00
930304e46b
Remove apparently dead code.
2015-07-03 13:57:42 +09:00
65e7667eba
build reverse history index, to know when a transaction can be removed
2015-07-02 16:07:04 +02:00
ccd07c6a80
Merge branch 'synchronizer-unthread' of https://github.com/kyuupichan/electrum into kyuupichan-synchronizer-unthread
2015-07-02 09:20:51 +02:00
0c37009cdb
fix is_address (forgot p2sh)
2015-07-02 08:53:17 +02:00
523aa7c380
update restore multisig to add type
2015-06-27 16:12:15 -04:00
765ef338ec
fix multisig seed detection
2015-06-27 21:53:55 +02:00
56b3c98332
generic m of n multisig
2015-06-27 12:43:29 +02:00
74d26f5bdc
better error message
2015-06-15 10:52:03 +02:00
00af3b394b
Merge pull request #1280 from kyuupichan/BIP-LI01
...
Implement BIP-LI01.
2015-06-14 08:08:55 +02:00
d09a10e0f7
fix is_used for unmatured tx
2015-06-13 16:40:50 +02:00
10740470cc
fix requests_dir bug
2015-06-12 20:18:06 +02:00
1fbbd5d65d
require network to show request status
2015-06-12 09:58:29 +02:00
317a9de71d
check amount before calling make_payment_request
2015-06-11 12:32:52 +02:00
e8db8983ec
Make the synchronizer not a thread.
...
The synchronizer's work is done from the network proxy's main loop.
A minor problem with the old synchronizer was that it considered itself
out of date if the network was out of date. This was too generic: the
network can have pending requests unrelated to the synchronizer. This
resulted in the synchronizer often unnecessarily flipping the wallet
between up-to-date and not-up-to-date, and causing unnecessary calls
to wallet.save_transactions(). This was observable when opening the
network dialog box: frequently just opening it would cause a wallet
status change and transaction flush, simply because the network dialog
sends a get_parameters() request. This rework of the synchronizer does
not have that issue.
2015-06-09 08:41:31 +09:00
8995cdbf14
rename fields: 'time' -> 'timestamp', payment_requests
2015-06-08 13:36:35 +02:00
357c405ac6
fix publish_request
2015-06-08 13:21:13 +02:00
9bd94e5062
refactor payment requests
2015-06-08 12:51:45 +02:00
48e53498db
improve requests
2015-06-07 18:44:33 +02:00
98bea614d8
Implement BIP-LI01.
...
No more need to randomly place change.
2015-06-06 22:25:40 +09:00
ab60da89ac
Add a help group for config variables. Change name of ssl variables
2015-06-03 11:34:52 +02:00
fb6a74e034
fix typo
2015-06-02 16:49:21 +02:00
3188ff05a3
fix is_watching_only
2015-06-02 16:41:32 +02:00
088d8e8415
show request status
2015-06-02 11:36:06 +02:00
2727df962e
requests: store path not url
2015-06-02 09:56:10 +02:00
b9e4825422
fix request_dir variable
2015-06-02 09:37:54 +02:00
d41785c783
save payment requests in requests_dir
2015-06-02 09:18:39 +02:00
Neil Booth
ThomasV
Chris Beaven
ThomasV
ThomasV
Michael Wozniak
ThomasV