351272f0b6
Small optimization for large wallets
...
Previously the verifier job would scan all transactions in
unverified_tx each time it ran.
Nothing was ever removed from this map; it would essentially
be the full set of transactions.
As the job runs about 10 times a second, for a wallet with 500 txs
this would be 5,000 useless loops a second.
This patch makes unverified_tx be simply the set of confirmed
transactions that haven't yet been verified. txs are added once
confirmed, and removed once verified. Hence it will almost always be
empty.
2015-08-28 12:39:19 +09:00
478bde8afa
Access to unverified_tx no longer needs a lock
...
Once the proxy thread jobs are created only they access this,
and they all run under the proxy thread, so there is no contention.
2015-08-28 11:10:50 +09:00
578a83fa30
show error message raised during sign_transaction. see issue #1422
2015-08-27 08:22:02 +02:00
b64c42b1eb
Make the verifier a thread job instead of a thread
...
The verifier, like the synchronizer, now runs as part of the
network proxy thread.
2015-08-26 17:07:36 +09:00
01491dd1d0
Have network_proxy use ThreadJob framework
...
Rename WalletSynchronizer to Synchronizer so that diagnostic messages,
which are based on class name, still refer to Synchronizer.
2015-08-26 16:50:40 +09:00
bfae04e6f0
Improved in network callbacks:
...
* Pass arguments
* Don't redraw history when a tx is verified.
* Fix new tx notifications.
2015-08-16 11:36:23 +02:00
e0939348c3
minimize calls to estimated_fee
2015-08-15 12:31:57 +02:00
6232a0b76c
speedup fee computation when collecting small inputs
2015-08-15 10:02:47 +02:00
d69da1ef43
add/remove transaction: remove unused tx_height parameter
2015-08-14 15:30:00 +02:00
6b87256795
sign tx with empty scriptSig inputs
2015-08-07 17:11:42 +02:00
714445aba8
fix: wallet.is_used
2015-08-06 19:19:25 +02:00
43880d452e
dynamic fees
2015-08-05 15:45:28 +02:00
e9f5e6866d
check www dir on daemon start
2015-07-25 12:25:47 +02:00
3da148f406
use local copy of javascript files
2015-07-24 12:36:08 +02:00
41d9c94821
don't add bip70 suffixes
2015-07-22 16:00:08 +02:00
8960b16e09
more sanitization
2015-07-22 15:28:43 +02:00
acbd434f76
cleanup request signing
2015-07-22 09:06:03 +02:00
a6c65b8997
change internal format of requests
2015-07-21 12:26:37 +02:00
380e072842
fix bug with import_key
2015-07-18 11:00:41 +02:00
da55d9ed6e
payment requests: cmdline fixes
2015-07-11 21:09:56 +02:00
cb2bc54f96
store and display signatures of own requests
2015-07-09 14:15:30 +02:00
0368a2cd5e
fix bug from #1281
2015-07-05 18:16:33 +02:00
b0f7411a0a
check and fix history on startup
2015-07-05 17:29:41 +02:00
e2c19ff871
fix #1344
2015-07-05 16:19:44 +02:00
930304e46b
Remove apparently dead code.
2015-07-03 13:57:42 +09:00
65e7667eba
build reverse history index, to know when a transaction can be removed
2015-07-02 16:07:04 +02:00
ccd07c6a80
Merge branch 'synchronizer-unthread' of https://github.com/kyuupichan/electrum into kyuupichan-synchronizer-unthread
2015-07-02 09:20:51 +02:00
0c37009cdb
fix is_address (forgot p2sh)
2015-07-02 08:53:17 +02:00
523aa7c380
update restore multisig to add type
2015-06-27 16:12:15 -04:00
765ef338ec
fix multisig seed detection
2015-06-27 21:53:55 +02:00
56b3c98332
generic m of n multisig
2015-06-27 12:43:29 +02:00
74d26f5bdc
better error message
2015-06-15 10:52:03 +02:00
00af3b394b
Merge pull request #1280 from kyuupichan/BIP-LI01
...
Implement BIP-LI01.
2015-06-14 08:08:55 +02:00
d09a10e0f7
fix is_used for unmatured tx
2015-06-13 16:40:50 +02:00
10740470cc
fix requests_dir bug
2015-06-12 20:18:06 +02:00
1fbbd5d65d
require network to show request status
2015-06-12 09:58:29 +02:00
317a9de71d
check amount before calling make_payment_request
2015-06-11 12:32:52 +02:00
e8db8983ec
Make the synchronizer not a thread.
...
The synchronizer's work is done from the network proxy's main loop.
A minor problem with the old synchronizer was that it considered itself
out of date if the network was out of date. This was too generic: the
network can have pending requests unrelated to the synchronizer. This
resulted in the synchronizer often unnecessarily flipping the wallet
between up-to-date and not-up-to-date, and causing unnecessary calls
to wallet.save_transactions(). This was observable when opening the
network dialog box: frequently just opening it would cause a wallet
status change and transaction flush, simply because the network dialog
sends a get_parameters() request. This rework of the synchronizer does
not have that issue.
2015-06-09 08:41:31 +09:00
8995cdbf14
rename fields: 'time' -> 'timestamp', payment_requests
2015-06-08 13:36:35 +02:00
357c405ac6
fix publish_request
2015-06-08 13:21:13 +02:00
9bd94e5062
refactor payment requests
2015-06-08 12:51:45 +02:00
48e53498db
improve requests
2015-06-07 18:44:33 +02:00
98bea614d8
Implement BIP-LI01.
...
No more need to randomly place change.
2015-06-06 22:25:40 +09:00
ab60da89ac
Add a help group for config variables. Change name of ssl variables
2015-06-03 11:34:52 +02:00
fb6a74e034
fix typo
2015-06-02 16:49:21 +02:00
3188ff05a3
fix is_watching_only
2015-06-02 16:41:32 +02:00
088d8e8415
show request status
2015-06-02 11:36:06 +02:00
2727df962e
requests: store path not url
2015-06-02 09:56:10 +02:00
b9e4825422
fix request_dir variable
2015-06-02 09:37:54 +02:00
d41785c783
save payment requests in requests_dir
2015-06-02 09:18:39 +02:00
0938299e9b
move payment requests logic to wallet, add basic commands
2015-06-01 13:02:09 +02:00
5cd3bfedb6
always pass coins to wallet.make_unsigned_transactions. fix \! shortcut in commands
2015-05-31 11:31:41 +02:00
320f9a3790
get_spendable_coins and frozen addrs
...
Two callers of get_spendable_coins were removing frozen addrs
before calling. Put that functionality in the function.
We shouldn't be able to send_from a frozen address. This was
possible in the current release because logic assumed a two-element
tuple was returned when it is now three-element. Fix that too.
Command line options listunspent and createrawtransaction currently
ignore frozen addresses. I'm not sure that's right but I've preserved
that behaviour.
With this patch only the wallet class refers to self.frozen_addresses;
other clients use is_frozen() now.
2015-05-31 14:07:50 +09:00
0f29984f07
Speed up freezing and unfreezing of many addresses
...
Speedup mainly from writing to storage only once.
Make frozen_addresses a set in memory, as sets give cleaner
code and are more efficient.
Minor change in behaviour: command line freezing used to return
False if the address isn't in the wallet OR the address was already
frozen. Now it returns more like a success code: it returns False
only if the address isn't in the wallet regardless of frozen state.
Similarly for unfreezing.
2015-05-31 11:54:21 +09:00
92a158b910
proper handling of arg_types. add more options for listaddresses
2015-05-30 18:49:58 +02:00
4eaff5678d
Avoid change address reuse if possible
...
As discussed on #electrum yesterday.
Increase change gap limit to 6.
Choose the next unused change address, if any, otherwise pick
one at random from the gap limit.
2015-05-30 17:07:29 +09:00
3195b94f28
Merge pull request #1257 from kyuupichan/update_fee
...
Fix calls to update_fee
2015-05-28 19:34:04 +02:00
9dc8393cf6
move import test to wallet.py
2015-05-28 15:39:26 +02:00
05cb9975cb
Fix calls to update_fee
...
Fees should be recalculated when send_from changes.
Fees should be recalculated when editing fee preference, but
only save to storage when leaving the fee per kb widget.
No need to emit a textEdited signal; the widget does that already
(with the effect that we used to call update_fee() twice).
2015-05-28 15:52:31 +09:00
dd8493f97e
make coin selection a bit faster
2015-05-27 11:07:57 +02:00
ae957f3736
make_transaction: remove unneeded inputs
2015-05-26 09:09:07 +02:00
89c277de9d
fix pruning error in #1223
2015-05-23 08:45:27 +02:00
4aaa9e24f2
Merge pull request #1234 from kyuupichan/storage-tmpfile
...
Prevent race with two electrum instances on same wallet.
2015-05-23 07:22:12 +02:00
77490e4764
Flush wallet storage once for a sequence of puts.
...
This speeds up save_transactions by 2 to 3 times for me.
2015-05-23 10:52:10 +09:00
33a8348d48
Prevent race with two electrum instances on same wallet.
...
Whilst it's not a good idea to have two electrum instances
open on the same wallet, we should avoid throwing an
exception. Also note how the old code's handling of the
exception (caused by both renaming the file almost at the
same time, rather than a non-POSIX system not supporting
the atomic rename) can lead to the wallet file being lost
enirely because os.remove(self.path) succeeds and the
rename of the temporary no-longer-existing file then fails.
2015-05-23 10:24:10 +09:00
7b27f01e07
call fsync before rename
2015-05-19 11:56:33 +02:00
7e9153aaa4
test if labels exist before loop. don't raise if a label cannot be converted
2015-05-11 11:55:26 +02:00
fe5be618db
Convert old latin1 labels, Raise exception if json conversion fails.
...
A couple of changes
1) Old electrum wallets seemed to save labels in latin1, when you call json.dumps on line 83/84 it fails silently, which causes the label import to fail. Whenever electrum saves, it then overwrites your default wallet with no labels - essentially deleting all your labels. The solution to this is iterating over all the labels for old wallets decoding anything that fails to unicode() as latin1, and then unicoding it :)
2) Failing to import data and then deleting it is bad. So I'm raising an exception to avoid data being lost.
2015-05-10 20:28:42 +01:00
59a9e4f710
fix new_wallet and seed language
2015-05-10 08:31:31 +02:00
233fd8ed77
revert 175bfae9e6. store last known height in wallet instead
2015-05-08 13:43:42 +02:00
c2a4252065
do not pass config to storage. request height from network_proxy if connected
2015-05-08 10:58:54 +02:00
13b9b577a4
Don't use self.network to get the local height.
...
This restores a working offline mode.
2015-05-08 14:45:23 +09:00
37c3cce329
Remove wallet.get_transactions()
...
Because references are returned, it's not threadsafe as ThomasV
pointed out.
2015-05-08 09:31:45 +09:00
a47881d72b
Move the verified and unverified txs to the wallet.
2015-05-07 23:54:39 +09:00
656560be72
show many address labels in tx default label. fixes #1200
2015-05-07 16:09:39 +02:00
79de458101
Preparation for moving the set of verified and unverified txs to the wallet.
...
The verifier will retain responsibility for verification, but will no longer
hold the transaction sets itself.
Change requires_fee to take a wallet.
Add new function add_unverified_tx()
Move get_confirmations() to the wallet from the verifier.
2015-05-07 09:21:08 +09:00
687cc7783f
show unmatured coins in status bar. fixes #1163
2015-05-05 20:52:14 +02:00
25c6a78ae0
fix missing immport
2015-05-02 16:29:41 +02:00
2fc38332e7
Make it 3-step instead of four. Avoid quadratic insertions.
...
This is preparation to hopefully fix #1163
2015-05-02 23:17:50 +09:00
75ddc066bb
fix #1181
2015-05-02 11:05:38 +02:00
db2517b901
Shrink size of changes; functionality unchanged.
2015-04-30 13:32:01 +09:00
f56413d602
Put title() member func, with localization, in main_window.py
2015-04-28 21:12:25 +09:00
889174ae19
Show wallet basename in tray tooltip for those of us using multiple wallets
...
Move basename (and title) logic to the wallet and use those member functions.
2015-04-28 19:32:56 +09:00
cb09d88322
fix bug introduced in 21673c95f4
2015-04-24 21:01:34 +02:00
21673c95f4
Fix wallet write to support windows
2015-04-24 13:14:17 +02:00
4a28c88946
atomic write wallet file
2015-04-23 17:12:02 +02:00
e8189490e9
store contacts in a separate file, shared between wallets
2015-04-23 12:16:46 +02:00
065145e557
get_history: return empty history if balance check fails
2015-04-23 09:49:24 +02:00
524db55b90
don't display hashes or addresses as default labels
2015-04-19 14:30:44 +02:00
eac3129cba
Merge pull request #1135 from Kausheel/get_addr_received
...
Add wallet function get_addr_received()
2015-04-19 13:38:45 +02:00
036f96cf35
store invoices in a separate file, with their status
2015-04-13 14:19:59 +02:00
eb9802356a
fix variable name in from_seed
2015-04-09 18:59:51 +02:00
8cf793ab98
Add wallet function get_addr_received()
2015-04-09 01:44:44 +10:00
b8a72180c7
HistoryWidget class; address history window
2015-04-04 18:26:52 +02:00
0a7b585b6c
redo default labels with incoming tx outputs
2015-04-04 15:55:28 +02:00
75cf142be0
fix typo
2015-04-03 11:30:36 +02:00
a3422d3fae
generic multisig wallet constructor. fixes #1129
2015-04-03 11:27:57 +02:00
e3e5d95794
fix account key bug
2015-03-31 22:44:00 +02:00
a44f1bc4d3
Merge pull request #1115 from romanz/offline-mode-fix
...
Offline mode fixes
2015-03-31 13:57:27 +02:00
f77311328a
add get_completions to wallet
2015-03-31 12:01:42 +02:00
4d7b68658b
fix delete_contact
2015-03-31 11:29:18 +02:00
a7440fc89c
wallet: skip history sort when verifier is not set
2015-03-31 09:32:21 +03:00
da502076bd
fix get_history
2015-03-30 20:39:06 +02:00
2d84deeaad
sanity check history
2015-03-30 14:10:46 +02:00
ec11e58add
handle pruning in wallet.txi/txo
2015-03-30 14:10:46 +02:00
3d1fa1e27f
find_pay_to_pubkey_address
2015-03-30 14:10:46 +02:00
bc3ed470e1
use hash as default label
2015-03-30 14:10:46 +02:00
e3de121be9
store deserialized tx in/out in wallet file for fast computation
2015-03-30 14:10:46 +02:00
973f7f9fe5
mpk window: detect self and cosigner keys
2015-03-24 17:33:08 +01:00
1369c02011
safeguard: do not let daemon treads write wallet file
2015-03-24 12:23:11 +01:00
a5a7a34c2d
IOError: add file path to exception message
2015-03-15 08:04:02 +01:00
5b8588ee90
rename spv class, use own print_error
2015-03-14 09:20:27 +01:00
72688a5cfa
clean implementation of daemon threads
2015-03-13 23:04:29 +01:00
58f9ab3492
add a lock to wallet.synchronize() and fix #1049
2015-03-13 16:51:31 +01:00
4ba4611599
check arg type in change_gap_limit()
2015-03-07 12:51:35 -05:00
15636282e4
fix issue #1061 : normalize trezor passphrases. Add passphrases to restore from seed with trezor.
2015-03-05 17:09:39 +01:00
490de0d8ce
fix password bug with xprv wallet
2015-03-04 18:57:28 +01:00
78573e202d
add try..except arount get_next_account
2015-02-27 21:35:50 +01:00
52b43c57b8
android create and restore
2015-02-25 22:48:47 +01:00
18d16ba82c
bugfix: add pubkey to PendingAccount, to be able to spend from it
2015-02-23 19:33:31 +01:00
0934976f3a
fix #1011
2015-02-17 10:30:10 +01:00
76cbafe754
fix Master Public Keys dialog
2015-02-05 13:29:18 +01:00
8982a463a4
allow change_gap_limit in bip32 wallets
2015-02-03 16:26:00 +01:00
036147db44
fix: change_gap_limit
2015-02-03 16:18:42 +01:00
2f7b8ce864
fix wallet.can_sign: use isinstance with BIP32 class
2015-02-03 13:14:35 +01:00
ca01e1d7be
handle 1.9.8 bug that created seed_v6 wallets
2015-02-03 12:20:03 +01:00
0b674eb35d
fix can_sign: detect if OldWallet is used
2015-02-02 16:06:29 +01:00
395312e70f
fix: add wallet types only if available
2015-02-01 10:44:29 +01:00
4ce699bf25
disable key import in all bip32 wallet classes; users should create an ImportedWallet
2015-01-23 13:54:33 +01:00
84fc4574d6
add password when creating imported wallet
2015-01-23 00:06:17 +01:00
8863b6f294
remove remaining instances of op_return type
2015-01-18 17:23:21 +01:00
6d2d53b43f
Move root_name to parent class
2015-01-11 13:58:03 -05:00
da968b60e4
drop support for multiple accounts (bip44) in standard wallets
2015-01-05 00:33:10 +01:00
9f9bab6cf0
fix issue #968
2014-12-31 19:21:54 +01:00
63c7a27d7e
add InvalidPassword exception
2014-12-03 22:35:05 +01:00
7ca3ba4e80
various fixes for reveive_requests
2014-11-24 12:28:11 +01:00
f2988b657b
Merge branch 'contacts' of github.com:Tafelpoot/electrum into Tafelpoot-contacts
2014-11-24 11:55:57 +01:00
01cf04079f
add NotEnoughFunds exception
2014-11-20 19:10:43 +01:00
6d8eebe2db
raise exception when seed version does not match
2014-11-15 14:42:35 +01:00
218a1ee2f7
Updated Requests
...
- added Date and Account field to Saved Requests
- requests are now saved as dict()
old requests will be deleted!!
- Account field is hidden when only 1 account is available
- address line now follows the current_account
- saved requests is sortable, default sorted by date
- saved requests only shows request for current_account
2014-11-14 19:47:34 +01:00
9b28ed9ba0
do not require name to create an account
2014-11-14 14:08:28 +01:00
c5b47bd513
always store next_account a PendinfAccount is created
2014-11-14 13:48:15 +01:00
b6f0f8c02c
Merge branch 'master' of https://github.com/spesmilo/electrum into showaccount
2014-11-05 00:38:02 +01:00
5c12c2bc2f
optimized, cleaned up, commented
2014-11-05 00:37:43 +01:00
fb75e2e53d
fix get_private_key_from_xpubkey
2014-11-04 10:50:28 +01:00
e6317ceca1
Merge pull request #909 from Tafelpoot/showaccount
...
add account info for internal transfer description
2014-10-31 15:01:22 +01:00
16f36ee6e2
Extend transaction serialization, format to handle unsigned inputs where only the address is known, the public key is unknown.
2014-10-31 13:01:16 +01:00
b3684ad40a
add account info for internal transfer description
2014-10-30 17:56:36 +01:00
581ed1ed26
separate signtxwithkey and signtxwithwallet, and simplify sign_transaction
2014-10-30 16:36:29 +01:00
cf1fbbf3ad
fix is_watching_only for imported wallets
2014-10-27 15:47:10 +01:00
Neil Booth
ThomasV
ThomasV
Michael Wozniak
ThomasV
Azelphur
Maran
Kausheel Kumar
Roman Zeyde
Christopher Gurnee
Charles Lehner
Tafelpoot