Commit Graph

10280 Commits

Author SHA1 Message Date
Pedro Alvarez 57772ffa35 lib,pdcp_nr: added warning for trying to use t-Reordering of infinity on RLC UM bearers 2022-05-24 14:35:05 +01:00
Pedro Alvarez 8d65b40734 lib,pdcp_nr: allow for t-reordering of inifinity 2022-05-24 14:35:05 +01:00
Andre Puschmann 573dc34b73 gnb,rrc_nr_test: fix uninit memory 2022-05-23 15:57:57 +02:00
Andre Puschmann f3ee8b2078 ngap: fix invalid access of amf ID when context wasn't created yet 2022-05-23 15:56:45 +02:00
Andre Puschmann bed35c747c gnb,rrc: fix handling of DRB for reconfig/reestablishment
the five_qi value received from the 5GC was not stored/passed when
the UE object was moved from one RNTI to another during e.g.
reestablishment. this makes sure the selected 5qi is passed over
during that process.
2022-05-23 15:56:45 +02:00
Andre Puschmann bbd84f087e gnb,rrc: add error checking/handling when creating cellgroup cfg 2022-05-23 15:56:45 +02:00
Andre Puschmann d3a049bd7b readme: add github actions badge 2022-05-23 15:56:45 +02:00
Andre Puschmann 35c8c712e4 cmake: fix typo 2022-05-23 15:56:45 +02:00
Robert Falkenberg e891d72ab8 lib,rlc_am_nr: fix out-of-bounds access when unpacking malformed status PDUs 2022-05-23 14:19:18 +02:00
Pedro Alvarez cc93b5b6b0 ue,gnb,rrc_nr: make sure that RLC is setup before PDCP, so the PDCP can know wether the RLC is UM or AM 2022-05-20 11:01:04 +01:00
Pedro Alvarez 84cf5c30ec lib,pdcp_nr: rm ifdef to select PDCP NR. PDCP NR is always selected now 2022-05-20 11:01:04 +01:00
Robert Falkenberg e0620873ef lib,rlc_am_nr: no error on insufficient space for new or continued segment. 2022-05-19 15:32:32 +02:00
Robert Falkenberg cbc8364a94 lib,rlc_am_nr: no error on insufficient space for RETX segment. 2022-05-19 15:32:32 +02:00
Robert Falkenberg 21a4a675dd cmake/gcc: disable [-Werror=maybe-uninitialized] for GCC >= 12.1.0
With GCC 12.1.0 there are numerous false-positive warnings on
"maybe uninitialized" variables.
2022-05-18 15:01:37 +02:00
Robert Falkenberg 0c9ba5b87e lib,asn1_utils: fix out of bounds access on zero-sized array
* fix error: ... offset 0 is out of the bounds [0, 0] [-Werror=array-bounds]
* fix note: destination object of size 0 allocated by ‘operator new []’
--> data_ = new T[cap_];
2022-05-18 15:01:37 +02:00
Pedro Alvarez 58f71b10b6 gnb,config: make SRB configuration mandatory 2022-05-18 14:27:03 +02:00
Pedro Alvarez 02b3558390 lib,pdcp_nr: fix typos 2022-05-17 10:29:37 +01:00
Pedro Alvarez a08579dae9 ue,rrc_nr: mark is_security_active as true, after updating SK counter. 2022-05-17 10:29:37 +01:00
Pedro Alvarez 7f98101f30 lib,pdcp_nr: fix rx unit tests 2022-05-17 10:29:37 +01:00
Pedro Alvarez 904dbff471 lib,pdcp_nr: fixed PDCP NR tx unit tests 2022-05-17 10:29:37 +01:00
Pedro Alvarez b361ab0650 lib,pdcp_nr: fix pdcp nr encryption 2022-05-17 10:29:37 +01:00
Pedro Alvarez 1b2c9502e2 lib,pdcp_nr: fix order in which header discard was done in PDCP NR. 2022-05-17 10:29:37 +01:00
Pedro Alvarez 39fbf21174 lib,pdcp_nr: fix order of integrity generation 2022-05-17 10:29:37 +01:00
Pedro Alvarez a148dff0cd gnb,ue,rrc: enable using integrity on DRBs 2022-05-17 10:29:37 +01:00
Robert Falkenberg aa9f844630 adt,fsm: ignore GCC warning for template specialization w/wo defaults for ReactFn or GuardFn 2022-05-17 09:53:32 +02:00
Robert Falkenberg 02cb2532f8 lib,pdcp_nr: make sure MAC-I is computed on SRBs, even when integrity is not active yet 2022-05-16 16:16:07 +01:00
Pedro Alvarez c015540f54 lib,pdcp_nr: make sure MAC-I is added on SRBs, even when integrity is not active yet 2022-05-16 16:16:07 +01:00
Pedro Alvarez 25b8a35d7a lib,pdcp_nr: make sure we don extract MAC-I if integrity is not enabled. Make sure gNB does not enable integrity on DRBs 2022-05-16 16:16:07 +01:00
Pedro Alvarez ae8191c46d lib,rlc_am_nr: make sure we check that ACK_SN is not larger than TX_NEXT (after we checked we didn't get an ACK out of order) 2022-05-13 10:27:52 +01:00
Pedro Alvarez 97b66dbc4c lib,rlc_am_nr: fixed mal-formed status report in test. 2022-05-13 10:27:52 +01:00
Pedro Alvarez abc7294316 lib,rlc_am_nr: addded unit test for out of order status report 2022-05-13 10:27:52 +01:00
Pedro Alvarez 6d55560256 lib,rlc_am_nr: check if ACK SN is within rx_window. Stop
t-PollRetransmit only if status report is not ignored
2022-05-13 10:27:52 +01:00
Pedro Alvarez c457132570 lib,rlc_am_nr: avoid if that would always be true when checking the
out-of-order ACK. Check ACK_SN instead of stop SN with Tx_Next_Ack
2022-05-13 10:27:52 +01:00
Pedro Alvarez 7c42b09e89 lib,rlc_am_nr: check if rx ACK is smaller than current Tx_Next_Ack 2022-05-13 10:27:52 +01:00
Robert Falkenberg 0c24e9c55f lib,rlc_am_nr: clean retx_queue of ACK'ed SDUs 2022-05-13 06:49:13 +02:00
Robert Falkenberg 95480297f4 lib,rlc_am_nr: unit test removal of ACK'ed SDUs from retx queue 2022-05-13 06:49:13 +02:00
Robert Falkenberg e20cb2e0c8 lib,rlc_am_nr: empty PDUs shall not increment metrics.num_tx_pdus 2022-05-13 06:49:13 +02:00
Pedro Alvarez 2c5a74340b lib,rlc_um_nr: reduce log level of message 2022-05-12 22:25:11 +01:00
Robert Falkenberg 7b77558fd4 lib,rlc_um_nr: add log message if tx_sdu_queue has no non-null SDU 2022-05-12 22:25:11 +01:00
Pedro Alvarez 6a40fd8411 lib,pdcp_nr: disabe discard timer with RLC UM 2022-05-12 22:25:11 +01:00
Pedro Alvarez 92a6d8ec66 lib,rlc_um_nr: fix issue with discard in RLC UM NR 2022-05-12 22:25:11 +01:00
Pedro Alvarez 68b6facac8 lib,pdcp_nr: log RLC mode in PDCP configuration 2022-05-12 22:25:11 +01:00
Robert Falkenberg 9687af7660 add missing include for build with GCC 12
Related info: https://gcc.gnu.org/gcc-12/porting_to.html
2022-05-12 15:00:58 +02:00
Pedro Alvarez a72279dcbd Addressed review comments:
1 - enb,cfg: fix typo
2 - enb,config: added back deleted config option
3 - ue,rrc_nr: fix wrong log level in log message
4 - enb,config: remove unused parameter
2022-05-11 18:19:29 +01:00
Pedro Alvarez 97b32f2fb6 rrc_nr,utils: fix generation of RLC configs from ASN.1 structs created from cfg parser. 2022-05-11 18:19:29 +01:00
Pedro Alvarez 42011401ff gnb,config: remove SN length for 4G SRB configs 2022-05-11 18:19:29 +01:00
Pedro Alvarez b446fa87b0 gnb,config: enable changing the SN length of SRBs 2022-05-11 18:19:29 +01:00
Pedro Alvarez f79b3e9435 gnb,rrc: fix SRB config generation when configuration is present in rb.conf 2022-05-11 18:19:29 +01:00
Pedro Alvarez c737f75abb gnb,config: enable SRB config parser for SA 2022-05-11 18:19:29 +01:00
Pedro Alvarez ece3c69d45 gnb,rrc: make it possible to use default configs when SRB configs are not present. 2022-05-11 18:19:29 +01:00