Commit Graph

1758 Commits

Author SHA1 Message Date
Xavier Arteaga 9984e14170 BladeRF: Solved all clang tidy warnings 2019-09-20 15:43:07 +02:00
Ismael Gomez 0984debe1b
Fix issues with RLF in B210 and X300 (#669)
* Calling tx_end() from radio_reset() causes long execution time in B210. Using boolean to call later instead. Fixes RLF failing in B210. Checked in X300

* Fix issue #655
2019-09-20 15:41:16 +02:00
Andre Puschmann a2ab043c0d fix memleaks and uninitialized vars found by cppcheck 2019-09-20 10:55:29 +02:00
Francisco Paisana 946ead06e8 using an interface between the stack and lower mac to process demux pdus. 2019-09-19 10:19:46 +02:00
Andre Puschmann 57317fab7c expose debug_long to class log and use in RRC to log ASN1 structs 2019-09-18 16:12:24 +02:00
Andre Puschmann 7ad2b217df fix logging all in error level 2019-09-18 15:15:41 +02:00
Francisco Paisana 7e67aee839 resolved the uninit variable issue in the queue_test 2019-09-18 12:18:33 +02:00
Francisco Paisana 14267640ee implemented andre's PR review requests 2019-09-18 12:18:33 +02:00
Francisco Paisana b2bc05c50a make queue_test less dependent on thread timings 2019-09-18 12:18:33 +02:00
Francisco Paisana ceba00f00e extended multiqueue to support blocking push 2019-09-18 12:18:33 +02:00
Francisco Paisana 63457f195c extented queue test 2019-09-18 12:18:33 +02:00
Francisco Paisana 647c624423 created a multiqueue handler, and started using it for the ue stack 2019-09-18 12:18:33 +02:00
Andre Puschmann 95b2239dd5 add base class for socket handler using netsource object 2019-09-17 21:56:47 +02:00
Andre Puschmann 6baa89cd2c add MAC NR PDU packing and associated unit tests 2019-09-17 17:19:13 +02:00
Andre Puschmann 090f2b4110 add MAC-NR PCAP support 2019-09-17 17:19:13 +02:00
Ismael Gomez a3932f9bea Minor change to fix coverty issue 2019-09-17 14:22:38 +02:00
Francisco Paisana 94667beb00 added a bound checker to bit_ref packer, and other fixes 2019-09-17 14:15:43 +02:00
Ismael Gomez f74efe908b
Fix blocking in resume() after RLF in 100 PRB (#654) 2019-09-17 11:42:42 +02:00
Francisco Paisana cd521a84cb bigger log buffer. Now it is 1024 chars (#649)
Use dynamic string for debug_long() function and known relation of size between log_str and log_filter
2019-09-17 11:42:17 +02:00
Andre Puschmann 5189bbad69 add stop() to logger_file
this allows to close and currently running log process, flush the content
to the file, continue logging during that time, open a new file
and write the new log entries to that new file

basically it allows to use the logger_file multiple times without
needing to destroy the object

this is used in the UE tester to write each testcase into a separate
log file
2019-09-16 21:39:15 +02:00
Andre Puschmann 4869509c7b add write function to netsource
this is useful for listening sockets to also send responses,
i.e. implement bi-directional communication
2019-09-16 21:39:15 +02:00
Francisco Paisana e768989074 added a packer/unpacker for bytes. This should a faster version than normal bit_ref::pack, when we want to pack multiple bytes, and the bit_ref::offset is 0. Also added a way to skip a fixed number of bits 2019-09-13 21:09:26 +02:00
Ismael Gomez 6bb0790cf1
Fix coverty issues (#652) 2019-09-13 15:06:20 +02:00
Xavier Arteaga 1a567a764e SRSUE: Call Radio tx-end when PHY is reseted and removed redundant attribute is_start_of_burst. 2019-09-12 09:49:56 +02:00
Andre Puschmann 4ea9ed058c fix reporting of Tx gain stages in rf_soapy
reported by DreamNik
2019-09-11 21:44:03 +02:00
Pedro Alvarez 1d3e541069 Fixed warning on bytes_to_mnc 2019-09-10 13:46:21 +02:00
Pedro Alvarez 9b20a0de16 Added comment to zuc.cc and zuc.h 2019-09-10 13:46:21 +02:00
Pedro Alvarez 004db4a067 Applied clang-format to zuc_support PR. 2019-09-10 13:46:21 +02:00
Pedro Alvarez 595185d4b5 Fixed small compiler warning. 2019-09-10 13:46:21 +02:00
David Rupprecht 50332089ce Add EEA3 and EIA3 support for UE/enodeb and MME 2019-09-10 13:46:21 +02:00
David Rupprecht f05bb12c78 Process with EIA3 test cases and fix EIA3 2019-09-10 13:46:21 +02:00
David Rupprecht d580a94dab Add EIA3 and test case 2019-09-10 13:46:21 +02:00
David Rupprecht 7e13860dd5 Add decryption function and all tests for enc 2019-09-10 13:46:21 +02:00
David Rupprecht 0841d837de Make ZUC state ful no global vars 2019-09-10 13:46:21 +02:00
David Rupprecht ef4cf7aa52 First ZUC working test case 2019-09-10 13:46:21 +02:00
Andre Puschmann 8da610d68b fix gcc (<= 5) warning with type-limits by casting vr_r to a signed type
this warning is a bit annoying as it is really safe to do
that kind of comparision, it's just that for vr_r==0, any other
unsigned number is >= 0.
2019-09-10 13:43:57 +02:00
Andre Puschmann 49279c89d8 send DL-DCCH on SRB2 after it has been established 2019-09-09 17:16:22 +02:00
Harald Welte 2e426948fe [ENB] Add CFSB support
This commit introduces CSFB (circuit switched fall-back) capabilities to
srsLTE.  Actually, all the eNB has to do is to send a
RrcConnectionRelease with the RedirectedCarrierInfo IE.

The MME triggers this by the S1AP CS Fallback Indicator IE, which may
be present either in the Initial Context Setup Requst or in the
UE Context Modification Request.

As srsLTE has no support for the UE Context Modification Request at all
yet (!), basic support for this message is introduced in this patch.

Both Mobile Originated and Mobile Terminated CSFB with a coupel of
different UE models have been verified using this patch in a setup
consisting of srsENB attached to an undisclosed EPC connected via SGsAP
to a complete  Osmocom 2G network.

Closes: #358
Closes: #363
2019-09-09 16:59:00 +02:00
Andre Puschmann d9577f0e1e suppress type-limit warning issued by some compilers by making var signed
Used to happen with older gcc giving:

"rlc_am.cc:1791:22: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]"
2019-09-09 16:30:48 +02:00
Andre Puschmann a9bea7e30c add -Werror to compile flags 2019-09-09 16:30:48 +02:00
Ismael Gomez bfddc55148
RRC-PHY interface (#639)
RRC-PHY interface refactor. Moved RRC-MAC interface to rrc_asn1_utils and created RRC-PHY interface also in rrc_asn1_utils. All ASN1 includes should be made from rrc_asn1_utils only keeping ue_interfaces clean of ASN1

Tested with different common and dedicated configurations (64QAM UL, 256QAM, CA, SRS enabled/disabled, etc)
2019-09-04 16:59:10 +02:00
Merlin Chlosta 2079c1324c UHD: Wait for `lo_locked` after frequency change (#635)
* UHD: clang-tidy rf_uhd_imp.c
* UHD: wait for LO_lock after frequency change
2019-09-04 16:51:02 +02:00
Ismael Gomez c92c61d560
Optimized front-end logging processing (#641)
Avoid memory allocation and stringstream in log frontend calls (executed from worker threads). Uses a buffer pool of fixed buffer and vsnprintf
2019-09-04 15:32:29 +02:00
Francisco Paisana 67d6a25194 Moving mac timers to stack timers (#638)
* first step towards moving MAC timers to stack. Mac is still using its own timers. srslte::timers class can be restructured.

* moved timers out of the UE MAC
2019-09-04 15:28:09 +02:00
Ismael Gomez 69edee4e6c
Fix issues in uplink QoS (#636)
Fix bugs in Long BSR and Truncated BSR and added unit tests
2019-09-02 22:48:41 +02:00
Francisco Paisana ef61f0408c fix asn1 version separator string 2019-09-02 20:21:54 +02:00
Francisco Paisana ad64207a32 added test for unknown group extensions, and the asn1 lib version in its generated files 2019-09-02 20:21:54 +02:00
Francisco Paisana 939c8905cb now the unknown group exts are also consumed 2019-09-02 20:21:54 +02:00
Francisco Paisana 116dc0a57b fixed group extensions, removed extra presence flag for copy_ptr<T> types as it was just a source of bugs. 2019-09-02 20:21:54 +02:00
Robert Falkenberg bf35f83a5e Fixed inverted interpretation of new data indication (ndi) field in dci_format1As_pack() function 2019-08-29 20:49:24 +02:00
Robert Falkenberg c75f314c3f Fixed incorrect DCI location assignment in pdsch_enodeb.c example 2019-08-29 20:49:16 +02:00
Mark Rohrbacher 4a76801459 Fixed duplex spacing for bands 65 to 70 2019-08-29 20:49:10 +02:00
Robert Falkenberg 3cf4431c66 Fixed inverted handling of fseek result value in srslte_filesource_seek 2019-08-29 20:48:57 +02:00
Igor Kim dd613c1514 Fix TBS table with auto-generated one (#368) 2019-08-29 20:47:07 +02:00
Andre Puschmann ada4e6644f fixing various issues in NB-IoT sync code detected by Coverity and clang-tidy 2019-08-08 11:12:49 +02:00
Francisco Paisana c9d3b61038 added resumable procedures to make RRC and NAS non-blocking 2019-08-08 10:56:54 +02:00
Andre Puschmann e42449532b fix wrong namespace definition in various places 2019-08-07 15:32:49 +02:00
Andre Puschmann deb3cbec28 soapy: start rx stream without extra flags and print error if not successful 2019-08-05 11:11:04 +02:00
Andre Puschmann 80655db4a4 fix missing include in filesink 2019-08-05 11:11:04 +02:00
Andre Puschmann 95a5c2dcdb adding NB-IoT sync code 2019-08-05 11:11:04 +02:00
Ismael Gomez d887624e74 Increased PSS threshold to detect RLF after change to number of missed subframes 2019-07-31 16:57:21 +02:00
Ismael Gomez 19066c49ab Ad Rel10 info to dci logs 2019-07-30 18:18:44 +02:00
Pedro Alvarez 6efa944b5e Removed srslte prefix from pdcp_config_t 2019-07-30 15:01:50 +02:00
Pedro Alvarez 0e7c5634f1 Added comment to PDCP maximum SDU size. 2019-07-30 15:01:50 +02:00
Pedro Alvarez dd56d08269 Replaced byte_buffer by array in PDCP base 2019-07-30 15:01:50 +02:00
Pedro Alvarez 8c10eabf23 Changed PDCP LTE to use unique_lock. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 3da0391fff Adding default initializers to PDCP config. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 494be243c0 Changed security direction to use an enum. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 61051b4cb3 Changed PDCP NR read_data_header to return SN. 2019-07-30 15:01:50 +02:00
Pedro Alvarez f90b69e5f4 More clang-format for PDCP 2019-07-30 15:01:50 +02:00
Pedro Alvarez 491695ab77 Clang-formated PDCP NR PR. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 38bbc55631 Added tests for PDCP NR Rx with SN Len = 18. In-sequence reception seems to work. 2019-07-30 15:01:50 +02:00
Pedro Alvarez d4aeb12db8 Adding more TX tests to PDCP NR entity. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 39e3800781 Fixed header packing for SN length 18 for PDCP NR. First TX test is passing. 2019-07-30 15:01:50 +02:00
Pedro Alvarez d399c65082 Starting to add PDCP SN len 18 unit tests. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 7a69e8ba64 Removed comment. 2019-07-30 15:01:50 +02:00
Pedro Alvarez adfe9f950e Fixed issue in computing the SN. Added test for packets received in sequence for PDCP NR. Test is passing now. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 2104e6bbcf Added test for more TX packets in PDCP NR. Tests passing for TX_NEXT = 0, 2048 and 4096 2019-07-30 15:01:50 +02:00
Pedro Alvarez ecd164ed65 Starting to add more tx tests to PDCP NR tests. 2019-07-30 15:01:50 +02:00
Pedro Alvarez af2b593b8c Added check for integrity in test. First Rx PDCP NR test passing. 2019-07-30 15:01:50 +02:00
Pedro Alvarez d3b6828082 Changed PDCP configuration to explicitly have tx and rx direction. Decrypt on PDCP NR seems fine. 2019-07-30 15:01:50 +02:00
Pedro Alvarez ea3c44e9ac Removing header before decrypting. Continuing to add decryption tests to PDCP NR 2019-07-30 15:01:50 +02:00
Pedro Alvarez 7e6725f0a2 Fixing up PDCP NR tx test. Starting to add rx test. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 378c8d247e Starting to add the mechanisms to store the last PDU in the PDCP tests. 2019-07-30 15:01:50 +02:00
Pedro Alvarez a42726f836 Fixed hdr_len_bytes in PDCP NR. Tx seems OK now. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 73e30743d1 Added enum to PDCP config to replace two bools. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 457f35699d Reverted back to a single config structure between PDCP NR and PDCP LTE. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 810cacdc02 Adding write_data_header and append_mac helper functions to PDCP NR entity. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 9d0db108c6 Continue to add PDCP tx test 2019-07-30 15:01:50 +02:00
Pedro Alvarez d1ac121100 Writting PDU into PDCP in tx test. 2019-07-30 15:01:50 +02:00
Pedro Alvarez c9e99443d8 Adding PDCP NR Tx test. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 4bb99464ed Starting to add PDCP NR tests. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 8e8a7a4154 Add more logic to PDCP NR tx logic. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 2081b22465 Added PDCP_SN_LEN constants. Added bearer_id and direction back to the pdcp_entity_base. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 8e1b9b9f5b Starting to implement the receive function of PDCP NR. 2019-07-30 15:01:50 +02:00
Pedro Alvarez d7a2721bb0 Adding algorithm to get COUNT for PDCP NR. Added convinience functions to manipulate HFN, SN and COUNT. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 52f75c3cf2 Starting to add PDCP NR state variables. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 2449f901f0 Fixed error in setting Kint in pdcp_entity_lte. 2019-07-30 15:01:50 +02:00
Pedro Alvarez 1944bf9a80 Continue to split pdcp_entity_lte and pdcp_entity_nr. Compiling now. 2019-07-30 15:01:50 +02:00
Pedro Alvarez bd91678d98 Continuing to split pdcp_entity into pdcp_entity_lte and pdcp_entity_nr 2019-07-30 15:01:50 +02:00
Pedro Alvarez 005d03cb1a Starting to split pdcp_entity into pdcp_entity_lte and pdcp_entity_nr to support NR PDCP 2019-07-30 15:01:50 +02:00
Ismael Gomez 069c55f2e5 Fix db to dbm typo 2019-07-30 10:34:34 +02:00
Ismael Gomez 2859a75ca0 Reset counter for sync lost when PSS is found 2019-07-29 17:12:42 +02:00
Ismael Gomez d32739c315 Minor logging changes in PHY 2019-07-25 13:21:47 +02:00
Andre Puschmann e0bd7f156d replace remaining warning macros with pragma message 2019-07-23 15:38:21 +02:00
Andre Puschmann 09610ce788 add type setter to sch_subh and use it for MCH PDUs 2019-07-23 15:38:21 +02:00
Andre Puschmann c4bc151e14 rlc: fix MRB logging 2019-07-21 22:27:17 +02:00
Andre Puschmann e562dfed15 minor code formating and debug fixes 2019-07-21 22:27:17 +02:00
yagoda 408400bee6 adding fixes and tests for eMBMS 2019-07-21 22:27:17 +02:00
Francisco Paisana 424876c5e4 added DL TTI mask for MBMS 2019-07-21 22:27:17 +02:00
yagoda b99178d8da updating timing advance values for lime 2019-07-18 12:49:53 +02:00
Ismael Gomez 50e1ed6cc6 Change order of radio stop to avoid locking on rf_ms() by async thread 2019-07-17 16:48:07 +02:00
Guillem Foreman 2574de4d2d Fixed soft demodulator 2019-07-17 15:23:57 +02:00
Ismael Gomez 126f2efb5c
Radio and UHD fixes to avoid changing master clock rate and fixes X300 (#589)
* Fixes X300 MIMO

* Do not change sampling rate and calibrate time_adv_nsamples for b210
2019-07-16 18:22:09 +02:00
Andre Puschmann 9ee415ac82 correct the max size for a single TB
since the size in bits is counted per TB we don't need to allocate
space for the 2x2 MIMO case. Both CW have their own buffer.
2019-07-16 17:31:03 +02:00
Andre Puschmann 21f8698397 fix MAC PDU packing for large TB sizes
update the byte_buffer length variable after updating the remaining
PDU length. This has caused an error when calculating the
remaing space in the PDU because the SDU length was counted twice.
2019-07-16 17:31:03 +02:00
Andre Puschmann 94cc61e4b1 add MAC PDU pack test for max size TB PDU 2019-07-16 17:31:03 +02:00
Ismael Gomez c9c43e44e9 Fixed PDU buffer size 2019-07-16 17:31:03 +02:00
Andre Puschmann 2ae35e4ce0 make sure status PDU doens't exceed grant size 2019-07-14 07:29:10 +02:00
Pedro Alvarez 9597cc4c14 Clang-formated liblte_* 2019-07-13 14:41:04 +02:00
Xavier Arteaga 5e49aca835
Merge pull request #570 from softwareradiosystems/feature_256qam_fix
Resource allocation extended tables and PDSCH table 2 for 256QAM
2019-07-12 12:32:47 -04:00
Ismael Gomez 6d2c6ec58d Do not change master clock rate in UHD if dynamic rate is supported 2019-07-12 18:18:30 +02:00
Guillem Foreman 2a8ec5c9b9 More fixes 256QAM 2019-07-12 15:35:27 +02:00
Guillem Foreman eab73829f6 Changes requested 2019-07-12 14:11:26 +02:00
Ismael Gomez 538f38cf54 Let PDCP Control PDUs be processed 2019-07-12 13:08:42 +02:00
Pedro Alvarez 9b6aaac1b5 Ignore PDCP status PDUs, instead of passing them to the GW. Check on the GW if the packet is large enough to hold an IPv4 header. 2019-07-12 13:08:42 +02:00
Ismael Gomez 11d42acb3a Fix using deallocated PDU 2019-07-12 13:08:42 +02:00
Ismael Gomez 8c41625599 Add RLC suspend and resume 2019-07-12 13:08:42 +02:00
Andre Puschmann db196cc052 add RLC AM test for status PDU generation with small and big MAC grants 2019-07-12 13:06:39 +02:00
Andre Puschmann db9f093b63 add debug log when handling reordering timer 2019-07-12 13:06:39 +02:00
Andre Puschmann 849ad2655c fix creation of malformed RLC AM status PDU
the issue was caused by an unneeded length check during the
assembly of the status PDU. This length check caused an too early
break from the while-loop that adds all missing SNs to the status PDU
leaving the PDU struct in an invalid state where ack_sn was equal to
one of the NACK_SNs.
The fix is to simply remove the length check during the generation to
fully generate the status PDU. If, for whatever reason, MAC provides
a too small grant to fully fit the status PDU, the PDU will not be
generated, i.e. the calling function checks the return value and does
not pass the (then too big PDU) down the stack.
2019-07-12 13:06:39 +02:00
Andre Puschmann 9f3a947c02 modify RLC AM retx test to provide exactly a MAC opportunity of the size
that is reported as buffer state
2019-07-12 13:06:39 +02:00
Xavier Arteaga aa6652155c Phy: added ue_ul normalization mode parameter 2019-07-12 13:05:10 +02:00
Xavier Arteaga 20823e191d SRSUE: Added UL force amplitude optional parameter 2019-07-12 13:05:10 +02:00
Andre Puschmann 4e86b2f6b2 introduce layerd architecture we use for UE to eNB
- this allows flexible use of different PHYs and radios
- use common radio_multi (moved to lib)
2019-07-12 04:17:56 +02:00
Xavier Arteaga 2530894374 Channel emulator: added input pointer checks 2019-07-11 10:28:13 -04:00
Ismael Gomez d595c4d882 Fixes issue #545 and unlocking of tti_sync condvar before closing causing deadlock at stop 2019-07-11 14:55:35 +02:00
Andre Puschmann aff26abc89 fix memleak in Soapy driver when no device was found 2019-07-10 22:46:33 +02:00
Ismael Gomez 773c2a9721 Fixed multiple issues in Random Access procedure and extended MAC test 2019-07-08 17:14:25 +02:00
Andre Puschmann 6b2961fcee add MAC DL-SCH unpacking test 2019-07-05 17:24:06 +02:00
Andre Puschmann 92f0d58856 mac: move further init/config into ctor to allow early logging, etc. 2019-07-05 17:24:06 +02:00
Francisco Paisana 92b4b168fe added default rlc um and am in the interface as factories 2019-07-05 10:44:15 +02:00
Francisco Paisana b903c1a52c made default init for rlc um test 2019-07-05 10:44:15 +02:00
Francisco Paisana 58e2e51044 removed rlc_interfaces. The rlc_cnfg types are now part of the rrc_interface_types. Removed implicit RB initialization in the RLC. 2019-07-05 10:44:15 +02:00
Francisco Paisana c5509caece added extra operators and remove rrc_asn1 in some cmake targets 2019-07-05 10:44:15 +02:00
Francisco Paisana b936629221 removed rrc asn1 header from bcd_helpers, from rlc_interface, and rlc tests 2019-07-05 10:44:15 +02:00
Francisco Paisana bb0dbf0f1c created a asn1 utils with helper functions and types related to the asn1. These types/functions will help isolate the rrc_asn1 lib from most of the layers, reducing this way the compile times, and leading to better isolation. This will also make the transition to NR smoother. I removed the asn1 types from the NAS and USIM interface so far. 2019-07-05 10:44:15 +02:00
Francisco Paisana 416f9896ec fixes to include the findings from PR #550 2019-07-05 10:38:28 +02:00
Guillem Foreman 46724c336d Fixed errors for phy_dl_test and pdsch test 2019-07-04 15:49:43 +02:00
Guillem Foreman 4627737c87 Revert "Disable 256QAM tests failing in CentOS"
This reverts commit 833ce5224a.
2019-07-04 15:49:43 +02:00