Commit Graph

8091 Commits

Author SHA1 Message Date
Prathyusha Lakkireddy d3e51cf8a7
Improve create proposal code (#8586)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-15 15:43:09 +00:00
Robert Zaremba adbf5a71e6
adr-028 address generation (#8415)
* Optimize secp256k1 hashing

* Add ADR-028 related functions

* Update ed25519

* fix errors/handle

* fix build

* fix build

* Add tests and update function names

* wip

* Use LengthPrefix for composed addresses

* add tests for NewComposed

* add module hash function

* fix append

* rollback ed25519 ADR-28 update

* rollback ed25519 ADR-28 test

* Adding Module tests and convert tests to test suite

* convert store_key_test.go to test suite

* rollback test check comment

* Rename assert.Panic and add comment

* add note to ed25519 about SDK support with regards to ADR-28

* Update ed25519 TestAddress

* Adding Deprecated notes for ed25519.PrivKey

* Update crypto/keys/ed25519/ed25519.go

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

* Update types/address/hash_test.go

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

* solve linter issues

* linter: remove gocritic

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2021-02-15 15:32:51 +00:00
Marko b4690d8ec6
atlas: evidence (#8561)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2021-02-15 13:51:42 +00:00
Emmanuel T Odeke a534a960db
types: use (*math/big.Int).BitLen() == 0 to check if value is 0 (#8580)
Instead of using len((*math/big.Int).Bytes()) == 0, which expensively
creates a byte slice and marshals a value, on the majority hot path,
instead use the cheaper method .BitLen() to check if 0.

Benchmarking results, just from types:

name                                           old time/op    new time/op    delta
CoinsAdditionIntersect/sizes:_A_1,_B_1-8          132ns ± 2%     126ns ±13%   -4.55%  (p=0.050 n=10+10)
CoinsAdditionIntersect/sizes:_A_5,_B_5-8         1.41µs ± 3%    1.41µs ± 2%     ~     (p=1.000 n=10+10)
CoinsAdditionIntersect/sizes:_A_5,_B_20-8        2.30µs ± 1%    2.27µs ± 3%     ~     (p=0.066 n=10+10)
CoinsAdditionIntersect/sizes:_A_1,_B_1000-8      30.9µs ± 3%    30.7µs ± 1%     ~     (p=0.218 n=10+10)
CoinsAdditionIntersect/sizes:_A_2,_B_1000-8      31.4µs ± 3%    30.8µs ± 2%   -1.94%  (p=0.015 n=10+10)
CoinsAdditionNoIntersect/sizes:_A_1,_B_1-8        116ns ± 1%     114ns ± 4%     ~     (p=0.142 n=10+10)
CoinsAdditionNoIntersect/sizes:_A_5,_B_5-8       1.11µs ± 1%    1.08µs ± 3%   -2.36%  (p=0.003 n=8+10)
CoinsAdditionNoIntersect/sizes:_A_5,_B_20-8      1.85µs ± 2%    1.82µs ± 1%   -1.38%  (p=0.001 n=10+9)
CoinsAdditionNoIntersect/sizes:_A_1,_B_1000-8    30.7µs ± 1%    30.6µs ± 3%     ~     (p=0.393 n=10+10)
CoinsAdditionNoIntersect/sizes:_A_2,_B_1000-8    31.1µs ± 1%    30.7µs ± 2%   -1.32%  (p=0.015 n=10+10)
CoinsAdditionNoIntersect/sizes:_A_1000,_B_2-8    31.0µs ± 2%    30.7µs ± 2%     ~     (p=0.190 n=10+10)
Bech32ifyPubKey-8                                28.8µs ± 5%    28.8µs ± 3%     ~     (p=0.965 n=10+8)
GetPubKeyFromBech32-8                            38.8µs ± 3%    39.4µs ± 2%   +1.70%  (p=0.013 n=9+10)
ParseCoin-8                                      16.7µs ± 6%    15.8µs ± 4%   -5.21%  (p=0.001 n=10+10)
MarshalTo-8                                       521ns ± 5%     508ns ± 3%   -2.56%  (p=0.029 n=10+10)
UintMarshal-8                                    3.10µs ±17%    2.56µs ± 3%  -17.45%  (p=0.000 n=10+9)
IntMarshal-8                                     2.52µs ±10%    1.94µs ± 2%  -23.10%  (p=0.000 n=10+10)

name                                           old alloc/op   new alloc/op   delta
Bech32ifyPubKey-8                                4.02kB ± 0%    4.02kB ± 0%     ~     (all equal)
GetPubKeyFromBech32-8                            2.48kB ± 0%    2.48kB ± 0%     ~     (all equal)
ParseCoin-8                                      2.21kB ± 0%    2.21kB ± 0%     ~     (all equal)
MarshalTo-8                                       80.0B ± 0%     80.0B ± 0%     ~     (all equal)
UintMarshal-8                                      440B ± 0%      392B ± 0%  -10.91%  (p=0.000 n=10+10)
IntMarshal-8                                       216B ± 0%      168B ± 0%  -22.22%  (p=0.000 n=10+10)

name                                           old allocs/op  new allocs/op  delta
Bech32ifyPubKey-8                                  25.0 ± 0%      25.0 ± 0%     ~     (all equal)
GetPubKeyFromBech32-8                              85.0 ± 0%      85.0 ± 0%     ~     (all equal)
ParseCoin-8                                        71.0 ± 0%      71.0 ± 0%     ~     (all equal)
MarshalTo-8                                        2.00 ± 0%      2.00 ± 0%     ~     (all equal)
UintMarshal-8                                      31.0 ± 0%      25.0 ± 0%  -19.35%  (p=0.000 n=10+10)
IntMarshal-8                                       24.0 ± 0%      18.0 ± 0%  -25.00%  (p=0.000 n=10+10)

name                                           old speed      new speed      delta
UintMarshal-8                                  2.27MB/s ±15%  2.75MB/s ± 2%  +20.87%  (p=0.000 n=10+8)
IntMarshal-8                                   2.78MB/s ± 9%  3.60MB/s ± 2%  +29.69%  (p=0.000 n=10+10)

Fixes #8575

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-15 10:53:10 +00:00
MD Aleem d162b29cf4
Add pagination to GetValidatorSetByHeight response (#8567)
* fix pagination

* add test

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-15 10:41:39 +00:00
Amaury e306e5b6f5
Make gRPC requests go through tendermint Query (#8549)
* Make gRPC requests go through tendermint Query

* Remove commented code

* Dry run in InitChain?

* Save type of first run

* Add metadata in repsonse

* Factorize some code

* Fix lint

* Update comments

* Fix md test

* Fix test expected

* Don't put RunGRPCQuery as clientCtx method

* Update baseapp/grpcserver.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Address review comments

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2021-02-15 10:01:44 +00:00
Marko d9d078fbc2
docs: rest_grpc updates (#8582) 2021-02-15 09:41:26 +00:00
Sunny Aggarwal cb725e1959
Merge pull request #7802 from sikkatech/gov_split_vote_weighted_vote
ADR 037 Implementation:  Governance Split Votes
2021-02-12 13:20:40 -05:00
Sunny Aggarwal a417b5142f update CHANGELOG 2021-02-12 12:37:56 -05:00
Sunny Aggarwal 188a8a2e15 import hygiene 2021-02-12 12:27:07 -05:00
Sunny Aggarwal 8847157a73
Update x/gov/client/utils/utils.go
Co-authored-by: Marko <markobaricevic3778@gmail.com>
2021-02-12 12:19:14 -05:00
Sunny Aggarwal 47f7502e72
Merge branch 'master' into gov_split_vote_weighted_vote 2021-02-12 11:07:27 -05:00
Sunny Aggarwal ac16c90e5c remove legacy rest endpoints as per @anilCSE 2021-02-12 11:06:45 -05:00
Prathyusha Lakkireddy e4b2d75dc4
ibc : replace strings.Contains to bytes.Contains (#8574)
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2021-02-12 13:32:03 +00:00
dependabot[bot] fc6c678bd2
build(deps): bump github.com/spf13/cobra from 1.1.2 to 1.1.3 (#8566)
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spf13/cobra/compare/v1.1.2...v1.1.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-12 10:19:07 -03:00
dependabot[bot] 591e46f35c
build(deps): bump github.com/tendermint/tendermint from 0.34.3 to 0.34.4 (#8573)
Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.34.3 to 0.34.4.
- [Release notes](https://github.com/tendermint/tendermint/releases)
- [Changelog](https://github.com/tendermint/tendermint/blob/v0.34.4/CHANGELOG.md)
- [Commits](https://github.com/tendermint/tendermint/compare/v0.34.3...v0.34.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-12 12:31:21 +00:00
Riccardo Montagnin 090411a7b5
Removed GetValidator caching to fix concurrency error (#8546)
* Removed GetValidator caching to fix concurrency error

* Fixed linting and added CHANGELOG entry

* Moved benchmark test into its own file

* Moved CHANGELOG entry to bug fix

* Update CHANGELOG.md

Co-authored-by: Cory <cjlevinson@gmail.com>

Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-12 11:52:03 +00:00
Sunny Aggarwal 3a7cc3bd3a epoched staking 2021-02-11 16:23:53 -05:00
ValarDragon 352a19e6eb Add epoched staking ADR 2021-02-11 11:30:42 -06:00
MD Aleem 2154815f4c
x/authz specs (#8499)
* init

* init

* add events

* add state & messages

* WIP

* update Readme

* WIP

* Update x/README.md

Co-authored-by: Alessio Treglia <alessio@tendermint.com>

* Update x/authz/spec/README.md

Co-authored-by: Amaury <amaury.martiny@protonmail.com>

* Update x/authz/spec/02_state.md

Co-authored-by: Amaury <amaury.martiny@protonmail.com>

* Update x/authz/spec/01_concepts.md

Co-authored-by: Amaury <amaury.martiny@protonmail.com>

* review changes

* Update x/authz/spec/01_concepts.md

Co-authored-by: Amaury <amaury.martiny@protonmail.com>

* Update x/authz/spec/02_state.md

Co-authored-by: Amaury <amaury.martiny@protonmail.com>

* Update x/authz/spec/01_concepts.md

Co-authored-by: Cory <cjlevinson@gmail.com>

* Update x/authz/spec/04_events.md

Co-authored-by: Cory <cjlevinson@gmail.com>

* Update x/authz/spec/04_events.md

Co-authored-by: Cory <cjlevinson@gmail.com>

* Update x/authz/spec/README.md

Co-authored-by: Cory <cjlevinson@gmail.com>

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
2021-02-11 16:56:37 +00:00
SaReN bddbc131fd
update pagination tests (#8565) 2021-02-11 09:49:26 +00:00
Amaury dfc8dd813e
Add in-place store migrations (#8485)
* Add 1st version of migrate

* Put migration logic into Configurator

* add test to bank store migration

* add test for configurator

* Error if no migration found

* Remove RunMigrations from Configurator interface

* Update spec

* Rename folders

* copy-paste from keys.go

* Fix nil map

* rename function

* Update simapp/app.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update simapp/app_test.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Adderss reviews

* Fix tests

* Update testutil/context.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update docs for ConsensusVersion

* Rename to forVersion

* Fix tests

* Check error early

* Return 1 for intiial version

* Use MigrationKeeper

* Fix test

* Revert adding marshaler to Configurator

* Godoc updates

* Update docs

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-02-10 17:49:31 +00:00
Sunny Aggarwal 065c1b39ce
Apply suggestions from code review
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2021-02-10 12:27:06 -05:00
billy rennekamp 9ca52f4202
Update cosmovisor.md (#8552)
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-10 09:52:57 +00:00
dependabot[bot] 7baf715495
build(deps): bump github.com/spf13/cobra from 1.1.1 to 1.1.2 (#8554)
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spf13/cobra/compare/v1.1.1...v1.1.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-10 09:49:43 +00:00
dependabot[bot] 926ef341bf
build(deps): bump JamesIves/github-pages-deploy-action from 3.7.1 to 4.0.0 (#8535)
Bumps [JamesIves/github-pages-deploy-action](https://github.com/JamesIves/github-pages-deploy-action) from 3.7.1 to 4.0.0.
- [Release notes](https://github.com/JamesIves/github-pages-deploy-action/releases)
- [Commits](https://github.com/JamesIves/github-pages-deploy-action/compare/3.7.1...049a95c516cd5723d8cfde79dc7a79fcdcbd6c97)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-10 08:32:27 +00:00
dependabot[bot] 41f3c05007
build(deps): bump github.com/tendermint/tm-db from 0.6.3 to 0.6.4 (#8555)
Bumps [github.com/tendermint/tm-db](https://github.com/tendermint/tm-db) from 0.6.3 to 0.6.4.
- [Release notes](https://github.com/tendermint/tm-db/releases)
- [Changelog](https://github.com/tendermint/tm-db/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tendermint/tm-db/compare/v0.6.3...v0.6.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-10 08:29:06 +00:00
Tobias Schwarz 011e75ba35
Update chain-upgrade-guide-040.md (#8326)
Still a problem with `cat` - a tmp_genesis file needs to be created and then moved to the old location

Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
2021-02-09 15:13:19 -08:00
Sunny Aggarwal 157a24681c
Merge branch 'master' into gov_split_vote_weighted_vote 2021-02-09 15:18:53 -05:00
dependabot[bot] 816306b85a
build(deps): bump github.com/improbable-eng/grpc-web (#8536)
Bumps [github.com/improbable-eng/grpc-web](https://github.com/improbable-eng/grpc-web) from 0.13.0 to 0.14.0.
- [Release notes](https://github.com/improbable-eng/grpc-web/releases)
- [Changelog](https://github.com/improbable-eng/grpc-web/blob/master/CHANGELOG.md)
- [Commits](https://github.com/improbable-eng/grpc-web/compare/v0.13.0...v0.14.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-08 13:00:11 +00:00
Afanti bb85a690ab
Fix typo in context and node docs (#8533)
* Update context.md

* fix typo in the node document
2021-02-08 09:55:24 +00:00
Alessio Treglia 8001e3ca3a
bank: don't ignore errors returned by Balance.GetAddress() (#8531)
Closes: #8530
2021-02-06 21:51:26 +00:00
SaReN c5c049a045
Persist evidence in equivocation handler (#8502)
* Persist evidence in handler

* update docs

* update docs

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-05 15:35:03 +00:00
antstalepresh 46d6fa0ecc fix simulation test, marshal json process 2021-02-06 01:21:22 +10:00
Alessio Treglia c54b3c4344
cosmovisor: ln -s docs/run-node/cosmovisor.md cosmovisor/README.md (#8526)
Avoid duplication of contents.
2021-02-05 15:17:52 +00:00
antstalepresh 404dc4f356 Merge branch 'master' of github.com:sikkatech/cosmos-sdk into gov_split_vote_weighted_vote 2021-02-06 01:03:32 +10:00
antstalepresh b55913ddad fix comments and add CHANGELOG 2021-02-06 00:57:12 +10:00
dependabot[bot] c0c0665d4e
build(deps): bump actions/cache from v2.1.3 to v2.1.4 (#8521)
Bumps [actions/cache](https://github.com/actions/cache) from v2.1.3 to v2.1.4.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](https://github.com/actions/cache/compare/v2.1.3...26968a09c0ea4f3e233fdddbafd1166051a095f6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-05 13:45:56 +00:00
Ian Norden a3757e14a8
ADR 038: State Listening (#8012)
* ADR-038 state listening

* updates/fixes

* review fixes/adjustments

* review fixes/adjustments part 2

* review updates part 3: refactor after review to coordinate store changes with block and tx messages and enable file pruning

* review updates part 4: additional details and fixes; addressing recent feedback; use binary protobuf encoding for kv pairs in files

* review updates part 5: formatting fixes; updated StreamingService/Hook interface

* auxiliary streaming/queue service

* review updates part 6: update StoreKVPair to differentiate between Set and Deletes on nil byte values; some minor adjustments

* typo fix
2021-02-04 18:09:28 -08:00
atheeshp 0af248b95b
Add specs for feegrant (#8496)
* add specs

* address review comments

* Address review changes

Co-authored-by: Amaury <amaury.martiny@protonmail.com>

* review changes

* address review changes

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2021-02-04 13:38:16 +00:00
Victor França Ferreira 0ddb7041a8
fixing typo at 'os' backend session (#8477)
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-04 09:58:27 +00:00
Alessio Treglia 2e04f2778f
snapshots: document use of ioutil.TempDir() (#8508)
Document with inline comments the changes introduced
in https://github.com/cosmos/cosmos-sdk/pull/8475.

Run make format.
2021-02-04 09:54:01 +00:00
Robert Zaremba 931af4350b
Finalize ADR-028 (#8398)
Finalize ADR-028

* added note about Named Accounts
* Update docs/architecture/adr-028-public-key-addresses.md
* remove blake2b
* move some paragraphs to 'Further Discussion'
* move composing module accounts to a new subsectoin
* adding appendix from meeting with Alan
* composed addresses: use LengthPrefix before sorting
2021-02-04 04:08:11 +01:00
Amaury d84942c1c0
Remove useless package-lock.json (#8506) 2021-02-03 20:38:23 +00:00
Sunny Aggarwal 2c1ef714f8
Merge pull request #65 from psaradev/issue#8365/staking_power_reduction_chain_param
power reduction as on-chain param
2021-02-03 09:42:24 -05:00
psaradev 2a43a2d8a4 reduce legacy code 2021-02-03 23:15:42 +10:00
SaReN 2e9fd04020
Remove Info Importer from legacy keybase (#8500) 2021-02-03 13:11:42 +00:00
psaradev 36bc29a993 golang-ci lint 2021-02-03 23:06:02 +10:00
psaradev 71305449d6 regen staking.pb.go 2021-02-03 22:43:27 +10:00
psaradev 0e6b9a613a
Merge branch 'master' into issue#8365/staking_power_reduction_chain_param 2021-02-03 22:40:05 +10:00