crypto.LedgerShowAddress() is a ledger specific function
and should takes acc address prefix instead of depending
on a sdk.Config singleton.
crypto/keys/mintkey:
- decryptPrivKey() return error instead of os.Exit()ing.
- encryptPrivKey() should panic instead of os.Exit() when
bcrypt.GenerateFromPassword() call fails so that the
caller is given a chance to recover().
crypto/keys:
- SignWithLedger() does not need to be method of
baseKeybase. Method receiver is unused.
- ledgerInfo objecta may be pointers, type switch
should handle both to avoid panics.
- keyringKeybase should not provide Update() at all.
More test cases are added to increase package crypto
and subpackages overall coverage.
* fix DiffKVStores(), store/types gets 100% coverage
DiffKVStores() used to return duplicated entries
in some cases.
Add test cases, aiming to reach 100% coverage for
store package.
Remove duplicate Cp function from the store package.
Same functionality is provided by types.CopyBytes().
* More test cases
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* make .golangcy.yml work with Goland's Golint plugin
Explicitly disable all linters. Whitelist of enabled
plugins is already provided.
This would enable Goland users to user Golint plugin.
* fix deadcode warnings
* fix gocritic error
unslice: could simplify pkBytes[:] to pkBytes
* use simapp into keeper
* refactor TestHistoricalInfo to use simapp
* refactor historical info test
* temporal commit on querier test, it passes
* commit end of day refactoring
* rename and temp commit
* fix test query validators
* make TestQueryDelegations pass with simapp :D
* rename function
* make TestQueryRedelegations pass with simapp
* finish keeper refactor for querier in staking using simapp
* refactor delegation test TestUnbondDelegation to use simapp
* make all test pass temporary
* avoid usage of historicals
* refactor creation of the simapp
* refactor creation of simapp
* comment before creating new way to generate accounts
* make TestDelegation pass with generated accounts
* refactor to use accounts
* refactor test unbondingdelegationsmax entries
* refactor TestUndelegateSelfDelegationBelowMinSelfDelegation to use simapp
* update TestUndelegate from unbonding validator and fix bug
* refactor TestUndelegateFromUnbondedValidator to use simapp
* TestUnbondingAllDelegationFromValidator to use simapp
* refactor TestGetRedelegationsFromSrcValidator to use simapp
* refactor TestRedelegation to use simapp
* refactor TestRedelegateToSameValidator to use simapp
* refacotr TestRedelegationMaxEntries to use simapp
* refactor delegation test
* refactor TestRedelegateFromUnbondingValidator to use simapp
* finish refactor delegation test
* refactor and remove unused code
* migrate revocation of old slash test
* fix TestSlashUnbondingDelegation test to use simapp
* refactor TestSlashRedelegation to use simapp
* refactor TestSlashAtFutureHeight test
* test TestSlashAtNegativeHeight migrated to simapp
* migrated two tests from slash_test to use simapp
* refactor TestSlashWithRedelegation
* end refactoring slash_test
* refactor first test validation to simapp
* refacor TestUpdateValidatorByPowerIndex to use simapp
* refactor TestUpdateBondedValidatorsDecreaseCliff to simapp
* refactor TestSlashToZeroPowerRemoved
* TestValidatorBasics
* refactro TestGetValidatorSortingUnmixed to simapp
* refactor TestGetValidatorSortingMixed test to simap
* refctor TestGetValidatorsEdgeCases to use simapp
* make test TestValidatorBondHeight pass
* refactor TestFullValidatorSetPowerChange test
* end refactoring validator_test
* clean code
* move methods
* rename
* rename commont test
* git remove unused vars
* refactor ordering functions
* refactor old genesis_test to use simapp
* refactor TestValidatorByPowerIndex
* refactor TestDuplicatesMsgCreateValidator
* refactor TestInvalidPubKeyTypeMsgCreateValidator
* temporary commit
* refactor TestLegacyValidatorDelegations to use simapp
* refactor TestIncrementsMsgDelegate
* refactor next
* refactor TestEditValidatorIncreaseMinSelfDelegationBeyondCurrentBond
* refactor TestIncrementsMsgUnbond
* refator TestMultipleMsgCreateValidator
* refactor TestMultipleMsgDelegate
* refactor TestJailValidator
* refactor TestUnbondingPeriod and TestValidatorQueue
* refactor TestUnbondingFromUnbondingValidator and TestRedelegationPeriod
* refactor TestTransitiveRedelegation and TestMultipleRedelegationAtSameTime
* refactor TestMultipleRedelegationAtUniqueTimes and TestMultipleUnbondingDelegationAtSameTime
* refactor TestMultipleUnbondingDelegationAtUniqueTimes and TestUnbondingWhenExcessValidators
* end refactor handler_test
* remove test_common
* remove create test public keys
* fix based on PR comments
* use prealloc array for ConvertAddrsToValAddrs
* fix lint errors
* fix lint errors 2
* remove duplicated func
* rename function names
* Update simapp/test_helpers.go
* Update x/staking/keeper/keeper.go
* Update simapp/test_helpers.go
* Update simapp/test_helpers.go
* add last touches to the PR
* edit text
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
seungyeon-hwang
Alexander Bezobchuk
Jonathan Gimeno
Alessio Treglia