Commit Graph

2956 Commits

Author SHA1 Message Date
Christopher Goes 777d7bee5a
Merge PR #1593: tools: Add code complexity linter, gocyclo 2018-07-10 01:45:54 +02:00
ValarDragon 30c4abb394 Fix golint error 2018-07-09 16:27:51 -07:00
ValarDragon 472e168a72 Minor refactor to reduce complexity, add nolint 2018-07-09 16:24:20 -07:00
ValarDragon 99e91dd276 Add nolints on remaining functions 2018-07-09 16:16:43 -07:00
ValarDragon 17b5370c22 Continue fixing gocyclo errors 2018-07-09 16:08:35 -07:00
ValarDragon 592419c83a Reduce code complexity of testnet command 2018-07-09 15:29:16 -07:00
ValarDragon e906272ca0 Reduce complexity of baseapp query 2018-07-09 15:29:16 -07:00
ValarDragon 2a419a3192 add helper to UpdateBondedValidatorsFull 2018-07-09 15:29:16 -07:00
ValarDragon 1433b61a92 Missed a min in slashing 2018-07-09 15:29:16 -07:00
ValarDragon 0c5358c267 Continue reducing code complexity:
* Adds a Min function to Int, and uses that in the slash function
* Adds a getHeight helper function to iavlstore
* Adds a splitPath function to baseapp
* Changes cyclo param from 10 to 11
2018-07-09 15:29:16 -07:00
ValarDragon 2b5ccdbf87 Reduce code complexity in AnteHandler, and GetExternalIP 2018-07-09 15:29:16 -07:00
ValarDragon a768543d92 tools: Add code complexity linter, gocyclo
Gocyclo is a code complexity linter. It uses cyclomatic complexity.
Cyclomatic complexity essentially measures the number of different
paths code could go through. (The conditional in a for loop counts
as adding one path) It looks at this on a per-function level. The
idea that this would be enforcing is that if there are too many
different paths code can go through in a function, it needs to be
better split up. (A function with too many code paths is hard to
reason about)

The complexity which we want the linter to start failing on is
configurable. The default is 10. Change the "Cyclo" parameter in
`tools/gometalinter.json` to try other values.
2018-07-09 15:29:16 -07:00
Christopher Goes 37640d6c00
Merge PR #1601: Fix LCD rest-server command 2018-07-09 22:34:01 +02:00
Christopher Goes cc113bae37
Merge PR #1588: Add SECURITY.MD 2018-07-09 22:33:20 +02:00
Aleksandr Bezobchuk 7fc2363191 Merge pull request #1601: Fix LCD rest-server Command 2018-07-09 15:56:08 -04:00
ValarDragon 8603eb2f62 Remove mismatch in specification section (for now) 2018-07-09 11:36:43 -07:00
Christopher Goes 0d6f99d6d5
Merge PR #1590: store: Setting default back to archive mode / no pruning 2018-07-09 19:23:01 +02:00
Christopher Goes 0d94c5a255
Merge PR #1591: gaiad: Genesis txs now use bech32 encoding of address and pubkey 2018-07-08 22:13:24 +02:00
Ethan Buchman 988614e4aa
Merge pull request #1579 from cosmos/bucky/baseapp-tests
Cleanup Baseapp tests
2018-07-07 19:04:54 -04:00
ValarDragon 611e4faa3a gaiad: Genesis txs now use bech32 encoding of address and pubkey
* `gaiad init gen-tx` makes the outputted file use bech32, with acct prefix
* `gaiad init --gen-txs` only reads bech32 with acct prefixes

The reason for using the account prefix is that in principle you could
have genesis transactions for non-validators.

Closes #1475
2018-07-07 14:23:19 -07:00
ValarDragon 3a7a19deec Address comments 2018-07-07 12:44:06 -07:00
Jeremiah Andrews 4c5850d405 setting default to archive mode / no pruning 2018-07-07 12:34:11 -07:00
Christopher Goes 4d303ce745
Merge PR #1589: tools: Switch gometalinter to use a config file 2018-07-07 21:22:59 +02:00
ValarDragon 08e98d3124 tools: Switch gometalinter to use a config file 2018-07-07 12:00:06 -07:00
Ethan Buchman 6159554d8a fixes from review 2018-07-07 14:50:19 -04:00
ValarDragon eb8b85c0c9 Add SECURITY.MD
Closes #1267
2018-07-07 11:28:03 -07:00
Ethan Buchman fe7ae1151d baseapp: refactor tests
* simplify mock tx type, msgs, and handlers
* remove dependencies on auth and bank
* dedup with setupBaseApp
* lots of comments and cleanup
* fixes where we weren't checking results
* use some table driven tests
* remove TestValidatorChange - its not testing anything since baseapp
doesnt track validator changes
* prepare for CheckTx only running the AnteHandler
* fix runTx gas handling and add more tests
* new tests for multi-msgs
2018-07-07 13:41:36 -04:00
Christopher Goes 51a50210e9
Merge PR #1565: Validator Cliff Updates 2018-07-07 02:50:54 +02:00
Christopher Goes 88bc3744e6
Merge PR #1514: Unbond validators set to zero power 2018-07-07 02:40:12 +02:00
Christopher Goes 3b7fbf66ab assert -> require 2018-07-07 02:37:59 +02:00
rigelrozanski d36dda0267 address cwgoes comments 2018-07-06 20:29:39 -04:00
Christopher Goes 3630cde63e Address PR comments 2018-07-07 02:20:37 +02:00
rigelrozanski f08f02d67d changelog 2018-07-06 20:04:01 -04:00
Christopher Goes dbe7744b14 Simplify test slightly 2018-07-07 02:02:46 +02:00
rigelrozanski 062a683d11 completely fix dem tests 2018-07-06 20:00:33 -04:00
Christopher Goes eafd1e492f Update comments 2018-07-07 01:53:40 +02:00
rigelrozanski 37a5f2fd4c fix count in UpdateBondedValidators to not include revoked validators 2018-07-06 19:53:07 -04:00
Christopher Goes c456daae25 Merge remote-tracking branch 'origin/develop' into cwgoes/zero-power-should-not-be-bonded 2018-07-07 01:49:46 +02:00
Christopher Goes ad3e123c82 Ignore slashes on nonexistent validators; update testcases 2018-07-07 01:49:17 +02:00
Christopher Goes 3805c35aff Merge pull request #1582: Simplify auth.StdSignMsg fields, add testcase
* Simplify auth.StdSignMsg

* Add StdSignMsg.Bytes() test
2018-07-06 19:26:22 -04:00
rigelrozanski 5d2b6c81ea split out cliff problems to more tests 2018-07-06 18:41:04 -04:00
rigelrozanski 2bf0b842fa Merge remote-tracking branch 'origin/develop' into rigel/a-validator-on-a-cliff 2018-07-06 18:04:49 -04:00
Christopher Goes 723e057d95 Merge pull request #1566: Fix validator power decrease bug
* Demonstrative testcase

* Update when decreasing but still bonded

* Only update when decreasing, not when equal

* Cleanup conditional; changelog

* Clarify comments

* Simplify conditional
2018-07-06 18:00:00 -04:00
Dev Ojha 6f8f222ef6 Merge pull request #1175: Randomized Module Testing
* WIP, ammend this later

* Add randomized testing suite

* Fix linting

* Auth invariant check, method to take in seed, way to run invariant check less frequently

* Fix merge conflicts

* Update bank

* Fix error on zero input by skipping it

* Add PeriodicInvariant Function

* Abstract verification / send functionality

* Fix liniting errors (PeriodicInvariant godoc)

* Update formatting and docs of randomization

* Minor refactor, update godocs

* Update godoc for mock

* Export TestAndRunTx

* fix cyclic dependencies

* Address PR most pr comments

* Fix merge conflict: Bring back codec.seal

* remove debug code, fix linting

* Fix merge conflicts
2018-07-06 16:19:11 -04:00
rigelrozanski 926a6160c9 rearrage cliff tests to reveal new problem 2018-07-06 03:04:01 -04:00
Christopher Goes 86d7b8f981
Merge PR #1573: gov/client: rename submitproposal to submit-proposal 2018-07-06 08:02:59 +02:00
Christopher Goes 601ecba239
Merge PR #1572: cli: Add async flag to all broadcasting txs 2018-07-06 08:01:36 +02:00
ValarDragon 12c1eb4d31 gov/client: rename submitproposal to submit-proposal
It is standard in the sdk to use a dash for subcommands / flags
with multiple words. This makes submitproposal comply with that.
2018-07-05 22:22:50 -07:00
ValarDragon c708c799fd Add print-response flag 2018-07-05 22:19:50 -07:00
ValarDragon 8e20200abe Add --json flag 2018-07-05 20:42:41 -07:00