colin axnér
ed9fc058f1
Add an IBC prefix to transfer escrow addresses ( #7967 )
...
* add IBC prefix to escrow addresses
* use ADR 028 AddressHash construction
* remove extra space
* apply @AdityaSripal suggestion; prefix from ibc -> ibc-transfer-escrow-prefix
* Use alternative 1 proposed by @andrey-kuprianov
* anticpate necessary build fix
* add escrow address issue link into module.go
* Update x/ibc/applications/transfer/types/keys.go
Co-authored-by: Andrey Kuprianov <59489470+andrey-kuprianov@users.noreply.github.com>
* Update x/ibc/applications/transfer/types/keys.go
Co-authored-by: Andrey Kuprianov <59489470+andrey-kuprianov@users.noreply.github.com>
* apply @andrey-kuprianov review suggestions
Deduplicate code into a helper function as suggested. Add unit tests for max transfer channels test.
Co-authored-by: Andrey Kuprianov <59489470+andrey-kuprianov@users.noreply.github.com>
2020-11-26 13:44:54 +00:00
yihuang
512b533242
cli: ParseCoin doesn't do normalize ( #7954 )
...
follow up on https://github.com/cosmos/cosmos-sdk/pull/7777
ParseCoin need to be treated similarly.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-25 18:02:10 +00:00
MD Aleem
c58a8923a0
gRPC-gateway routes as alternative to legacy tendermint REST endpoints ( #7965 )
...
* WIP
* WIP setup
* WIP setup testsuite
* add node_info
* add GetLatestBlock,GetBlockByHeight grpc endpoints
* add GetValidatorSetByHeight, GetLatestValidatorSet
* fix lint
* fix tests
* proto format
* Update Makefile
* review changes
* Makefile format
* handle nil pagination
* rename query.go to service.go
* format Makefile
* format Makefile
* review changes
* review changes
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-25 15:58:11 +00:00
Amaury
a9dd334c34
Fix legacy querying tx ("unregistered type" bug) ( #7992 )
...
* Add tests for query txs
* Add test for IBC
* Refactor checkSignModeError
* Fix lint
* Add successful IBC test
* Remove logs
* break
* Remove known errors
* Update error message
* Better comments
* Revert variable renaming
* Fix lint
* Add mention of gRPC as TODO
2020-11-25 12:02:31 +00:00
Alessio Treglia
9c47612b5d
Makefile: use docker run --rm whenever possible ( #8026 )
...
Remove terminated containers once their execution
has finished. This saves the users a bit of disk
space.
Closes : #8023
2020-11-25 11:23:37 +00:00
Amaury
1b3ce2c1d1
CLI `migrate` command for x/{upgrade,params} proposals ( #7875 )
...
* Add v038 upgrade types
* Add migrate x/upgrade
* remove nolint
* Add ParameterChangeProposal
* Revert change
* Don't register crypto twice
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-24 23:32:32 +00:00
Amaury
12a02b98a5
CopyTx also copies timeoutHeight ( #8015 )
...
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-24 17:09:30 +00:00
Aditya
c15884a204
Rename Version to Revision in IBC Height ( #8020 )
...
* rename Version to Revision in ibc Height
* lint
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-24 15:38:24 +00:00
colin axnér
88e03e4f40
Deterministic connection and channel identifiers ( #7993 )
...
* add generate identifier functions for connection and channel
* update proto types and begin open init changes
remove unnecessary field from open init msgs. Update connectionopeninit handshake, begin updating channel handshake
* finish connection handshake chanes and some channel handshake changes
Finish updating connection handshake changes, update genesis for connection and channel, some channel handshake changes, fix build for tests but still failing
* finish channel handshake changes
* fix more tests
* fix connection handshake tests
* fix more tests
* fix build
* changes from self review
* address @fedekunze review suggestions
* update spec
* fix build
* fix tests
* Update x/ibc/testing/chain.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Update x/ibc/core/03-connection/types/msgs.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* address @AdityaSripal comments
* reflect spec changes
* address @AdityaSripal review suggestions
* nit
* add connection/channel identifier parsing and validation as per @AdityaSripal suggestion, cc @fedekunze
* Fix auth rest test
Change dummy channel id to a valid channel id given the updated stricter channel identifier checks cc @amaurymartiny
Co-authored-by: Aditya <adityasripal@gmail.com>
2020-11-24 15:28:20 +00:00
Amaury
ccd0d63f80
Update "Core Concepts" docs ( #7948 )
...
* Update "Core Concepts" docs
* Update tags
* Update more subsctions
* Revert basics
* ADd link to run-node
* Typo
* Add sign modes
* Finish transaction.md
* Update docs/core/baseapp.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update docs/core/baseapp.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update docs/core/baseapp.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update docs/core/baseapp.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update docs/core/baseapp.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update docs/core/baseapp.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Wording
* Update docs/core/baseapp.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Revert basics changes
* revert space change
* typo
* Update docs/core/transactions.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update docs/core/node.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/core/store.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-24 15:03:20 +00:00
Amaury
13bc504bec
docs: Add REST endpoints migration guide ( #8011 )
...
* Add REST endpoints migration guide
* add bank, distrib, evidence
* Add slashing, mint
* Add staking
* Add query
* Add todo
* Typos
* Add link to interact node
* grammar
* Better wording
* Update docs/migrations/rest.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/migrations/rest.md
* Add footnote
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-11-24 14:34:20 +00:00
Aditya
53294f5269
check clients against params and consensus against clients ( #8016 )
...
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-11-24 12:27:35 +00:00
Aditya
def3c5ba71
Add ConsensusState to IBC Upgrades ( #7919 )
...
* upgrade progress
* fix build minus cli
* write state at block before upgrade height
* refix build
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* fix upgrade and start with tests
* fix tendermint tests
* add tests and remove unnecessary relayer options on upgradedClient
* fix all tests except weird msg panic
* add invalid final client test and codec stuff
* fix everything but msg issue
* remove problematic test for now
* safer self validation
* upgrade fixes
* proto-linting
* remove unnecessary last height
* add timestamp to committed upgrade consensus state
* address final nits
* address nit
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-24 11:45:33 +00:00
Amaury
74435137e9
Show height on legacy REST endpoints ( #7997 )
...
* Fix showing height in rest endpoints
* Fix query height
* Manually inject req.Height
* Small tweaks
* Use withHeight
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-24 10:28:12 +00:00
Aaron Craelius
251a27d104
Update ADR status ( #8009 )
2020-11-23 16:31:17 +00:00
colin axnér
966e26d23d
Fix tendermint misbehaviour trusted consensus state age check ( #8006 )
...
* use TrustingPeriod instead of UnbondingPeriod when verifying the age of the trusted consensus state
* update comment
2020-11-23 16:10:25 +01:00
Emmanuel T Odeke
6344d626db
types/Coin: compile and reuse Regexps to reduce massive RAM+CPU burn ( #7989 )
...
* types/Coin: compile and reuse Regexps to reduce massive RAM+CPU burn
Fixes a resource (CPU+RAM) burn from recompiling Regexps which would
consume 1.2+MiB of RAM and 1.1ms per ParseCoin invocation, which means
that 1,000 invocations would consume 1.2GiB of RAM and >1second.
With the change, ParseCoin now takes 3.2us down from 1.1ms, with
dramatic results:
name old time/op new time/op delta
ParseCoin-8 1.04ms ± 4% 0.00ms ± 1% -99.69% (p=0.000 n=9+10)
name old alloc/op new alloc/op delta
ParseCoin-8 1.20MB ± 0% 0.00MB ± 0% -99.94% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
ParseCoin-8 17.8k ± 0% 0.0k ± 0% -99.89% (p=0.000 n=10+10)
Fixes #7986 .
* replace the CoinDenomRegex variable with SetCoinDenomRegex() (#7998 )
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-11-20 19:37:45 +00:00
Aleksandr Bezobchuk
a7296d3d4e
Bump Tendermint v0.34.0 ( #7995 )
...
* init commit
* ibc: remove redundant casting
* ci: attempt fix liveness job
2020-11-20 19:00:11 +01:00
Alexander Peters
d8928c6b80
CI: Fix codecov flag project config ( #7994 )
2020-11-20 09:13:25 -05:00
Robert Zaremba
a054da8d62
Merge pull request #7979 from cosmos/robert/bech32-pubkey-slashing
...
Bech32 PubKey: use protobuf in slashing keeper
2020-11-20 12:58:28 +01:00
SaReN
07cfed4178
Merge branch 'master' into robert/bech32-pubkey-slashing
2020-11-20 01:23:54 +05:30
Aleksandr Bezobchuk
4be5cd3454
docs: x/bank: Atlas Doc ( #7961 )
2020-11-19 11:57:10 -05:00
Alessio Treglia
fcb6c33c34
revert tiny portion of #7970 ( #7984 )
...
Testable examples were accidentally converted into tests.
2020-11-19 16:15:31 +00:00
Robert Zaremba
fdac39813c
changelog update
2020-11-19 13:34:35 +01:00
Alessio Treglia
ba4bc4b5c8
exclude *.pb.gw.go files from codecov.io report ( #7981 )
2020-11-19 09:48:55 +00:00
Robert Zaremba
a4130f5821
remove unused function
2020-11-19 02:19:19 +01:00
Robert Zaremba
0034e48458
Bech32 PubKey: use protobuf in slashing keeper
2020-11-19 01:10:11 +01:00
Robert Zaremba
fe58ee9951
ADR-031: elaborate consequences and encapsulation of module client-se… ( #7839 )
...
* ADR-031: elaborate consequences and encapsulation of module client-server implementation
* Update docs/architecture/adr-031-msg-service.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-11-18 23:11:04 +00:00
Amaury
35183a37e6
Fix StatusCommand ( #7974 )
...
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2020-11-18 21:44:13 +00:00
Federico Kunze
87315a6aab
ibc: commit packet and hash ( #7808 )
...
* ibc: commit packet and hash
* minor changes
* fix build
* update err msgs
* don't use Any
* update commitment hash to used fixed length preimage
The commitment hash will now use 8 bytes timeout timestamp + 8 bytes timeout height version number + 8 bytes timeout height version height + sha 256 hash of data
* remove error from CommitPacket return values
* update godoc
* rm proto-tools-stamp
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-18 19:01:22 +00:00
Federico Kunze
97d96612c9
crypto/hd: add 'm/' prefix to hd path ( #7970 )
...
* crypto/hd: add 'm/' prefix to hd path
* update fundraiser path
* fix some tests
* tests
* fix test case
* changelog
* fix ledger tests
2020-11-18 18:42:45 +00:00
colin axnér
f02a46263f
update transfer error messages ( #7968 )
...
* update transfer err messages
* apply @AdityaSripal review suggestion
2020-11-18 14:56:26 +01:00
Marie Gauthier
1cc8af8d9b
[docs]: update building modules section to reflect ADR31 ( #7702 )
...
* Revert "Revert "Update old ref of RegisterQueryService""
This reverts commit 03e4c56de53938ccbf025a441e54b9842f7c4544.
* Update intro, module-manager and messages-and-queries
* Update messages-and-queries
* Update handler
* Update structure
* Add doc related to RegisterMsgServiceDesc
* Update docs/building-modules/handler.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/building-modules/handler.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/building-modules/handler.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/building-modules/messages-and-queries.md
* Update handler.md
* Rename handler.md to msg-services.md
* Update legacy msgs wording
* Update messages-and-queries.md
* Update docs/building-modules/msg-services.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/intro.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Remove handler mention from intro.md
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/msg-services.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/keeper.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/msg-services.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Address review comments
* Use tag
* Update docs/building-modules/intro.md
Co-authored-by: Cory <cjlevinson@gmail.com>
* Update docs/building-modules/intro.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/core/transactions.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Remove framework related explanation from docs
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/module-manager.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/module-manager.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/core/baseapp.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/core/baseapp.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update beginblock-endblock.md
* Update docs/core/baseapp.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/core/transactions.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Add deprecated notice
* Update tx-lifecycle.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-17 20:41:43 +00:00
Denis Fadeev
b90bacb775
docs: add newline to versions file ( #7938 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-11-17 19:25:32 +00:00
colin axnér
03c8fb313d
add domain separation between port and channel ( #7960 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-17 15:37:20 +00:00
colin axnér
a7435d03eb
fix validate basic check ( #7962 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-17 15:18:16 +00:00
colin axnér
715933b5f3
reduce redundancy ( #7959 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-17 15:01:34 +00:00
atheeshp
ab7104865d
improve error messages for legacy rest endpoints ( #7856 )
...
* improve error messages for legacy rest endpoints
* add test
* review changes
* review changes
* refactor
* Update x/auth/client/rest/query.go
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-11-17 14:46:24 +00:00
Emmanuel T Odeke
9369a00557
x/simulation: make signals channel buffered to avoid missing signals ( #7952 )
...
Invoking:
c := make(chan os.Signal)
signal.Notify(c, signals...)
is explicitly called out as a bug in the os/signal docs
and should instead make that channel buffered lest
a signal could be lost.
Fixes #7950
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-11-17 14:27:12 +00:00
colin axnér
0647d897f5
add is frozen client state check to send packet ( #7957 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-17 12:55:33 +00:00
colin axnér
e93b18e60e
self height uses GTE in self client check ( #7945 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-17 11:40:12 +00:00
Jun Kimura
f962f3a28c
Fix int64 overflow error for height comparison ( #7944 )
...
* fix int64 overflow for height comparison
* apply suggestions from review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-17 10:42:06 +00:00
dependabot[bot]
2f6ebb7792
build(deps): bump codecov/codecov-action from v1.0.14 to v1.0.15 ( #7953 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from v1.0.14 to v1.0.15.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Commits](https://github.com/codecov/codecov-action/compare/v1.0.14...239febf655bba88b16ff5dea1d3135ea8663a1f9 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-17 08:05:24 +01:00
Sunny Aggarwal
10d5ce39ad
Merge pull request #7897 from sikkatech/fix_power_reduction_test_cast_int64
...
Fix power reduction test cast int64
2020-11-16 18:57:59 -04:00
Sunny Aggarwal
479ad6be45
Merge branch 'master' into fix_power_reduction_test_cast_int64
2020-11-16 12:19:39 -04:00
colin axnér
be10bcb163
counterParty -> counterparty ( #7946 )
...
* nit
* fix spec and docs
2020-11-16 15:06:55 +00:00
yihuang
54201d11e6
cli: convert coins to smallest unit registered ( #7777 )
...
* cli: convert coins to smallest unit registered
fixes : #7623
- test order of decimal operations
- support both int and decimal coins, truncate when normalizing to
base unit
* Update types/coin_test.go
* Update types/coin_test.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-16 11:34:54 +00:00
dependabot[bot]
0d0c9696e8
build(deps): bump github.com/prometheus/common from 0.14.0 to 0.15.0 ( #7942 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.14.0 to 0.15.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.14.0...v0.15.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-16 10:36:09 +00:00
Paul Kim
b5e873cd91
version --long displays replaced build dependencies ( #7941 )
...
* version --long displays replaced modules
* Update CHANGELOG
* Update CHANGELOG
* Update version/version.go
* Update CHANGELOG.md
* Update CHANGELOG.md
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
2020-11-16 10:00:34 +00:00
colin axnér
cd29fd642a
Fix connection path validation and remove unused PathValidator function ( #7930 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-16 09:30:57 +00:00