Emmanuel T Odeke a534a960db types: use (*math/big.Int).BitLen() == 0 to check if value is 0 (#8580) ... Instead of using len((*math/big.Int).Bytes()) == 0, which expensively creates a byte slice and marshals a value, on the majority hot path, instead use the cheaper method .BitLen() to check if 0. Benchmarking results, just from types: name old time/op new time/op delta CoinsAdditionIntersect/sizes:_A_1,_B_1-8 132ns ± 2% 126ns ±13% -4.55% (p=0.050 n=10+10) CoinsAdditionIntersect/sizes:_A_5,_B_5-8 1.41µs ± 3% 1.41µs ± 2% ~ (p=1.000 n=10+10) CoinsAdditionIntersect/sizes:_A_5,_B_20-8 2.30µs ± 1% 2.27µs ± 3% ~ (p=0.066 n=10+10) CoinsAdditionIntersect/sizes:_A_1,_B_1000-8 30.9µs ± 3% 30.7µs ± 1% ~ (p=0.218 n=10+10) CoinsAdditionIntersect/sizes:_A_2,_B_1000-8 31.4µs ± 3% 30.8µs ± 2% -1.94% (p=0.015 n=10+10) CoinsAdditionNoIntersect/sizes:_A_1,_B_1-8 116ns ± 1% 114ns ± 4% ~ (p=0.142 n=10+10) CoinsAdditionNoIntersect/sizes:_A_5,_B_5-8 1.11µs ± 1% 1.08µs ± 3% -2.36% (p=0.003 n=8+10) CoinsAdditionNoIntersect/sizes:_A_5,_B_20-8 1.85µs ± 2% 1.82µs ± 1% -1.38% (p=0.001 n=10+9) CoinsAdditionNoIntersect/sizes:_A_1,_B_1000-8 30.7µs ± 1% 30.6µs ± 3% ~ (p=0.393 n=10+10) CoinsAdditionNoIntersect/sizes:_A_2,_B_1000-8 31.1µs ± 1% 30.7µs ± 2% -1.32% (p=0.015 n=10+10) CoinsAdditionNoIntersect/sizes:_A_1000,_B_2-8 31.0µs ± 2% 30.7µs ± 2% ~ (p=0.190 n=10+10) Bech32ifyPubKey-8 28.8µs ± 5% 28.8µs ± 3% ~ (p=0.965 n=10+8) GetPubKeyFromBech32-8 38.8µs ± 3% 39.4µs ± 2% +1.70% (p=0.013 n=9+10) ParseCoin-8 16.7µs ± 6% 15.8µs ± 4% -5.21% (p=0.001 n=10+10) MarshalTo-8 521ns ± 5% 508ns ± 3% -2.56% (p=0.029 n=10+10) UintMarshal-8 3.10µs ±17% 2.56µs ± 3% -17.45% (p=0.000 n=10+9) IntMarshal-8 2.52µs ±10% 1.94µs ± 2% -23.10% (p=0.000 n=10+10) name old alloc/op new alloc/op delta Bech32ifyPubKey-8 4.02kB ± 0% 4.02kB ± 0% ~ (all equal) GetPubKeyFromBech32-8 2.48kB ± 0% 2.48kB ± 0% ~ (all equal) ParseCoin-8 2.21kB ± 0% 2.21kB ± 0% ~ (all equal) MarshalTo-8 80.0B ± 0% 80.0B ± 0% ~ (all equal) UintMarshal-8 440B ± 0% 392B ± 0% -10.91% (p=0.000 n=10+10) IntMarshal-8 216B ± 0% 168B ± 0% -22.22% (p=0.000 n=10+10) name old allocs/op new allocs/op delta Bech32ifyPubKey-8 25.0 ± 0% 25.0 ± 0% ~ (all equal) GetPubKeyFromBech32-8 85.0 ± 0% 85.0 ± 0% ~ (all equal) ParseCoin-8 71.0 ± 0% 71.0 ± 0% ~ (all equal) MarshalTo-8 2.00 ± 0% 2.00 ± 0% ~ (all equal) UintMarshal-8 31.0 ± 0% 25.0 ± 0% -19.35% (p=0.000 n=10+10) IntMarshal-8 24.0 ± 0% 18.0 ± 0% -25.00% (p=0.000 n=10+10) name old speed new speed delta UintMarshal-8 2.27MB/s ±15% 2.75MB/s ± 2% +20.87% (p=0.000 n=10+8) IntMarshal-8 2.78MB/s ± 9% 3.60MB/s ± 2% +29.69% (p=0.000 n=10+10) Fixes #8575 Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>		2021-02-15 10:53:10 +00:00
..
address	Refactor store keys for variable-length addresses (#8363)	2021-02-01 13:17:44 +00:00
bech32	…
errors	implement x/authz module (#7629)	2021-01-25 16:41:30 +00:00
grpc	…
kv	Update gogo proto deps with v1.3.2 security fixes (#8350)	2021-01-15 19:45:34 +00:00
module	Add in-place store migrations (#8485)	2021-02-10 17:49:31 +00:00
msgservice	implement x/authz module (#7629)	2021-01-25 16:41:30 +00:00
query	update pagination tests (#8565)	2021-02-11 09:49:26 +00:00
rest	cli: convert coins to smallest unit registered (#7777)	2020-11-16 11:34:54 +00:00
simulation	implement x/authz module (#7629)	2021-01-25 16:41:30 +00:00
tx	Rosetta API implementation (#7695)	2021-01-21 09:33:02 +00:00
abci.go	…
abci.pb.go	Update gogo proto deps with v1.3.2 security fixes (#8350)	2021-01-15 19:45:34 +00:00
address.go	Refactor store keys for variable-length addresses (#8363)	2021-02-01 13:17:44 +00:00
address_bench_test.go	all: ensure b.ReportAllocs() in all the benchmarks (#8460)	2021-01-27 23:52:08 -08:00
address_test.go	Refactor store keys for variable-length addresses (#8363)	2021-02-01 13:17:44 +00:00
bench_test.go	types: use (*math/big.Int).BitLen() == 0 to check if value is 0 (#8580)	2021-02-15 10:53:10 +00:00
codec.go	…
coin.go	cli: ParseCoin doesn't do normalize (#7954)	2020-11-25 18:02:10 +00:00
coin.pb.go	Update gogo proto deps with v1.3.2 security fixes (#8350)	2021-01-15 19:45:34 +00:00
coin_benchmark_test.go	all: ensure b.ReportAllocs() in all the benchmarks (#8460)	2021-01-27 23:52:08 -08:00
coin_test.go	types/Coin: compile and reuse Regexps to reduce massive RAM+CPU burn (#7989)	2020-11-20 19:37:45 +00:00
config.go	…
config_test.go	…
context.go	…
context_test.go	Add in-place store migrations (#8485)	2021-02-10 17:49:31 +00:00
dec_coin.go	types/Coin: compile and reuse Regexps to reduce massive RAM+CPU burn (#7989)	2020-11-20 19:37:45 +00:00
dec_coin_test.go	cli: convert coins to smallest unit registered (#7777)	2020-11-16 11:34:54 +00:00
decimal.go	types: unconditionally divide by 2 because of integer truncation ⌊x/2⌋ (#8202)	2020-12-20 10:41:59 -08:00
decimal_internal_test.go	…
decimal_test.go	all: ensure b.ReportAllocs() in all the benchmarks (#8460)	2021-01-27 23:52:08 -08:00
denom.go	cli: convert coins to smallest unit registered (#7777)	2020-11-16 11:34:54 +00:00
denom_internal_test.go	cli: convert coins to smallest unit registered (#7777)	2020-11-16 11:34:54 +00:00
events.go	Rename GRPCRouter (#8079)	2020-12-04 15:06:50 +00:00
events_test.go	…
handler.go	…
handler_test.go	…
int.go	types: use (*math/big.Int).BitLen() == 0 to check if value is 0 (#8580)	2021-02-15 10:53:10 +00:00
int_internal_test.go	…
int_test.go	types: use (*math/big.Int).BitLen() == 0 to check if value is 0 (#8580)	2021-02-15 10:53:10 +00:00
invariant.go	…
invariant_test.go	…
proto.go	…
queryable.go	…
result.go	…
result_test.go	…
router.go	…
router_test.go	…
service_msg.go	…
staking.go	…
staking_test.go	…
store.go	…
store_test.go	…
tx_msg.go	Rename GRPCRouter (#8079)	2020-12-04 15:06:50 +00:00
tx_msg_test.go	…
uint.go	types: use (*math/big.Int).BitLen() == 0 to check if value is 0 (#8580)	2021-02-15 10:53:10 +00:00
uint_internal_test.go	…
uint_test.go	types: use (*math/big.Int).BitLen() == 0 to check if value is 0 (#8580)	2021-02-15 10:53:10 +00:00
utils.go	…
utils_test.go	…