379973f315
Problem: tracking RequiredSignaturesChanged is complicated
...
This requires retreiving validators contract, calling
`requiredSignatures()` and carefully tracking
`RequiredSignaturesChanged` events.
Solution: use recently introduced additional parameter in
CollectedSignatures to obtain the number of required signatures.
2018-05-23 01:02:12 -07:00
8a56c5cafb
Problem: required_signatures is static
...
Validators' information is completely configured through validators
contracts and does not depend on `authorities.required_signatures`
parameter of bridge's configuration.
The number of validators also could be changed during run-time and
therefore `authorities.required_signatures` parameter will not reflect
the actual number of signatures required for transaction validation.
Solution: retrieve required_signatures from RequiredSignaturesChanged
event and requiredSignatures() method
Closes #74
2018-05-19 08:38:53 -07:00
2e6bd0b930
added README to reflect that contracts are for integration tests only
...
Contracts in the repo are not used for the bridge any more.
So, in order to reduce number of questions in the future, a note to reflect the status of contracts is added.
2018-05-02 18:36:51 +03:00
1b0315bfa1
Merge pull request #26 from yrashk/integration-tests-work
...
Problem: integration tests won't compile or pass
2018-03-09 10:04:30 +01:00
d9bc432ab8
Problem: integration tests won't compile or pass
...
Solution: map it to the API used in bridge.sol
2018-03-05 15:23:36 +07:00
dcdb5cf75f
proposed changes for https://github.com/poanetwork/parity-bridge/issues/20 and https://github.com/poanetwork/parity-bridge/issues/18
2018-02-28 01:20:09 +03:00
ee633d18a2
rolled back a workaround from HomeBridge contract after removing little-endian encoding for integers in withdraw_confirm's message
2018-02-25 00:24:00 +03:00
2f2af35440
fixed missed semicolon
2018-02-24 07:34:45 +03:00
5e1b7f43f7
example of ERC20 token to work with current version of ForeignBridge contract
2018-02-23 04:26:48 +03:00
0714eb70c8
quick and dirty fix to allow performing withdraw. A separate issue will be created
2018-02-23 04:25:45 +03:00
ca64cf3b6a
merge from master branch
2018-02-16 02:13:46 +03:00
586afe8773
bridge.sol: uint -> uint256: more explicit, clear.
...
seen in many other solidity projects with high code quality
2018-02-15 14:27:07 +01:00
033a923432
make ForeignBridge.submitSignature a bit easier to understand
2018-02-15 14:22:20 +01:00
d7feac802f
verifySignatures -> hasEnoughValidSignatures and make it return bool
2018-02-13 17:18:24 +01:00
85a2e10fcb
remove redundance require. signatures of wrong length don't pass the address recovery above
2018-02-13 15:47:17 +01:00
4e56c9ec65
require value to be greater estimated wei cost for relay
2018-02-13 15:46:51 +01:00
76c85e6f84
bridge.sol: add HelpersTest.verifySignatures
2018-02-13 14:25:11 +01:00
a1dc3bcb05
bridge.sol: improve docstring for verifySignatures
2018-02-13 14:25:00 +01:00
467c5dc2f2
remove contract code that dealt with removed ignoring of insufficient value withdraws
2018-02-09 09:44:55 +01:00
41543ca40e
user explicitely specifies homeGasPrice on withdraw. resolves #112
2018-02-09 09:41:45 +01:00
36c0859d78
bridge.sol: move withdraw sig verify from modifier into function
...
more explicit, easier to test in isolation
2018-02-09 09:39:08 +01:00
f7587409f9
bridge.sol: improve param names
2018-02-09 09:39:08 +01:00
c7ef6bfd65
bridge.sol: improve docstring of withdraw
2018-02-09 09:39:08 +01:00
ddc54802dd
bridge.sol: check for overflow in transferFrom
2018-01-26 12:05:37 +01:00
e0d4c52fd6
bridge.sol: improve docstrings and comments
2018-01-26 10:00:44 +01:00
60130d0d6f
bridge.sol: improve comment
2018-01-26 10:00:44 +01:00
5ef7c895ec
bridge.sol: add period to comment
2018-01-26 10:00:44 +01:00
165e822c31
bridge.sol: improve name
2018-01-26 10:00:44 +01:00
0e13ed406b
bridge.sol: emit Tranfer to 0x0 if tokens are destroyed
2018-01-26 10:00:44 +01:00
2f75f3683f
bridge.sol: emit Transfer from 0x0 on token creation as laid out in ERC20
2018-01-26 10:00:44 +01:00
08d481206d
bridge.sol: improve comment
2018-01-26 10:00:44 +01:00
b8bf9bee54
remove unnecessary check for overflow in transferHomeViaRelay
...
resolve #88
2018-01-26 10:00:44 +01:00
1c66c591a9
bridge.sol: fix docstring
2018-01-26 10:00:44 +01:00
e084966f25
bridge.sol: comments
2018-01-26 10:00:44 +01:00
334a7535b8
bridge.sol: make name a public var instead of a function
2018-01-26 10:00:44 +01:00
a73c64a446
bridge.sol: more sensible grouping and add comments
2018-01-26 10:00:44 +01:00
d8e81a8593
bridge.sol: first rough full implementation of ERC20 for ForeignBridge
2018-01-26 10:00:44 +01:00
856f340327
bridge.sol: fix typo
2018-01-26 10:00:44 +01:00
292891ed96
bridge.sol: improve docstring
2018-01-26 10:00:44 +01:00
73dd502b88
bridge.sol: authority -> authorityResponsibleForRelay
2018-01-26 10:00:44 +01:00
10cfea8172
bridge.sol: improve docstring
2018-01-26 10:00:44 +01:00
9b9d109f57
bridge.sol: fix typo
2018-01-26 10:00:44 +01:00
e6db3476ca
bridge.sol: fix typo
2018-01-26 10:00:44 +01:00
ea18c198b4
make ForeignBridge.Transfer event conform to ERC20
2018-01-26 10:00:44 +01:00
ffc0b31eb3
ForeignBridge.transferLocal -> transfer to conform to ERC20
2018-01-26 10:00:44 +01:00
cdcb33641f
bridge.sol: add function ForeignBridge.name
2018-01-26 10:00:44 +01:00
64b0a5ae27
bridge.sol: constant -> view
2018-01-26 10:00:44 +01:00
ee37db7c93
bridge.sol: add function ForeignBridge.balanceOf
2018-01-26 10:00:44 +01:00
25b92a17e0
bridge.sol: fix typo
2018-01-26 10:00:44 +01:00
2ec0b2d23c
bridge.sol: add function ForeignBridge.totalSupply
2018-01-26 10:00:44 +01:00
Yurii Rashkovskii
Alexander Kolotov
Maximilian Krüger