Commit Graph

594 Commits

Author SHA1 Message Date
Maximilian Krüger 80d67642ad add test "withdraw should fail if duplicate signature is provided" 2018-01-15 11:30:45 +01:00
Maximilian Krüger 6a052c12e3 add test "withdraw should fail if not enough signatures are provided" 2018-01-15 11:21:46 +01:00
Maximilian Krüger 1634dc735f add docstring to Helpers.uintToString 2018-01-15 11:00:30 +01:00
Maximilian Krüger 8211007da2 Helpers.intToString -> Helpers.uintToString 2018-01-15 11:00:04 +01:00
Maximilian Krüger 43feb6065b test/helpers: add test of intToString with really large uint 2018-01-15 10:57:05 +01:00
Maximilian Krüger 01cfab8f5d bridge.sol: Helpers.intToString: uint256 -> uint 2018-01-15 10:50:23 +01:00
Maximilian Krüger d432e73905 replace Helpers.intToString implementation by one that uses less gas and doesn't break for numbers with more than 8 digits 2018-01-15 10:47:50 +01:00
Maximilian Krüger f400ccaa80 bridge.sol: add HelpersTest library to be able to test internal Helpers functions 2018-01-15 10:30:52 +01:00
Maximilian Krüger c89323b512 bridge.sol: proper return in Helpers.intToString 2018-01-15 10:30:21 +01:00
Maximilian Krüger e87e189b9f add tests for the Helpers library 2018-01-15 10:19:10 +01:00
Maximilian Krüger 263d846782 add test helper `range` 2018-01-15 10:18:52 +01:00
Maximilian Krüger 053e7876bd test/foreign: improve test description 2018-01-15 09:29:58 +01:00
Maximilian Krüger 4fec6a4126 test/foreign: add test: should ignore deposits that are not from authorities 2018-01-13 16:04:36 +01:00
Maximilian Krüger 3f1d4950bf test/home: fix test: should not allow withdraw with message.length != 84 2018-01-13 15:53:59 +01:00
Maximilian Krüger 5b742f492d test/message_signing: add test: should fail to recover address from signature that is too short 2018-01-13 15:07:12 +01:00
Maximilian Krüger 30f4669b00 test/message_signing: improve test names 2018-01-13 15:06:57 +01:00
Maximilian Krüger 3dcab58a39 bridge.sol: add some docstrings 2018-01-13 14:41:27 +01:00
Maximilian Krüger 9be5c02d9e make solium happy 2018-01-13 14:41:12 +01:00
Maximilian Krüger 06e363dfca bridge.sol: extract message related fns into `Message` library 2018-01-12 17:28:02 +01:00
Maximilian Krüger d96ebc026e truffle tests: move `createMessage` to helpers 2018-01-12 17:26:14 +01:00
Maximilian Krüger 78d1387d95 bridge.sol: move MessageSigningTest close to MessageSigning 2018-01-12 16:53:29 +01:00
Maximilian Krüger 067759faa2 bridge.sol: SignerTest -> MessageSigningTest 2018-01-12 16:51:51 +01:00
Maximilian Krüger d9c6675df5 bridge.sol: hash -> hashMessage 2018-01-12 16:48:39 +01:00
Maximilian Krüger 7011150651 bridge.sol: signer -> recoverAddressFromSignedMessage 2018-01-12 16:46:00 +01:00
Maximilian Krüger 49351f764d bridge.sol: rename Signer to MessageSigning 2018-01-12 16:42:09 +01:00
Maximilian Krüger 6dc1021aba bridge.sol: Helpers.toString -> Helpers.intToString 2018-01-12 16:36:47 +01:00
Maximilian Krüger 03b74fc270 bridge.sol: rename Utils to Helpers 2018-01-12 16:34:34 +01:00
Maximilian Krüger 277bafac60 bridge.sol: get rid of `using Authorities for address[];` and `library Authorities` 2018-01-12 16:17:34 +01:00
Marek Kotewicz bd5d0aeeef
Merge pull request #81 from paritytech/snd-issue-55
issue 55 - split ForeignBridge.transfer into two functions and increase branch coverage
2018-01-11 16:50:50 +01:00
Maximilian Krüger 868ee4a10b test/foreign: increase coverage: add test "should not be possible to do same deposit twice for same authority" 2018-01-11 15:15:33 +01:00
Maximilian Krüger f1c74da470 test/foreign: fix test "should not be possible to submit signature twice" increasing coverage 2018-01-11 15:06:03 +01:00
Maximilian Krüger aed0a09ad8 test/foreign: should fail to transfer with value overflow both locally and to home 2018-01-11 15:00:30 +01:00
Maximilian Krüger 15c6e925d6 test/foreign: various improvements and more coverage for transferHomeViaRelay 2018-01-11 14:52:19 +01:00
Maximilian Krüger 23ea4be253 test/foreign: improve some variable names and test names 2018-01-11 14:51:17 +01:00
Maximilian Krüger 81a5d3f18d test/foreign: underscore -> camelcase 2018-01-11 14:50:43 +01:00
Maximilian Krüger 44b5d32f99 bridge.sol: style consistency: remove space between func name and param list 2018-01-11 14:21:16 +01:00
Maximilian Krüger c62cfd3692 adapt tests to split of ForeignBridge.transfer 2018-01-11 14:16:25 +01:00
Maximilian Krüger 597019b8e1 split ForeignBridge.transfer into transferHomeViaRelay and transferLocal
resolve #55
2018-01-11 14:15:51 +01:00
Marek Kotewicz 5f1cdc17c2
Merge pull request #77 from paritytech/snd-issue-54-attack-vector
Issue 54 - close attack vector
2018-01-11 11:39:57 +01:00
Maximilian Krüger 5dd0144537 README.md: improve documentation for issue-54 [ci skip] 2018-01-10 12:01:19 +01:00
Maximilian Krüger 27e95e8d8d README.md: initial documentation of issue-54 [ci skip] 2018-01-10 11:52:36 +01:00
Maximilian Krüger 56b5e6d22d test: isMessageValueSufficientToCoverRelay should work correctly 2018-01-09 14:35:31 +01:00
Maximilian Krüger 22e70cc079 test: remove unused var 2018-01-09 14:35:17 +01:00
Maximilian Krüger 47fe40daaa README.md: document estimated_gas_cost_of_withdraw 2018-01-09 13:11:23 +01:00
Maximilian Krüger 0798bf181d withdraw_relay.rs: add some docstrings 2018-01-09 13:11:02 +01:00
Maximilian Krüger 067bafa545 examples/config.toml: add estimated_gas_cost_of_withdraw 2018-01-09 13:10:02 +01:00
Maximilian Krüger 55d2e1bf55 add config option `estimated_gas_cost_of_withdraw` 2018-01-09 12:53:50 +01:00
Maximilian Krüger f7f78e7cfc improve test description 2018-01-09 12:52:49 +01:00
Maximilian Krüger 68d02ac5fd refactor test code a bit 2018-01-09 11:42:08 +01:00
Maximilian Krüger ba8aedecb1 add test for message part getters (getRecipientFromMessage) 2018-01-09 11:36:00 +01:00