Commit Graph

337 Commits

Author SHA1 Message Date
Maximilian Krüger ada27d9819 bridge.sol: introduce storage var estimatedGasCostOfWithdraw 2018-01-04 15:14:34 +01:00
Maximilian Krüger 0df75a5ae2 bridge.sol: add to comment 2018-01-04 14:14:29 +01:00
Maximilian Krüger 21390fa2f2 bridge.sol: consistency: make ForeignBridge constructor more readable 2018-01-04 14:12:03 +01:00
Maximilian Krüger ba04292c02 bridge.sol: make HomeBridge constructor more readable 2018-01-04 13:59:02 +01:00
Maximilian Krüger e38967fd94 readme: update test instructions 2018-01-04 13:56:09 +01:00
snd 7e6d443fba
Merge pull request #71 from paritytech/issue-59-solium
[pleasereview] introduce solium and solve all linter/compiler errors/warnings (#59)
2017-12-18 16:15:34 +01:00
Maximilian Krüger 6cec01f8f0 bridge.sol: mark pure functions as pure to get to 0 solc compiliation warnings 2017-12-15 11:25:53 +01:00
Maximilian Krüger 31a17f2644 add .soliumignore: without it solium complains 2017-12-15 11:01:44 +01:00
Maximilian Krüger d090b1d403 add .soliumrc.json. without it solium exits 2017-12-15 11:01:15 +01:00
Maximilian Krüger b270bb240b run solium on CI 2017-12-14 18:34:34 +01:00
Maximilian Krüger 71571b895d update yarn.lock 2017-12-14 18:33:31 +01:00
Maximilian Krüger f1e3dc05ea package.json: add solium 2017-12-14 18:33:16 +01:00
Maximilian Krüger baaf98a512 bridge.sol: solium: allow the two cases where we need assembly 2017-12-14 18:28:22 +01:00
Maximilian Krüger ca68df43c2 bridge.sol: solium: fix remaining "No visibility specified explicitly" 2017-12-14 18:28:22 +01:00
Maximilian Krüger 23a919f2ef bridge.sol: solium: fix errors ala: Avoid using 'sha3(...)'. Use --fix to replace it with 'keccak256(...)' 2017-12-14 18:28:22 +01:00
Maximilian Krüger c917c95b40 bridge.sol: solium: fix errors ala "No visibility specified explicitly" 2017-12-14 18:28:22 +01:00
Maximilian Krüger 4da533e3ee bridge.sol: fix solium linter whitespace errors 2017-12-14 18:27:16 +01:00
Maximilian Krüger d27347380b Migrations.sol: fix solium linter errors 2017-12-14 18:27:16 +01:00
snd 58a80b4ace fix for #61 and tests for withdraw (#66)
* readme: add section on running truffle tests

* extract `sign` from test/foreign into test/helpers and improve it

* add test helper signatureToVRS

* add test helper bigNumberToHexString

* add test helper bigNumberToPaddedBytes32

* add test "should allow correct withdraw" which fails and exposes #61

* resolve #61 and document it

* fix typo

* fix typo

* use num.toString(16) instead of bigNumberToHexString

https://github.com/paritytech/parity-bridge/pull/66#discussion_r156030874

* add comment

* use explicit transaction hash

* add test "withdraw without funds on HomeBridge should fail"

* add test "should not allow withdraw with message.length != 84"

* add test ""should allow second withdraw with different transactionHash but same recipient and value"

* add test "should not allow second withdraw with same transactionHash but different recipient and value"

* fix typo

* bridge.sol: add note that anyone can call HomeBridge.withdraw

* test that anyone can call withdraw provided they have the message and signatures

* test/home.js: improve wording of test
2017-12-14 17:54:49 +01:00
snd 63b0745ea0 Issue 58 solidity test code coverage (#70)
* add initial package.json with test, ci and coverage scripts

inspired by 86794a866b/package.json

* .travis.yml: use ci script from package.json

* upload coverage to coveralls

* README.md: add coveralls badge

* .travis.yml: run npm install

* package.json: make ganache ports match up so truffle can connect

* .travis.yml: call coveralls script directly

* README.md: try to put badges on one line [ci skip]

* README.md: try to fix badge formatting [ci skip]

* package.json: remove directories prop which is not needed

* add notice that code coverage is for contracts only

* .gitignore: node_modules

* package.json: improve description

* package.json: add license

* package.json: replace npm with yarn

* .travis.yml: use yarn instead of npm

* add yarn.lock

* .travis.yml: cache cargo to speed things up
2017-12-14 17:52:36 +01:00
Robert Habermeier e3d7737323
Merge pull request #65 from zacwellmer/patch-1
mention home when should be foreign
2017-12-13 11:27:39 +01:00
Robert Habermeier fbfd7a9e6a
Merge pull request #67 from paritytech/issue-29-ci-truffle
#29 run truffle tests on travis
2017-12-12 18:18:30 +01:00
Maximilian Krüger 8095fda3e3 enable rust tests again 2017-12-12 17:02:13 +01:00
Maximilian Krüger ac9745d36d remove need for package.json for now 2017-12-12 16:59:39 +01:00
Maximilian Krüger 2e5da3e9cd change quoting of concurrent commands. see if that works 2017-12-12 16:57:29 +01:00
Maximilian Krüger 85a2c63e16 first attempt at running truffle tests on travis 2017-12-12 16:53:15 +01:00
Zac Wellmer 8e89bff3ff
debug -> release 2017-12-09 20:51:59 +08:00
Zac Wellmer 79ca831f1a
mention home when should be foreign 2017-12-09 16:11:40 +08:00
Marek Kotewicz 7406015300
Merge pull request #53 from paritytech/remove_truncate
remove unused truncate, closes #51
2017-11-16 17:06:15 +01:00
debris 0149ef8cef remove unused truncate, closes #51 2017-11-16 16:51:29 +01:00
Marek Kotewicz 8cc7156722 Merge pull request #50 from paritytech/foreign_overflow
check ForeignBridge transfer() overflow
2017-10-24 12:33:25 +07:00
debris e4f9f24792 check ForeignBridge transfer() overflow 2017-10-24 13:23:17 +08:00
Marek Kotewicz d721b1ff2b Merge pull request #47 from paritytech/rename
rename to home/foreign, closes #46
2017-10-10 11:10:46 +02:00
debris 59403966fc rename to home/foreign, closes #46 2017-10-10 11:02:58 +02:00
Marek Kotewicz f859c62175 Merge pull request #44 from paritytech/fixes
fixed loading .bin files, filter topics and example gas amounts
2017-10-02 18:00:22 +02:00
viktor 3fad3f4789 README typo 2017-10-02 17:52:53 +02:00
debris d34f0e5427 Merge branch 'master' into fixes 2017-10-02 17:52:49 +02:00
debris 134bf5a620 fixed loading .bin files, filter topics and example gas amounts 2017-10-01 19:18:50 +02:00
Marek Kotewicz 6b649b149d Merge pull request #38 from vbaranov/master
Function names typos
2017-09-29 18:21:04 +02:00
Marek Kotewicz 882292ac90 Update README.md 2017-09-29 01:32:31 +02:00
Marek Kotewicz 6e9e17ea7e Basic docs 2017-09-29 01:26:15 +02:00
viktor ef62bcc427 Function names typos 2017-09-28 15:59:19 -07:00
debris 40e76eecaa udpated links to travis in README.md 2017-09-29 00:51:53 +02:00
Marek Kotewicz a89a50b9c4 Merge pull request #37 from paritytech/license
LICENSE
2017-09-28 10:52:10 +02:00
debris b662888ff6 LICENSE 2017-09-28 10:51:23 +02:00
Marek Kotewicz ef5336404a Merge pull request #32 from paritytech/truffle
more solidity tests
2017-09-04 16:11:22 +02:00
debris 9a893c9842 test for submitting signature twice 2017-09-04 16:05:47 +02:00
debris 57c8427539 submitSignature tests 2017-09-04 16:02:41 +02:00
debris c475cb9009 tests for solidity contract transfer 2017-09-04 14:42:10 +02:00
debris 769c98e013 fixed sol files indentation 2017-09-04 12:50:43 +02:00