Commit Graph

33 Commits

Author SHA1 Message Date
Maximilian Krüger cce5b09fac bridge.sol: fix setting of estimatedGasCostOfWithdraw in constructor 2018-01-04 15:30:10 +01:00
Maximilian Krüger cd5a3e5889 bridge.sol: fix solium errors 2018-01-04 15:29:54 +01:00
Maximilian Krüger 6a859f004f bridge.sol: improve linebreak of comment 2018-01-04 15:15:02 +01:00
Maximilian Krüger ada27d9819 bridge.sol: introduce storage var estimatedGasCostOfWithdraw 2018-01-04 15:14:34 +01:00
Maximilian Krüger 0df75a5ae2 bridge.sol: add to comment 2018-01-04 14:14:29 +01:00
Maximilian Krüger 21390fa2f2 bridge.sol: consistency: make ForeignBridge constructor more readable 2018-01-04 14:12:03 +01:00
Maximilian Krüger ba04292c02 bridge.sol: make HomeBridge constructor more readable 2018-01-04 13:59:02 +01:00
Maximilian Krüger 6cec01f8f0 bridge.sol: mark pure functions as pure to get to 0 solc compiliation warnings 2017-12-15 11:25:53 +01:00
Maximilian Krüger baaf98a512 bridge.sol: solium: allow the two cases where we need assembly 2017-12-14 18:28:22 +01:00
Maximilian Krüger ca68df43c2 bridge.sol: solium: fix remaining "No visibility specified explicitly" 2017-12-14 18:28:22 +01:00
Maximilian Krüger 23a919f2ef bridge.sol: solium: fix errors ala: Avoid using 'sha3(...)'. Use --fix to replace it with 'keccak256(...)' 2017-12-14 18:28:22 +01:00
Maximilian Krüger c917c95b40 bridge.sol: solium: fix errors ala "No visibility specified explicitly" 2017-12-14 18:28:22 +01:00
Maximilian Krüger 4da533e3ee bridge.sol: fix solium linter whitespace errors 2017-12-14 18:27:16 +01:00
snd 58a80b4ace fix for #61 and tests for withdraw (#66)
* readme: add section on running truffle tests

* extract `sign` from test/foreign into test/helpers and improve it

* add test helper signatureToVRS

* add test helper bigNumberToHexString

* add test helper bigNumberToPaddedBytes32

* add test "should allow correct withdraw" which fails and exposes #61

* resolve #61 and document it

* fix typo

* fix typo

* use num.toString(16) instead of bigNumberToHexString

https://github.com/paritytech/parity-bridge/pull/66#discussion_r156030874

* add comment

* use explicit transaction hash

* add test "withdraw without funds on HomeBridge should fail"

* add test "should not allow withdraw with message.length != 84"

* add test ""should allow second withdraw with different transactionHash but same recipient and value"

* add test "should not allow second withdraw with same transactionHash but different recipient and value"

* fix typo

* bridge.sol: add note that anyone can call HomeBridge.withdraw

* test that anyone can call withdraw provided they have the message and signatures

* test/home.js: improve wording of test
2017-12-14 17:54:49 +01:00
debris 0149ef8cef remove unused truncate, closes #51 2017-11-16 16:51:29 +01:00
debris e4f9f24792 check ForeignBridge transfer() overflow 2017-10-24 13:23:17 +08:00
debris 59403966fc rename to home/foreign, closes #46 2017-10-10 11:02:58 +02:00
debris 57c8427539 submitSignature tests 2017-09-04 16:02:41 +02:00
debris 769c98e013 fixed sol files indentation 2017-09-04 12:50:43 +02:00
debris 9046cf8d62 fixed signature validation in solidity, added truffle tests for it 2017-09-04 12:49:05 +02:00
debris f0d9e56699 fix KovanBridge vulnerability when one of the authorities is misbehaving 2017-09-01 16:26:06 +02:00
debris e69c9ce08d tests for solidity contract consturctor params 2017-09-01 15:44:36 +02:00
debris 9eadffcfdd first truffle tests for EthereumBridge 2017-09-01 15:11:20 +02:00
debris 52ed724bfa withdraw_relay tests, more readable error messages for test macros, closes #9 2017-08-29 16:22:18 +02:00
debris 316b9ce4a0 withdraw_relay guarantees and tests 2017-08-28 12:28:21 +02:00
debris a9709f942a fixed verification of signatures signed with eth_sign, closes #17 2017-08-25 18:29:29 +02:00
debris ddd68c1f4f typos 2017-08-25 16:27:55 +02:00
debris b2c9699b98 fetching collected signatures 2017-08-23 19:09:51 +02:00
debris 5598c5d73b KovanBridge message getter 2017-08-22 13:53:40 +02:00
debris e0cbcaff13 KovanBridge submited signatures getter 2017-08-22 13:47:01 +02:00
debris 95ea7fb303 replace throw with require in bridge.sol 2017-08-22 13:01:16 +02:00
debris 38befc6fc7 use use_contract! macro instead of handwriting contracts api, closes #1, closes #12, closes #13 2017-08-21 17:32:37 +02:00
debris a08c0c597b contracts 2017-06-13 11:18:03 +02:00