1634dc735f
add docstring to Helpers.uintToString
2018-01-15 11:00:30 +01:00
8211007da2
Helpers.intToString -> Helpers.uintToString
2018-01-15 11:00:04 +01:00
01cfab8f5d
bridge.sol: Helpers.intToString: uint256 -> uint
2018-01-15 10:50:23 +01:00
d432e73905
replace Helpers.intToString implementation by one that uses less gas and doesn't break for numbers with more than 8 digits
2018-01-15 10:47:50 +01:00
f400ccaa80
bridge.sol: add HelpersTest library to be able to test internal Helpers functions
2018-01-15 10:30:52 +01:00
c89323b512
bridge.sol: proper return in Helpers.intToString
2018-01-15 10:30:21 +01:00
3dcab58a39
bridge.sol: add some docstrings
2018-01-13 14:41:27 +01:00
9be5c02d9e
make solium happy
2018-01-13 14:41:12 +01:00
06e363dfca
bridge.sol: extract message related fns into `Message` library
2018-01-12 17:28:02 +01:00
78d1387d95
bridge.sol: move MessageSigningTest close to MessageSigning
2018-01-12 16:53:29 +01:00
067759faa2
bridge.sol: SignerTest -> MessageSigningTest
2018-01-12 16:51:51 +01:00
d9c6675df5
bridge.sol: hash -> hashMessage
2018-01-12 16:48:39 +01:00
7011150651
bridge.sol: signer -> recoverAddressFromSignedMessage
2018-01-12 16:46:00 +01:00
49351f764d
bridge.sol: rename Signer to MessageSigning
2018-01-12 16:42:09 +01:00
6dc1021aba
bridge.sol: Helpers.toString -> Helpers.intToString
2018-01-12 16:36:47 +01:00
03b74fc270
bridge.sol: rename Utils to Helpers
2018-01-12 16:34:34 +01:00
277bafac60
bridge.sol: get rid of `using Authorities for address[];` and `library Authorities`
2018-01-12 16:17:34 +01:00
44b5d32f99
bridge.sol: style consistency: remove space between func name and param list
2018-01-11 14:21:16 +01:00
597019b8e1
split ForeignBridge.transfer into transferHomeViaRelay and transferLocal
...
resolve #55
2018-01-11 14:15:51 +01:00
7c9e0bb268
bridge.sol: constant -> view
2018-01-08 11:42:48 +01:00
cff04ba033
bridge.sol: messageValueSufficientToCoverRelay -> isMessageValueSufficientToCoverRelay
2018-01-08 11:42:33 +01:00
1ca0439057
bridge.sol: reuse functions to reduce logic duplication
2018-01-05 16:31:46 +01:00
ea9f25003a
bridge.sol: add HomeBridge.messageValueSufficientToCoverRelay()
2018-01-05 16:31:23 +01:00
c7fcfe76f0
bridge.sol: add HomeBridge.getWithdrawRelayCost()
2018-01-05 16:31:07 +01:00
5b8f6d7bfd
bridge.sol: extract functions that read values from message so they can be tested/reused
...
and withdraw stays more focused
2018-01-05 16:05:13 +01:00
44d559c043
fix new solium rule security/no-assign-params
2018-01-05 14:07:20 +01:00
178b2de87b
bridge.sol: charge recipient for withdraw relay cost and ignore too low values
2018-01-04 15:42:36 +01:00
f86400a810
bridge.sol: pragma solidity ^0.4.17;
2018-01-04 15:42:21 +01:00
cce5b09fac
bridge.sol: fix setting of estimatedGasCostOfWithdraw in constructor
2018-01-04 15:30:10 +01:00
cd5a3e5889
bridge.sol: fix solium errors
2018-01-04 15:29:54 +01:00
6a859f004f
bridge.sol: improve linebreak of comment
2018-01-04 15:15:02 +01:00
ada27d9819
bridge.sol: introduce storage var estimatedGasCostOfWithdraw
2018-01-04 15:14:34 +01:00
0df75a5ae2
bridge.sol: add to comment
2018-01-04 14:14:29 +01:00
21390fa2f2
bridge.sol: consistency: make ForeignBridge constructor more readable
2018-01-04 14:12:03 +01:00
ba04292c02
bridge.sol: make HomeBridge constructor more readable
2018-01-04 13:59:02 +01:00
6cec01f8f0
bridge.sol: mark pure functions as pure to get to 0 solc compiliation warnings
2017-12-15 11:25:53 +01:00
baaf98a512
bridge.sol: solium: allow the two cases where we need assembly
2017-12-14 18:28:22 +01:00
ca68df43c2
bridge.sol: solium: fix remaining "No visibility specified explicitly"
2017-12-14 18:28:22 +01:00
23a919f2ef
bridge.sol: solium: fix errors ala: Avoid using 'sha3(...)'. Use --fix to replace it with 'keccak256(...)'
2017-12-14 18:28:22 +01:00
c917c95b40
bridge.sol: solium: fix errors ala "No visibility specified explicitly"
2017-12-14 18:28:22 +01:00
4da533e3ee
bridge.sol: fix solium linter whitespace errors
2017-12-14 18:27:16 +01:00
58a80b4ace
fix for #61 and tests for withdraw ( #66 )
...
* readme: add section on running truffle tests
* extract `sign` from test/foreign into test/helpers and improve it
* add test helper signatureToVRS
* add test helper bigNumberToHexString
* add test helper bigNumberToPaddedBytes32
* add test "should allow correct withdraw" which fails and exposes #61
* resolve #61 and document it
* fix typo
* fix typo
* use num.toString(16) instead of bigNumberToHexString
https://github.com/paritytech/parity-bridge/pull/66#discussion_r156030874
* add comment
* use explicit transaction hash
* add test "withdraw without funds on HomeBridge should fail"
* add test "should not allow withdraw with message.length != 84"
* add test ""should allow second withdraw with different transactionHash but same recipient and value"
* add test "should not allow second withdraw with same transactionHash but different recipient and value"
* fix typo
* bridge.sol: add note that anyone can call HomeBridge.withdraw
* test that anyone can call withdraw provided they have the message and signatures
* test/home.js: improve wording of test
2017-12-14 17:54:49 +01:00
0149ef8cef
remove unused truncate, closes #51
2017-11-16 16:51:29 +01:00
e4f9f24792
check ForeignBridge transfer() overflow
2017-10-24 13:23:17 +08:00
59403966fc
rename to home/foreign, closes #46
2017-10-10 11:02:58 +02:00
57c8427539
submitSignature tests
2017-09-04 16:02:41 +02:00
769c98e013
fixed sol files indentation
2017-09-04 12:50:43 +02:00
9046cf8d62
fixed signature validation in solidity, added truffle tests for it
2017-09-04 12:49:05 +02:00
f0d9e56699
fix KovanBridge vulnerability when one of the authorities is misbehaving
2017-09-01 16:26:06 +02:00
e69c9ce08d
tests for solidity contract consturctor params
2017-09-01 15:44:36 +02:00
Maximilian Krüger
debris