Commit Graph

258 Commits

Author SHA1 Message Date
Maximilian Krüger 4ebe2a8e54 fix travis: remove assertion which fails during coverage testing
since coverage testing inserts instructions which increase the gas cost
2018-01-05 14:27:47 +01:00
Maximilian Krüger 44d559c043 fix new solium rule security/no-assign-params 2018-01-05 14:07:20 +01:00
Maximilian Krüger 0b12c2cc98 truffle: bump everything to newest version 2018-01-05 14:04:20 +01:00
Maximilian Krüger 49981435fb travis fix: fetch gas price dynamically 2018-01-05 13:51:25 +01:00
Maximilian Krüger b2bf3b6dfe use long argument when setting port on ganache-cli 2018-01-05 13:39:07 +01:00
Maximilian Krüger a900fcffd4 fix travis: explicitely setting gas price to lower value 2018-01-05 13:19:49 +01:00
Maximilian Krüger 6a64f4c6dc trying more things to debug why tests only fail on travis 2018-01-05 13:11:50 +01:00
Maximilian Krüger 609c8065a4 debugging test which only fails on travis 2018-01-04 19:05:40 +01:00
Maximilian Krüger 434b845319 force truffle gasPrice to make it consistent since it seems different on travis 2018-01-04 19:00:36 +01:00
Maximilian Krüger a28fa13f87 add test that recipient pays for relay 2018-01-04 18:49:54 +01:00
Maximilian Krüger 4834e25e97 tests: helpers: add getBalances helper 2018-01-04 18:49:32 +01:00
Maximilian Krüger 03aacc8f16 truffle tests: use camelcase consistently for variable names 2018-01-04 18:17:14 +01:00
Maximilian Krüger a7910aa5cd change ganache port to 8547 so it doesn't clash with vanilla parity rpc port 2018-01-04 17:38:47 +01:00
Maximilian Krüger ee49dc5c3b tools/estimate_gas_costs.sh: improve wording 2018-01-04 16:27:49 +01:00
Maximilian Krüger 109c8e35b3 add tools/estimate_gas_costs.sh 2018-01-04 16:26:05 +01:00
Maximilian Krüger 178b2de87b bridge.sol: charge recipient for withdraw relay cost and ignore too low values 2018-01-04 15:42:36 +01:00
Maximilian Krüger f86400a810 bridge.sol: pragma solidity ^0.4.17; 2018-01-04 15:42:21 +01:00
Maximilian Krüger cce5b09fac bridge.sol: fix setting of estimatedGasCostOfWithdraw in constructor 2018-01-04 15:30:10 +01:00
Maximilian Krüger cd5a3e5889 bridge.sol: fix solium errors 2018-01-04 15:29:54 +01:00
Maximilian Krüger 66bc676891 make tests pass again after introducing `estimatedGasCostOfWithdraw` 2018-01-04 15:15:32 +01:00
Maximilian Krüger 6a859f004f bridge.sol: improve linebreak of comment 2018-01-04 15:15:02 +01:00
Maximilian Krüger ada27d9819 bridge.sol: introduce storage var estimatedGasCostOfWithdraw 2018-01-04 15:14:34 +01:00
Maximilian Krüger 0df75a5ae2 bridge.sol: add to comment 2018-01-04 14:14:29 +01:00
Maximilian Krüger 21390fa2f2 bridge.sol: consistency: make ForeignBridge constructor more readable 2018-01-04 14:12:03 +01:00
Maximilian Krüger ba04292c02 bridge.sol: make HomeBridge constructor more readable 2018-01-04 13:59:02 +01:00
Maximilian Krüger e38967fd94 readme: update test instructions 2018-01-04 13:56:09 +01:00
snd 7e6d443fba
Merge pull request #71 from paritytech/issue-59-solium
[pleasereview] introduce solium and solve all linter/compiler errors/warnings (#59)
2017-12-18 16:15:34 +01:00
Maximilian Krüger 6cec01f8f0 bridge.sol: mark pure functions as pure to get to 0 solc compiliation warnings 2017-12-15 11:25:53 +01:00
Maximilian Krüger 31a17f2644 add .soliumignore: without it solium complains 2017-12-15 11:01:44 +01:00
Maximilian Krüger d090b1d403 add .soliumrc.json. without it solium exits 2017-12-15 11:01:15 +01:00
Maximilian Krüger b270bb240b run solium on CI 2017-12-14 18:34:34 +01:00
Maximilian Krüger 71571b895d update yarn.lock 2017-12-14 18:33:31 +01:00
Maximilian Krüger f1e3dc05ea package.json: add solium 2017-12-14 18:33:16 +01:00
Maximilian Krüger baaf98a512 bridge.sol: solium: allow the two cases where we need assembly 2017-12-14 18:28:22 +01:00
Maximilian Krüger ca68df43c2 bridge.sol: solium: fix remaining "No visibility specified explicitly" 2017-12-14 18:28:22 +01:00
Maximilian Krüger 23a919f2ef bridge.sol: solium: fix errors ala: Avoid using 'sha3(...)'. Use --fix to replace it with 'keccak256(...)' 2017-12-14 18:28:22 +01:00
Maximilian Krüger c917c95b40 bridge.sol: solium: fix errors ala "No visibility specified explicitly" 2017-12-14 18:28:22 +01:00
Maximilian Krüger 4da533e3ee bridge.sol: fix solium linter whitespace errors 2017-12-14 18:27:16 +01:00
Maximilian Krüger d27347380b Migrations.sol: fix solium linter errors 2017-12-14 18:27:16 +01:00
snd 58a80b4ace fix for #61 and tests for withdraw (#66)
* readme: add section on running truffle tests

* extract `sign` from test/foreign into test/helpers and improve it

* add test helper signatureToVRS

* add test helper bigNumberToHexString

* add test helper bigNumberToPaddedBytes32

* add test "should allow correct withdraw" which fails and exposes #61

* resolve #61 and document it

* fix typo

* fix typo

* use num.toString(16) instead of bigNumberToHexString

https://github.com/paritytech/parity-bridge/pull/66#discussion_r156030874

* add comment

* use explicit transaction hash

* add test "withdraw without funds on HomeBridge should fail"

* add test "should not allow withdraw with message.length != 84"

* add test ""should allow second withdraw with different transactionHash but same recipient and value"

* add test "should not allow second withdraw with same transactionHash but different recipient and value"

* fix typo

* bridge.sol: add note that anyone can call HomeBridge.withdraw

* test that anyone can call withdraw provided they have the message and signatures

* test/home.js: improve wording of test
2017-12-14 17:54:49 +01:00
snd 63b0745ea0 Issue 58 solidity test code coverage (#70)
* add initial package.json with test, ci and coverage scripts

inspired by 86794a866b/package.json

* .travis.yml: use ci script from package.json

* upload coverage to coveralls

* README.md: add coveralls badge

* .travis.yml: run npm install

* package.json: make ganache ports match up so truffle can connect

* .travis.yml: call coveralls script directly

* README.md: try to put badges on one line [ci skip]

* README.md: try to fix badge formatting [ci skip]

* package.json: remove directories prop which is not needed

* add notice that code coverage is for contracts only

* .gitignore: node_modules

* package.json: improve description

* package.json: add license

* package.json: replace npm with yarn

* .travis.yml: use yarn instead of npm

* add yarn.lock

* .travis.yml: cache cargo to speed things up
2017-12-14 17:52:36 +01:00
Robert Habermeier e3d7737323
Merge pull request #65 from zacwellmer/patch-1
mention home when should be foreign
2017-12-13 11:27:39 +01:00
Robert Habermeier fbfd7a9e6a
Merge pull request #67 from paritytech/issue-29-ci-truffle
#29 run truffle tests on travis
2017-12-12 18:18:30 +01:00
Maximilian Krüger 8095fda3e3 enable rust tests again 2017-12-12 17:02:13 +01:00
Maximilian Krüger ac9745d36d remove need for package.json for now 2017-12-12 16:59:39 +01:00
Maximilian Krüger 2e5da3e9cd change quoting of concurrent commands. see if that works 2017-12-12 16:57:29 +01:00
Maximilian Krüger 85a2c63e16 first attempt at running truffle tests on travis 2017-12-12 16:53:15 +01:00
Zac Wellmer 8e89bff3ff
debug -> release 2017-12-09 20:51:59 +08:00
Zac Wellmer 79ca831f1a
mention home when should be foreign 2017-12-09 16:11:40 +08:00
Marek Kotewicz 7406015300
Merge pull request #53 from paritytech/remove_truncate
remove unused truncate, closes #51
2017-11-16 17:06:15 +01:00