Commit Graph

471 Commits

Author SHA1 Message Date
Maximilian Krüger 7011150651 bridge.sol: signer -> recoverAddressFromSignedMessage 2018-01-12 16:46:00 +01:00
Maximilian Krüger 49351f764d bridge.sol: rename Signer to MessageSigning 2018-01-12 16:42:09 +01:00
Maximilian Krüger 6dc1021aba bridge.sol: Helpers.toString -> Helpers.intToString 2018-01-12 16:36:47 +01:00
Maximilian Krüger 03b74fc270 bridge.sol: rename Utils to Helpers 2018-01-12 16:34:34 +01:00
Maximilian Krüger 277bafac60 bridge.sol: get rid of `using Authorities for address[];` and `library Authorities` 2018-01-12 16:17:34 +01:00
Marek Kotewicz bd5d0aeeef
Merge pull request #81 from paritytech/snd-issue-55
issue 55 - split ForeignBridge.transfer into two functions and increase branch coverage
2018-01-11 16:50:50 +01:00
Maximilian Krüger 868ee4a10b test/foreign: increase coverage: add test "should not be possible to do same deposit twice for same authority" 2018-01-11 15:15:33 +01:00
Maximilian Krüger f1c74da470 test/foreign: fix test "should not be possible to submit signature twice" increasing coverage 2018-01-11 15:06:03 +01:00
Maximilian Krüger aed0a09ad8 test/foreign: should fail to transfer with value overflow both locally and to home 2018-01-11 15:00:30 +01:00
Maximilian Krüger 15c6e925d6 test/foreign: various improvements and more coverage for transferHomeViaRelay 2018-01-11 14:52:19 +01:00
Maximilian Krüger 23ea4be253 test/foreign: improve some variable names and test names 2018-01-11 14:51:17 +01:00
Maximilian Krüger 81a5d3f18d test/foreign: underscore -> camelcase 2018-01-11 14:50:43 +01:00
Maximilian Krüger 44b5d32f99 bridge.sol: style consistency: remove space between func name and param list 2018-01-11 14:21:16 +01:00
Maximilian Krüger c62cfd3692 adapt tests to split of ForeignBridge.transfer 2018-01-11 14:16:25 +01:00
Maximilian Krüger 597019b8e1 split ForeignBridge.transfer into transferHomeViaRelay and transferLocal
resolve #55
2018-01-11 14:15:51 +01:00
Marek Kotewicz 5f1cdc17c2
Merge pull request #77 from paritytech/snd-issue-54-attack-vector
Issue 54 - close attack vector
2018-01-11 11:39:57 +01:00
Maximilian Krüger 5dd0144537 README.md: improve documentation for issue-54 [ci skip] 2018-01-10 12:01:19 +01:00
Maximilian Krüger 27e95e8d8d README.md: initial documentation of issue-54 [ci skip] 2018-01-10 11:52:36 +01:00
Maximilian Krüger 56b5e6d22d test: isMessageValueSufficientToCoverRelay should work correctly 2018-01-09 14:35:31 +01:00
Maximilian Krüger 22e70cc079 test: remove unused var 2018-01-09 14:35:17 +01:00
Maximilian Krüger 47fe40daaa README.md: document estimated_gas_cost_of_withdraw 2018-01-09 13:11:23 +01:00
Maximilian Krüger 0798bf181d withdraw_relay.rs: add some docstrings 2018-01-09 13:11:02 +01:00
Maximilian Krüger 067bafa545 examples/config.toml: add estimated_gas_cost_of_withdraw 2018-01-09 13:10:02 +01:00
Maximilian Krüger 55d2e1bf55 add config option `estimated_gas_cost_of_withdraw` 2018-01-09 12:53:50 +01:00
Maximilian Krüger f7f78e7cfc improve test description 2018-01-09 12:52:49 +01:00
Maximilian Krüger 68d02ac5fd refactor test code a bit 2018-01-09 11:42:08 +01:00
Maximilian Krüger ba8aedecb1 add test for message part getters (getRecipientFromMessage) 2018-01-09 11:36:00 +01:00
Maximilian Krüger e64ed795c2 withdraw_relay_single_explicit_contract_addresses 2018-01-08 18:21:00 +01:00
Maximilian Krüger 95d8e80de2 add comments 2018-01-08 18:20:15 +01:00
Maximilian Krüger 5153cb9dae withdraw_relay_check_gas -> with_relay_explicit_gas 2018-01-08 18:19:47 +01:00
Maximilian Krüger 5d99a39848 tests: add missing comma 2018-01-08 18:19:32 +01:00
Maximilian Krüger c0cfcfe567 add test withdraw_relay_single_log_insufficient_value_no_relay 2018-01-08 18:13:59 +01:00
Maximilian Krüger fa7959810b tests: add comments 2018-01-08 18:12:56 +01:00
Maximilian Krüger aa436c5885 tests: add comments 2018-01-08 18:11:50 +01:00
Maximilian Krüger d094ca6c87 withdraw_relay_single_log_no_relay -> withdraw_relay_single_log_authority_not_responsible_no_relay 2018-01-08 18:10:23 +01:00
Maximilian Krüger 848e9fe200 withdraw_relay_single_log_relay -> withdraw_relay_single_log_sufficient_value_relay 2018-01-08 18:09:21 +01:00
Maximilian Krüger 3d06ee2655 withdraw_realy_basic -> withdraw_relay_no_log_no_relay & add comment 2018-01-08 17:59:47 +01:00
Maximilian Krüger 89c92bd490 tests/lib.rs: assert that expected stream len matches actual stream len 2018-01-08 17:44:44 +01:00
Maximilian Krüger d9964a8472 address grumble
https://github.com/paritytech/parity-bridge/pull/77#discussion_r160170545
2018-01-08 17:43:38 +01:00
Maximilian Krüger 2b03faf04f add call to `isMessageValueSufficientToCoverRelay` to withdraw relay transport tests 2018-01-08 15:08:55 +01:00
Maximilian Krüger 171bf29ba0 withdraw_relay.rs: make withdraw_relay_payload take references as we no longer necessarily own its inputs 2018-01-08 14:26:57 +01:00
Maximilian Krüger 20bc965604 withdraw_relay.rs: fetch whether message value is sufficient and filter out insufficient 2018-01-08 14:26:19 +01:00
Maximilian Krüger d4d1b2d582 withdraw_relay.rs: add FetchMessageValueSufficient to WithdrawRelayState 2018-01-08 14:25:46 +01:00
Maximilian Krüger 24a926bdb6 withdraw_relay.rs: add message_value_sufficient_payload 2018-01-08 14:25:16 +01:00
Maximilian Krüger bd6ff44ced add comments 2018-01-08 14:16:33 +01:00
Maximilian Krüger 21bb9a6adc add docstring 2018-01-08 14:15:41 +01:00
Maximilian Krüger e71c9c53c9 withdraw_relay.rs: improve docstring 2018-01-08 14:14:39 +01:00
Maximilian Krüger 3d76ce0309 withdraw_relay.rs: improve var name and comments 2018-01-08 14:12:55 +01:00
Maximilian Krüger b8246bfe4b deploy.rs: hardcode estimatedGasCostOfWithdraw for now 2018-01-08 14:10:33 +01:00
Maximilian Krüger 4b408fa023 add compiled contract .abi and .bin 2018-01-08 14:09:22 +01:00