588bf77492
wow we have two separate per-cylinder trims?! fix #5237
...
refactoring: bringing two offsets much closer together, no change in overall logic
2023-04-12 15:04:14 -04:00
e1b4ed2a41
https://github.com/rusefi/rusefi/issues/5237
...
only renaming variable here
2023-04-12 11:49:11 -04:00
0c1859b77e
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-14 15:33:17 -05:00
f82f604a3f
ohhh we already have FO_1_2_3_4_5_6_7_8
2022-12-20 21:23:25 -05:00
4e61d92099
FO_1_2_3_4_5_6_7_8
2022-12-20 21:13:33 -05:00
18165e4b02
guards
2022-12-17 14:36:27 -05:00
57ad9b7311
random getOrZero clean-up
2022-12-14 19:48:07 -05:00
55062b1ef6
refactoring: constexpr fuel computer ( #4830 )
...
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 12:25:04 -05:00
23698be5f8
without ValueProvider3D interface how do we mock? ( #4829 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:23:54 -05:00
5c50ad2db4
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
ec77afeaa0
reducing ugly
2022-11-06 20:47:57 -05:00
fd86dc2b0f
minor trigger refactoring
2022-11-05 22:30:08 -04:00
b57bf2903a
minor trigger refactoring
2022-11-05 21:43:12 -04:00
2bc8fbce7d
VE blend tables ( #4640 )
...
* blendy ve too
* ui
* small optimizations
* save kinetis memory
* changelog
2022-10-19 06:42:22 -04:00
dfe1b47b4d
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
9e7f36a5ca
tear down Engine god object #4511
2022-09-15 21:28:27 -04:00
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
6b0941b8ed
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
b536651a24
some dead nonsense
2022-09-14 01:15:26 -04:00
fedfd42989
removing dead parameter
2022-09-14 01:13:57 -04:00
e522c7d149
tear down Engine god object #4511
...
just trying different things
2022-09-14 01:09:32 -04:00
91d4844e38
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
4934d76d88
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:24:17 -04:00
d329f8ae10
tear down Engine god object #4511
...
just trying different things
2022-09-03 07:44:24 -04:00
25f4ebbc01
moving state into specific class ( #4520 )
...
* moving state into specific class
* moving state into specific class
2022-09-02 14:38:03 -04:00
c63fb29aaf
refactoring: reducing outputChannels copy
2022-09-01 00:13:55 -04:00
d7802e6373
dead initial value?
2022-07-30 16:07:40 -04:00
483915f20f
correct behavior in case of failed CLT but not failed IAT ( #4406 )
2022-07-30 15:44:54 -04:00
932f5e1f30
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit 32d46d1f09d5e131b1d0
2022-06-09 17:21:22 -04:00
66fffee321
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
7df4f36f88
Revert "Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150"
...
This reverts commit 76243afa9c
2022-05-08 07:10:54 -04:00
76243afa9c
Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150
2022-05-08 07:07:34 -04:00
e62877964a
Move curves out of engineConfiguration in order to reduce RAM usage #4127
2022-05-01 23:43:43 -04:00
38213bbc00
more missing autoscale ( #4112 )
...
* autoscale m_config->timeConstant
* min/max afr
* more
* dwell voltage
* closed loop fuel
* knock
* map estimate
* applyNonlinearBelowPulse
* fix
* add a test while we're at it for un-covered code
* test fallback MAP since we touched that
* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
0b21ddce9c
random progress
2022-04-16 16:39:52 -04:00
3c7eb93fe1
steps towards ignition live data
2022-04-13 16:48:25 -04:00
7d657106d7
warning cleanup ( #4020 )
2022-03-22 16:53:24 -04:00
40e96a03d5
table for tcharge interpolation ( #3855 )
...
* extract getTChargeCoefficient
* new table
2022-01-30 08:45:11 -05:00
28950acf3e
disable fuel trim shortly after DFCO ( #3847 )
...
* vss based dfco
* fix digits while we're here
* fix some other digits for fun
* don't use custom assert
* simplify test
* less than or equal, test vss behavior
* disable closed loop fuel after dfco1
* I can't type
* correct comparison helps
* poke
2022-01-28 21:35:23 -05:00
3b6ecb432b
migrating to SensorType::Rpm API
2022-01-20 22:38:08 -05:00
71b2dc762a
https://en.wikipedia.org/wiki/Pi
2022-01-14 21:23:27 -05:00
7d341cfc9d
improve maf output channels and logging ( #3743 )
...
* maf channels
* s
* binary log
* if only I could type
* can
* instant RPM too
* s
* test
* graceful zero rpm
* test works
* float near
2022-01-12 15:41:35 -05:00
d9175696a2
mk files refactoring
2022-01-06 21:40:48 -05:00
3a4a0ba18d
simplify some table lookups ( #3692 )
...
* simplify
* expand interpolation test
2021-12-20 08:14:30 -05:00
0810198185
clean up timing table defaults ( #3705 )
...
* less crazy configs
* cleanup
* make that test happy
2021-12-20 08:02:38 -05:00
76768d6ac4
2 byte table axis #3045
...
fixing build
2021-12-20 01:50:23 -05:00
66f82a0cdb
2 byte table axis #3045
2021-12-19 22:43:10 -05:00
940b04ab24
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
555a8d5f43
simplify cylinder phasing ( #3650 )
2021-12-05 10:46:35 -05:00
fda7a3a775
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00
de0680209b
why so many channels are hidden in debug ? #3614
2021-11-29 10:15:28 -05:00
3334a6963c
oh my god we've had no asserts ( #3595 )
2021-11-22 17:52:03 -05:00
69d36dad6e
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
6d0dfe4542
refactoring - magic constant bad
2021-11-07 00:09:17 -04:00
475edecee5
this warning should be promoted to fatal!
2021-10-26 17:10:53 -04:00
d84cf5eea8
splitting accelerations
2021-10-16 20:16:40 -04:00
ea87d9c9be
Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
...
dead code
2021-10-14 15:17:09 -04:00
9797d25b7c
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
b4884498cb
OBD error renames
2021-10-03 01:30:42 -04:00
c4ff0cd19d
more firing orders!
2021-09-18 00:18:06 -04:00
520d81d75c
Dwell voltage correction ( #3234 )
...
* cfg + impl
* ui
* value_or
* changelog
* fix
2021-09-15 08:07:33 -04:00
6b6c8abfc4
firing order for some 911
2021-08-24 07:31:55 -04:00
24ff3a5cd5
firing order for some 911
2021-08-24 07:28:56 -04:00
d24f1462e2
even more pch ( #3112 )
...
* s
* more
* s
* f7
2021-08-04 19:30:52 -04:00
25414ebdad
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
643aa672e4
VH41DE (Japaneese Y32 Variant) firing order
2021-07-20 21:16:51 -04:00
2ce7777865
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
3d0ba4af5c
VAG canned tunes
2021-07-08 20:42:35 -04:00
9377a01aec
store cylinder count as plain number ( #2915 )
...
* update test framework
* eh
* hey look it's fewer warnings
* unwind
* fix
* config
* configs
* logic
* even java had some
* no need to be a typedef
* paste in actual cylinder count
2021-07-07 08:31:05 -04:00
2eb0b2a631
Unified cyl count macro ( #2914 )
...
* update test framework
* eh
* hey look it's fewer warnings
* unwind
* fix
* config
* configs
* logic
* even java had some
* console needs help
2021-07-06 20:14:08 -04:00
7d2057e74a
remove cranking dwell angle ( #2814 )
...
* config & impl
* settings
* engines & boards
* this test doesn't do anything interesting
2021-06-13 07:52:07 -04:00
3ef969d743
warnings & assorted cleanup ( #2793 )
...
* lua hook
* validateBuffer
* tables
* simplify fsio table
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 14:30:25 -04:00
981e8f5047
defaults cleanup: base engine & fuel ( #2790 )
...
* build
* fuel and base
* fix build
* cleanup
* extern
* tps/tps
* alternator
* tps
* iat timing
* cranking RPM
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 00:50:07 +03:00
de7879b6e4
convert a table to scaled_channel ( #2724 )
...
* scaled VE table
* use setTable
* efi::clear
* ratio -> struct
2021-05-20 20:00:32 -04:00
a762853d3b
refactoring magic constant STOICH_RATIO
2021-05-20 02:39:20 -04:00
da6518dcb1
remove deprecated getEngineLoadT ( #2676 )
...
* remove
* few more
2021-05-10 08:30:41 -04:00
4474f9f1c2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00
ad71016862
rip the bandaid: find-replace most of scheduleMsg ( #2572 )
...
* biiiig find replace
* more trivial find replace
* pwm
* almost all of them
* few more
* gpio
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 12:53:13 -04:00
70e0723626
use cylinders_count_t in loops through cylinders ( #2563 )
...
to supress signed vs usigned warnings
2021-04-18 08:58:56 -04:00
fa840a7593
hip9011 and friends ( #2527 )
...
* engine math: extrant getFiringOrderTable for reuse
* engine math: getNextFiringCylinderId helper
* introduce knock_logic: first member is getCylinderKnockBank()
moved from software_knock.cpp
* hip9011: support two inputs/banks
* fix CI
* Board Subaru EG33: populated with TPIC8101 with Advanced mode
* hip9011: test communication in advanced mode
* hip9011: handle situation when chip is already in advanced mode
* Board Subaru EG33: cylinder to knock bank mapping
* hip9011: count spi transactions in advansed mode too
* hip9011: reset incalid responce counter after chip initialization
* hip9011: make debug output more structured
2021-04-04 18:13:21 -04:00
881c3739a2
Add two new V8 firing orders ( #2423 )
...
* fix typos, spelling
* add two V8 firing orders
* use the available number of CPU cores, not just 4
* add new firing orders to config
* updating generated files to include new v8 firing orders
* reverting update of auto-generated files
* correct firing order labels for new firing orders
2021-03-05 19:28:17 -05:00
3a8313a94a
try rpm calculator timer ( #2053 )
...
* add api
* rpm calculator
* fix fsio
* fix float
* remove wrong comment
* fix timer
* clang didn't like this
* oops
* format
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-28 18:56:34 -05:00
4a1d3de9a6
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
25560b85c2
Supress annoing unused warnings ( #2216 )
2021-01-11 08:49:20 -05:00
a5266cd6ef
part of 2217 which may fix it alone ( #2220 )
2021-01-11 08:01:54 -05:00
571122d461
Start support for multi-bank closed loop fueling ( #2184 )
...
* cfg
* cell
* N banks
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-10 08:10:49 -05:00
92ea09b0a6
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
f29ca22b99
fix ( #2109 )
2020-12-20 19:31:14 -05:00
a08e79789d
second lambda (x-series CAN only, for now) ( #2048 )
...
* add sensor
* second sensor
* switch sensor name
* gobblin up your memory
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-09 20:26:23 -05:00
b3d45b909f
Revert "switch rpm calculator to use timer class ( #2005 )"
...
This reverts most of a26ed3eb5a
2020-12-06 18:05:53 -05:00
a26ed3eb5a
switch rpm calculator to use timer class ( #2005 )
...
* add api
* rpm calculator
* fix fsio
* fix float
* remove wrong comment
* fix timer
* clang didn't like this
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 16:01:45 -05:00
89eaae8234
LM_ALPHA_N_2 rename
2020-11-27 15:44:31 -05:00
09b41bb1bb
Everything in lambda! ( #1893 )
...
* lambda
* default configs, fix build
* config, gauge, UI
* more digits
* change menu text
* fix that while I'm here
* doesn't need extra word
* todo note
* tests
* last test
* missed a config
* update java
* store target lambda
* more java
* format
* hopefully enough java for CI to pass
2020-10-26 18:15:17 -04:00
c1699d91d0
fix closed loop fuel ( #1797 )
...
* fix
* add a test
* signature
2020-09-19 03:44:01 -04:00
eebded8caa
scale tables using type system ( #1776 )
...
* store scale in the type
* efi ratio
* boost control scaling
* fix boost tests
2020-09-10 18:44:10 -04:00
95798a5246
fix broken master, inject engine ptr to rpmcalculator ( #1759 )
...
* fix
* oops
2020-09-05 18:49:42 -04:00
ca21d5b4c2
refactoring
2020-09-03 19:29:15 -04:00
Andrey
rusefillc
rusefillc
Matthew Kennedy
Andrey G
Scott Smith
slowriot