Commit Graph

40 Commits

Author SHA1 Message Date
Andrey f60bd6c683 better file name to actually reflect what the content is about 2024-03-25 23:31:49 -04:00
Matthew Kennedy 26b351ba40 Remove/make injector duty limit configurable fix #4798 2024-01-07 22:36:18 -05:00
rusefillc 1e02aaff3d Require Foot On Brake To Crank 2023-11-27 01:01:19 -05:00
rusefillc 4cb45a354b
Better efi engine control guard (#5695)
* better EFI_ENGINE_CONTROL

* better EFI_ENGINE_CONTROL

* better EFI_ENGINE_CONTROL

* better EFI_ENGINE_CONTROL

* better EFI_ENGINE_CONTROL

* better EFI_ENGINE_CONTROL

* better EFI_ENGINE_CONTROL
2023-11-05 13:54:06 -05:00
rusefillc 850d79d89d shall we be just a little less Toyota 2023-11-01 09:48:33 -04:00
rusefi 381b9bb9e7 fuelCutCode for lack of GDI4 communications #5631
only:proteus_f7
2023-10-23 13:25:53 -04:00
Matthew Kennedy 447543d942 add lambda protect cut code 2023-06-29 11:51:50 -04:00
rusefillc c50ef201b1 https://github.com/rusefi/rusefi/issues/5293 2023-05-31 12:44:59 -04:00
Andrey b9c1e1660a only:better variable name 2023-04-29 11:07:08 -04:00
Matthew Kennedy 25a3589edf pause closed loop fuel after cuts
(cherry picked from commit a861d76da6)
2023-04-29 07:10:28 -04:00
Andreika c17e2adfb7
RPM limit fix and unit-tests (#5238)
* fix rpm limit timing/fuel corrections

* rpm limit timing - more unit-tests
2023-04-15 12:03:47 -04:00
Andreika 919ed2d934
RPM soft limit and hysteresis #5214, #5224 (#5228)
* [DRAFT] RPM soft limit and hysteresis #5214, #5224

* fix m_timingRetard

* fix rpmHardLimitHyst

* unit-tests for #5214, #5224
2023-04-10 17:18:51 -04:00
rusefillc f94aa7a7cd https://rusefi.com/forum/viewtopic.php?f=2&t=2484 luaIgnCut 2023-01-02 17:46:56 -05:00
Matthew Kennedy 466833d95a
ETB error counter logic (#4854)
* simplify ETB error counter logic

* dropped this: {

* happy test

* reorder logic, test etbErrorCode

* test that fails

* independent TPS and PPS counters

* missed a file

* happy test
2022-11-30 22:20:09 -05:00
rusefi 1e7baa1089 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-29 22:39:55 -05:00
rusefi b5049c8284 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-29 22:13:59 -05:00
rusefi 84512567ba ETB duty cycle jitter #4833
still totally dead on real hardware and I've already fixed two defects! time for an indicator
2022-11-29 22:01:15 -05:00
rusefi b3a3c97b87 ETB duty cycle jitter #4833
still totally dead on real hardware and I've already fixed two defects! time for an indicator
2022-11-29 22:01:15 -05:00
rusefillc 3745d34249 better method name 2022-11-27 18:17:08 -05:00
rusefillc 3c73be35b5 https://writer.com/blog/occurred-occured/ 2022-11-26 23:44:48 -05:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
Andrey baaec6a603 refactoring: encapsulation 2022-09-28 22:42:08 -04:00
Matthew Kennedy 3a57c41c1b
add fuel/spark cut codes to TS indicators (#4592)
* add fuel/spark cut codes to TS indicators

* fix list

* only set clearReason if not cleared
2022-09-19 22:01:03 -04:00
Andrey 2c0ce0ec7d deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
rusefillc 0b6cb09869 kick Start Cranking mode #4569 2022-09-13 02:23:57 -04:00
Matthew Kennedy b305308ef6
add hysteresis to limp rpm, boost, injector duty (#4541)
* add hysteresis

* changelog
2022-09-05 20:56:32 -04:00
rusefi 0013a8151c m_hasSynchronizedSymmetrical handling improvements #4099 2022-04-23 17:56:35 -04:00
Matthew Kennedy f1742c44ff
output channel tweaks (#4023)
* shuffle around output channels

* postState should take a ref

* s

* s

* patch input file

* limits

* accel bad bounds check

* units

* units

* Revert "accel bad bounds check"

This reverts commit b2bb493be3.

* missed an autoscale
2022-03-24 08:58:55 -04:00
Matthew Kennedy f742ae8b7e
limp mangaer handles more stuff (#3983) 2022-03-20 09:28:17 -04:00
Benas Brazdziunas 2035c2fa7f
Launch fuel and spark cut issue (#3988)
* Launch fual and spark cut issue

* moved launch cuts to limp_manager

* Applied recomendations

* Auto-generated configs and docs

* Added recomendations

* Auto-generated configs and docs

Co-authored-by: GitHub build-firmware Action <action@github.com>
Co-authored-by: Benas <bbrazdziunas@gavea.co.uk>
2022-03-11 09:27:42 -05:00
rusefillc 751355a04b
Limp shutdown rebase (#3879)
* limp manager handles engine stop

* use timer

* dead relevant fsio

* this stuff needs its own ticket

* if we can comment out 'business logic' and tests do not fail it's not a great sign :(

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-02-01 20:47:17 -05:00
rusefillc 901a6cf869 limp ClearReason 2022-01-08 23:10:40 -05:00
rusefillc a2844a2d37 limp ClearReason 2022-01-08 22:52:45 -05:00
rusefillc 177a5faa63 limp ClearReason 2022-01-08 22:13:20 -05:00
Scott Smith 69d36dad6e
Final cleanup of ENGINE macros (#3567)
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy 145316c497
less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
Matthew Kennedy 3a30f038ce
kill engine if no oil pressure (#2800)
* min oil pressure for crank

* do it time-based

* rename field

* include

* fix existing test

* tests

* fix logic

* more test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-16 17:20:28 -04:00
Matthew Kennedy 93b034b8e9
Limp handles inj/ign disable (#2245)
* status loop just asks limp mgr

* put logic in limp manager

* don't need that function any more

* bye

* TIL these bits already exist in the configuration
2021-01-27 21:28:53 -05:00
Matthew Kennedy ff4ce2fb1f
create limp manager (#2142)
* move rev limit to limp manager

* call fatal error

* include order

* fix bug

* tests

* comment

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 17:30:46 -05:00