1315591c85
Make streams' read and write return void
...
The stream implementations had two cascading layers (the upper one
with operator<< and operator>>, and a lower one with read and write).
The lower layer's functions are never cascaded (nor should they, as
they should only be used from the higher layer), so make them return
void instead.
2018-04-16 07:38:37 -06:00
670a7686a6
Remove unused ReadVersion and WriteVersion
...
CDataStream and CAutoFile had a ReadVersion and WriteVersion method
that was never used. Remove them.
2018-04-16 07:38:37 -06:00
d1c9ef8606
serialization: teach serializers variadics
...
Also add a variadic CDataStream ctor for ease-of-use.
2018-04-16 07:38:37 -06:00
ead36d85c7
[WIP] Remove unused statement in serialization
...
Zcash: Excludes changes to CBanEntry and CHDChain, which we don't have yet.
2018-04-16 07:38:37 -06:00
c803fa1094
Add COMPACTSIZE wrapper similar to VARINT for serialization
2018-04-16 07:38:37 -06:00
6cbe2c482c
add bip32 pubkey serialization
...
CExtPubKey should be serializable like CPubKey
2018-04-16 07:38:36 -06:00
d2fb34fb7c
Handle usage of prevector for CScript in Zcash-specific code
2018-04-16 07:38:36 -06:00
29a8ade782
Prevector type
2018-04-16 07:38:36 -06:00
690d38f0f8
Resolve issue bitcoin/bitcoin#3166 .
...
These changes decode valid SIGHASH types on signatures in assembly (asm) representations of scriptSig scripts.
This squashed commit incorporates substantial helpful feedback from jtimon, laanwj, and sipa.
2018-04-16 07:38:36 -06:00
312f70091b
Auto merge of #3169 - ebfull:sapling-global-params, r=str4d
...
Import sapling global parameters
This will also test the API a bit by invoking the Pedersen hashes.
Part of #3053 .
2018-04-14 18:35:11 -07:00
65dc30c5a1
Update librustzcash hash
2018-04-14 19:33:10 -06:00
1594c845f5
Auto merge of #3157 - bitcartel:2966_extend_sprout_tests_part_2, r=str4d
...
Part of #2966 , extending Sprout tests to other epochs
This continues the work started in PR #3109 .
2018-04-14 16:36:30 -07:00
ceb4559eac
Auto merge of #2784 - kozyilmaz:fetch, r=str4d
...
[macOS] added curl download method to fetch-params.sh
added curl download method and flock workaround for macOS
Part of #2246 .
2018-04-14 14:38:07 -07:00
8be9d79c21
Auto merge of #3153 - str4d:default-disable-libs, r=str4d
...
Disable building libzcashconsensus by default
The library is not currently a supported build artifact; it needs work in
order to build on certain platforms (e.g. MacOS), and its dependencies need to
be narrowed down (Equihash is not a requirement for validating scripts).
2018-04-14 13:04:35 -07:00
341b775b19
Link with -ldl
2018-04-13 22:26:24 -06:00
395bcd3647
Invoke the merkle_hash API in librustzcash via test suite.
2018-04-13 22:26:22 -06:00
65a8f9f201
Auto merge of #3086 - str4d:cli-binary-improvements-1, r=str4d
...
CLI binary improvements
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#5936
- bitcoin/bitcoin#7550
- bitcoin/bitcoin#7989
- bitcoin/bitcoin#7957
- bitcoin/bitcoin#9067
- bitcoin/bitcoin#9220
Excludes any changes that affected the QT code.
2018-04-12 20:46:05 -07:00
ee6220c0ed
[Bitcoin-Tx] Adjust util-test test cases for Zcash
2018-04-12 19:36:48 -06:00
e6bbd8481e
Switch to latest librustzcash
2018-04-12 18:52:00 -06:00
abf5dd31af
Add static asserts to ensure CONTINUE_EXECUTION doesn't collide
2018-04-12 18:11:46 -06:00
3b26f5c361
Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places.
2018-04-12 18:10:04 -06:00
c06245c1e3
Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers
2018-04-12 18:10:04 -06:00
fadbbe1e04
Fix exit codes:
...
- `--help`, `--version` etc should exit with `0` i.e. no error ("not enough args" case should still trigger an error)
- error reading config file should exit with `1`
Slightly refactor AppInitRPC/AppInitRawTx to return standard exit codes (EXIT_FAILURE/EXIT_SUCCESS) or CONTINUE_EXECUTION (-1)
2018-04-12 18:10:04 -06:00
f11fb32967
[Bitcoin-Tx] Add tests for sequence number support
2018-04-12 18:10:04 -06:00
c09d76ea3c
[bitcoin-tx] allow to set nSequence number over the in= command
2018-04-12 18:10:04 -06:00
216e94fb24
[RPC] createrawtransaction: add option to set the sequence number per input
2018-04-12 18:10:04 -06:00
e8f5b0278e
bitcoin-cli.cpp: Use symbolic constant for exit code
2018-04-12 18:10:04 -06:00
5e39c5a655
doc: mention bitcoin-cli -stdin in release notes
2018-04-12 18:10:04 -06:00
21e33231af
rpc: Input-from-stdin mode for bitcoin-cli
...
Implements #7442 by adding an option `-stdin` which reads
additional arguments from stdin, one per line.
For example
```bash
echo -e "mysecretcode\n120" | src/bitcoin-cli -stdin walletpassphrase
echo -e "walletpassphrase\nmysecretcode\n120" | src/bitcoin-cli -stdin
```
2018-04-12 18:08:17 -06:00
6c9d672f3c
Add optional locktime to createrawtransaction
...
A non-zero locktime also causes input sequences to be set to
non-max, activating the locktime.
2018-04-12 18:08:17 -06:00
3e7b5f23e4
Auto merge of #3081 - str4d:sapling-activation-logic, r=str4d
...
Add Sapling to upgrade list
2018-04-12 12:32:50 -07:00
176fada24d
Add Sapling to upgrade list
2018-04-12 12:13:05 -06:00
b691234beb
Auto merge of #3162 - str4d:3052-sapling-crypto-deps, r=str4d
...
depends: Update to latest librustzcash with sapling-crypto dependencies
Part of #3052 .
2018-04-12 11:03:55 -07:00
42e3025237
Auto merge of #3165 - str4d:release-v1.1.0, r=str4d
...
Release v1.1.0
2018-04-12 08:55:29 -07:00
b89b48cda1
Auto merge of #3166 - str4d:3132-reset-pindexbestinvalid, r=str4d
...
When rewinding, reset pindexBestInvalid if it is pointing to a removed block
2018-04-11 21:41:30 -07:00
39ee63c876
When rewinding, reset pindexBestInvalid if it is pointing to a removed block
2018-04-11 21:46:58 -06:00
4d234cd2f8
Overwinter mainnet activation height
2018-04-11 20:21:45 -06:00
2141de16e8
make-release.py: Updated release notes and changelog for 1.1.0.
2018-04-11 20:15:29 -06:00
145ee79099
make-release.py: Updated manpages for 1.1.0.
2018-04-11 20:15:13 -06:00
f64c346eca
make-release.py: Versioning changes for 1.1.0.
2018-04-11 20:02:10 -06:00
a560c24d6b
depends: Update to latest librustzcash with sapling-crypto dependencies
2018-04-11 08:06:40 -06:00
c63c9f20e4
depends: Add support for unpackaged Rust crates
2018-04-11 08:00:23 -06:00
b123b9bb79
depends: Upgrade Rust to 1.26.0-beta.3
2018-04-11 07:59:46 -06:00
61624ed05d
Part of #2966 , extending Sprout tests to other epochs.
...
This continues the work started in PR #3109 .
2018-04-09 16:17:30 -07:00
47fe5f72f4
Disable building libzcashconsensus by default
...
The library is not currently a supported build artifact; it needs work in
order to build on certain platforms (e.g. MacOS), and its dependencies need to
be narrowed down (Equihash is not a requirement for validating scripts).
2018-04-06 15:09:50 +01:00
079d9e6a57
Auto merge of #3149 - str4d:release-v1.1.0-rc1, r=str4d
...
Release v1.1.0-rc1
2018-04-05 04:36:15 -07:00
ecf544d062
Set Overwinter protocol version to 170005
...
170004 is the protocol version for the NODE_BLOOM change, which is being
"released" in this RC. The activation height is being set in the final release,
which means that we may end up with both RC and final release versions online
when Overwinter activates. Bumping the protocol version for Overwinter enables
RC nodes to be correctly disconnected.
2018-04-05 12:07:44 +01:00
600c4acee1
Auto merge of #3151 - bitcartel:fix_alertnotify_test, r=str4d
...
Fix Deprecation test to check for sanitized string from alertnotify.
Closes #3150
2018-04-05 02:08:42 -07:00
6901d30830
Fix test to check for sanitized string from alertnotify.
...
If client version is 1.1.0-rc1, the alertnotify message will have
been sanitized and will show as 1.1.0rc1.
2018-04-04 21:55:20 -07:00
776b494aec
make-release.py: Updated release notes and changelog for 1.1.0-rc1.
2018-04-05 03:26:17 +01:00
Pieter Wuille
Cory Fields
Pavel Janík
Matt Corallo
Jonas Schnelli
Jack Grigg
mruddy
Homu
Sean Bowe
Karl-Johan Alm
UdjinM6
Jonas Schnelli
Puru
Wladimir J. van der Laan
Tom Harding
Simon