Simon
9b5da42745
Fixes #2480 . Null entry in map was dereferenced leading to a segfault.
2017-07-14 00:10:54 -07:00
Daira Hopwood
52ca5aac5b
Change wording in Security Warnings section of README.md.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-07-14 05:18:08 +01:00
Homu
2c0fd9e5e4
Auto merge of #2522 - bitcartel:2446_coinbase_field_listunspent, r=daira
...
Add generated field to listunspent output
Closes #2446
2017-07-12 23:46:25 -07:00
Wladimir J. van der Laan
20fb708e6f
rpc: Add WWW-Authenticate header to 401 response
...
A WWW-Authenticate header must be present in the 401
response to make clients know that they can authenticate,
and how.
WWW-Authenticate: Basic realm="jsonrpc"
Fixes #7462 .
2017-07-12 16:37:48 -05:00
Jack Grigg
689264bbff
Add test for issue #2444
...
A WWW-Authenticate header must be present in the 401 response to make clients
know that they can authenticate, and how.
2017-07-12 16:34:58 -05:00
Simon
b639bb1eef
Fixes #2519 . When sending from a zaddr, minconf cannot be zero.
2017-07-11 11:29:43 -07:00
Simon
d77a0ac4a0
Closes #2446 by adding generated field to listunspent.
...
If generated is true, the unspent transaction output is from a
coinbase transaction and can only be sent to a shielded address.
2017-07-11 10:44:36 -07:00
Homu
5df11e9d8e
Auto merge of #2460 - str4d:process-temp-release-notes, r=daira
...
Pull in temporary release notes during the release process
This PR assumes we always have at least one notable change in `doc/release-notes.md`, which should be the case for every release.
2017-07-10 11:44:00 -07:00
Homu
90a255a747
Auto merge of #2464 - str4d:torcontrol-rbf-resource-leak, r=daira
...
Net: Fix resource leak in ReadBinaryFile(...)
Introduced in 3290567bbd
via PR #2177 .
Cherry-picked from Bitcoin PR https://github.com/bitcoin/bitcoin/pull/10408
2017-07-10 10:43:22 -07:00
Jack Grigg
046c3d4f24
Simplify Python installation, inform user if they need to manually configure
2017-07-10 10:30:23 -05:00
Jack Grigg
c73014a2e3
Variable overrides for FreeBSD
...
These are insufficient to enable FreeBSD to build.
2017-07-04 17:47:34 -07:00
Jack Grigg
6f4a1721f2
Variable overrides for Debian, Ubuntu and Fedora
2017-07-04 17:47:11 -07:00
Jack Grigg
6db418c982
Ansible playbook for installing Zcash dependencies and Buildbot worker
2017-07-04 17:46:17 -07:00
Daira Hopwood
506a21850a
Remove UPnP support. fixes #2500
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-07-03 08:57:05 +01:00
Jack Grigg
caafbbb483
Pull in temporary release notes during the release process
2017-06-29 15:42:40 -07:00
Daira Hopwood
262fc5f4e3
Alert 1004 (version 1.0.10 only)
...
Author: Simon <simon@bitcartel.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-24 19:49:41 +01:00
Homu
d6ec3954c6
Auto merge of #2474 - bitcartel:release-v1.0.10-1, r=bitcartel
...
Release v1.0.10-1
2017-06-23 20:13:47 -07:00
Simon
2762b68576
make-release.py: Updated release notes and changelog for 1.0.10-1.
2017-06-23 19:50:41 -07:00
Simon
a0a3eb70b9
make-release.py: Updated manpages for 1.0.10-1.
2017-06-23 19:50:40 -07:00
Simon
d444e1cf40
make-release.py: Versioning changes for 1.0.10-1.
2017-06-23 19:43:29 -07:00
Homu
ad5e8a544b
Auto merge of #2462 - str4d:2404-gitian-no-proton, r=ebfull
...
Disable building Proton in Gitian
This is the patch used to build 1.0.9 and 1.0.10.
Part of #2404 .
2017-06-23 18:34:31 -07:00
Homu
1605da740e
Auto merge of #2473 - ebfull:init-proto-hotfix-release, r=ebfull
...
Revert changes to INIT_PROTO_VERSION
This reverts https://github.com/zcash/zcash/pull/2245 in order to fix degraded networking behavior for 1.0.10 clients.
2017-06-23 17:26:34 -07:00
Sean Bowe
15a9937654
Revert "Delete old protocol version constants and simplify code that used them."
...
This reverts commit 5a49c929dd
.
2017-06-23 18:19:25 -06:00
Sean Bowe
9ad9a25eff
Revert "Remove an unneeded version workaround as per @str4d's review comment."
...
This reverts commit 1e9db0b38a
.
2017-06-23 18:19:17 -06:00
practicalswift
1240717431
Net: Fix resource leak in ReadBinaryFile(...)
...
Introduced in 3290567bbd
via PR #2177 .
2017-06-23 18:49:43 +12:00
Daira Hopwood
ff0f305497
Cosmetics (trailing whitespace, comment conventions, etc.)
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:05 +01:00
Daira Hopwood
811b36ba80
For unused variables reported by pyflakes, either remove the variable,
...
suppress the warning, or fix a bug (if the wrong variable was used).
refs #2450
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:05 +01:00
Daira Hopwood
aff0bf7fa1
Clean up imports to be pyflakes-checkable. fixes #2450
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:04 +01:00
Jack Grigg
f86111d3f5
Disable building Proton in Gitian
...
This is the patch used to build 1.0.9 and 1.0.10.
Part of #2404 .
2017-06-23 01:02:01 +12:00
Homu
d52ac0d498
Auto merge of #2461 - str4d:release-v1.0.10, r=str4d
...
Release v1.0.10
2017-06-21 20:40:11 -07:00
Jack Grigg
5073467dad
Move temporary release notes to final ones
2017-06-22 15:23:02 +12:00
Jack Grigg
93a63765b6
make-release.py: Updated release notes and changelog for 1.0.10.
2017-06-22 15:13:04 +12:00
Jack Grigg
c04ffa0e32
make-release.py: Updated manpages for 1.0.10.
2017-06-22 15:05:04 +12:00
Jack Grigg
dc2ead6021
make-release.py: Versioning changes for 1.0.10.
2017-06-22 14:47:15 +12:00
Homu
59de56eeca
Auto merge of #2342 - bitcartel:1081__mempoolpatch, r=str4d
...
Add ability for node to reject tx from mempool by number of tx inputs
Implement short-term solution described in #2343 so that users can respond promptly to critical short-term problems caused by quadratic validation scaling, such as the getblocktemplate latency, block propagation latency, and mempool size inflation issues described in #2333 .
2017-06-21 14:42:13 -07:00
Jack Grigg
6ea58d1531
Use sendfrom for both t-addr calls
2017-06-22 09:34:10 +12:00
Homu
02e5fffadc
Auto merge of #2360 - daira:2359.remove-lax-der-validation, r=arcalinea
...
Remove unneeded lax ECDSA signature verification
Fixes #2359 . Removes code for lax ECDSA verification, and the SCRIPT_VERIFY_DERSIG flag that controlled it. The behaviour is as-if the flag is always set.
2017-06-20 19:05:58 -07:00
Simon
99f6d5da6c
Fix #b1eb4f2 so test checks sendfrom as originally intended.
...
Also reduce number of z_sendmany calls made so test runs quicker.
2017-06-20 22:49:47 +00:00
Daira Hopwood
193b3e8b28
Delete test that is redundant and inapplicable to Zcash.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-20 10:03:17 +01:00
Homu
c050b99469
Auto merge of #2456 - btccom:master, r=str4d
...
[mining] let "getblocktemplate" work when disable wallet
we already support GetBlockTemplate without build wallet, see:
https://github.com/zcash/zcash/blob/master/src/rpcmining.cpp
```
// Wallet or miner address is required because we support coinbasetxn
if (GetArg("-mineraddress", "").empty()) {
#ifdef ENABLE_WALLET
if (!pwalletMain) {
throw JSONRPCError(RPC_METHOD_NOT_FOUND, "Wallet disabled and -mineraddress not set");
}
#else
throw JSONRPCError(RPC_METHOD_NOT_FOUND, "zcashd compiled without wallet and -mineraddress not set");
#endif
}
```
so the macro should be removed from `src/rpcserver.cpp`, otherwise you can't call `getblocktemplate` when you disable wallet.
2017-06-20 01:15:15 -07:00
Jack Grigg
b1eb4f251a
Fix comment
2017-06-20 19:54:11 +12:00
Homu
00fd23930b
Auto merge of #2443 - str4d:1621-priority-download-path, r=str4d
...
Rename FALLBACK_DOWNLOAD_PATH to PRIORITY_DOWNLOAD_PATH
Closes #1621 .
2017-06-19 23:46:44 -07:00
Simon
d8616d012a
Partial revert & fix for commit 9e84b5a
; code block in wrong location.
2017-06-19 21:11:34 -07:00
Jack Grigg
4ef014151d
Additional testing of -mempooltxinputlimit
2017-06-20 15:58:46 +12:00
Kevin Pan
26d27a15ce
"getblocktemplate" could work without wallet
2017-06-20 10:41:46 +08:00
Daira Hopwood
c2a722d3c4
Fix a comment that was made stale before launch by #1016 (commit 542da61
).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-19 16:33:18 +01:00
Daira Hopwood
00fde35b1c
Make transaction test failures print the comments preceding the test JSON.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-19 16:33:18 +01:00
Daira Hopwood
4a785b0a5b
Repair tests for strict DER signatures.
...
While we're at it, repair a similar test for CLTV, and make the repaired RPC tests run by default.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-19 16:32:15 +01:00
Simon
9e84b5aa0d
Check mempooltxinputlimit when creating a transaction to avoid local
...
mempool rejection.
2017-06-17 14:41:25 -07:00
Daira Hopwood
de609b8c54
Strict DER signatures are always enforced; remove the flag and code that used it.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-17 17:19:08 +01:00