zec
/
halo2
mirror of https://github.com/zcash/halo2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix omitted notation to explicitly designate l_last and l_blind as polynomials.

This commit is contained in:
Sean Bowe 2021-07-13 16:30:52 -06:00
parent 4cd0bffc8e
commit 74f3e1c6d9
No known key found for this signature in database
GPG Key ID: 95684257D8F8B031
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/plonk/lookup.rs
View File

@ -36,7 +36,7 @@ impl<F: Field> Argument<F> {
//
// Enable the permutation argument for only the rows involved.
// degree (2 + input_degree + table_degree) or 4, whichever is larger:
// (1 - (l_last + l_blind)) * (
// (1 - (l_last(X) + l_blind(X))) * (
// z(\omega X) (a'(X) + \beta) (s'(X) + \gamma)
// - z(X) (\theta^{m-1} a_0(X) + ... + a_{m-1}(X) + \beta) (\theta^{m-1} s_0(X) + ... + s_{m-1}(X) + \gamma)
// ) = 0
@ -48,7 +48,7 @@ impl<F: Field> Argument<F> {
// Either the two values are the same, or the previous
// value of a' is the same as the current value.
// degree 3:
// (1 - (l_last + l_blind)) * (a′(X) − s′(X))⋅(a′(X) − a′(\omega^{-1} X)) = 0
// (1 - (l_last(X) + l_blind(X))) * (a′(X) − s′(X))⋅(a′(X) − a′(\omega^{-1} X)) = 0
let mut input_degree = 1;
for expr in self.input_expressions.iter() {
input_degree = std::cmp::max(input_degree, expr.degree());

2
src/plonk/lookup/prover.rs
View File

@ -444,7 +444,7 @@ impl<'a, C: CurveAffine> Committed<C> {
(self.product_coset.clone() * &self.product_coset - &self.product_coset)
* &pk.l_last,
))
// (1 - (l_last + l_blind)) * (
// (1 - (l_last(X) + l_blind(X))) * (
// z(\omega X) (a'(X) + \beta) (s'(X) + \gamma)
// - z(X) (\theta^{m-1} a_0(X) + ... + a_{m-1}(X) + \beta) (\theta^{m-1} s_0(X) + ... + s_{m-1}(X) + \gamma)
// ) = 0

4
src/plonk/lookup/verifier.rs
View File

@ -161,7 +161,7 @@ impl<C: CurveAffine> Evaluated<C> {
Some(l_last * &(self.product_eval.square() - &self.product_eval)),
)
.chain(
// (1 - (l_last + l_blind)) * (
// (1 - (l_last(X) + l_blind(X))) * (
// z(\omega X) (a'(X) + \beta) (s'(X) + \gamma)
// - z(X) (\theta^{m-1} a_0(X) + ... + a_{m-1}(X) + \beta) (\theta^{m-1} s_0(X) + ... + s_{m-1}(X) + \gamma)
// ) = 0
@ -172,7 +172,7 @@ impl<C: CurveAffine> Evaluated<C> {
l_0 * &(self.permuted_input_eval - &self.permuted_table_eval),
))
.chain(Some(
// (1 - (l_last + l_blind)) * (a′(X) − s′(X))⋅(a′(X) − a′(\omega^{-1} X)) = 0
// (1 - (l_last(X) + l_blind(X))) * (a′(X) − s′(X))⋅(a′(X) − a′(\omega^{-1} X)) = 0
(self.permuted_input_eval - &self.permuted_table_eval)
* &(self.permuted_input_eval - &self.permuted_input_inv_eval)
* &active_rows,

2
src/plonk/permutation.rs
View File

@ -34,7 +34,7 @@ impl Argument {
// following will not affect the required degree of
// this middleware.
//
// (1 - (l_last + l_blind)) * (
// (1 - (l_last(X) + l_blind(X))) * (
// z(\omega X) \prod (p(X) + \beta s_i(X) + \gamma)
// - z(X) \prod (p(X) + \delta^i \beta X + \gamma)
// )

2
src/plonk/permutation/prover.rs
View File

@ -259,7 +259,7 @@ impl<C: CurveAffine> Committed<C> {
.collect::<Vec<_>>(),
)
// And for all the sets we enforce:
// (1 - (l_last + l_blind)) * (
// (1 - (l_last(X) + l_blind(X))) * (
// z_i(\omega X) \prod_j (p(X) + \beta s_j(X) + \gamma)
// - z_i(X) \prod_j (p(X) + \delta^j \beta X + \gamma)
// )

2
src/plonk/permutation/verifier.rs
View File

@ -146,7 +146,7 @@ impl<C: CurveAffine> Evaluated<C> {
.map(move |(set, prev_last)| (set - &prev_last) * &l_0),
)
// And for all the sets we enforce:
// (1 - (l_last + l_blind)) * (
// (1 - (l_last(X) + l_blind(X))) * (
// z_i(\omega X) \prod (p(X) + \beta s_i(X) + \gamma)
// - z_i(X) \prod (p(X) + \delta^i \beta X + \gamma)
// )