mirror of https://github.com/zcash/halo2.git
Apply suggestions from code review
Co-authored-by: str4d <jack@electriccoin.co>
This commit is contained in:
parent
98f5b17359
commit
bc9d05e67b
|
@ -92,7 +92,7 @@ impl<C: CurveAffine> VerifyingKey<C> {
|
||||||
|
|
||||||
// Hash in final Blake2bState
|
// Hash in final Blake2bState
|
||||||
transcript.common_scalar(C::Scalar::from_bytes_wide(
|
transcript.common_scalar(C::Scalar::from_bytes_wide(
|
||||||
hasher.finalize().as_bytes().try_into().unwrap(),
|
hasher.finalize().as_array(),
|
||||||
))?;
|
))?;
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
|
@ -103,7 +103,7 @@ impl<C: CurveAffine> std::fmt::Display for VerifyingKey<C> {
|
||||||
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
|
||||||
write!(
|
write!(
|
||||||
f,
|
f,
|
||||||
"VerificationKey {{\
|
"VerificationKey {{ \
|
||||||
base_modulus = {base_modulus}, \
|
base_modulus = {base_modulus}, \
|
||||||
scalar_modulus = {scalar_modulus}, \
|
scalar_modulus = {scalar_modulus}, \
|
||||||
domain = {domain}, \
|
domain = {domain}, \
|
||||||
|
|
|
@ -384,7 +384,7 @@ impl<F: PrimeField> std::fmt::Display for ConstraintSystem<F> {
|
||||||
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
|
||||||
write!(
|
write!(
|
||||||
f,
|
f,
|
||||||
"ConstraintSystem {{\
|
"ConstraintSystem {{ \
|
||||||
num_fixed_columns: {num_fixed_columns}, \
|
num_fixed_columns: {num_fixed_columns}, \
|
||||||
num_advice_columns: {num_advice_columns}, \
|
num_advice_columns: {num_advice_columns}, \
|
||||||
num_instance_columns: {num_instance_columns}, \
|
num_instance_columns: {num_instance_columns}, \
|
||||||
|
|
|
@ -381,7 +381,7 @@ impl<G: Group> std::fmt::Display for EvaluationDomain<G> {
|
||||||
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
|
||||||
write!(
|
write!(
|
||||||
f,
|
f,
|
||||||
"Domain {{\
|
"Domain {{ \
|
||||||
k = {k:?}, \
|
k = {k:?}, \
|
||||||
extended_k = {extended_k:?}, \
|
extended_k = {extended_k:?}, \
|
||||||
omega = {omega:?} \
|
omega = {omega:?} \
|
||||||
|
|
Loading…
Reference in New Issue