Commit Graph

129 Commits

Author SHA1 Message Date
Marek 507aed8a54 Change "strict subgroups" to "proper subgroups" 2021-09-05 18:58:45 +02:00
parazyd 1b0a22096b
book: Fix rendering of cost-model output.
This should stop html tags appearing inside the <code> tags.
2021-07-31 15:24:50 +02:00
Daira Hopwood 20c347b269
Merge pull request #320 from daira/book-zk-changes
[Book] Zero knowledge changes (and misc cleanups)
2021-07-12 20:35:20 +01:00
Daira Hopwood 103c93391d Clarify the statement about the δ^i being distinct quadratic non-residues.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 17:24:21 +01:00
Daira Hopwood 8ac20608e4 Merge branch 'kw-halo-book' into book-zk-changes
Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:32:36 +01:00
Daira Hopwood 06ff90ba95 Rename UPA to PLONKish.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:12:58 +01:00
Daira Hopwood 6a11c2b97e Update the circuit commitments section for the changes to the permutation argument.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:03:41 +01:00
Daira Hopwood 1b3241d757 Clarify product argument and add a diagram.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:03:41 +01:00
Daira Hopwood fedcc1960d Permutation argument cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood 69ca38d2b1 Update permutation argument for zero knowledge changes in #316.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood 25b42a531d Follow https://github.com/zcash/halo2/pull/316 and https://github.com/zcash/orchard/issues/143
in using 1 - Z(X) instead of Z(X) - 1.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood 0dbf7cf4af Match the order of q_last and q_blind in the implementation.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood 5deb3fcd72 Lookup argument cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood 55c48007c9 Update lookup argument for zero knowledge changes in #316.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Jack Grigg 5fe6323a8d book: Add note about efficient FFTs for Pallas and Vesta 2021-07-09 19:53:41 +01:00
Jack Grigg fe4996af35 book: Add a note about the multiplicative subgroups we use for Halo 2 2021-07-09 17:48:43 +01:00
Jack Grigg 9f77c93d4e book: Fix definition of the nth roots of unity 2021-07-09 17:48:03 +01:00
therealyingtong 69e7fb8221 [book] Fix Sarkar square root explanation 2021-06-30 19:31:23 +08:00
Jack Grigg 7379e96a70 book: Use M for number-of-circuit-instances in proof encoding 2021-06-01 17:26:00 +01:00
Jack Grigg 9a7f331f1b book: Document k constant in proof encodings 2021-06-01 14:05:33 +01:00
Jack Grigg 4b362669e4 book: Document encoding of proofs
Closes zcash/halo2#144.
2021-05-28 02:21:58 +01:00
Jack Grigg 081e353681 book: Move implementation notes about proofs into a subsection 2021-05-28 01:13:20 +01:00
str4d e4072e78ce
Merge pull request #234 from zcash/book-point-addition
[book] Point addition and compression background
2021-05-27 22:37:06 +01:00
str4d 36cd8633e2
book: Adjustments to point addition and compression sections 2021-05-27 18:43:24 +01:00
str4d 15c79bcd89
Merge pull request #260 from zcash/book-chip-refactor
[book] Remove core/chip abstraction
2021-05-27 18:23:25 +01:00
Jack Grigg 7cb2e6a954 book: Fix CI failure 2021-05-18 20:19:31 +01:00
Jack Grigg a1c067e555 book: Add page describing developer tools 2021-05-18 14:51:54 +01:00
therealyingtong dd32a962b8 Remove core/chip abstraction
We now directly compose chips in a hierarchy.
2021-05-06 20:21:16 +08:00
therealyingtong d7b88addd9 [book] Point compression background section 2021-03-30 04:29:35 +08:00
therealyingtong c3c80cd0a1 [book] Point addition background section 2021-03-29 23:08:56 +08:00
Daira Hopwood 532e5eb11c Fixed columns are not necessarily selector columns.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:14:38 +00:00
Daira Hopwood 25616616e3 "Copy constraints" -> "equality constraints". (There were no other uses of this terminology.)
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:14:12 +00:00
Daira Hopwood 2f34318510 Fix mistaken use of "extended domain" in the permutation argument section, and improve wording.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:13:11 +00:00
Daira Hopwood 8fbf20beae The algorithm for constructing the permutation needs to update the sizes array when merging cycles.
Thanks to @porcuquine for spotting this. (The implementation is correct.)

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:06:09 +00:00
Jack Grigg 2f21135e68 book: Note that none of the documented gadgets have been reviewed 2021-02-25 20:05:19 +00:00
Jack Grigg 668bd8e89a book: Tidy up Sarkar explanation and make adjustments for clarity 2021-02-23 14:01:47 +00:00
Jack Grigg b2d91140e7 book: Move Sarkar explanation into implementation section 2021-02-23 14:01:47 +00:00
ebfull 2e8af8f0ca
Merge pull request #198 from zcash/book-sarkar
[book] Add Sarkar sqrt explanation to Fields section
2021-02-22 16:39:23 -07:00
Jack Grigg 6717594c46 book: Render gtab and invtab as matrices 2021-02-19 01:13:16 +00:00
therealyingtong b148c34c10 [book] Add Sarkar sqrt explanation to Fields section 2021-02-19 00:21:05 +00:00
Daira Hopwood e2f20770bb Edits from pairing with @str4d. This fixes an error in Z_P for the equality constraint argument,
and also errors in the circuit commitments section.

Co-authored-by: Jack Grigg <jack@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-18 23:27:42 +00:00
Daira Hopwood ad771f89cb Book: improve the section explaining the permutation argument.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-17 21:26:39 +00:00
Daira Hopwood a73560c842 Book: cosmetics and minor corrections / wording improvements.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-17 17:10:11 +00:00
Daira Hopwood 07af9ea3e7 Book: generalize input columns to expressions in lookup argument.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-17 17:09:10 +00:00
str4d c10b84ce13
Merge pull request #187 from zcash/book-fixes
Book fixes
2021-02-17 06:53:10 +13:00
str4d e1a3cc5e9e
book: Evaluation points are elements of fields, not groups
Polynomials require both addition and multiplication, which fields have, whereas a group only specifies a single operation.
2021-02-17 06:46:28 +13:00
Daira Hopwood c769dd0fa6 Address @str4d's review comment about advice and instance columns being treated almost identically.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-15 15:08:29 +00:00
Jack Grigg ba9917e35c book: Linkify URLs in references 2021-02-15 14:38:46 +00:00
Jack Grigg cf68b5ba05 book: Clarify meaning of "evaluation point" in our context
Polynomial evaluation points and elliptic curve points are both things
we rely on, but never in the same context (we either use elliptic curve
points inside circuits, or implement proving systems on top of them).
2021-02-15 14:30:12 +00:00
Daira Hopwood 760d69bd2c Rename "auxiliary column" to "instance column" in the book and in code. fixes #181
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-14 21:09:49 +00:00