Sean Bowe
d8df7a12d5
Fix clippy lint on beta.
2021-07-10 08:52:30 -06:00
Sean Bowe
cc84e9bf52
Additional documentation suggestions from @str4d.
2021-07-10 08:47:57 -06:00
Sean Bowe
50768bff20
Add comment explaining the extra caution in minimum_rows().
2021-07-10 08:43:01 -06:00
Sean Bowe
9023161988
Add bounds check to Assignment::query_instance impls.
2021-07-10 08:25:00 -06:00
Sean Bowe
c4e2554654
Incorporate documentation improvements suggested by @str4d.
2021-07-10 08:20:34 -06:00
Sean Bowe
3942d4e2e8
(examples) Specify row when calling expose_public in simple-example.
2021-07-10 08:13:24 -06:00
Sean Bowe
1be7bf1df0
Address review comments from @daira.
2021-07-10 08:12:08 -06:00
Sean Bowe
20653acc39
Document `permutation::Argument::required_degree`.
2021-07-10 07:52:42 -06:00
Sean Bowe
fc946d99bf
Use Option in sanity-check rather than a random value.
2021-07-09 12:47:36 -06:00
Sean Bowe
9e6277ef6b
Make `usable_rows` temporary to avoid duplicative code.
2021-07-09 12:45:51 -06:00
Sean Bowe
326cae153e
Fix minor typos in comments.
2021-07-09 12:44:27 -06:00
Sean Bowe
90be1c29ab
Fix bug in sanity check during lookup argument witness creation.
2021-07-09 12:41:52 -06:00
Sean Bowe
bd29ebdb05
Use ranges to clarify bounds on cell assignment.
2021-07-09 12:38:38 -06:00
Sean Bowe
00b0b6c535
Add documentation for ConstraintSystem::num_advice_queries.
2021-07-09 09:28:45 -06:00
Sean Bowe
1c48ace3d9
Simplify l_last assignment.
2021-07-09 09:22:25 -06:00
Sean Bowe
7c66323d87
Rename l_cover to l_blind for clarity.
2021-07-09 09:22:25 -06:00
Sean Bowe
f89e27ad10
Address some comments from @daira.
2021-07-09 09:22:20 -06:00
Sean Bowe
e16aa31357
clippy fixes
2021-07-09 09:00:35 -06:00
Sean Bowe
8582731073
Build examples during CI bitrot check.
2021-07-08 15:33:03 -06:00
Sean Bowe
26739bbffe
Improvement to error messages for permutation argument failures in the mock prover.
2021-07-08 15:32:56 -06:00
Sean Bowe
0766983686
Fix examples to account for public input API changes.
2021-07-08 15:32:56 -06:00
Sean Bowe
b246897a8d
Add `constrain_instance` and `assign_advice_from_instance` APIs.
2021-07-08 15:32:56 -06:00
Sean Bowe
fe215d153d
Update tests with API changes for public inputs and permutation argument.
2021-07-08 15:32:51 -06:00
Sean Bowe
1f1b705fa6
Make lookup argument perfectly zero-knowledge and complete.
2021-07-08 14:52:44 -06:00
Sean Bowe
7afe549524
clippy fixes
2021-07-02 16:33:22 -06:00
Sean Bowe
32df26d881
Make permutation argument perfectly complete and zero-knowledge.
2021-07-02 16:20:36 -06:00
Sean Bowe
2ef2f7e73c
Change create_proof API to take vectors of scalars and compute polynomials internally.
2021-07-01 13:53:54 -06:00
Sean Bowe
1c586c081c
Switch directionality of the permutation argument's constraints.
2021-07-01 13:47:03 -06:00
Sean Bowe
9118697213
Additional comment about blinding h(X)
2021-07-01 13:01:39 -06:00
Sean Bowe
7fda6f672e
Always commit to a random polynomial that is evaluated at x in order to blind the multiopen evaluation of h(X).
2021-07-01 12:59:53 -06:00
Sean Bowe
fa2d0b061e
Remove unnecessary clones of fixed columns.
2021-07-01 12:52:27 -06:00
Sean Bowe
0a6804bb30
Compute the number of blinding factors each advice polynomial needs.
2021-07-01 12:48:01 -06:00
Sean Bowe
8eb3b7313c
Add support for computing ranges of evaluations of the Lagrange basis polynomials.
2021-07-01 12:46:22 -06:00
Sean Bowe
7bf2bbb941
Clippy fixes
2021-07-01 12:45:14 -06:00
Sean Bowe
fd91b6b42c
Allow MSMs to be queried and not just raw commitments.
...
This allows us to avoid some interstitial arithmetic in the vanishing argument.
2021-07-01 12:42:24 -06:00
Sean Bowe
f7ef626858
Linearize the h(X) check.
2021-06-30 10:11:53 -06:00
str4d
93aabf26c6
Merge pull request #310 from zcash/clippy-capitalized-acronyms
...
clippy: Fix capitalized acronyms in tests and examples
2021-06-23 16:28:38 +01:00
str4d
62414a92b6
Merge pull request #309 from zcash/dev-metadata
...
dev: Refactor VerifyFailure to extract metadata structs
2021-06-23 16:28:25 +01:00
Jack Grigg
e262941b70
clippy: Fix capitalized acronyms in tests and examples
2021-06-23 13:33:04 +01:00
str4d
305ca89bab
Merge pull request #302 from daira/clippy-nightly-clean
...
Make this crate clippy clean for warnings on nightly
2021-06-23 13:30:07 +01:00
str4d
3c24e6b811
Merge pull request #306 from zcash/final-transcript-changes
...
Final transcript changes
2021-06-23 13:28:53 +01:00
Jack Grigg
32edf65efa
dev: Refactor VerifyFailure to extract metadata structs
2021-06-23 13:16:20 +01:00
str4d
b88435712f
Merge pull request #305 from zcash/integrate-layouter-with-circuit
...
Introduce a FloorPlanner trait and integrate it into the Circuit trait
2021-06-22 23:53:24 +01:00
Jack Grigg
6d0017f47c
Introduce a FloorPlanner trait and integrate it into the Circuit trait
...
This is the beginning of the process to enable full floor planning
capabilities in `halo2`. For now, all that a floor planner can do is
synthesize a circuit, which makes it no more powerful than a layouter,
but easier to use (as moving to a multi-pass layouter no longer requires
changes to `Circuit::synthesize`).
2021-06-22 23:47:17 +01:00
str4d
2474647af0
Merge pull request #304 from zcash/reduce-fieldext
...
Reduce various trait requirements from `FieldExt` to `Field`
2021-06-22 23:42:54 +01:00
str4d
be6db1f489
Merge pull request #303 from zcash/migrate-plonk-examples
...
Migrate PLONK-gate-using circuits to use SingleChipLayouter
2021-06-22 23:42:11 +01:00
Sean Bowe
6194b49dee
Make prover messages unambiguous and alter the manner in which challenges are squeezed.
2021-06-22 14:06:02 -06:00
Sean Bowe
7211d78dfe
Minor improvements to the transcript implementation.
2021-06-22 13:51:31 -06:00
Jack Grigg
f5bd3109eb
Reduce various trait requirements from `FieldExt` to `Field`
2021-06-22 00:35:57 +01:00
Jack Grigg
1b04877b3d
Migrate PLONK-gate-using circuits to use SingleChipLayouter
...
These were all early examples that used the Circuit trait without any
layouter, which is incompatible with upcoming changes.
The minimal change to the PinnedVerificationKey is because the lookup
table is being allocated at the top of its columns instead of in-place.
2021-06-22 00:22:12 +01:00