572563338b
Add a protobuf representation for transaction proposals.
...
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2023-11-09 20:02:36 -07:00
2d6a02eb2d
Merge pull request #1039 from zcash/736-refactor-sapling-components
...
Refactor Sapling components and builder into `zcash_primitives::sapling`
2023-11-09 20:00:32 -07:00
c6dd9ad858
zcash_primitives: Expose Sapling bundle component parsers needed by zcashd
...
These can be removed after future zcashd refactors.
2023-11-10 02:09:22 +00:00
68ae453e5d
zcash_primitives: Move Sapling bundle parsing into `transaction::components::sapling`
2023-11-10 02:09:22 +00:00
e1a5539094
zcash_primitives: Rework Sapling parsers to be plain functions
...
Once `zcash_primitives::sapling` is extracted to `sapling-crypto`, these
would have become orphan impls.
2023-11-10 01:06:18 +00:00
6077a712e4
Merge pull request #1024 from nuttycom/wallet/orchard_block_metadata
...
zcash_client_backend: Add Orchard note commitment tree size to block metadata.
2023-11-09 15:44:56 -07:00
7720a4fc58
zcash_client_backend::scanning: Use `checked_sub` instead of manual check.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2023-11-09 15:09:54 -07:00
09e37bcc8d
Fix comment in zcash_client_backend::scanning
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-11-09 14:00:50 -07:00
b9ac7c5eda
zcash_client_backend: Fix off-by-one in tree heights at NU activation.
2023-11-09 09:44:57 -07:00
54eb03e34e
zcash_primitives: Move Sapling bundle types into `sapling` module
2023-11-09 04:04:07 +00:00
f5595122f9
zcash_primitives: Move `builder` module to `zcash_primitives::sapling`
2023-11-09 04:02:19 +00:00
74c12ea9ec
Merge pull request #1038 from nuttycom/fix_doc_link
...
zcash_client_sqlite: Fix broken intra-doc link on `unstable` feature.
2023-11-08 17:47:51 -07:00
1eafb046ae
Merge pull request #1037 from nuttycom/update_dependencies
...
Update `Cargo.lock` file with upgraded dependency versions.
2023-11-08 17:47:05 -07:00
1ab411ada8
zcash_client_sqlite: Fix broken intra-doc link on `unstable` feature.
2023-11-08 17:31:23 -07:00
1b9eaa8694
Update `Cargo.lock` file with upgraded dependency versions.
2023-11-08 17:00:39 -07:00
8ce8cc8145
zcash_client_backend: Remove duplicative continuity checks.
2023-11-08 16:46:44 -07:00
ae4cb53c49
Apply suggestions from code review
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-11-08 16:46:44 -07:00
27f78d1894
zcash_client_backend: Add Orchard note commitment tree size to block metadata.
2023-11-08 16:46:44 -07:00
64d657ed31
Merge pull request #1033 from zcash/sapling-params-refactor
...
Introduce newtypes for Sapling circuit parameters
2023-11-08 21:01:30 +00:00
e4b9d73d0c
Merge pull request #1003 from nuttycom/wallet/reusable_input_selection
...
zcash_client_backend: Factor out `InputSource` from `WalletRead`
2023-11-08 20:20:03 +00:00
aa063ae3fd
zcash_client_backend: Factor out input source traits from `WalletRead`
...
Prior to this change, it's necessary to implement the entirety of the
`WalletRead` trait in order to be able to use the input selection
functionality provided by `zcash_client_backend::data_api::input_selection`.
This change factors out the minimal operations required for transaction
proposal construction to better reflect the principle of least authority
and make the input selection code reusable in more contexts.
In order to minimize the operations of the newly-created `InputSource`
and `ShieldingSource` traits, this change also removes the
`min_confirmations` field from transaction proposals, in favor of
storing explicit target and anchor heights. This has the effect of
limiting the lifetime of transaction proposals to `PRUNING_DEPTH -
min_confirmations` blocks.
2023-11-08 12:41:49 -07:00
c915c93862
Merge pull request #1017 from nuttycom/test_with_bundled_prover
...
Test with bundled prover instead of local prover.
2023-11-07 13:14:47 -07:00
c56ab0001e
Fix intra-doc link
2023-11-07 03:11:38 +00:00
82535112c2
zcash_primitives: Add Sapling verification key newtypes
2023-11-07 03:11:15 +00:00
1b9f26c984
Move `{Spend,Output}Parameters` from `zcash_proofs` to `zcash_primitives`
2023-11-07 03:09:25 +00:00
8bb9c4e7ba
Move Sapling proof verifiers from `zcash_proofs` to `zcash_primitives`
2023-11-07 03:08:43 +00:00
7b4a0d858d
Merge pull request #1036 from zcash/sapling-builder-markers-clone
...
zcash_primitives: Implement `Clone` on bundle marker types
2023-11-05 19:13:54 +00:00
3b8c932ab9
zcash_primitives: Implement `Clone` on bundle marker types
...
This enables unauthorized Sapling bundles to be cloned, for example when
loading them into a `TransactionData` for signature hashing.
2023-11-04 04:27:07 +00:00
7d1c0a29ca
Merge pull request #1035 from zcash/ci-reliable-wasm32-builds
...
CI: Build `wasm32-wasi` in a synthetic crate
2023-11-03 18:35:14 -06:00
c846fba564
CI: Build `wasm32-wasi` in a synthetic crate
...
This target is incompatible with various crates that we use for testing.
However, when those crates are enabled via dev-dependencies, they become
part of the build graph and prevent us from building the regular code.
Downstream crates don't inherit dev-dependencies, so we simulate this
directly in CI.
2023-11-03 23:57:10 +00:00
bf8868ca91
Merge pull request #1031 from zcash/sapling-prover-cleanups
...
Sapling prover cleanups
2023-11-03 22:23:29 +00:00
c0a0ef1653
zcash_proofs: Remove obsolete examples.
...
Since we now use the bundled prover everywhere, we no longer need
utilities to download Zcash parameters, which was the only purpose that
these examples were serving.
2023-11-03 16:15:24 -06:00
ea7c608f45
Remove parameters download step from github CI
...
Now that the tests use the bundled prover, we no longer need them to
download the zcash parameters files.
2023-11-03 16:13:38 -06:00
e27dcf498e
Use the bundled prover rather than local params files for testing by default.
...
`fetch_params.sh` is now deprecated and the bundled proving parameters
from `wagyu-zcash-parameters` are used everywhere, so the tests should
follow suit.
Fixes #1016
2023-11-03 16:13:34 -06:00
6e42d839cd
zcash_proofs: Remove `sapling::SaplingProvingContext`
2023-11-03 21:09:19 +00:00
b20641ae58
zcash_primitives: Remove `sapling::prover::TxProver`
...
Removed
-------
- `zcash_primitives::sapling`:
- `prover::TxProver` (use `SpendProver` and `OutputProver` instead).
- `prover::mock::MockTxProver` (use `MockSpendProver` and `MockOutputProver`
instead).
2023-11-03 21:08:37 +00:00
7154e65864
Merge pull request #1030 from zcash/changelog-cleanups
...
Changelog cleanups
2023-11-03 14:49:45 -06:00
8e0e77b0a0
zcash_client_backend: Remove `fees::ChangeError::map` from the public API
...
It is undocumented, unused outside of this crate, and unreleased, so we
make it crate-private for now.
2023-11-03 00:56:56 +00:00
a77b6c631c
Add missing unreleased changelog entries
2023-11-03 00:56:56 +00:00
bed5bc6cf6
Clean up unreleased changelog entries
2023-11-03 00:56:26 +00:00
44c64e1fb9
Merge pull request #1023 from zcash/741-sapling-builder-refactor
...
Refactor Sapling builder to separate out proof generation
2023-11-02 23:41:31 +00:00
b2ff29db78
Refactor Sapling builder to separate out proof generation
...
Closes zcash/librustzcash#741 .
2023-10-31 22:01:34 +00:00
13fb0a4819
Merge pull request #1019 from nuttycom/wallet/proposals_with_minconf
...
zcash_client_backend: Move `min_confirmations` into `Proposal`
2023-10-31 12:59:40 -06:00
4cd26b7ea9
zcash_client_backend: Move `min_confirmations` into `Proposal`
...
This fixes an API issue whereby it was possible to execute a `Proposal`
with a different value of `min_confirmations` than that with which the
`Proposal` was constructed.
2023-10-31 10:38:52 -06:00
be8daefb84
Merge pull request #1026 from nuttycom/wallet/remove_extfvk_api
...
zcash_client_backend: remove `WalletRead::is_valid_account_extfvk`
2023-10-28 19:21:58 +01:00
a0935b5ecd
zcash_client_backend: remove `WalletRead::is_valid_account_extfvk`
2023-10-27 15:01:26 -06:00
9627c806e4
zcash_client_backend: Pass `Proposal` values by reference.
2023-10-26 16:11:10 -06:00
113f558b1f
Merge pull request #1018 from nuttycom/wallet/standard_fee_rule
...
Add an enumeration of standard fee rules.
2023-10-26 16:10:26 -06:00
570ea48588
Apply suggestions from code review
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-26 15:24:45 -06:00
f1c08693a5
zcash_client_backend: Add propose_standard_transfer.
2023-10-25 08:08:49 -06:00
sasha
Kris Nuttycombe
Jack Grigg
Kris Nuttycombe
Daira Emma Hopwood