zec
/
librustzcash
mirror of https://github.com/zcash/librustzcash.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
2,272 Commits 13 Branches 89 Tags 45 MiB
Commit Graph

123 Commits

Author SHA1 Message Date
Jack Grigg 144512b547 Migrate to `ff 0.12` 2022-05-06 20:03:49 +00:00
Jack Grigg 4674291fd9 zcash_proofs: Silence clippy 1.54.0 lint 2022-02-16 00:03:07 +00:00
Jack Grigg dbfa673500 Merge branch 'non-consensus-changes-on-branchid-37519621' into merge-non-consensus-changes-again 2022-02-14 18:11:09 +00:00
Dimitris Apostolou e600d7b917
Fix typos 2022-02-03 20:15:32 +02:00
Kris Nuttycombe a304c3953b Fix Clippy beta linting complaints. 2022-02-02 16:02:45 -07:00
Jack Grigg 65e1d32774 ff 0.11, group 0.11, etc. 2021-09-09 18:20:37 +01:00
Jack Grigg e2fb5e6402 Impl ZIP 216 on SaplingVerificationContext and redjubjub::PublicKey 
`PublicKey::verify` now always uses post-ZIP 216 validation rules, which
is fine in non-consensus contexts.

`SaplingVerificationContext` is used by `zcashd`'s consensus rules.
 2021-06-06 23:45:15 +01:00
Jack Grigg 1222391dd7 Migrate to bitvec 0.22, ff 0.10, etc. 
Requires patching three dependencies:

- bellman is pending a new release.
- nom is part of the funty breakage; we are blocking on a new release.
- orchard is in development.
 2021-06-04 22:02:48 +01:00
Jack Grigg 5623e02a7c Migrate to ff 0.9 et al. 2021-05-19 18:29:37 +01:00
Jack Grigg 63db2729e9 Temporarily allow clippy::result_unit_err lint 
Fixing these lints is deferred to zcash/librustzcash#367.
 2021-03-27 19:01:03 +13:00
Jack Grigg 636845d0f9 Renames to use lower-case abbreviations (matching Rust convention) 
As of our MSRV bump to 1.51.0, we get lints for this.
 2021-03-27 19:01:03 +13:00
Kris Nuttycombe 4086df772c Move sapling-specific primitives into the sapling module. 2021-03-27 16:18:21 +13:00
Kris Nuttycombe bc087a5ff7 Move pedersen hashes to sapling module. 2021-03-27 16:18:21 +13:00
Kris Nuttycombe 16948d9d78 Move zcash_primitives::prover to sapling module 2021-03-27 16:18:21 +13:00
Kris Nuttycombe bf97b21632 Move redjubjub to sapling module. 2021-03-27 16:18:21 +13:00
Jack Grigg 38f7a0330c Fix various clippy lints 
The remainder will be fixed after the refactor PRs are merged.
 2021-03-27 08:50:40 +13:00
Jack Grigg 9d9c0579f8 Use new name for broken_intra_doc_links lint 
We also add the lint to crates in the workspace that didn't have it.

Closes zcash/librustzcash#279.
 2021-03-27 08:27:17 +13:00
Kris Nuttycombe 3423b03c6d Fix a couple more lints. 2021-02-04 07:31:00 -07:00
Kris Nuttycombe 98530184c0 Fix clippy complaints. 2021-02-03 14:27:31 -07:00
François Garillot f5b6fa6dfb
Removes a panic in synthesis 
The error case - a witness_256 failure - is folded in the SynthesisError case of its enclosing result.

The panic was found with [comby-rust](https://github.com/huitseeker/comby-rust/blob/master/nopanic.toml) (using the nopanic template).
 2021-02-01 13:37:56 -05:00
Kris Nuttycombe 7d92150965 Fix test compilation with WalletWrite changes. 2021-01-11 18:13:40 -07:00
Kris Nuttycombe aad2e174c1 Consistently use nullifier and AccountId newtypes. 2021-01-08 21:49:38 -07:00
Jack Grigg 91796adcda Remove wrapping closures around mapping functions 2020-10-30 14:10:35 +00:00
Jack Grigg 025deda712 impl Default for T on types with T::new() 2020-10-30 14:10:35 +00:00
Jack Grigg 44cbc6cc6d Remove unnecessary references 2020-10-30 14:10:35 +00:00
Jack Grigg 0cb51f963c Remove unnecessary clones 2020-10-30 13:51:40 +00:00
adityapk00 b8aa2d9169 Build prover with byte arrays of params 2020-10-20 11:49:42 -07:00
narodnik 6297087a5d Mark EDWARDS_D, MONTGOMERY_A, MONTGOMERY_SCALE and PEDERSEN_CIRCUIT_GENERATORS as public only within the crate. 2020-09-21 22:59:38 +02:00
narodnik 81e3ab1c91 make fixed generator functions publicly accessible 2020-09-20 21:01:39 +02:00
Jack Grigg 96bd59b942 Migrate to ff 0.8 and bellman 0.8 
bellman 0.8 includes fixes for several performance regressions.

MSRV is now 1.44.0, matching the ff crate.
 2020-09-09 00:27:51 +01:00
Jack Grigg cda56ef862 zcash_proofs: Add feature flags to docs.rs documentation 2020-08-23 12:12:11 +01:00
Daira Hopwood 74abb88dce Fix some comments. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2020-08-22 01:28:13 +01:00
Daira Hopwood 9e0041c497 Consistently use (u, v) for affine-ctEdwards coordinates. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2020-08-22 01:28:13 +01:00
Daira Hopwood cfed47c176 Rename ValueCommitment.cm() to .commitment() (because it's confusing to have cm referring to both note and value commitments). 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2020-08-22 01:28:13 +01:00
Daira Hopwood 20c5096793 Fix remaining cases of cm -> cmu. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2020-08-22 01:28:13 +01:00
Jack Grigg 24c61f9417 zcash_proofs: Remove unnecessary comment 
Likely left over from the Sapling audit.
 2020-08-21 18:37:51 +01:00
Jack Grigg d15acf8acc zcash_primitives: Rename Note::cm to Note::cmu 2020-08-21 18:35:04 +01:00
Jack Grigg b9a8e1e415 zcash_primitives: Remove Jubjub implementation 
We now use the jubjub crate for this.
 2020-08-19 23:08:19 +01:00
Jack Grigg fdf06032e3 s/{pairing::bls12_381, zcash_primitives::jubjub}/{bls12_381, jubjub} 
FINALLY.
 2020-08-19 23:08:19 +01:00
Jack Grigg 315f00d6d4 zcash_proofs: Define generator constants using new crates 
Includes tests to ensure that the new generator constants match the
current zcash_primitives::JUBJUB generators.
 2020-08-19 23:08:19 +01:00
Daira Hopwood 81c3b54b24
Merge pull request #258 from therealyingtong/zip212-esk-plaintext-impl 
ZIP212 implementation
 2020-08-12 10:19:08 +01:00
Henry de Valence 139fc09f10
bellman: add VerificationError (#254) 
* bellman: add VerificationError

This adds a distinct VerificationError type to the crate and changes
`verify_proof` to return `Result<(), VerificationError>` rather than
`Result<bool, SynthesisError>`.  This is significantly safer, because it avoids
the need to mix pattern-matching logic with boolean logic (the cause of
RUSTSEC-2019-0004).

* Rename VerificationError variants per review comments.

* Add missing Clone impl to VerificationError.
 2020-08-05 22:26:31 +12:00
therealyingtong 0a47a9dbea
Pass rseed to Prover 2020-08-04 16:40:53 +08:00
therealyingtong 895e251793
Fix tests 2020-07-31 22:40:48 +08:00
therealyingtong 65504d9ca7
Add enum Rseed<E::Fs> to Note struct 2020-07-31 22:28:40 +08:00
Jack Grigg c921cfcf97 zcash_proofs: Add LocalProver::bundled 
Requires the bundled-prover feature, which enables the
wagyu-zcash-parameters crate and adds around 50 MiB to the overall
binary size. That crate bundles the same Sapling parameter files we
normally obtain from disk, so we constrain them to match the same
hard-coded hashes.
 2020-07-10 22:15:23 +12:00
Jack Grigg bbc3ec54c7 CI: Fetch and cache Sapling parameters for tests 2020-06-27 00:46:05 +12:00
Jack Grigg 9012672164 zcash_proofs: Add API for downloading the Sapling parameters 
Includes an example that exposes the API as a binary.
 2020-06-27 00:45:12 +12:00
Jack Grigg e910788e8e zcash_proofs: Extract default params folder logic 2020-06-27 00:45:12 +12:00
Jack Grigg 0b2293bcc0 bellman: Replace E: ScalarEngine with Scalar: PrimeField 
Instead of imposing the requirement that bellman users explicitly
specify an engine for every proving system, we allow the Rust type
system to figure it out for us. An engine is specifically useful in
places where we require defined relationships between several types;
ff::ScalarEngine only has one type, and thus any usage of it can be
trivially replaced by an explicit Scalar type. This is also more
readable :)
 2020-05-31 02:00:10 +12:00