abd63166c0
Apply suggestions from code review
...
Co-authored-by: str4d <jack@electriccoin.co>
2022-03-11 17:17:21 -07:00
71657b4f18
Generalize vector and array writes & reads.
...
In a number of places, we transform other kinds of collections with
known length information into vectors simply to be able to use them with
`Vector::write` or `Vector::read`. We can avoid these extra allocations
by writing from iterators directly, and similarly by reading directly
into our desired collection types.
2022-03-11 16:48:28 -07:00
d602c01ef6
Standardize how we write and read usize values for incrementalmerkletree.
...
Also, make consistent use of helper functions for reading
and writing `Position` values.
2022-03-11 16:48:28 -07:00
2d34ac5654
Update incrementalmerkletree version.
2022-03-11 16:48:28 -07:00
cd9274aa6f
Merge pull request #517 from zcash/update-orchard
...
Update `orchard` crate
2022-02-28 23:18:56 +00:00
22ebe95de6
zcash_primitives: Replace custom `Debug` impl on `TransactionData`
2022-02-28 22:39:43 +00:00
bdaad53832
Update `orchard` revision
2022-02-28 21:34:03 +00:00
cfb49cfd52
Merge pull request #516 from nuttycom/update_incrementalmerkletree
...
Update the versions of incrementalmerkletree & orchard.
2022-02-24 20:55:22 +00:00
b97d777361
Update the versions of incrementalmerkletree & orchard.
...
This removes unreleased incrementalmerkletree::BridgeTree serialization
that was zcashd-specific.
2022-02-24 13:54:31 -07:00
600c06a408
Update MSRV to 1.56.1
2022-02-24 12:26:14 -07:00
3d935a94e7
Merge pull request #507 from nuttycom/map_authorization
...
Define transaction::TransactionData::map_authorization
2022-02-12 03:22:09 +00:00
54e3dded92
Add `TransactionData::map_bundles`
...
This is needed for FFI-crossing in `zcashd`.
2022-02-12 02:59:18 +00:00
f590134ee8
Add transaction::Transaction::into_data
2022-02-11 15:29:44 -07:00
af9edcea25
Define transaction::TransactionData::map_authorization
2022-02-11 15:29:44 -07:00
caba2dc8b0
Merge pull request #508 from nuttycom/account_id_ord
...
Add missing trait impls for AccountId
2022-02-10 12:12:51 -07:00
e20de50b84
Make AccountId internal representation private.
2022-02-10 11:30:02 -07:00
970b6d6750
Add missing trait impls for AccountId
2022-02-10 09:12:18 -07:00
c07d82e360
Merge pull request #505 from zcash/zcash_address-cleanups
...
`zcash_address` cleanups
2022-02-03 00:28:22 +00:00
fa75c9587c
zcash_address: Avoid an unnecessary allocation while parsing a UA
2022-02-03 00:02:03 +00:00
4a30679491
f4jumble: Return `Error` from allocating functions
2022-02-03 00:02:03 +00:00
682d5235c2
Merge pull request #501 from nuttycom/fix_beta_lints
...
Fix Clippy beta linting complaints.
2022-02-02 23:31:33 +00:00
a304c3953b
Fix Clippy beta linting complaints.
2022-02-02 16:02:45 -07:00
4f4a25252f
Merge pull request #341 from nuttycom/autoshield-poc-daa
...
Add auto-shielding to the data access API
2022-02-02 14:26:05 -07:00
3699a6df97
Fix typos.
2022-02-02 14:00:05 -07:00
cdd899dda1
Fix documentation.
...
Co-authored-by: str4d <jack@electriccoin.co>
2022-02-02 12:53:59 -07:00
488d13fde3
Do not delete sent note data in rewind.
2022-02-02 12:48:22 -07:00
1507d1de0a
Fix incorrect construction of transparent OVKs.
2022-02-02 10:33:44 -07:00
b4ff3f368e
Add test vectors for transparent OVKs.
2022-02-02 10:33:44 -07:00
6b189f18ff
Correct the changelog relating to `store_decrypted_tx`
2022-02-02 10:33:44 -07:00
632b9ee22f
Merge pull request #494 from zcash/internal-key-tvs
...
Internal key test vectors
2022-02-02 10:33:44 -07:00
0c80399fe1
zcash_primitives::zip32::tests: Use internal test vectors.
2022-02-02 10:33:44 -07:00
cf4c982483
zcash_primitives::zip32: Include test vectors for internal key components.
2022-02-02 10:33:44 -07:00
9c2d485c80
Address comments from code review.
...
Co-authored-by: str4d <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-02 10:33:41 -07:00
2dd0348792
Remove the `nullifiers` argument from `store_decrypted_tx`
...
This value can be obtained internally within the implementation
of `store_decrypted_tx` and does not need to be part of the
public API.
2022-02-02 10:32:35 -07:00
41810e5be9
Merge remote-tracking branch 'upstream/non-consensus-changes-on-branchid-37519621' into autoshield-poc-daa
2022-02-02 10:32:35 -07:00
3d51c53d68
Address comments from code review.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-02 10:32:33 -07:00
8916a16f38
Replace ripemd160 dependency with ripemd
2022-02-02 10:30:43 -07:00
d0e1f98429
Use extension traits for transparent-related data api functionality.
2022-02-02 10:30:43 -07:00
5a75c210f0
Fix order of note deletion relative to transactions being un-mined in rewind.
2022-02-02 10:30:07 -07:00
e8e5d94ea6
Mark functions that will be made crate-private as deprecated
2022-02-02 10:29:19 -07:00
d52171768f
Merge pull request #496 from nuttycom/beta_lints
...
Use clippy beta instead of nightly
2022-02-01 15:55:47 +00:00
9940d275fb
Use clippy beta instead of nightly
2022-02-01 08:26:05 -07:00
9711fa227f
Merge pull request #495 from zcash/pin-protobuf
...
Restrict cargo to `protobuf >=2.20,<2.26`
2022-02-01 08:25:28 -07:00
e9ecb19143
Restrict cargo to `protobuf >=2.20,<2.26`
...
`protobuf 2.26.0` bumped its MSRV to 1.52.1, which is incompatible with
our current MSRV.
2022-02-01 14:26:47 +00:00
b3fbf2410d
Allow use of internal deprecated pubkey_to_address method.
2022-01-27 21:21:18 -07:00
2f1d3da26d
Update changelogs.
2022-01-27 16:25:01 -07:00
4057b066bd
ExtendedFullViewingKey::chain_code should not be public.
2022-01-27 16:18:26 -07:00
6e11f2d11a
Validate ZIP 321 request by roundtrip through the URI format.
...
Co-authored-by: str4d <jack@electriccoin.co>
2022-01-27 16:08:04 -07:00
544c4ed6bb
Remove unused zcash_address dependency.
2022-01-27 16:08:04 -07:00
a1e693d15f
Remove the Wif type; it should not be used.
...
We should attempt to avoid passing spending keys back and forth
across the FFI entirely, but in any case this is no longer the
correct type to use at this boundary; we should use the encoding
of the transparent component of a unified spending key instead.
2022-01-27 16:08:04 -07:00
Kris Nuttycombe
str4d
therealyingtong
Kris Nuttycombe