b54969953f
zcash_client_sqlite: Simplify range query in `replace_queue_entries`
...
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2023-09-08 03:43:07 +00:00
341379ee8d
Merge pull request #951 from nuttycom/wallet/balance_for_all_accounts
...
zcash_client_sqlite: Return a balance for every account from `get_wallet_summary`
2023-09-07 11:49:23 -06:00
8dfab23683
Merge pull request #946 from nuttycom/test/unspendable_chain_tip
...
zcash_client_sqlite: Add a test demonstrating chain tip fund unavailability
2023-09-07 11:27:51 -06:00
2131cd547e
zcash_client_sqlite: Return a balance for every account from `get_wallet_summary`
...
Fixes #948
2023-09-07 11:02:59 -06:00
0937c6a384
zcash_client_sqlite: Add a test demonstrating chain tip fund unavailability.
...
This also factors out and cleans up repeated code that checks for anchor
shard completeness.
2023-09-07 10:55:16 -06:00
a89e65b302
Merge pull request #949 from nuttycom/sbs/update_tip_lower_bound
...
zcash_client_sqlite: Bound creation of scan ranges on wallet birthday.
2023-09-07 17:31:27 +01:00
19582a4ca6
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2023-09-07 10:29:21 -06:00
a6328a098f
zcash_client_sqlite: Bound creation of scan ranges on wallet birthday.
...
This modifies `update_chain_tip` and `scan_complete` to ensure that
newly created scan ranged do not extend below the wallet birthday
height.
Fixes #947
2023-09-07 09:58:21 -06:00
3d0ec004a2
Merge pull request #944 from nuttycom/wallet/progress_from_birthday
...
Measure scan progress from wallet birthday, not the fully scanned height
2023-09-06 19:38:28 +01:00
f56c5d8f4b
Measure scan progress from wallet birthday, not the fully scanned height.
2023-09-06 12:07:18 -06:00
362e5d05f1
Merge pull request #943 from zcash/938-bugfix
...
zcash_client_sqlite: Fix bug in `check_shard_discontinuity`
2023-09-06 11:59:35 -06:00
c9d58b223c
zcash_client_sqlite: Fix bug in `check_shard_discontinuity`
...
The previous code was checking that the existing shard range was at
least partially inside the proposed insertion range, but this didn't
handle the case where the proposed insertion range was fully contained
by the existing shard range.
2023-09-06 17:13:12 +00:00
0cc0af7ac5
Merge pull request #942 from nuttycom/wallet/block_max_scanned
...
zcash_client_backend: Add `WalletRead::block_max_scanned`
2023-09-06 09:57:56 -06:00
65420f59df
zcash_client_backend: Add `WalletRead::block_max_scanned`
...
Fixes #941
2023-09-06 08:49:43 -06:00
b4772e948d
Merge pull request #938 from ebfull/check-subtree-discontinuity
...
Check for potential discontinuities when inserting into the `*_tree_shards` table
2023-09-06 01:05:18 +01:00
236e9f2cd0
Merge pull request #914 from nuttycom/sbs/nonlinear_sync_aware_balance
...
Add `get_wallet_summary` to `WalletRead`
2023-09-06 01:04:42 +01:00
1e12e9d0e6
Clarify zero-conf shielded note behaviour for `get_wallet_summary`
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-06 00:18:11 +01:00
6cbb107c71
zcash_client_sqlite: allow zero-conf transactions in unshielded balance.
2023-09-05 16:49:36 -06:00
7abd1324de
Apply suggestions from code review
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2023-09-05 16:49:36 -06:00
f53ea2d778
Add `get_wallet_summary` to `WalletRead`
...
The intent of this API is to provide a single API which returns in a
single call:
* per-account balances, including pending values
* wallet sync progress
Fixes #865
Fixes #900
2023-09-05 16:06:55 -06:00
976b0f0931
Check for potential discontinuities when inserting into the `*_tree_shards` table.
...
Closes #924
2023-09-05 15:25:26 -06:00
f6040decef
Merge pull request #933 from zcash/dependabot/github_actions/actions/checkout-4
...
build(deps): bump actions/checkout from 3 to 4
2023-09-05 18:38:22 +01:00
6478113855
Merge pull request #935 from nuttycom/sbs/post_907_cleanup
...
Address unresovled code review comments from #907
2023-09-05 10:42:43 -06:00
4e823d92eb
Merge pull request #932 from zcash/update_chain_tip-bugs
...
Fix `update_chain_tip` bugs
2023-09-05 16:31:39 +01:00
dd60f51d3c
Address unresovled code review comments from #907
2023-09-05 09:30:17 -06:00
f132af1f33
Documentation fixes
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-05 15:54:15 +01:00
afec2ee218
`zcash_client_sqlite`: Fix refactor bug: ignore pre-Sapling chain tips
...
The pre-refactor code did this correctly, but the comment was moved
without fully moving the logic.
2023-09-05 14:52:33 +00:00
75d4f28b9c
build(deps): bump actions/checkout from 3 to 4
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-09-05 05:54:36 +00:00
81d7d9349c
zcash_client_sqlite: Fix bugs in `update_chain_tip`
...
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2023-09-02 03:01:23 +00:00
9f9a1fb92f
zcash_client_sqlite: Rework `update_chain_tip` tests to pin behaviour
2023-09-02 03:01:19 +00:00
224e021558
Merge pull request #931 from nuttycom/remove_deprecated_default_fee
...
zcash_primitives: Remove the deprecated 1000-ZAT DEFAULT_FEE constant
2023-09-01 14:40:11 -06:00
14d61a2e98
zcash_primitives: Remove the deprecated 1000-ZAT DEFAULT_FEE constant
2023-09-01 12:46:13 -06:00
7421d85cc0
Merge pull request #926 from zcash/debugging
...
Debugging improvements
2023-09-01 19:41:29 +01:00
229f6e82ad
Merge pull request #907 from nuttycom/sbs/wallet_birthday
...
zcash_client_backend: Add account birthday management to the Data Access API
2023-09-01 18:10:30 +01:00
5b3f544102
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-01 10:38:20 -06:00
a51712830f
zcash_client_sqlite: ignore unscanned ranges below the birthday height in note selection
2023-09-01 10:12:19 -06:00
0b0274cdc1
zcash_client_backend: Make wallet and account birthday heights available via the data access API
2023-09-01 10:11:43 -06:00
459dc49b54
zcash_client_backend: Accept account birthday as a parameter to `create_account`
...
This also removes the zcash_client_sqlite-specific database
initialization procedures in favor of a standardized approach using the
methods available via the data access API.
2023-09-01 10:08:17 -06:00
c99c0fc884
zcash_client_sqlite: Enable forced re-scanning of previously scanned ranges.
...
When `force_rescans` is set to `true` in a call to
`replace_queue_entries`, previously scanned ranges will have their
existing priority overwritten by the scan priority for a provided range;
otherwise, the existing scan priority dominance rule continues to be
enforced. This enables us to require previously scanned ranges be
re-scanned without interfering with higher-priority scan operations.
2023-09-01 08:13:11 -06:00
cf4c769609
Merge pull request #927 from nuttycom/sbs/prevent_scan_fragmentation
...
zcash_client_sqlite: Prevent scan range fragmentation.
2023-09-01 07:50:04 -06:00
8bcc3c1cc1
Fix unused imports.
2023-08-31 17:56:04 -06:00
fb8c3a178c
zcash_client_sqlite: Ensure that fragmentation also can't occur at scan range ends.
2023-08-31 17:52:29 -06:00
4fe9d61959
zcash_client_sqlite: Fix a comment on range inclusion.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2023-08-31 15:07:07 -06:00
2ba9c25b9f
Merge pull request #928 from zcash/lightwalletd-expose-service-types
...
zcash_client_backend: Reduce scope of `lightwalletd-tonic` feature flag
2023-08-31 22:06:55 +01:00
3272f129e2
zcash_client_backend: Remove now-superfluous braces from build script
2023-08-31 20:32:42 +00:00
3ad07cad9e
zcash_client_backend: Reduce scope of `lightwalletd-tonic` feature flag
...
The `zcash_client_backend::proto::service::compact_tx_streamer_client`
is now the only module controlled by that feature flag, exposing the
service types for use by parsers.
2023-08-31 20:32:04 +00:00
bcafb7d4b4
zcash_client_sqlite: Prevent scan range fragmentation.
...
Fixes #922
Co-authored-by: Sean Bowe <ewillbefull@gmail.com>
2023-08-31 14:18:30 -06:00
f33c8ea418
zcash_primitives: Parse the full opcode set
...
This enhances the alternate `impl Debug for Script` to render unexpected
scripts correctly.
2023-08-30 20:41:27 +00:00
c8e2d81f58
Render byte slices as hex more often in `Debug` impls
...
This is more generally useful for debugging purposes than the default
`Debug` impl for `&[u8]`.
We also provide an alternate `Debug` impl for `legacy::Script` that
parses and renders known opcodes. Note that we only parse a subset of
the full opcode set.
2023-08-30 20:41:27 +00:00
57a3914e3a
zcash_primitives: Drop `byteorder::LittleEndian` usage in sighash
2023-08-30 19:46:38 +00:00
Jack Grigg
Kris Nuttycombe
Kris Nuttycombe
ebfull
str4d
dependabot[bot]