Kris Nuttycombe
d99b4d4d6e
Update memo retrieval API to reflect that memos may not be present.
...
Memos may be absent for both sent and received notes in cases where only
compact block information has been used to populate the wallet database.
This fixes a potential crash in the case that we attempt to decode a
SQLite `NULL` as a byte array. It does, however, introduce a slight
semantic confusion that will need to be considered in the case of future
updates where a note may not have an associated memo; at present, the
only reason we might not have the memo is that we might not have
retrieved the full transaction information from the chain, but in the
future there might be other possible reasons for this absence.
Fixes #384
2023-05-16 10:27:40 -06:00
Kris Nuttycombe
bc55893267
Merge pull request #838 from daira/update-fee-constants
...
Revert #830 and instead modify `zcash_primitives::transaction::fees::fixed::FeeRule::standard()`
2023-05-09 13:17:27 -06:00
Kris Nuttycombe
a718810fa8
Update zcash_client_backend/src/data_api/wallet.rs
2023-05-09 12:32:56 -06:00
Kris Nuttycombe
6ceed86e9a
Merge pull request #839 from daira/fix-default-tx-expiry-delta
...
Update `DEFAULT_TX_EXPIRY_DELTA` to 40 blocks
2023-05-09 12:32:22 -06:00
Daira Emma Hopwood
32296e7327
Update `DEFAULT_TX_EXPIRY_DELTA` to 40 blocks, as specified in
...
<https://zips.z.cash/zip-0203#changes-for-blossom >. fixes #837 .
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 18:38:39 +01:00
Daira Emma Hopwood
9cc6319f26
Fix clippy lints.
...
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 17:59:03 +01:00
Daira Emma Hopwood
3903935234
Deprecate `transaction::components::amount::DEFAULT_FEE` and
...
`zcash_primitives::transaction::fees::fixed::FeeRule::standard()`.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 17:18:34 +01:00
Daira Emma Hopwood
736d11b45b
Change `transaction::fees::fixed::FeeRule::standard()` to use the ZIP 317
...
minimum fee (10000 zatoshis rather than 1000 zatoshis) as the fixed fee.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 16:42:41 +01:00
Daira Emma Hopwood
043cc59c76
Add `transaction::fees::zip317::MINIMUM_FEE` constant and
...
`transaction::components::amount::Amount::const_from_i64`.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 16:42:19 +01:00
Daira Emma Hopwood
4cf27126e5
Revert "Update DEFAULT_FEE to 10_000 from 1000"
...
This reverts commit 2a6dc59c5d
.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 13:15:52 +01:00
Kris Nuttycombe
d37e6adee5
Merge pull request #783 from nuttycom/upgrade_bridgetree
...
Upgrade `zcash_primitives` to use updated `incrementalmerkletree` types.
2023-05-08 12:00:00 -06:00
str4d
62bc15ccf0
Merge pull request #824 from zcash/823-secp256k1-0.26
...
Migrate to `secp256k1 0.26`, `hdwallet 0.4`
2023-05-08 18:55:14 +01:00
str4d
579ab92b93
Merge branch 'main' into 823-secp256k1-0.26
2023-05-08 18:53:33 +01:00
Kris Nuttycombe
ec29836df9
Remove `bridgetree` dependency from `zcash_primitives`.
...
This also now makes `zcash_extensions` use `incrementalmerkletree`
transitively via type aliases in `zcash_primitives`.
2023-05-04 15:42:39 -06:00
Kris Nuttycombe
c9f53ddde5
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-05-04 14:46:34 -06:00
Kris Nuttycombe
882d60a915
Merge pull request #830 from zingolabs/update_fixed_fee_to_zip317_minimum
...
Update DEFAULT_FEE to 10_000 from 1000
2023-05-04 14:39:06 -06:00
Kris Nuttycombe
4d32a8ac20
Remove serialization version constants.
2023-05-04 12:46:15 -06:00
Kris Nuttycombe
71f74d4ac1
Remove the `merkle_tree::incremental` module.
...
This consolidates all the seralization code for frontiers and
incremental witnesses in the `merkle_tree` module.
2023-05-04 12:46:15 -06:00
Kris Nuttycombe
6aaa96d377
Remove zcashd-specific `bridgetree` serialization.
2023-05-04 12:46:15 -06:00
Kris Nuttycombe
1f9747e15f
Move merkle tree types to the `incrementalmerkletree` crate.
...
This removes the `CommitmentTree`, `IncrementalWitness`, and
`MerklePath` types in favor of equivalent versions available
from the `incrementalmerkletree` crate.
2023-05-04 12:30:56 -06:00
Kris Nuttycombe
667a7b841e
Move-only: restructure merkle tree source for extraction.
2023-05-04 12:21:50 -06:00
Kris Nuttycombe
6f2cbfc7de
Factor serialization out from merkle tree data structures.
2023-05-04 12:21:47 -06:00
Kris Nuttycombe
831a6cd396
Remove superfluous inner functions now that tree depth is a constant.
2023-05-04 12:16:09 -06:00
Kris Nuttycombe
ec57d23115
Use const generics to set commitment tree & incremental witness depths.
...
This is in preparation for extraction into the `incrementalmerkletree`
crate, which is not Sapling-specific and therefore cannot hard-code
the depths of these data structures.
2023-05-04 12:16:09 -06:00
Kris Nuttycombe
69430c3da2
Upgrade incrementalmerkletree and use bridgetree crate for `Bridgetree`.
2023-05-04 12:08:38 -06:00
Hazel OHearn
2a6dc59c5d
Update DEFAULT_FEE to 10_000 from 1000
2023-05-03 16:42:01 -03:00
Daira Hopwood
e4f793db35
Merge pull request #833 from str4d/zcash_history-fix-deps
...
zcash_history: Migrate to `primitive-types 0.12`
2023-05-03 17:37:28 +00:00
Jack Grigg
149d7ad83e
zcash_history: Migrate to `primitive-types 0.12`
...
We also disable the default `std` feature, to remove transitive
dependencies we don't use.
2023-05-03 17:55:14 +01:00
Kris Nuttycombe
0d980da3f6
Merge pull request #832 from nuttycom/pin_winnow_dep
...
Pin winnow dependency to avoid MRSV break.
2023-05-03 10:19:52 -06:00
Kris Nuttycombe
730b05510e
Pin winnow dependency to avoid MRSV break.
2023-05-03 08:39:55 -06:00
str4d
8b8cedbdbd
Merge pull request #825 from zcash/dependabot/github_actions/codecov/codecov-action-3.1.3
...
Bump codecov/codecov-action from 3.1.2 to 3.1.3
2023-04-28 12:43:29 +01:00
str4d
581c686b6b
Merge pull request #828 from zcash/zcash_client_backend-0.9
...
`zcash_client_backend 0.9.0`, `zcash_client_sqlite 0.7.0`
2023-04-28 03:28:45 +01:00
Jack Grigg
3db0395e5b
zcash_client_sqlite 0.7.0
2023-04-28 01:47:20 +00:00
Jack Grigg
8b53d4a0c4
zcash_client_backend 0.9.0
2023-04-28 01:46:28 +00:00
Kris Nuttycombe
6f7e22db4a
Merge pull request #826 from nuttycom/wallet/store_change_on_send
...
Store change notes as received for internal transfers.
2023-04-27 18:41:43 -06:00
Kris Nuttycombe
8e8388a9f6
Add migration to enable storage of unmined change notes.
2023-04-27 17:26:11 -06:00
Kris Nuttycombe
fa282695da
Store change notes as received for internal transfers.
2023-04-27 14:41:26 -06:00
Kris Nuttycombe
7abe7ecf89
Merge pull request #827 from nuttycom/cleanup/sapling_naming
...
Remove deprecated APIs & rename Sapling-specific data structures to include "Sapling".
2023-04-27 14:40:23 -06:00
Kris Nuttycombe
f3745c0cb5
Make the internal state of `SentTransactionOutput` private.
2023-04-27 13:07:34 -06:00
Kris Nuttycombe
ac3439e65e
Rename *rewind* to *truncate* in data_api methods.
...
This better reflects the semantics of wallet behavior. Also, this
adds a `zcash_client_backend::WalletRead::get_min_unspent_height`
method that replaces the deprecated & removed (and misleadingly
named) `get_rewind_height` method.
2023-04-27 09:12:07 -06:00
Kris Nuttycombe
7405d0cd69
Make internals of `WalletSaplingSpend` and `WalletSaplingOutput` private.
2023-04-26 14:47:10 -06:00
Kris Nuttycombe
bfc5b9a5b3
Parameterize `DecryptedOutput` by note type.
2023-04-26 14:47:10 -06:00
Kris Nuttycombe
55c2de0066
Remove the redundant `WalletSaplingOutput::to` and `DecryptedOutput::to` fields.
2023-04-26 14:47:10 -06:00
Kris Nuttycombe
c15a185454
Remove deprecated APIs & rename Sapling-specific data structures to include "Sapling"
...
This helps to clarify the Sapling-specific nature of a number of
operations in wallet code.
2023-04-26 14:47:10 -06:00
dependabot[bot]
554c712ac8
Bump codecov/codecov-action from 3.1.2 to 3.1.3
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v3.1.2...v3.1.3 )
---
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-04-21 05:58:44 +00:00
Jack Grigg
ec1c1bcf21
Migrate to `secp256k1 0.26`, `hdwallet 0.4`
...
Closes zcash/librustzcash#823 .
2023-04-19 19:33:34 +00:00
str4d
f293526aa2
Merge pull request #820 from zcash/zcash_address-0.2.1
...
`zcash_address 0.2.1`
2023-04-15 02:45:04 +01:00
Jack Grigg
5f7ccb6d84
zcash_address 0.2.1
2023-04-15 00:51:29 +00:00
str4d
c48633dadc
Merge pull request #819 from zcash/release-0.11.0
...
`zcash_primitives 0.11.0`, `zcash_proofs 0.11.0`, `zcash_client_backend 0.8.0`, `zcash_client_sqlite 0.6.0`
2023-04-15 01:42:24 +01:00
Jack Grigg
adeb19ab40
zcash_client_sqlite 0.6.0
2023-04-15 00:02:00 +00:00