Merge pull request #402 from zcash/ci-updates

CI: Modernise workflows

.github/workflows/bench.yml

@@ -13,7 +13,7 @@ jobs:
     name: Performance regression check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Run benchmark
         run: cargo bench -- --output-format bencher | tee output.txt
       - name: Store benchmark result

.github/workflows/book.yml

@@ -7,20 +7,18 @@ on:
 
 jobs:
   deploy:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
-
-      - name: Setup mdBook
-        uses: peaceiris/actions-mdbook@v1
         with:
-          mdbook-version: '0.4.5'
+          fetch-depth: 0
 
-      - name: Install mdbook-katex
+      - name: Install mdbook and mdbook-katex
-        uses: actions-rs/cargo@v1
+        run: |
-        with:
+          mkdir mdbook
-          command: install
+          curl -sSL https://github.com/rust-lang/mdBook/releases/download/v0.4.35/mdbook-v0.4.35-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=./mdbook
-          args: mdbook-katex
+          curl -sSL https://github.com/lzanini/mdbook-katex/releases/download/v0.5.8pub/mdbook-katex-v0.5.8-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=./mdbook
+          echo `pwd`/mdbook >> $GITHUB_PATH
 
       - name: Build Orchard book
         run: mdbook build book/

.github/workflows/ci.yml

@@ -11,11 +11,31 @@ jobs:
         os: [ubuntu-latest, windows-latest, macOS-latest]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Run tests
         run: cargo test --verbose
+      - name: Verify working directory is clean
+        run: git diff --exit-code
 
-  build:
+  build-latest:
+    name: Latest build on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macOS-latest]
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+        id: toolchain
+      - run: rustup override set ${{steps.toolchain.outputs.name}}
+      - name: Remove lockfile to build with latest dependencies
+        run: rm Cargo.lock
+      - name: Build crate
+        run: cargo build --all-features --verbose
+      - name: Verify working directory is clean (excluding lockfile)
+        run: git diff --exit-code ':!Cargo.lock'
+
+  build-nodefault:
     name: Build target ${{ matrix.target }}
     runs-on: ubuntu-latest
     strategy:
@@ -24,7 +44,7 @@ jobs:
           - wasm32-wasi
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Add target
         run: rustup target add ${{ matrix.target }}
       - run: cargo fetch
@@ -35,7 +55,7 @@ jobs:
     name: Bitrot check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       # Build benchmarks to prevent bitrot
       - name: Build benchmarks
         run: cargo build --benches
@@ -44,54 +64,43 @@ jobs:
     name: Book tests
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
-      - name: Setup mdBook
+      - name: Install mdbook
-        uses: peaceiris/actions-mdbook@v1
+        run: |
-        with:
+          mkdir mdbook
-          mdbook-version: '0.4.5'
+          curl -sSL https://github.com/rust-lang/mdBook/releases/download/v0.4.35/mdbook-v0.4.35-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=./mdbook
+          echo `pwd`/mdbook >> $GITHUB_PATH
       - name: Test Orchard book
         run: mdbook test book/
 
   codecov:
     name: Code coverage
     runs-on: ubuntu-latest
+    container:
+      image: xd009642/tarpaulin:develop-nightly
+      options: --security-opt seccomp=unconfined
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
-      # Use stable for this to ensure that cargo-tarpaulin can be built.
-      - uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          override: true
-      - name: Install cargo-tarpaulin
-        uses: actions-rs/cargo@v1
-        with:
-          command: install
-          args: cargo-tarpaulin
       - name: Generate coverage report
-        uses: actions-rs/cargo@v1
+        run: cargo tarpaulin --engine llvm --all-features --release --timeout 600 --out xml
-        with:
-          command: tarpaulin
-          args: --all-features --timeout 600 --out Xml
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v3.1.4
-        with:
-          token: ${{secrets.CODECOV_TOKEN}}
 
   doc-links:
     name: Intra-doc links
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - run: cargo fetch
-      # Requires #![deny(intra_doc_link_resolution_failure)] in crates.
+      # Requires #![deny(rustdoc::broken_intra_doc_links)] in crates.
       - name: Check intra-doc links
-        run: cargo doc --document-private-items
+        run: cargo doc --all-features --document-private-items
 
   fmt:
     name: Rustfmt
     timeout-minutes: 30
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - run: cargo fmt -- --check

.github/workflows/lints-beta.yml

@@ -11,17 +11,16 @@ jobs:
     runs-on: ubuntu-latest
     continue-on-error: true
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
-      - uses: actions-rs/toolchain@v1
+      - uses: dtolnay/rust-toolchain@beta
+        id: toolchain
         with:
-          toolchain: beta
           components: clippy
-          override: true
+      - run: rustup override set ${{steps.toolchain.outputs.name}}
-      - name: Run Clippy (beta)
+      - name: Run Clippy
-        uses: actions-rs/clippy-check@v1
+        uses: auguwu/clippy-action@1.3.0
         continue-on-error: true
         with:
-          name: Clippy (beta)
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-features --all-targets
+          working-directory: ${{ inputs.target }}
-
+          warn: clippy::all

.github/workflows/lints-stable.yml

@@ -9,10 +9,10 @@ jobs:
     timeout-minutes: 30
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Run Clippy
-        uses: actions-rs/clippy-check@v1
+        uses: auguwu/clippy-action@1.3.0
         with:
-          name: Clippy (MSRV)
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-features --all-targets -- -D warnings
+          working-directory: ${{ inputs.target }}
+          deny: warnings

.gitignore

@@ -1,5 +1,4 @@
 /target
 **/*.rs.bk
-Cargo.lock
 .vscode
 action-circuit-layout.png