zec
/
orchard
mirror of https://github.com/zcash/orchard.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #323 from defuse/nu5-consensus-labeled 

Label Consensus Rules
This commit is contained in:
str4d 2023-11-29 04:36:23 +00:00 committed by GitHub
parent c48247dd34 2d15aeaa69
commit 4bb65b9330
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bundle.rs
View File

@ -111,6 +111,7 @@ impl Flags {
/// ///
/// [txencoding]: https://zips.z.cash/protocol/protocol.pdf#txnencoding /// [txencoding]: https://zips.z.cash/protocol/protocol.pdf#txnencoding
pub fn from_byte(value: u8) -> Option<Self> { pub fn from_byte(value: u8) -> Option<Self> {
// https://p.z.cash/TCR:bad-txns-v5-reserved-bits-nonzero
if value & FLAGS_EXPECTED_UNSET == 0 { if value & FLAGS_EXPECTED_UNSET == 0 {
Some(Self::from_parts( Some(Self::from_parts(
value & FLAG_SPENDS_ENABLED != 0, value & FLAG_SPENDS_ENABLED != 0,
@ -376,6 +377,7 @@ impl<T: Authorization, V: Copy + Into<i64>> Bundle<T, V> {
/// This can be used to validate the [`Authorized::binding_signature`] returned from /// This can be used to validate the [`Authorized::binding_signature`] returned from
/// [`Bundle::authorization`]. /// [`Bundle::authorization`].
pub fn binding_validating_key(&self) -> redpallas::VerificationKey<Binding> { pub fn binding_validating_key(&self) -> redpallas::VerificationKey<Binding> {
// https://p.z.cash/TCR:bad-txns-orchard-binding-signature-invalid?partial
(self (self
.actions .actions
.iter() .iter()

2
src/bundle/batch.rs
View File

@ -67,6 +67,8 @@ impl BatchValidator {
/// figure out which of the accumulated bundles might be invalid; if that information /// figure out which of the accumulated bundles might be invalid; if that information
/// is desired, construct separate [`BatchValidator`]s for sub-batches of the bundles. /// is desired, construct separate [`BatchValidator`]s for sub-batches of the bundles.
pub fn validate<R: RngCore + CryptoRng>(self, vk: &VerifyingKey, rng: R) -> bool { pub fn validate<R: RngCore + CryptoRng>(self, vk: &VerifyingKey, rng: R) -> bool {
// https://p.z.cash/TCR:bad-txns-orchard-binding-signature-invalid?partial
if self.signatures.is_empty() { if self.signatures.is_empty() {
// An empty batch is always valid, but is not free to run; skip it. // An empty batch is always valid, but is not free to run; skip it.
// Note that a transaction has at least a binding signature, so if // Note that a transaction has at least a binding signature, so if