mirror of https://github.com/zcash/orchard.git
fixed clippy warrnings
This commit is contained in:
parent
6a10f456fc
commit
69f0ea493f
|
@ -141,7 +141,7 @@ impl ActionInfo {
|
|||
/// [orchardsend]: https://zips.z.cash/protocol/nu5.pdf#orchardsend
|
||||
fn build(self, mut rng: impl RngCore) -> (Action<SigningMetadata>, Circuit) {
|
||||
let v_net = self.value_sum();
|
||||
let cv_net = ValueCommitment::derive(v_net, self.rcv.clone(), NoteType::native());
|
||||
let cv_net = ValueCommitment::derive(v_net, self.rcv, NoteType::native());
|
||||
|
||||
let nf_old = self.spend.note.nullifier(&self.spend.fvk);
|
||||
let sender_address = self.spend.note.recipient();
|
||||
|
|
|
@ -906,7 +906,7 @@ mod tests {
|
|||
|
||||
let value = spent_note.value() - output_note.value();
|
||||
let rcv = ValueCommitTrapdoor::random(&mut rng);
|
||||
let cv_net = ValueCommitment::derive(value, rcv.clone(), NoteType::native());
|
||||
let cv_net = ValueCommitment::derive(value, rcv, NoteType::native());
|
||||
|
||||
let path = MerklePath::dummy(&mut rng);
|
||||
let anchor = path.root(spent_note.commitment().into());
|
||||
|
|
|
@ -208,7 +208,7 @@ impl TryFrom<ValueSum> for i64 {
|
|||
}
|
||||
|
||||
/// The blinding factor for a [`ValueCommitment`].
|
||||
#[derive(Clone, Debug)]
|
||||
#[derive(Clone, Copy, Debug)]
|
||||
pub struct ValueCommitTrapdoor(pallas::Scalar);
|
||||
|
||||
impl ValueCommitTrapdoor {
|
||||
|
@ -418,7 +418,7 @@ mod tests {
|
|||
use crate::primitives::redpallas;
|
||||
|
||||
fn _bsk_consistent_with_bvk(
|
||||
values: &Vec<(ValueSum, ValueCommitTrapdoor)>,
|
||||
values: &[(ValueSum, ValueCommitTrapdoor)],
|
||||
note_type: NoteType,
|
||||
) {
|
||||
let value_balance = values
|
||||
|
@ -434,8 +434,8 @@ mod tests {
|
|||
.into_bsk();
|
||||
|
||||
let bvk = (values
|
||||
.into_iter()
|
||||
.map(|(value, rcv)| ValueCommitment::derive(value.clone(), rcv.clone(), note_type))
|
||||
.iter()
|
||||
.map(|(value, rcv)| ValueCommitment::derive(*value, *rcv, note_type))
|
||||
.sum::<ValueCommitment>()
|
||||
- ValueCommitment::derive(value_balance, ValueCommitTrapdoor::zero(), note_type))
|
||||
.into_bvk();
|
||||
|
|
Loading…
Reference in New Issue