zec
/
orchard
mirror of https://github.com/zcash/orchard.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
840 Commits 5 Branches 11 Tags 24 MiB
Commit Graph

840 Commits

Author SHA1 Message Date
Kris Nuttycombe c803114bf6 Go ahead and clone IVKs to limit borrowing hassles. 2021-08-23 11:29:07 -06:00
Kris Nuttycombe d8bf892c72 Return key used to decrypt an output along with decrypted note contents. 2021-08-23 11:29:07 -06:00
Kris Nuttycombe 5d78ab3508 Add Eq and Ord implementations for Orchard keys. 2021-08-23 11:29:06 -06:00
Kris Nuttycombe 52f0f158ef Add serialization and parsing of full viewing keys. 2021-08-23 11:28:27 -06:00
Kris Nuttycombe 1fd00e6236 Add raw address serialization and parsing. 2021-08-23 11:28:27 -06:00
Kris Nuttycombe e33cd4ade4 Add trial decryption of actions to Bundle 2021-08-23 11:28:25 -06:00
Kris Nuttycombe 77cf4c9831 Implement IncomingViewingKey::to_bytes 2021-08-23 11:27:02 -06:00
str4d f2400baa01
Improve NoteCommit input value gate doc 
Brings it in line with the other gate docs.

Co-authored-by: ying tong <yingtong@z.cash>
 2021-08-19 14:35:56 +01:00
str4d bac22d9b19
clippy: Remove redundant clones 
Co-authored-by: ying tong <yingtong@z.cash>
 2021-08-19 14:34:15 +01:00
str4d ac900148ed
Fix typo in gate documentation 
Co-authored-by: ying tong <yingtong@z.cash>
 2021-08-19 14:33:52 +01:00
str4d b4a82211ce
Merge pull request #184 from zcash/poseidon-domain-spec 
poseidon::Domain: Remove Spec trait bound.
 2021-08-17 12:55:01 +01:00
therealyingtong 4082ee615f [book] sinsemilla.md: Correct constraint degrees. 
Co-authored-by: Jack Grigg <jack@electriccoin.co>
 2021-08-17 00:07:30 +08:00
str4d cb28e00ebd
Merge pull request #178 from zcash/batch-note-decryption 
Speed up batched note decryption
 2021-08-13 14:27:41 +01:00
Jack Grigg 79988a5317 Move the interpolation logic into `SharedSecret::batch_to_affine` 
This makes the method interface clearer, as the same pattern of shared
secrets is returned as was provided.
 2021-08-13 14:27:20 +01:00
str4d 63ca0aaf32
Merge pull request #181 from zcash/sinsemilla-moar-speed 
More Sinsemilla optimisations
 2021-08-13 14:27:02 +01:00
therealyingtong 1f852544cf poseidon::Domain: Remove Spec trait bound. 
The methods in the Domain trait are not generic over Spec.
 2021-08-13 14:47:02 +08:00
therealyingtong a72d4d3a7f [book] note-commit.md: Update field element regions. 2021-08-13 12:22:51 +08:00
str4d 4e33fe7aec Use correct symbol for incomplete addition 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-08-12 21:34:35 +01:00
str4d 459e68b71e
Fix clippy lint 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-08-12 21:32:14 +01:00
therealyingtong 8d7bf509f2 [book] note-commit.md: Update message piece decomposition gates. 2021-08-13 01:19:30 +08:00
Jack Grigg 9f3c9a7e60 Use mixed addition for Sinsemilla bases 
Performance improvements:
- MerkleCRH:  ~5%
- Commit^ivk: ~1%
- NoteCommit: ~3%
 2021-08-12 15:45:00 +01:00
Jack Grigg 6197a0ef62 Use `group::Wnaf` to accelerate `sinsemilla::CommitDomain::commit` 
Performance improvements:
- Commit^ivk: ~31%
- NoteCommit: ~22%
 2021-08-12 15:45:00 +01:00
str4d 5f0c3b3585
Merge pull request #179 from zcash/sinsemilla-bases 
primitives::sinsemilla: Use hard-coded generators in sinsemilla_s.
 2021-08-12 15:18:38 +01:00
therealyingtong 92a7e20d30 Remove sinsemilla_s_generators() function. 
Co-authored-by: Jack Grigg <jack@electriccoin.co>
 2021-08-12 20:54:51 +08:00
Jack Grigg c79acc0e08 Fix length of output Vec for `SharedSecret::batch_to_affine` 
It was too long, and `group::Curve::batch_normalize` panics if its
inputs are not the same length (which would be the case if a batch
included an output with an invalid `ephemeral_key`).
 2021-08-12 13:40:56 +01:00
str4d 5df0038bd8
Merge pull request #177 from zcash/bench-primitives 
Add benchmarks for Poseidon and Sinsemilla primitives
 2021-08-12 13:35:10 +01:00
therealyingtong a9e96eb0a4 sinsemilla_s: Add documentation. 2021-08-12 16:15:24 +08:00
therealyingtong 995728caa6 primitives::sinsemilla: Use hard-coded generators in sinsemilla_s. 2021-08-12 15:45:14 +08:00
Jack Grigg 8e13986101 Implement `Domain::batch_epk` for note decryption 
Improves throughput of batched trial decryption by around 10%.
 2021-08-12 01:36:38 +01:00
Jack Grigg 8c15cc25be Benchmark batch trial decryption 2021-08-12 01:36:38 +01:00
Jack Grigg 0d306d18aa Expose and benchmark Poseidon 2021-08-10 13:44:04 +01:00
Jack Grigg 08b279b900 Expose and benchmark Sinsemilla primitive 2021-08-10 13:39:14 +01:00
str4d c4fb1efb1c
Merge pull request #176 from zcash/doc-cmx-canon 
ExtractedNoteCommitment::from_bytes: Document cmx canonicity.
 2021-08-09 18:33:03 +01:00
therealyingtong e62cfaa398 ExtractedNoteCommitment::from_bytes: Document cmx canonicity. 2021-08-09 20:11:27 +08:00
str4d 506b6a6dcd
Merge pull request #175 from zcash/note-decryption-wnaf 
Use w-NAF in `ka_orchard`
 2021-08-06 15:00:19 +01:00
Jack Grigg f4a8c082a9 Use w-NAF in `ka_orchard` 
Improves the base-line cost of trial decryption by over 40%.
 2021-08-06 13:43:19 +01:00
str4d fe923cc391
Merge pull request #174 from zcash/bench-note-decryption 
Benchmark note decryption
 2021-08-06 11:17:59 +01:00
Jack Grigg cad3c8a1b8 Add benchmark for note decryption 2021-08-06 01:03:03 +01:00
Jack Grigg 2283310236 Expose `orchard::note_encryption::{CompactAction, OrchardNoteEncryption}` 
This also removes the `orchard::OrchardDomain` re-export, which is now
available at `orchard::note_encryption::OrchardDomain`.
 2021-08-06 01:01:12 +01:00
str4d d0baa18fc6
Merge pull request #173 from nuttycom/update_incrementalmerkletree 
Update incrementalmerkletree version.
 2021-08-05 15:11:13 +01:00
Kris Nuttycombe d8091dd575 Update incrementalmerkletree version. 2021-08-05 07:51:19 -06:00
str4d 55279b8648
Merge pull request #171 from daira/poseidon-rounds-update 
Update Poseidon instantiation from 58 to 56 partial rounds. fixes #166
 2021-08-05 14:36:42 +01:00
Daira Hopwood e4612f7f6c Update Poseidon instantiation from 58 to 56 partial rounds. fixes #166 
Test vectors are from https://github.com/zcash-hackworks/zcash-test-vectors/pull/45

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-08-04 13:04:13 +01:00
Jack Grigg 9af22a8cbc circuit: Add region layout diagrams for y_switch constraint 
Helps to see why we can't optimise it to remove the `prev` query.
 2021-07-29 20:57:33 +01:00
Jack Grigg 6aa85fcdfe circuit: Refactor NoteCommit input processing into multiple regions 
The new regions take up more cells overall, but across fewer columns,
and the gates now only query `cur` and `next` rows.
 2021-07-29 20:13:27 +01:00
Jack Grigg 2198675f9d circuit: Rotate `q_commit_ivk` selector up by one row 
This ensures the Commit^ivk gate only queries `cur` and `next` rows.
 2021-07-29 14:56:56 +01:00
Jack Grigg 0009070358 circuit: Rotate`q_mul_lsb` selector up by one row 
This ensures the "LSB check" gate only queries `cur` and `next` rows.
 2021-07-29 14:56:56 +01:00
Jack Grigg 16e9076080 Add names to some nameless constraints 2021-07-29 14:56:56 +01:00
str4d 8454f86d42
Merge pull request #140 from nuttycom/bundle_zip244_commitments 
Implement ZIP-244 txid and authorizing commitments.
 2021-07-29 14:45:24 +01:00
Kris Nuttycombe 40d80c4d6f
Apply suggestions from code review 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-29 07:16:14 -06:00