Commit Graph

3312 Commits

Author SHA1 Message Date
Kris Nuttycombe 2d5bf5d8d9
Merge pull request #1100 from zcash/1098-ci-lint-protobuf
CI: Add lint to check protobuf consistency with generated files
2024-01-05 16:32:15 -07:00
Jack Grigg 3789e46700 CI: Add lint to check protobuf consistency with generated files
Closes zcash/librustzcash#1098.
2024-01-05 21:03:01 +00:00
str4d 0548b3dd9b
Merge pull request #1090 from nuttycom/rename_wallet_note
zcash_client_backend: rename `WalletNote` to `Note`
2024-01-05 17:16:29 +00:00
Kris Nuttycombe 5d7638ccf8
Merge pull request #1089 from rex4539/typos
Fix typo
2024-01-05 09:57:17 -07:00
Kris Nuttycombe 1b036f1e0d zcash_client_backend: rename `WalletNote` to `Note` 2024-01-05 09:13:53 -07:00
Dimitris Apostolou 652c393896
Fix typo 2024-01-05 12:44:57 +02:00
Kris Nuttycombe 28319ffc38
Merge pull request #1085 from nuttycom/wallet/common_input_source
Replace SaplingInputSource and TransparentInputSource with InputSource
2024-01-04 15:07:23 -07:00
Kris Nuttycombe 5126fd6b5f
Merge pull request #1086 from zcash/docs-rs-feature-flags
Show feature flags in documentation
2024-01-04 14:34:40 -07:00
str4d 3ea8b909c9
Merge pull request #1077 from nerdcash/unstableVsCode
Enable unstable features when editing in VS Code
2024-01-04 21:19:48 +00:00
Kris Nuttycombe d4aa2d6f06 Replace SaplingInputSource and TransparentInputSource with InputSource
This unification allows us to better isolate transparent-input dependent
functionality. Previously, `TransparentInputSource` could not be placed
under a feature flag because the interface was needed for proposal
deserialization; by instead making the transparent input source methods
flag-dependent, we can correctly produce an error when proposal
deserializaiton attempts to select transparent inputs and the feature
flag is off.
2024-01-04 14:00:20 -07:00
str4d b83877f44b
Merge pull request #1080 from nuttycom/wallet/orchard_feature_flag
zcash_client_backend: Introduce an "orchard" feature flag.
2024-01-04 20:59:51 +00:00
Jack Grigg 3989ee9926 Show feature flags in documentation
This can be rendered locally with:
    RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --no-deps --workspace --all-features
2024-01-04 19:07:22 +00:00
Kris Nuttycombe 967fd36d39
Apply suggestions from code review
Co-authored-by: str4d <thestr4d@gmail.com>
2024-01-04 11:56:59 -07:00
Andrew Arnott 1804647112
Update .vscode/settings.json
Co-authored-by: str4d <thestr4d@gmail.com>
2024-01-04 11:44:17 -07:00
Kris Nuttycombe 857e44a11c zcash_client_backend: Use a polymorphic type for `ScannedBlock` note commitment and nullifier data. 2024-01-04 11:19:22 -07:00
Kris Nuttycombe f18d082aa3 zcash_client_backend: Introduce an "orchard-client" feature flag.
We plan to also introduce a similar flag to gate access to Sapling
functionality. Since introduction of Orchard functionality is still
nascent, it's the correct time to introduce this isolation, before
there's more functionality that needs to be isolated in this fashion.
2024-01-03 17:05:20 -07:00
str4d 4bd6520013
Merge pull request #1081 from zcash/api-cleanups
API cleanups
2024-01-03 20:43:27 +00:00
Jack Grigg 2ea83243a7 Document the feature flags 2024-01-03 20:15:21 +00:00
Jack Grigg 0df4c6f043 Remove implicit feature flags for optional dependencies
All optional dependencies are enabled as part of dedicated feature
flags.
2024-01-03 20:15:21 +00:00
Jack Grigg b7bba9bbb2 zcash_primitives: Remove `keys` module 2024-01-03 17:29:59 +00:00
Kris Nuttycombe 6c5bdf85ce
Merge pull request #1065 from nuttycom/primitives/padding_rule
zcash_primitives: Add explicit control over padding to the transaction builder.
2024-01-02 15:03:55 -07:00
Kris Nuttycombe 704e8e1144 zcash_primitives: Updates to reflect `sapling-crypto` and `orchard` builder changes. 2024-01-02 13:00:11 -07:00
Kris Nuttycombe 1ef6bf6656
Merge pull request #1066 from nuttycom/wallet/common_fee_logic
Factor out common logic from zip317 and fixed-fee single output change strategies.
2023-12-20 20:50:53 -07:00
Andrew Arnott 976a5e0366
Enable unstable features when editing in VS Code
This improves the editing experience by 'enabling' all the code that otherwise is turned off because of the `unstable` flag.
2023-12-16 14:22:03 -07:00
str4d 20f8b97195
Merge pull request #1063 from nuttycom/backend/parsed_address
zcash_client_backend: Rename `RecipientAddress` to `Address`
2023-12-15 17:40:22 +00:00
Kris Nuttycombe d74f635d9d zcash_client_backend: Factor out common single-output change strategy logic. 2023-12-14 12:55:34 -07:00
str4d 926c5dcb3f
Merge pull request #1068 from zcash/post-sapling-crypto-extraction-cleanup
Post sapling crypto extraction cleanup
2023-12-12 21:00:53 +00:00
Jack Grigg 35ea2ff38b zcash_primitives: Remove `sapling-crypto` re-export and update changelog 2023-12-12 19:50:26 +00:00
Jack Grigg b6907b14e6 Use `sapling-crypto` crate directly outside `zcash_primitives` 2023-12-12 19:50:26 +00:00
Jack Grigg bf984ff38d zcash_primitives: Remove benchmarks that were moved to `sapling-crypto` 2023-12-12 18:45:32 +00:00
str4d 164e21dbd6
Merge pull request #1067 from zcash/738-extract-sapling-crypto
Extract `sapling-crypto` crate again
2023-12-11 17:52:56 +00:00
Jack Grigg dc8094856b Migrate to `sapling-crypto` crate outside this repository 2023-12-11 17:27:34 +00:00
Jack Grigg 6acc64e61c Move `zcash_primitives::sapling` module into `sapling-crypto` 2023-12-11 17:07:45 +00:00
Jack Grigg e7f71c3f1f Revert "Remove sapling-crypto"
This reverts commit 1b865ecfdf.
2023-12-11 17:07:45 +00:00
str4d cf850c4baf
Merge pull request #1064 from zcash/1044-builder-progress
zcash_primitives: Add `ProverProgress` trait to `sapling::builder`
2023-12-11 17:06:59 +00:00
Jack Grigg b6ee98ed46 zcash_primitives: Add `ProverProgress` trait to `sapling::builder`
This breaks the link between the concrete `Sender<Progress>` channel
used by the main builder in `zcash_primitives`, and the proof creation
APIs in what will become the `sapling-crypto` crate.

Part of zcash/librustzcash#1044.
2023-12-11 16:37:53 +00:00
Kris Nuttycombe 9ac3594bbb zcash_client_backend: Rename RecipientAddress to Address 2023-12-08 11:34:27 -07:00
Kris Nuttycombe aab9938b53 zcash_client_backend: Rename `RecipientAddress::Shielded` to `RecipientAddress::Sapling` 2023-12-07 15:24:47 -07:00
str4d ecd5402266
Merge pull request #1061 from zcash/1044-sapling-prf-expand
zcash_primitives: Introduce type-safe `PRF^expand`
2023-12-07 18:03:37 +00:00
Jack Grigg ce7b7df0cc zcash_primitives: Switch to type-safe `PRF^expand`
Part of zcash/librustzcash#1044.
2023-12-07 17:09:44 +00:00
str4d f1fdce499a
Merge pull request #1062 from nuttycom/primitives/remove_sapling_fee_traits
zcash_primitives: Remove and relocate `InputView` traits.
2023-12-07 11:47:00 +00:00
Kris Nuttycombe 4eaa41affa zcash_primitives: Remove and relocate `InputView` traits. 2023-12-06 20:17:43 -07:00
str4d a9d6505148
Merge pull request #1059 from zcash/1044-extract-zip32
Extract `zip32` crate again
2023-12-06 18:46:35 +00:00
Jack Grigg 842ce36f7c Fix clippy lint 2023-12-06 18:19:15 +00:00
Jack Grigg d332aacf98 Merge branch 'main' into 1044-extract-zip32 2023-12-06 18:04:36 +00:00
Jack Grigg 3dfd478141 Migrate to published `zip32` crate outside this repository 2023-12-06 18:04:09 +00:00
Kris Nuttycombe 36cdc35428
Merge pull request #1055 from nuttycom/wallet/note_key_scope
Replace `SaplingReceivedNote` with `ReceivedNote`
2023-12-05 16:20:15 -07:00
Kris Nuttycombe ca54b3489d Apply suggestions from code review
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2023-12-05 15:55:52 -07:00
Jack Grigg 5aa0e6c6ee Revert "Convert zip32 crate into a module of zcash_primitives"
This reverts commit f25a8a557e.
2023-12-05 18:07:53 +00:00
Kris Nuttycombe cad4f25b75 zcash_client_backend: Replace `ReceivedSaplingNote` with `ReceivedNote`
`ReceivedNote` now allows Orchard notes to be represented as received
notes. As part of this change, received notes now track whether they
were received using internally- or externally-scoped viewing keys.
This eliminates the need to trial-regenerate notes using the wallet's
IVKs to determine scope at spend time.
2023-12-05 10:55:06 -07:00