Pass by const reference where possible.

Co-authored-by: Larry Ruane <larry@z.cash>
This commit is contained in:
Kris Nuttycombe 2020-07-07 09:41:32 -06:00 committed by GitHub
parent 88c5bf7217
commit 37b4faab6a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions

View File

@ -142,7 +142,7 @@ namespace Consensus {
const Consensus::Params& params,
const int startHeight,
const int endHeight,
const std::vector<std::string> strAddresses)
const std::vector<std::string>& strAddresses)
{
// Parse the address strings into concrete types.
std::vector<FundingStreamAddress> addresses;
@ -167,7 +167,7 @@ namespace Consensus {
FundingStreamIndex idx,
int startHeight,
int endHeight,
const std::vector<std::string> strAddresses)
const std::vector<std::string>& strAddresses)
{
vFundingStreams[idx] = FundingStream::ParseFundingStream(*this, startHeight, endHeight, strAddresses);
};

View File

@ -108,7 +108,7 @@ private:
int endHeight;
std::vector<FundingStreamAddress> addresses;
FundingStream(int startHeight, int endHeight, std::vector<FundingStreamAddress> addresses):
FundingStream(int startHeight, int endHeight, const std::vector<FundingStreamAddress>& addresses):
startHeight(startHeight), endHeight(endHeight), addresses(addresses) { }
public:
FundingStream(const FundingStream& fs):
@ -125,7 +125,7 @@ public:
const Consensus::Params& params,
const int startHeight,
const int endHeight,
const std::vector<std::string> strAddresses);
const std::vector<std::string>& strAddresses);
int GetStartHeight() const { return startHeight; };
int GetEndHeight() const { return endHeight; };
@ -212,7 +212,7 @@ struct Params {
FundingStreamIndex idx,
int startHeight,
int endHeight,
const std::vector<std::string> addresses);
const std::vector<std::string>& addresses);
/**
* Default block height at which the future timestamp soft fork rule activates.