Pass by const reference where possible.
Co-authored-by: Larry Ruane <larry@z.cash>
This commit is contained in:
parent
88c5bf7217
commit
37b4faab6a
|
@ -142,7 +142,7 @@ namespace Consensus {
|
||||||
const Consensus::Params& params,
|
const Consensus::Params& params,
|
||||||
const int startHeight,
|
const int startHeight,
|
||||||
const int endHeight,
|
const int endHeight,
|
||||||
const std::vector<std::string> strAddresses)
|
const std::vector<std::string>& strAddresses)
|
||||||
{
|
{
|
||||||
// Parse the address strings into concrete types.
|
// Parse the address strings into concrete types.
|
||||||
std::vector<FundingStreamAddress> addresses;
|
std::vector<FundingStreamAddress> addresses;
|
||||||
|
@ -167,7 +167,7 @@ namespace Consensus {
|
||||||
FundingStreamIndex idx,
|
FundingStreamIndex idx,
|
||||||
int startHeight,
|
int startHeight,
|
||||||
int endHeight,
|
int endHeight,
|
||||||
const std::vector<std::string> strAddresses)
|
const std::vector<std::string>& strAddresses)
|
||||||
{
|
{
|
||||||
vFundingStreams[idx] = FundingStream::ParseFundingStream(*this, startHeight, endHeight, strAddresses);
|
vFundingStreams[idx] = FundingStream::ParseFundingStream(*this, startHeight, endHeight, strAddresses);
|
||||||
};
|
};
|
||||||
|
|
|
@ -108,7 +108,7 @@ private:
|
||||||
int endHeight;
|
int endHeight;
|
||||||
std::vector<FundingStreamAddress> addresses;
|
std::vector<FundingStreamAddress> addresses;
|
||||||
|
|
||||||
FundingStream(int startHeight, int endHeight, std::vector<FundingStreamAddress> addresses):
|
FundingStream(int startHeight, int endHeight, const std::vector<FundingStreamAddress>& addresses):
|
||||||
startHeight(startHeight), endHeight(endHeight), addresses(addresses) { }
|
startHeight(startHeight), endHeight(endHeight), addresses(addresses) { }
|
||||||
public:
|
public:
|
||||||
FundingStream(const FundingStream& fs):
|
FundingStream(const FundingStream& fs):
|
||||||
|
@ -125,7 +125,7 @@ public:
|
||||||
const Consensus::Params& params,
|
const Consensus::Params& params,
|
||||||
const int startHeight,
|
const int startHeight,
|
||||||
const int endHeight,
|
const int endHeight,
|
||||||
const std::vector<std::string> strAddresses);
|
const std::vector<std::string>& strAddresses);
|
||||||
|
|
||||||
int GetStartHeight() const { return startHeight; };
|
int GetStartHeight() const { return startHeight; };
|
||||||
int GetEndHeight() const { return endHeight; };
|
int GetEndHeight() const { return endHeight; };
|
||||||
|
@ -212,7 +212,7 @@ struct Params {
|
||||||
FundingStreamIndex idx,
|
FundingStreamIndex idx,
|
||||||
int startHeight,
|
int startHeight,
|
||||||
int endHeight,
|
int endHeight,
|
||||||
const std::vector<std::string> addresses);
|
const std::vector<std::string>& addresses);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Default block height at which the future timestamp soft fork rule activates.
|
* Default block height at which the future timestamp soft fork rule activates.
|
||||||
|
|
Loading…
Reference in New Issue