zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Auto merge of #3716 - charlieok:initialize_params_in_transaction_builder_tests, r=daira 

initialize pCurrentParams in TransactionBuilder tests

In issue https://github.com/zcash/zcash/issues/3715 the failing tests were calling Params(), which includes an assertion that pCurrentParams is not null, without first calling SelectParams(), which will set that pointer. All the other tests in the same test case (which don't fail in the manner described in #3715 ) start out by calling `SelectParams(CBaseChainParams::REGTEST);`.

This change adds an identical call to the affected tests, getting past the failed assertion  in Params() on pCurrentParams.

Here is a GitLab pipeline showing output from these tests run in isolation before this change:
https://gitlab.com/charlieok/zcash/pipelines/38304730

...and here is one with the same set of tests after this change:
https://gitlab.com/charlieok/zcash/pipelines/38307556
This commit is contained in:
Homu 2018-12-16 06:01:54 -08:00
parent c4d352166d 67d2b19caa
commit e84b865a55
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/gtest/test_transaction_builder.cpp
View File

@ -95,6 +95,7 @@ TEST(TransactionBuilder, Invoke)
TEST(TransactionBuilder, ThrowsOnTransparentInputWithoutKeyStore)
{
SelectParams(CBaseChainParams::REGTEST);
auto consensusParams = Params().GetConsensus();
auto builder = TransactionBuilder(consensusParams, 1);
@ -103,6 +104,7 @@ TEST(TransactionBuilder, ThrowsOnTransparentInputWithoutKeyStore)
TEST(TransactionBuilder, RejectsInvalidTransparentOutput)
{
SelectParams(CBaseChainParams::REGTEST);
auto consensusParams = Params().GetConsensus();
// Default CTxDestination type is an invalid address
@ -113,6 +115,7 @@ TEST(TransactionBuilder, RejectsInvalidTransparentOutput)
TEST(TransactionBuilder, RejectsInvalidTransparentChangeAddress)
{
SelectParams(CBaseChainParams::REGTEST);
auto consensusParams = Params().GetConsensus();
// Default CTxDestination type is an invalid address