Daira Hopwood
1ef5372859
Update release notes: z_getnotescount already had the minconf parameter
...
Co-authored-by: Greg Pfeil <greg@technomadic.org>
2022-11-28 14:08:55 -07:00
Daira Hopwood
1dd4be5474
Add release notes for #6122 (`asOfHeight` RPC parameters).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-28 14:08:47 -07:00
str4d
32df2e6b7b
Merge pull request #6263 from sellout/release-v5.3.1-rc1
...
Release v5.3.1-rc1
2022-11-24 12:27:34 +00:00
Greg Pfeil
761b764b51
make-release.py: Updated release notes and changelog for 5.3.1-rc1.
2022-11-23 22:18:55 -07:00
Greg Pfeil
4ec715c6db
make-release.py: Updated manpages for 5.3.1-rc1.
2022-11-23 22:18:54 -07:00
Greg Pfeil
0647a9ba24
make-release.py: Versioning changes for 5.3.1-rc1.
2022-11-23 22:09:24 -07:00
Greg Pfeil
3de2348987
Postpone dependency updates for v5.3.1
2022-11-23 22:05:45 -07:00
Greg Pfeil
f6a4f68115
Merge pull request #6122 from nuttycom/wallet/listunspent_as_of
...
Add `asOfHeight` argument across the RPC API
2022-11-23 21:20:20 -07:00
Greg Pfeil
583fbb2218
Simplify filtering AvailableCoins by destination
2022-11-23 11:51:22 -07:00
Greg Pfeil
2eb29c2a66
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-11-23 11:00:10 -07:00
Greg Pfeil
368d04245d
Change asOfHeight to preserve Bitcoin compat
2022-11-22 22:06:51 -07:00
Greg Pfeil
4b2203a1fd
Change asOfHeight to use -1 as default
2022-11-22 16:47:40 -07:00
Greg Pfeil
6421f47ef7
Revert getinfo support of asOfHeight
...
This operation is practically deprecated, so don’t change it.
2022-11-22 16:47:40 -07:00
Greg Pfeil
7792228bab
Revert change to getbalance minconf
...
It was the docs that were wrong. In this case, the default `minconf` _should_ be
0 (to match upstream).
2022-11-22 16:47:40 -07:00
Greg Pfeil
d444f8b586
Fix small error in code review suggestions
2022-11-22 16:47:40 -07:00
Greg Pfeil
f290b9a7b4
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-11-22 15:59:07 -07:00
Daira Hopwood
6284f3f8b0
Merge pull request #6231 from miodragpop/headers-first-rebirth
...
Headers-first fix
2022-11-22 19:27:03 +00:00
Greg Pfeil
5ea600a102
Update src/rpc/server.cpp
...
Co-authored-by: Kris Nuttycombe <kris.nuttycombe@gmail.com>
2022-11-22 10:38:21 -07:00
Greg Pfeil
4f85307186
Add FIXMEs to repair comments after #6262 is fixed
2022-11-22 10:36:34 -07:00
Kris Nuttycombe
0a87047186
Merge pull request #6245 from sellout/wallet_accounts-formatting
...
Small formatting change
2022-11-22 07:55:40 -07:00
Kris Nuttycombe
30846624da
Merge pull request #6246 from sellout/zsendmany-docs
...
Improve z_sendmany documentation
2022-11-22 07:55:02 -07:00
str4d
b9158fe377
Merge pull request #6259 from str4d/debugmetrics
...
Place zcashd.debug.* metrics behind a -debugmetrics config option
2022-11-22 06:05:47 +00:00
Greg Pfeil
b27fdf54fd
Add matured_at_height test helper
2022-11-21 22:36:12 -07:00
Greg Pfeil
3b3f8f4cac
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-11-21 21:15:07 -07:00
Greg Pfeil
77fb36a422
Don’t trust mempool tx when using `asOfHeight`
2022-11-21 20:44:21 -07:00
Greg Pfeil
71b5f99ede
Work around #6262 in wallet_listunspent
2022-11-21 20:44:21 -07:00
Greg Pfeil
08469bd3c0
Add error cases and default to `asOfHeight`
2022-11-21 20:44:21 -07:00
Greg Pfeil
13d79c453b
Require minconf > 0 when asOfHeight is provided
2022-11-21 20:44:21 -07:00
Greg Pfeil
7f79b6b93d
GetUnconfirmedBalance should not take asOfHeight
...
This also
* renames `GetUnconfirmedBalance` to `GetUnconfirmedTransparentBalance`,
* reverts the `getunconfirmedbalance` RPC call to not accept `asOfHeight`,
* conditionalizes `getwalletinfo` to only include unconfirmed balances in calls
without `asOfHeight`, and
* removes the unused `Get*WatchOnlyBalance` functions.
2022-11-21 20:44:21 -07:00
Greg Pfeil
4b91d81e6f
Fix calls that should have specified asOfHeight
2022-11-21 20:44:21 -07:00
Greg Pfeil
952a1ac433
Ignore mempool when asOfHeight is set
...
This also catches a case where the default minconf was 0 (which disagreed with
the docs), and a case where asOfHeight checked the wrong param entry.
2022-11-21 20:44:21 -07:00
Daira Hopwood
154e4dfb2e
Update constants
...
@str4d and @daira decided on these.
2022-11-21 23:16:00 +00:00
str4d
c267c3ee26
Merge pull request #6192 from daira/reduce-equihash-solution-memory
...
Reduce memory usage of CBlockIndex
2022-11-21 22:25:30 +00:00
Jack Grigg
93de2aae0e
Place zcashd.debug.* metrics behind a -debugmetrics config option
2022-11-21 20:50:02 +00:00
Daira Hopwood
fb66589022
Declare `CBlockTreeDB::Read*` methods as `const` when they are trivially so.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-21 18:24:45 +00:00
Daira Hopwood
089acd75f7
Add Prometheus metrics so we have more visibility into what is going
...
on with the Equihash solution trimming:
* (counter) `zcashd.debug.memory.allocated_equihash_solutions` -
the number of Equihash solutions that have ever been allocated;
* (counter) `zcashd.debug.memory.trimmed_equihash_solutions` -
the number of Equihash solutions that were trimmed;
* (counter) `zcashd.debug.blocktree.trimmed_equihash_read_dbindex` -
the number of times a block index entry needed to be reread to
construct a block header because a solution had been trimmed;
* (counter) `zcashd.debug.blocktree.write_batch` -
the number of block tree batch write operations (calls to
`CBlockTreeDB::WriteBatchSync`);
* (counter) `zcashd.debug.blocktree.write_batch_read_dbindex` -
the number of times a block index entry needed to be reread
before being written during a block tree batch write operation.
These metrics are specific to `zcashd`; they are primarily intended
for performance debugging of this feature and should not be considered
stable.
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-21 18:24:45 +00:00
Daira Hopwood
8c958e13a5
Improve handling of database read errors.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-21 18:24:45 +00:00
Daira Hopwood
aee8d5c0ec
Avoid storing the Equihash solution in a CBlockIndex object once it has been written
...
to the leveldb database.
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-21 18:24:45 +00:00
Greg Pfeil
e4426a725c
Extract asOfHeight info from RPC calls
2022-11-19 01:03:28 -07:00
Greg Pfeil
10eb43c232
Don’t ignore asOfHeight in IsSpent calls
2022-11-18 21:39:39 -07:00
Daira Hopwood
27ffefed12
Merge pull request #6248 from sellout/reuse-python
...
Avoid inconsistent Python lookup
2022-11-18 22:52:38 +00:00
Greg Pfeil
d796114b2e
Add additional asOfHeight tests
2022-11-18 01:20:00 -07:00
Greg Pfeil
d01c5e744c
Implement `asOfHeight`
2022-11-18 01:20:00 -07:00
Greg Pfeil
659077aff2
Propagate asOfHeight to all relevant RPC calls
...
This removes the default `std::nullopt`[^1] and threads `asOfHeight` through the
call graph, only using `std::nullopt` where it is unconditionally correct (e.g.,
where we would be creating a tx, and thus need the actual chain tip).
This does not change deprecated or legacy operations.
[^1]: Having a default makes it easy to miss call sites that should be
updated. If a default is deemed useful, it should be added in a separate
commit, so that all call sites can be reviewed in an earlier commit.
2022-11-18 01:20:00 -07:00
Kris Nuttycombe
2c487c9430
Add RPC test for wallet_listunspent changes
2022-11-18 01:20:00 -07:00
Kris Nuttycombe
b745992489
Add `unspent_as_of` argument to `listunspent`
...
This makes it possible for `listunspent` to return utxos unspent as of a
particular depth in the main chain.
2022-11-18 01:20:00 -07:00
Greg Pfeil
d6c671c606
Merge pull request #6255 from 0xidm/0xidm-patch-1-clang-aarch64
...
fix aarch64 dependency native clang download URL
2022-11-17 14:32:48 -07:00
Daira Hopwood
22d262f67d
Merge pull request #6253 from daira/fix-show-help
...
Fix `show_help` and `receivedby` RPC tests
2022-11-15 20:15:51 +00:00
idm
2257e38efc
fix aarch64 dependency native clang download URL
...
Added assignment statement `$(package)_download_path_aarch64_linux` to ensure path for aarch clang is used.
2022-11-15 10:26:28 -05:00
Daira Hopwood
3529097153
Fix a dependency of the `show_help` RPC test on the number of cores,
...
and an incompatibility with Python 3.9 in the test framework that
affected the `receivedby` extended RPC test.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-15 13:58:26 +00:00