29e65bf536
Tolerate missing cached conflict data in ThreadNotifyWallets
2023-01-26 16:51:23 -07:00
887b2688df
Remove unused DEFAULT_BATCHSCANNERMEMLIMIT constant.
2023-01-26 12:33:55 -07:00
aab58d308f
Bound wallet batch scanner size to 1000 blocks instead of 100 MiB
...
1000 blocks was selected as a balance between limiting the likely
maximum memory usage of the batch scanner, and avoiding
artificially restricting scanning throughput of small/fast blocks
due to the second-boundary lock synchronization point.
This also removes the `zcashd.wallet.batchscanner.usage.bytes` gague
value that was previously made available when `-prometheusport` was
specified.
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-26 12:26:31 -07:00
ce694802d9
Fetch recently conflicted transactions incrementally in ThreadNotifyWallet.
...
We no longer fetch updates from the mempool unless we have fetched all
updates from the chain, as we would otherwise notify the wallet of
mempool changes for which they have not observed parent transactions
in the chain.
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-26 12:26:31 -07:00
069159b8c1
Merge commit '267ddf8efe36cc799c4c31772a8883ea332ef55b' into version-5.4.0
2023-01-26 09:30:33 -07:00
cc068329d5
Merge pull request #6370 from nuttycom/bug/dumpwallet_help
...
Fixes an error in `zcash-cli help` following the removal of `dumpwallet`.
2023-01-26 00:48:52 +00:00
25c62d804a
Fixes an error in `zcash-cli help` following the removal of `dumpwallet`.
2023-01-25 16:57:29 -07:00
a1589ac994
Merge pull request #6364 from str4d/release-v5.4.0-rc2
...
Release v5.4.0-rc2
2023-01-23 21:22:09 -07:00
6d182d7ae7
Update doc/release-notes.md
...
Minor wording correction.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-23 19:15:35 -07:00
214c3007f5
Enable tests of chain supply & transparent pool balance.
2023-01-24 02:13:05 +00:00
f5b123e494
make-release.py: Updated release notes and changelog for 5.4.0-rc2.
2023-01-24 02:13:05 +00:00
ad24667c1a
make-release.py: Updated manpages for 5.4.0-rc2.
2023-01-24 02:13:05 +00:00
ae7c2c742d
make-release.py: Versioning changes for 5.4.0-rc2.
2023-01-24 02:13:05 +00:00
8f4fff4529
Update release notes with notable changes for v5.4.0
2023-01-24 02:13:05 +00:00
5b74dbfddd
metrics: Update `zcash.pool.value.zatoshis` gauge for transparent pool
2023-01-24 02:13:05 +00:00
0ff03e9693
depends: Postpone cxx update
2023-01-24 02:12:55 +00:00
d6e2fada84
Merge pull request #6362 from nuttycom/issue2921-fix-copyright-headers
...
Replace fix-copyright-headers.py with a script that creates a scripted-diff git commit.
2023-01-23 22:13:05 +00:00
0e931a9397
Merge pull request #4470 from oxarbitrage/issue4294
...
Add transparent value pool to RPC calls
2023-01-23 21:55:00 +00:00
0f886c32fe
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2023-01-23 13:23:20 -07:00
3cec519ce4
scripted-diff: Update Zcash copyrights to 2023
...
-BEGIN VERIFY SCRIPT-
for party in "The Zcash developers" "The Bitcoin Core developers" "Bitcoin Developers"; do
sed -i"" -e "s#Copyright (c) \([0-9]\{4\}\)\(-[0-9]\{4\}\)\? $party#Copyright (c) \1-2023 $party#" COPYING
sed -i"" -e "s#\(.*\)\([0-9]\{4\}\)\(-[0-9]\{4\}\)\, $party#\1\2-2023, $party#" contrib/debian/copyright
done
sed -i"" -e "s/define(_COPYRIGHT_YEAR, [0-9]\{4\})/define(_COPYRIGHT_YEAR, 2023)/" configure.ac
sed -i"" -e "s/#define COPYRIGHT_YEAR [0-9]\{4\}/#define COPYRIGHT_YEAR 2023/" src/clientversion.h
git grep "^// Copyright (c) .* The Zcash developers" \
| awk -F ':' '{print $1}' \
| xargs -I {} sed -i"" -e "s#// Copyright (c) \([0-9]\{4\}\)\(-[0-9]\{4\}\)\? The Zcash developers#// Copyright (c) \1-2023 The Zcash developers#" {}
-END VERIFY SCRIPT-
2023-01-23 11:31:54 -07:00
b8fe1d2b78
Replace fix-copyright-headers.py with a script that creates a scripted-diff git commit.
...
Fixes #2921
Supersedes #4926
2023-01-23 11:31:41 -07:00
57ca26867b
Remove unnecessary delta_count variable.
2023-01-22 22:21:02 -07:00
193b22b754
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 11:33:23 -07:00
810c191216
Add script for verifying block rewards and fees not claimed by miners.
...
Co-authored-by: Jack Grigg <jack@z.cash>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
2fd52ada51
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
aa78fc0878
Verify sum of pool balances against chain total supply.
...
Co-authored-by: Jack Grigg <jack@z.cash>
2023-01-22 09:10:03 -07:00
486817498f
Add chain supply and transparent value to block index.
...
Co-authored-by: Jack Grigg <jack@z.cash>
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-01-22 09:10:03 -07:00
267ddf8efe
qa: Enable RPC test execution to be overridden from Python
...
`run_tests` now takes a (subclass of) `RPCTestHandler` as its first
argument, and returns `True` if all tests passed instead of calling
`sys.exit`. This enables RPC tests to be run from Python and the
execution of individual tests to be customised:
```python
import importlib
import sys
sys.path.append('qa/pull-tester')
rpc_tests = importlib.import_module('rpc-tests')
src_dir = '.'
build_dir = '.'
exeext = ''
class MyTestHandler(rpc_tests.RPCTestHandler):
def start_test(self, args, stdout, stderr):
print('Starting test!')
return subprocess.Popen(
args,
universal_newlines=True,
stdout=stdout,
stderr=stderr)
test_list = ['test_to_run.py']
all_passed = rpc_tests.run_tests(MyTestHandler, test_list, src_dir, build_dir, exeext)
```
2023-01-20 13:50:41 +00:00
1b72c1177d
Merge pull request #6357 from str4d/release-v5.4.0-rc1
...
Release v5.4.0-rc1
2023-01-20 04:02:54 +00:00
227887490b
make-release.py: Updated release notes and changelog for 5.4.0-rc1.
2023-01-19 22:57:59 +00:00
c426545081
make-release.py: Updated manpages for 5.4.0-rc1.
2023-01-19 22:57:58 +00:00
072fc26e3e
make-release.py: Versioning changes for 5.4.0-rc1.
2023-01-19 22:50:16 +00:00
95c6ff635d
depends: CMake 3.25.2
2023-01-19 22:48:36 +00:00
c94b3f40d1
doc: Fix arguments to make-release.py in hotfix process
...
Closes zcash/zcash#6280 .
2023-01-19 22:33:05 +00:00
9e1efad2d1
Merge pull request #6312 from str4d/6308-backport-6898
...
Backport `CreateNewBlock` rewrite
2023-01-19 21:47:20 +00:00
6ec042dd51
Merge pull request #6343 from rex4539/typos
...
Fix typos
2023-01-18 23:22:44 +00:00
8bc5740003
Merge pull request #6348 from str4d/update-deps-5.4.0
...
Update dependencies for 5.4.0 and fix some help messages
2023-01-13 16:18:10 +00:00
e490b7ff4f
qa: Update show_help RPC test
2023-01-13 02:57:39 +00:00
579e7d1e75
Merge pull request #6347 from daira/increase-wallet-timeout
...
Increase the time that the wallet will wait for the block index to load
2023-01-13 01:02:57 +00:00
7e42041772
Document -clockoffset option
2023-01-13 00:43:46 +00:00
0de7a08c86
cargo update
2023-01-13 00:33:13 +00:00
e91fe01387
depends: Update cxx to 1.0.83
2023-01-13 00:33:13 +00:00
9208bdaadd
qa: Postpone LLVM 15 and CCache 4.7 updates
2023-01-13 00:33:13 +00:00
0e33a7b313
depends: utfcpp 3.2.3
2023-01-13 00:33:13 +00:00
af8f1c207e
depends: Boost 1.81.0
2023-01-13 00:33:13 +00:00
0d17460c85
depends: Add tl_expected to update checker
2023-01-13 00:33:13 +00:00
828c63ecc4
init: Fix help message for checkblockindex
...
(cherry picked from commit bitcoin/bitcoin@4ae7d1529e )
2023-01-13 00:32:42 +00:00
fae6cd175c
Change the time that the wallet will wait for the block index to load from 5 minutes to 2 hours.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-01-13 00:02:03 +00:00
3748f3b83a
Fix typos
2023-01-13 00:49:12 +02:00
18b9f8fbd1
Merge pull request #6346 from daira/cleanup-exportwallet
...
Cleanup after removing dumpwallet
2023-01-12 22:37:09 +00:00
Kris Nuttycombe
str4d
Jack Grigg
Alfredo Garcia
Jack Grigg
MarcoFalke
Daira Hopwood
Dimitris Apostolou