Daira Hopwood
340840894a
Tweaks to message text.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-14 08:24:25 +00:00
Daira Hopwood
6ee6692c83
qa/zcash/full_test_suite.py: enable `test_rpath_runpath` for Rust binaries, and
...
reenable `test_fortify_source` for C++ binaries.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-14 08:05:59 +00:00
Daira Hopwood
1d31d4bc7c
Include $(bin_SCRIPTS) in `check-symbols`, `check-security`, and `clean` targets.
...
Checking for stack canaries in `check-security` is disabled for Rust executables
(Rust does support `-Z stack-protector=all` but only for the nightly compiler).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-13 22:53:29 +00:00
Daira Hopwood
55d14faebf
Correct the fallback instruction for how to clear the terminal on macOS: pressing Command + K
...
also clears scrollback.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-13 18:25:40 +00:00
Daira Hopwood
ccada66324
Simplify debug tracing.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-12 12:56:32 +00:00
Daira Hopwood
577f695af5
Set `meta` for `-datadir` option.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 19:02:31 +00:00
Daira Hopwood
3e36252d9a
Document that '~' cannot be used in `-datadir` (see #5661 ).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 18:35:52 +00:00
Daira Hopwood
d5b6e226f0
Ensure the buffer used in `prompt` is zeroized even on error.
...
Co-authored-by: Jack Grigg <str4d@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 18:21:11 +00:00
Daira Hopwood
7a98644ff2
Improve error message when the config file cannot be found, taking into account -conf and -datadir.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 18:16:40 +00:00
Daira Hopwood
cb2c89eedf
Use the tracing crate for debugging.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-11 17:17:56 +00:00
Daira Hopwood
799b46b90a
Cleanups to error handling for the first invocation of zcash-cli.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-10 17:18:26 +00:00
Daira Hopwood
999b395360
Improve memory hygiene, and use -stdin to pass the recovery phrase to the child zcash-cli process.
...
Co-authored-by: Jack Grigg <str4d@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-10 17:17:06 +00:00
Daira Hopwood
d4405feddf
Simplify extraction of recovery phrase.
...
Co-authored-by: Jack Grigg <str4d@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-09 18:04:27 +00:00
Daira Hopwood
9b20105413
Tweak the wording of the fallback messages when the terminal cannot be automatically cleared.
...
Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 19:34:31 +00:00
Daira Hopwood
6fb943d0f6
Refactor use of `export_path` as suggested.
...
Co-authored-by: Sean Bowe <sean@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 19:33:27 +00:00
Daira Hopwood
e940829313
The recovery phrase confirmation and `zcashd-wallet-tool` are being introduced in zcashd v4.7.0.
...
Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 19:32:51 +00:00
Daira Hopwood
6f5efcbb0f
Improved error handling.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
Daira Hopwood
25792cba93
Move `wallet_tool.rs` from `src/rust/src` into `src/rust/bin`.
...
Also add a brief description of `zcashd-wallet-tool` to `src/rust/README.md`.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
Daira Hopwood
8ec0d854b9
Add some text about choosing location of the physical backup.
...
Add TODO for better handling of file not found and permission errors.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
Daira Hopwood
de933c1cb5
Attempt to fix linking problem on ARM.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
Daira Hopwood
a36fceca70
Make a zcashd-wallet-tool executable.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-03-07 18:39:23 +00:00
str4d
13351ff31d
Merge pull request #5609 from str4d/bump-deps-4.7.0-rc1
...
Bump dependencies ahead of 4.7.0-rc1
2022-03-05 13:37:28 +00:00
Jack Grigg
fdb5709e7e
depends: Revert to `libc++ 13.0.0-3` for Windows cross-compile
...
The 13.0.1-1 MSYS2 binaries cause linker errors due to missing `new` and
`delete` symbols. This commit partially reverts the LLVM 13.0.1 upgrade:
Windows cross-compilation still uses `clang 13.0.1`, but is compiled
against `libc++ 13.0.0`.
2022-03-05 03:53:13 +00:00
Charlie O'Keefe
e33178615c
Merge pull request #5581 from LarryRuane/2022-02-log-getblocktemplate
...
Log calls to getblocktemplate
2022-03-03 15:56:34 -07:00
Charlie O'Keefe
c2b5bf0c42
Merge pull request #5622 from nuttycom/logging/sapling_note_witnesses
...
Log outpoint for failed Sapling witness lookup.
2022-03-03 15:21:10 -07:00
str4d
d4a019e89b
Merge pull request #5621 from nuttycom/test/orchard_tree_ser_roundtrip
...
Add a roundtrip test for Orchard merkle frontier serialization from the C++ side.
2022-03-03 21:56:41 +00:00
Kris Nuttycombe
8b44cc7072
Add a roundtrip test for Orchard merkle frontier serialization from the C++ side.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2022-03-03 11:04:40 -07:00
Kris Nuttycombe
ceff068e20
Merge pull request #5625 from therealyingtong/orchard-remove-with-anchor
...
Orchard: invalidate mempool transactions that use orphaned anchors.
2022-03-03 10:58:08 -07:00
Daira Hopwood
5990853de3
Merge pull request #5623 from str4d/nu5-fix-orchard-commitment-tree-bugs
...
Fix for chain forks on NU5 testnet
2022-03-03 15:21:58 +00:00
Kris Nuttycombe
fd2f5bdc28
Merge pull request #5610 from therealyingtong/debug-any-taddr
...
Ignore expired transactions in `CWallet::FindSpendableInputs`.
2022-03-03 08:08:06 -07:00
Jack Grigg
ae3d2a3525
Add missing `view.PopAnchor(_, ORCHARD)` in `DisconnectBlock`
...
By forgetting to pop the tree, we were leaving the view in an
inconsistent state, where it believed the best Orchard anchor was for a
tree that didn't correspond to the rest of the view. This would then
propagate in subsequent block connections, and the chain history
commitments to Orchard tree roots eventually result in inconsistent
`blockcommitments` values in subsequent blocks.
2022-03-03 13:26:48 +00:00
Jack Grigg
2230ba912f
Ensure the view's best Orchard anchor matches the previous block
...
`ConnectBlock` was already checking that the given view's "best block"
was the previous block. However, it then assumed the view was correct on
its claimed best anchors.
For Orchard, we know that `hashFinalOrchardRoot` field of `CBlockIndex`
will only ever be set when a block is (attempted to be) connected to the
main chain, and so we can instead add assertions around its value and
ensure the view is consistent with the previous block.
2022-03-03 13:26:48 +00:00
therealyingtong
dbb7e027c8
Orchard: invalidate mempool transactions that use orphaned anchors.
2022-03-03 17:37:07 +08:00
Kris Nuttycombe
681505e9d6
Log outpoint for failed Sapling witness lookup.
2022-03-02 16:00:15 -07:00
therealyingtong
cedf2b5ecb
wallet_sendmany_any_taddr.py: Expect expired tx to be ignored.
2022-03-03 01:31:32 +08:00
therealyingtong
454c1eed46
FindSpendableInputs: Add nDepth < 0 check.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2022-03-03 01:31:32 +08:00
therealyingtong
98cd4bab0b
wallet_sendmany_any_taddr.py: Test sending output from expired tx.
2022-03-03 01:31:32 +08:00
Kris Nuttycombe
5141c2971c
Merge pull request #5594 from LarryRuane/2022-02-getblocktemplate-locking
...
Fix csBestBlock/cvBlockChange waiting in rpc/mining
2022-03-01 20:08:29 -07:00
Larry Ruane
e170c3abd6
document global variables
2022-03-01 17:43:43 -07:00
Pieter Wuille
c079a518c0
Modernize best block mutex/cv/hash variable naming
...
(cherry picked from commit bitcoin/bitcoin@4a6c0e3dcf )
2022-03-01 17:09:19 -07:00
Pieter Wuille
4693f8165f
Fix csBestBlock/cvBlockChange waiting in rpc/mining
...
(cherry picked from commit bitcoin/bitcoin@45dd135039 )
2022-03-01 17:09:19 -07:00
therealyingtong
4a8bdabb2f
wallet_sendmany_any_taddr.py: Test sending from a change taddr.
2022-03-01 11:33:54 +08:00
Jack Grigg
b5ce94d16c
rust: Fix clippy lint
2022-03-01 01:35:46 +00:00
Jack Grigg
7b7dddba0c
cargo update
2022-03-01 00:34:02 +00:00
Jack Grigg
2f1fbcc81f
depends: Update Clang / libcxx to LLVM 13.0.1
2022-03-01 00:30:32 +00:00
Jack Grigg
21430b13ac
depends: Update Rust to 1.59.0
2022-03-01 00:09:18 +00:00
Jack Grigg
adb7d074d5
qa: Postpone recent CCache release
2022-03-01 00:05:01 +00:00
Jack Grigg
4c49af7750
qa: Bump all postponed dependencies
...
We have a pending PR to address the `native_ccache` and `googletest`
dependencies, and we aren't going to touch `bdb`.
2022-03-01 00:03:42 +00:00
Kris Nuttycombe
18f443db1c
Merge pull request #5604 from nuttycom/fix_missing_wallet_lock
...
GenerateNewKey must be guarded by a cs_wallet lock
2022-02-27 09:20:44 -07:00
Kris Nuttycombe
399ffa7f5c
GenerateNewKey must be guarded by a cs_wallet lock
2022-02-26 20:13:38 -07:00