Commit Graph

12782 Commits

Author SHA1 Message Date
Jack Grigg 363c945325
Initialize experimental mode in a separate function 2019-12-04 17:18:38 +00:00
Jonas Schnelli a425ac9706
Initialize logging before we do parameter interaction 2019-12-04 17:18:37 +00:00
Jonas Schnelli ef6b9b0fb2
Refactor parameter interaction, call it before AppInit2() 2019-12-04 17:18:36 +00:00
Luke Dashjr 5bedad9580
Bugfix: Omit wallet-related options from -help when wallet is disabled 2019-12-04 17:18:35 +00:00
Luke Dashjr a624c49219
Bugfix: If genproclimit is omitted to RPC setgenerate, don't change it; also show correct default in getmininginfo 2019-12-04 17:18:34 +00:00
Luke Dashjr 3779bea091
Bugfix: Describe dblogsize option correctly (it refers to the wallet database, not memory pool) 2019-12-04 17:18:33 +00:00
Luke Dashjr b90ea483dd
Bugfix: RPC: blockchain: Display correct defaults in help for verifychain method 2019-12-04 17:18:32 +00:00
Jorge Timón bd87de60ed
Chainparams: Translations: DRY: options and error strings
Also remove SelectBaseParamsFromCommandLine and SelectParamsFromCommandLine
2019-12-04 17:18:31 +00:00
Jorge Timón af9b9652fa
Chainparams: Replace CBaseChainParams::Network enum with string constants (suggested by Wladimir) 2019-12-04 17:18:30 +00:00
Casey Rodarmor aa1d014b40
Give a better error message if system clock is bad
Fixes #2007

This checks to see if the system clock appears to be bad and gives a
helpful error message. If the user's clock is set incorrectly, hopefully
they'll abort, fix it, and then save themselves a fruitless resync.
2019-12-04 17:18:29 +00:00
Wladimir J. van der Laan 921e9a2e53
doc: mention change to option parsing behavior in release notes 2019-12-04 17:18:28 +00:00
Wladimir J. van der Laan 5514316892
Fix argument parsing oddity with -noX
`bitcoind -X -noX` ends up, unintuitively, with `X` set.
(for all boolean options X)

This result is due to the odd two-pass processing of arguments. This
patch fixes this oddity and simplifies the code at the same time.
2019-12-04 17:18:27 +00:00
Gavin Andresen b346588c13
Unit test doublespends in new blocks
As suggested by Greg Maxwell-- unit test to make sure a block
with a double-spend in it doesn't pass validation if half of
the double-spend is already in the memory pool (so full-blown
transaction validation is skipped) when the block is received.
2019-12-04 17:13:57 +00:00
Homu 5e26d48a39 Auto merge of #4226 - str4d:2074-wallet-1, r=mdr0id
Bitcoin 0.12 wallet PRs 1

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6057
- bitcoin/bitcoin#6415

Part of #2074. Closes #3700.
2019-12-03 06:53:27 +00:00
Homu cc807987c9 Auto merge of #4244 - charlieok:add_check_depends_build_step, r=mdr0id
Add check-depends step to STAGE_COMMANDS list

Added to the beginning of the list of stage commands
2019-12-03 03:11:32 +00:00
Homu 2d4b6f9cc2 Auto merge of #4243 - mdr0id:ipv6_rpc_patch, r=mdr0id
IPv6 RPC patch

Cherry-picked from bitcoin/bitcoin#7489.

To support CI updates via GKE, this patch ensures hosts using only IPv4 can function gracefully on `proxy_test.py`.
2019-12-03 01:42:47 +00:00
Marshall Gaucher 017682f993
Update to stop random race error from assert 2019-12-02 17:39:00 -08:00
Marshall Gaucher acea0f7715
Update z_sendmany calls passing int 0, instead of Decimal('0') 2019-12-02 15:37:10 -08:00
str4d 6d57fcff13
Apply suggestions from code review
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-12-02 21:10:35 +00:00
Marshall Gaucher 62f5bdfbdc
Update `import *` to unblock pyflakes from failing 2019-12-02 11:38:33 -08:00
Charlie O'Keefe d4f70e5536 Add check-depends step to STAGE_COMMANDS list 2019-11-27 14:12:18 -08:00
Wladimir J. van der Laan e427f70a8c make proxy_test work on servers without ipv6 2019-11-27 10:38:14 -08:00
Matt Corallo 4f3f8899b3
SQUASH "Implement watchonly support in fundrawtransaction" 2019-11-14 15:52:26 +00:00
Matt Corallo f70fdf4efe
SQUASH "Add have-pubkey distinction to ISMINE flags" 2019-11-14 15:52:23 +00:00
Matt Corallo 60dc0a9e8e
Implement watchonly support in fundrawtransaction
Some code and test cases stolen from
Bryan Bishop <bryan@ledgerx.com> (pull #5524).
2019-11-14 15:46:07 +00:00
Matt Corallo e61f62923b
Add logic to track pubkeys as watch-only, not just scripts 2019-11-14 15:46:06 +00:00
Matt Corallo bd9987829a
Add have-pubkey distinction to ISMINE flags
This indicates that, eg, we have a public key for a key which may
be used as a pay-to-pubkey-hash. It generally means that we can
create a valid scriptSig except for missing private key(s) with
which to create signatures.
2019-11-14 15:46:02 +00:00
Matt Corallo a2f31aa50b
Update importaddress help to push its use to script-only 2019-11-14 15:10:52 +00:00
Matt Corallo 24df8c66dc
Add importpubkey method to import a watch-only pubkey 2019-11-14 15:10:33 +00:00
Matt Corallo a0d211537c
Add p2sh option to importaddress to import redeemScripts 2019-11-14 14:48:21 +00:00
Matt Corallo 14d1666bd3
Split up importaddress into helper functions 2019-11-14 14:40:11 +00:00
Matt Corallo 4ffc8e27e1
Also remove pay-2-pubkey from watch when adding a priv key 2019-11-14 13:56:20 +00:00
Jonas Schnelli ea4ee8a222
[squashme] improve/corrects prune mode detection test for required wallet rescans 2019-11-14 13:56:19 +00:00
Jonas Schnelli c4447e3df1
[RPC] disable import functions in pruned mode
import functions could lead to a rescan beyond prune level
2019-11-14 13:56:18 +00:00
Jonas Schnelli d510fb4aa4
[autoprune] allow wallet in pruned mode 2019-11-14 13:56:17 +00:00
Homu f859ae0067 Auto merge of #4216 - str4d:4214-windows-fix, r=mdr0id
Cast uint8* in InterruptibleRecv to char* for recv

Fixes a Windows-specific compile bug introduced in #4212.
Closes #4214.
2019-11-11 10:52:47 -08:00
Homu 019507a8ef Auto merge of #4179 - defuse:fuzz-addrman, r=str4d
Add More Fuzzing Targets
2019-11-11 03:14:26 -08:00
Homu fd8444d0b7 Auto merge of #4178 - oxarbitrage:issue3731, r=str4d
Remove z_mergetoaddress from experimental state

Closes #3731.
2019-11-11 01:57:21 -08:00
Jack Grigg 8f170cf033
Cast uint8* in InterruptibleRecv to char* for recv
Fixes a Windows-specific compile bug introduced in #4212.
Closes #4214.
2019-11-11 09:47:38 +00:00
Homu 98b70f1264 Auto merge of #4215 - zcash:hotfix-2.1.0-1, r=str4d
Hotfix v2.1.0-1
2019-11-09 08:05:33 -08:00
str4d 253fcaa997
Merge pull request #4213 from str4d/release-v2.1.0-1
Release v2.1.0-1
2019-11-08 20:23:28 +00:00
Jack Grigg 501ca0c2ec
make-release.py: Updated release notes and changelog for 2.1.0-1. 2019-11-08 18:56:32 +00:00
Jack Grigg 66e0605407
make-release.py: Updated manpages for 2.1.0-1. 2019-11-08 18:56:31 +00:00
Jack Grigg e07604a132
make-release.py: Versioning changes for 2.1.0-1. 2019-11-08 18:34:15 +00:00
ebfull cd5986c244
Merge pull request #4212 from ebfull/fix-CVE-2017-18350
Fix CVE-2017-18350
2019-11-08 11:18:36 -07:00
Sean Bowe 812d0ac44b
Fix of CVE-2017-18350
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan.

Co-Authored-By: Jack Grigg <jack@electriccoin.co>
Co-Authored-By: Daira Hopwood <daira@electriccoin.co>
2019-11-08 09:26:17 -07:00
Homu 18df8e67e1 Auto merge of #4181 - oxarbitrage:issue4084, r=Eirik0
Display "next upgrade" info on metrics screen

Closes #4084.
2019-11-07 11:41:54 -08:00
Alfredo Garcia 8aac988a82 get UPGRADE_TESTDUMMY back to default at the end of the test 2019-11-07 14:28:14 -03:00
Homu 362739c5cc Auto merge of #4182 - Jainan-Tandel:master, r=Eirik0
Minor tweak to the README.md file
2019-11-06 14:54:03 -08:00
Homu 0d7b08d1f0 Auto merge of #4160 - str4d:upgrade-librustzcash, r=str4d
Upgrade librustzcash to 0.2.0

This is backed by the 0.1.0 versions of our Zcash Rust crates.
2019-11-06 13:39:04 -08:00