mdr0id
78e6f25820
Update py2 conventions to py3, update Decimal calls
2020-02-09 08:14:21 -08:00
mdr0id
a7381d24ee
Update py2 conventions to py3, remove py2 env and assert
2020-02-09 08:14:21 -08:00
mdr0id
cb81b81576
Update py3 env path, remove py2 assert
2020-02-09 08:14:21 -08:00
mdr0id
e017e5c93f
Update hexlify for encoding, update to py3 io module
2020-02-09 08:14:21 -08:00
mdr0id
79484ef854
Update python3 env path, remove python 2.7 assert
2020-02-09 08:14:21 -08:00
mdr0id
0123af354b
Update ignored testScriptsExt to Python3
2020-02-09 08:14:21 -08:00
mdr0id
82162e7d20
Update rpc-test/test_framework to Py3 convention,modules,encoding
2020-02-09 08:14:21 -08:00
mdr0id
bda88213a6
update test_framework modules
2020-02-09 08:09:31 -08:00
Homu
e93586a0c4
Auto merge of #4331 - zcash:hotfix-v2.1.1-1, r=ebfull
...
Hotfix v2.1.1-1
The commits in this PR have been reviewed internally by our team.
2020-02-07 04:50:43 +00:00
Jack Grigg
5199ecdf41
test: Update RPC test cache generation to handle new consensus rule
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-02-04 23:12:36 +00:00
Alfredo Garcia
76a43b6790
Return address and type of imported key in z_importkey
...
Co-authored-by: Dagur Valberg Johannsson <dagurval@pvv.ntnu.no>
2020-01-22 14:41:02 -03:00
Homu
0a31c163c6
Auto merge of #4252 - str4d:wallet-interface-refactor, r=str4d
...
Wallet interface refactor
This refactors the logic introduced in #4144 to improve the separation between the node and wallet. The notifier thread now lives next in `src/validationinterface.cpp` directly next to the existing `CMainSignals` node-wallet interface.
Part of #3877 .
2019-12-18 22:48:26 +00:00
Jack Grigg
f93db1219b
test: Update wallet RPC test with change to "absurdly high fee" limit
2019-12-18 15:40:50 -06:00
Jack Grigg
e77e8660e3
test: Add missing sync_all point
...
This file was renamed in master, so it was missed in the first commit.
2019-12-18 15:06:54 -06:00
Jack Grigg
4f6b477fb6
test: Reverse hashtx and hashblock ordering at start of ZMQ RPC test
...
The "hashtx" message was previously triggered synchronously inside
ConnectBlock, while the "hashblock" message is triggered in ConnectTip
immediately after ConnectBlock returns. Thus ZMQ would see a "hashtx"
for every relevant transaction, followed by a "hashblock".
Now, "hashtx" is triggered asynchronously once the cs_main lock is
dropped, which does not occur until after ConnectTip returns. Thus ZMQ
will see a "hashblock" immediately after the block is connected, and
then a "hashtx" for relevant transactions at some point afterwards.
2019-12-18 15:06:54 -06:00
Jack Grigg
d57af95802
test: Remove genesis-block Sapling activation from shorter_block_times
...
Sapling can't be activated in the genesis block without recomputing it,
and we already activate Sapling by default in block 1, which is fine for
this RPC test.
2019-12-18 15:06:54 -06:00
Jack Grigg
f7eaf921bc
test: Add sync_all points after block generation to RPC tests
...
Previously we only required synchronization points where blocks were
sent between nodes; now we need them between action and query operations
on the same node, because wallet notification of mined blocks no longer
occurs in real-time.
2019-12-18 15:06:54 -06:00
Jack Grigg
03db5c8ca3
Tie sync_blocks in RPC tests to notifier thread
2019-12-18 15:06:54 -06:00
MarcoFalke
6d2629dd64
[doc] Fix markdown
2019-12-17 12:18:50 -06:00
Dimitris Apostolou
f0003239f8
Change "protect" terminology to "shield"
2019-12-04 23:17:06 +02:00
Homu
868c63f92d
Auto merge of #2390 - str4d:2132-mapargs-prep, r=str4d
...
Misc upstream PRs
Cherry-picked from the following upstream PRs:
- https://github.com/bitcoin/bitcoin/pull/6077
- Second commit only (first was already applied to 0.11.X and then reverted)
- https://github.com/bitcoin/bitcoin/pull/6284
- https://github.com/bitcoin/bitcoin/pull/6489
- https://github.com/bitcoin/bitcoin/pull/6235
- https://github.com/bitcoin/bitcoin/pull/6905
- https://github.com/bitcoin/bitcoin/pull/6780
- Excluding second commit (QT) and third commit (requires https://github.com/bitcoin/bitcoin/pull/6993 )
- https://github.com/bitcoin/bitcoin/pull/6961
- Excluding QT parts, and a small `src/policy/policy.cpp` change which depends on a bunch of other PRs, which we'll have to remember to come back to.
- https://github.com/bitcoin/bitcoin/pull/7044
- https://github.com/bitcoin/bitcoin/pull/8856
- https://github.com/bitcoin/bitcoin/pull/9002
Part of #2074 and #2132 .
2019-12-04 19:20:44 +00:00
Jack Grigg
1088866455
pyflakes fixes
2019-12-04 19:16:20 +00:00
Gregory Sanders
f4d9e06a90
Added additional config option for multiple RPC users.
2019-12-04 17:18:43 +00:00
Homu
9a06ea5ab8
Auto merge of #4221 - rex4539:typo, r=mdr0id
...
Fix typo
2019-12-03 22:12:39 +00:00
Homu
2383d1b1de
Auto merge of #4211 - dagurval:rm-mempooltxinputlimit, r=mdr0id
...
Remove option mempooltxinputlimit
This option is no longer used after Overwinter. Fixes #4209 .
2019-12-03 20:07:20 +00:00
Homu
5e26d48a39
Auto merge of #4226 - str4d:2074-wallet-1, r=mdr0id
...
Bitcoin 0.12 wallet PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6057
- bitcoin/bitcoin#6415
Part of #2074 . Closes #3700 .
2019-12-03 06:53:27 +00:00
Marshall Gaucher
017682f993
Update to stop random race error from assert
2019-12-02 17:39:00 -08:00
Marshall Gaucher
acea0f7715
Update z_sendmany calls passing int 0, instead of Decimal('0')
2019-12-02 15:37:10 -08:00
Marshall Gaucher
62f5bdfbdc
Update `import *` to unblock pyflakes from failing
2019-12-02 11:38:33 -08:00
Wladimir J. van der Laan
e427f70a8c
make proxy_test work on servers without ipv6
2019-11-27 10:38:14 -08:00
Dagur Valberg Johannsson
fe1ff82a7d
Remove option mempooltxinputlimit
...
This option is no longer used after Overwinter. Fixes #4209 .
2019-11-19 10:35:39 +01:00
Matt Corallo
60dc0a9e8e
Implement watchonly support in fundrawtransaction
...
Some code and test cases stolen from
Bryan Bishop <bryan@ledgerx.com> (pull #5524 ).
2019-11-14 15:46:07 +00:00
Matt Corallo
a0d211537c
Add p2sh option to importaddress to import redeemScripts
2019-11-14 14:48:21 +00:00
Dimitris Apostolou
40609b95ff
Fix typo
2019-11-12 12:51:45 +02:00
Homu
fd8444d0b7
Auto merge of #4178 - oxarbitrage:issue3731, r=str4d
...
Remove z_mergetoaddress from experimental state
Closes #3731 .
2019-11-11 01:57:21 -08:00
Alfredo Garcia
01998bdc9e
remove zmergetoaddress from experimental state in rpc-tests
2019-11-06 10:57:10 -03:00
Eirik Ogilvie-Wigley
40a7156026
Remove dots and underscores from parameter names
2019-10-21 09:20:17 -06:00
Eirik Ogilvie-Wigley
64fc25ed6e
Update parameter names to match ZIP
2019-10-17 16:39:32 -06:00
Eirik Ogilvie-Wigley
2033395e51
minor rpc test clean up
2019-10-17 12:37:05 -06:00
Eirik Ogilvie-Wigley
b680185f48
mempool_limit rpc test cleanup
2019-10-09 12:50:00 -06:00
Eirik Ogilvie-Wigley
a515b0057a
No need to activate Overwinter/Sapling in rpc test
2019-10-07 14:43:44 -06:00
Eirik Ogilvie-Wigley
1a06727c0c
Performance: Store weighted transactions in a tree
2019-10-07 14:23:42 -06:00
Eirik Ogilvie-Wigley
0b2c5cfcc2
Grammatical fixes
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley
a48b1ba7e2
Rebuild weighted list on removal and fix size calculation
2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley
ae9ecf09e8
DoS protection: Weighted random drop of txs if mempool full
2019-10-07 14:23:41 -06:00
Daira Hopwood
7167dc9b2c
Test setting an expiry height of 0.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-09-26 20:43:52 +01:00
Homu
961c0d58ec
Auto merge of #4060 - str4d:remove-libsnark, r=daira
...
Remove libsnark
Closes #167 . Closes #416 . Closes #418 . Closes #437 .
Closes #521 . Closes #743 . Closes #750 . Closes #894 .
Closes #903 . Closes #1125 . Closes #1136 . Closes #1240 .
Closes #1264 . Closes #1516 . Closes #1517 . Closes #1651 .
Closes #2064 . Closes #2158 . Closes #3478 . Closes #3652 .
Closes #3744 .
2019-09-26 11:21:40 -07:00
Homu
62dc5f0821
Auto merge of #4144 - zcash:hotfix-v2.0.7-3, r=str4d
...
Release v2.0.7-3
2019-09-24 16:02:35 -07:00
Jack Grigg
9d8322a341
Enable RPC tests to wait on mempool notifications
2019-09-20 21:41:49 +01:00
Jack Grigg
982e924e98
tests: Clean up use of repr() in mininode
2019-09-16 12:23:46 +01:00
Homu
06507722ac
Auto merge of #4088 - LarryRuane:3708-insightexplorer-formatting, r=Eirik0
...
insightexplorer: formatting, pyflakes cleanups
These changes were too late (post-review) for the Insight Explorer PRs, see #3708 . No functional differences.
2019-09-04 10:57:56 -07:00
Jack Grigg
8669cb692d
test: Update RPC tests to use a minimum of Sapling
...
The p2p_nu_peer_management and rewind_index RPC tests still start from
Sprout, because they are explicitly (and only) testing network behaviour
across network upgrades.
The mempool_tx_input_limit test is removed because the flag has been
ignored since Sapling activation, and will be removed at some point in
the near future.
2019-08-22 17:26:54 +01:00
Jack Grigg
d7d4dd8a0f
test: Add hashFinalSaplingProxy to create_block
2019-08-22 15:44:18 +01:00
Jack Grigg
0097df5c7a
test: Add Sapling v4 transactions to mininode framework
2019-08-22 15:44:16 +01:00
Jack Grigg
3019c0be14
test: Require minimum of Sapling for all RPC tests
2019-08-22 15:42:54 +01:00
Eirik Ogilvie-Wigley
b54725fbed
Remove constant
...
Co-Authored-By: str4d <thestr4d@gmail.com>
2019-08-19 12:30:24 -06:00
Daira Hopwood
f58bc7b638
Add RPC test and test framework constants for Sapling->Blossom activation.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-16 20:19:18 +01:00
Jack Grigg
cfdf040332
test: Fix AuthServiceProxy closed conn detection
2019-08-16 20:19:18 +01:00
Larry Ruane
7c5a791b73
insightexplorer: formatting, pyflakes cleanups
2019-08-09 15:27:52 -06:00
Homu
5fd1f5afc0
Auto merge of #3972 - LarryRuane:3708-getblockhashesrpc, r=str4d
...
3708 getblockhashesrpc
Part of #3708
2019-08-09 08:00:17 -07:00
Homu
2528af69ff
Auto merge of #4025 - bitcartel:shorter_block_target_interval_zip208, r=daira
...
Implement ZIP 208: Shorter Block Target Spacing
Closes #3690 .
2019-08-09 02:35:30 -07:00
Larry Ruane
2e505df351
add timestampindex related RPC getblockhashes
2019-08-08 14:35:07 -06:00
Larry Ruane
86b23f37ad
add spentindex RPC for bitcore block explorer
2019-08-07 14:23:42 -06:00
Eirik Ogilvie-Wigley
2f00729061
Add copyright info
2019-08-05 19:05:11 -06:00
Eirik Ogilvie-Wigley
42a21ef004
Test clean up and fixes
2019-08-05 14:52:34 -06:00
Eirik Ogilvie-Wigley
65df6225a6
Do not create transactions that will expire after the next epoch
2019-08-02 16:01:20 -06:00
Homu
c68511b876
Auto merge of #3926 - LarryRuane:3708-getaddressrpcs, r=str4d
...
add addressindex RPC for bitcore block explorer
Addresses #3708
2019-08-01 05:43:29 -07:00
Homu
2300b911f8
Auto merge of #4035 - Eirik0:use-committransaction, r=str4d
...
Use CommitTransaction
This enables `-walletbroadcast` to correctly control transactions created with `z_*` APIs. It also addresses some TODOs in the code and consolidates some repeated logic.
Closes #4077 (because `CommitTransaction` calls `KeepKey` on the transparent change address).
2019-08-01 03:04:06 -07:00
Jack Grigg
907554be3a
test: Fix pyflakes warnings
2019-08-01 10:43:03 +01:00
Jack Grigg
8e48ca1fb2
test: Fix permissions on wallet_changeaddresses RPC test
2019-08-01 10:21:27 +01:00
Larry Ruane
68e174e22b
add addressindex related RPCs
2019-07-31 10:31:16 -06:00
Jack Grigg
6bc69c39cb
test: Check for change t-addr reuse in z_sendmany
2019-07-31 12:11:14 +01:00
Eirik Ogilvie-Wigley
102dafdf89
Update block subsidy halving for zip208
2019-07-29 13:44:53 -06:00
Homu
5306121e5c
Auto merge of #4075 - Eirik0:4059-fix-migration-test, r=Eirik0
...
Fix nondeterministic failure in sapling migration test
Fixes #4059
2019-07-26 01:06:55 -07:00
Eirik Ogilvie-Wigley
a63ec6e717
Shorter block times rpc test
2019-07-25 12:49:15 -06:00
Eirik Ogilvie-Wigley
5fc227c7dd
Apply suggestions from code review
...
Show migration status in assertion failures
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-07-25 12:35:10 -06:00
Eirik Ogilvie-Wigley
6a3f9d8260
Clean up and fix typo
2019-07-24 15:43:08 -06:00
Homu
6da42887f1
Auto merge of #3944 - daira:update-license-info, r=daira
...
Update license info
Includes commits cherry-picked from bitcoin/bitcoin#8784 with some minor changes.
Fixes #2827 .
2019-07-24 04:07:03 -07:00
Eirik Ogilvie-Wigley
ded45b90d7
Fix nondeterministic failure in sapling migration test
2019-07-20 14:36:08 -06:00
Daira Hopwood
bc909a7a7f
Replace http with https: in links to the MIT license.
...
Also change MIT/X11 to just MIT, since no distinction was intended.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:26:01 +01:00
Homu
1c899f5a83
Auto merge of #4044 - Eirik0:fix-mergetoaddress-test-comment, r=Eirik0
...
Fix comment in mergetoaddress RPC test
2019-07-18 06:12:22 -07:00
Dimitris Apostolou
f57f76d789
Rename vjoinsplit to vJoinSplit
2019-06-16 19:13:49 +03:00
Eirik0
c9d14272af
Fix comment in mergetoaddress RPC test
2019-06-11 14:32:57 -06:00
Larry Ruane
f381d4e085
add spentindex to getrawtransaction RPC results
2019-06-11 10:29:51 -06:00
Eirik0
a8055cfe10
Fix z_mergetoaddress sending from ANY_SPROUT/ANY_SAPLING when the wallet contains both note types
2019-06-10 13:21:25 -06:00
Eirik0
bb0a3e1cb5
Remove old mergetoaddress RPC test
2019-05-22 16:01:50 -06:00
Eirik0
23d9826ef9
Fix LogPrint statements
2019-05-10 17:25:30 -06:00
Eirik0
7470ae8885
Do not automatically remove async migration operations and return txids
2019-05-10 17:19:56 -06:00
Daira Hopwood
e7529049fb
Test the expiry height of migration transactions.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 13:48:43 +01:00
Eirik0
7cf4749d0d
Correctly account for migration transactions in the mempool
...
Co-authored-by: LarryRuane <larry@z.cash>
2019-05-05 12:59:43 -06:00
Eirik0
345177cfc1
Do not look at vin/vout when determining migration txs and other cleanup
2019-04-30 09:52:53 -06:00
Eirik0
e9530f40f2
use -valueBalance rather than vpub_new to calculate migrated amount
2019-04-29 17:00:26 -06:00
Eirik0
108e587c14
Fix typos and update documentation
2019-04-29 15:29:29 -06:00
Eirik0
2276133bb3
Test migration using both the parameter and the default Sapling address
2019-04-29 15:29:29 -06:00
Eirik0
6e82d72852
Add rpc to get Sprout to Sapling migration status
2019-04-29 15:28:35 -06:00
Eirik0
6acb37bcee
Check for full failure message in test case
2019-04-26 19:01:23 -06:00
Eirik0
5519d16997
Set min depth when selecting notes to migrate
2019-04-25 13:43:23 -06:00
Eirik0
d2a584e35a
Refactor wait_and_assert_operationid_status to allow returning the result
2019-04-24 11:31:14 -06:00
Eirik0
699288b4b4
Documentation cleanup
2019-04-24 11:31:14 -06:00
Eirik0
81a45d6984
Add rpc to enable and disable Sprout to Sapling migration
2019-04-24 11:31:14 -06:00