Simon
e883ffef91
Add test for calling RPC z_getbalance, z_gettotalbalance, z_listreceivedbyaddress with invalid parameters.
2016-09-08 21:46:15 -07:00
Simon
12448b6457
Add extra RPC parameter checks for minconf<0 and zaddr not belonging to wallet.
2016-09-08 21:46:15 -07:00
Simon
5e363861e0
Replace unique_lock with lock_guard, where appropriate, for consistency
2016-09-08 21:46:15 -07:00
Simon
a50fd5fdb7
Add lock guard to getNumberOfWorkers()
2016-09-08 21:46:15 -07:00
Simon
e91048f28d
Fix formatting
2016-09-08 21:46:15 -07:00
Simon
69a4cb448a
Move lock guard to start of addOperation to protect isClosed() and isFinishing()
2016-09-08 21:46:15 -07:00
Simon
61ea2abaf5
Update formatting and documentation.
2016-09-08 21:46:15 -07:00
Simon
ca0ec80b4c
Add 'DEPRECATED' to help message of zcraw* commands
2016-09-08 21:46:15 -07:00
Simon
6c41028f7c
Add z_listreceivedbyaddress RPC call
2016-09-08 21:46:15 -07:00
Simon
1b141933e5
Rename GetUnspentNotes to GetFilteredNotes
...
Added parameter to ignore spent notes, which is true by default.
2016-09-08 21:46:15 -07:00
Simon
6d2d045c6b
Disable z_sendmany in safe mode
2016-09-08 21:46:15 -07:00
Simon
fc46069e81
Add more logging.
2016-09-08 21:46:14 -07:00
Simon
a9743bc8bf
Refactor async sendmany and getbalance calls to use GetUnspentNotes().
2016-09-08 21:46:14 -07:00
Simon
fe2f198277
Add test for GetUnspentNotes() in wallet.
2016-09-08 21:46:14 -07:00
Simon
a5ac2e25a0
Add GetUnspentNotes to wallet.
2016-09-08 21:46:14 -07:00
Simon
7b79275eba
Add tests to try and improve coverage of perform_joinsplit.
2016-09-08 21:46:14 -07:00
Simon
269310ce3c
Replace zcashParams_ with global.
2016-09-08 21:46:14 -07:00
Simon
5f8118c8a4
Revert "Reduce use of global pzcashParams with private member variable"
...
This reverts commit 4d71ba58d37eb4f93d68b5e437086ce14fb24825.
2016-09-08 21:46:14 -07:00
Simon
4b32c16ba5
Reduce use of global pzcashParams with private member variable
2016-09-08 21:46:14 -07:00
Simon
485145ea78
Disable proof generation when testmode is enabled in async SendMany operation.
2016-09-08 21:46:14 -07:00
Simon
4cff8a5c50
Fix typo in error message
2016-09-08 21:46:14 -07:00
Simon
a0a3334c4d
Add z_getbalance and z_gettotalbalance RPC calls to close #1201 .
2016-09-08 21:46:14 -07:00
Simon
cff6f0ac46
Add friend class for testing private members of AsyncRPCOperation_sendmany.
2016-09-08 21:46:14 -07:00
Simon
9bb6162626
Add extra checking of memo data in hexadecimal string format.
2016-09-08 21:46:14 -07:00
Simon
a5905772c8
Add logging under the category "asyncrpc".
2016-09-08 21:46:14 -07:00
Simon
39c7f954d0
Remove redundant call.
2016-09-08 21:46:14 -07:00
Simon
fc4b127ed3
Add tests for async queue and rpc commands: z_getoperationstatus, z_getoperationresult, z_listoperationids, z_sendmany
2016-09-08 21:46:14 -07:00
Simon
15c83ac6b4
Remove redundant check when getting spending key for a payment address.
2016-09-08 21:46:14 -07:00
Simon
f86f625dce
Update RPCServer to use AsyncRPCQueue's shared queue.
2016-09-08 21:46:14 -07:00
Simon
423a63d0a9
Add shared queue to AsynRPCQueue.
2016-09-08 21:46:14 -07:00
Simon
b922924d14
Add test for AsyncRPCQueue and AsyncRPCOperation.
2016-09-08 21:46:14 -07:00
Simon
017b3ede33
Clear the operation queue when closing it.
2016-09-08 21:46:14 -07:00
Simon
87f7c98795
Refactor to use wallet note tracking from commit a72379
2016-09-08 21:46:14 -07:00
Simon
97b6f365a1
Fix bug where wallet was not persisting witnesses to disk.
...
Author: str4d
2016-09-08 21:46:14 -07:00
Simon
9cd713439a
Added option to close a queue and wait for queued up operations to finish,
...
rather than just closing a queue and immediately cancelling all operations.
2016-09-08 21:46:14 -07:00
Simon
c93d8bdf9c
Fix bug where call to sign and send a transaction was in wrong scope.
2016-09-08 21:46:14 -07:00
Simon
3fd5a615ac
Coinbase utxos can only be spent when sending to a single zaddr.
...
Change from the transaction will be sent to the same zaddr.
2016-09-08 21:46:14 -07:00
Simon
008fccfa48
Disable option to allow multiple async rpc workers.
2016-09-08 21:46:13 -07:00
Simon
14af21e9f7
Add chaining of JoinSplits within a transaction.
2016-09-08 21:46:13 -07:00
Simon
c1eae2806c
Closes #1293 by adding z_getoperationresult and making z_getoperationstatus idempotent.
2016-09-08 21:46:13 -07:00
Simon
3b54bf5813
Refactoring and small improvements to async rpc operations.
...
Added AsyncRPCQueue::closeAndWait() so rpcserver can block on worker threads when shutting down.
AsyncRPCOperation is no longer copyable - copy constructor and assignment operators now private.
Refactoring: renamed methods, renamed member variables
Tidy up: comments, const, size_t, braces
2016-09-08 21:46:13 -07:00
Simon
34f0001ccc
Implement RPC call z_listoperationids and update z_getoperationstatus to take a list parameter.
2016-09-08 21:46:13 -07:00
Simon
861513a01f
Add public method to AsycnRPCQueue to retrieve all the known operation ids.
2016-09-08 21:46:13 -07:00
Simon
c72a427274
Add public method to get state as a human readable string from an AsyncRPCOperation.
2016-09-08 21:46:13 -07:00
Simon
15d345466d
Successful result of z_sendmany returns txid so it doesn't need to return raw hex.
2016-09-08 21:46:13 -07:00
Simon
b7d7b2ad9d
z_sendmany from a taddr now routes change to a new address instead of back to the sender's taddr,
2016-09-08 21:46:13 -07:00
Simon
4876de6c6d
Update find_unspent_notes() as mapNoteAddrs_t has been replaced by mapNoteData_t.
2016-09-08 21:46:13 -07:00
Simon
dafb81614b
Implement z_sendmany RPC call.
...
Simple implementation does not try to optimize coin or note selection.
Caller can send from a taddr or zaddr to multiple recipients.
Currently only one of the recipients can be a zaddr.
2016-09-08 21:46:13 -07:00
Simon
4eb1a96f9a
Add public field 'memo' to JSOutput to enable creation of notes with custom memos.
2016-09-08 21:46:13 -07:00
Simon
8d08172d0d
Add config option 'rpcasyncthreads' to specify number of async rpc workers. Default is 1.
2016-09-08 21:46:13 -07:00